From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E0B2C3ABBF for ; Wed, 7 May 2025 17:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E047E6B00A5; Wed, 7 May 2025 13:22:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8CE06B00A6; Wed, 7 May 2025 13:22:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C53B46B00A7; Wed, 7 May 2025 13:22:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A67126B00A5 for ; Wed, 7 May 2025 13:22:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7A6351A0BFD for ; Wed, 7 May 2025 17:22:59 +0000 (UTC) X-FDA: 83416782078.01.BF06583 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id C655C1C000B for ; Wed, 7 May 2025 17:22:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of "SRS0=ifWc=XX=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ifWc=XX=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746638578; a=rsa-sha256; cv=none; b=fne1WjJSY2rEEGCEfQnWaedaVVuR8o9RwkUJBc+Fm1la4lVPVwnWgtv03sTrzrqFUWRKz6 KaSBK0H2xDsqbp7yyoXar2OBzrQGCQ6lnJU7UbmvecBqbCaGibB42Wa81LzOuVYtGbw9P1 9pV0Cy8HOxF0qtHgOQsZ/I2Jp9fmjBY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of "SRS0=ifWc=XX=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ifWc=XX=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746638578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PBRZZu3GZpWR35ftkj7YhzIx+Qp3IYuc4r9NQ1K4xHA=; b=qf42vu4naz7JapblWuZmzSLvDQTfVAj6OycEjW8PRoF5Pn8lid+wE5BBDlYAyy/tDBc4JL XTqRrKWKQfQ/fRkoE4r+ffgR8L0ESzwWEk+F8tb/eXAQglZNPt0PGk9XISB6o1ShGLtFcC 4JOoZ27JwQ8btvhgf3l60+YF1nXrGk8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7AA255C5DD5; Wed, 7 May 2025 17:20:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABFB3C4CEE2; Wed, 7 May 2025 17:22:52 +0000 (UTC) Date: Wed, 7 May 2025 13:23:02 -0400 From: Steven Rostedt To: Petr Mladek Cc: Bhupesh , akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: Re: [PATCH v3 3/3] exec: Add support for 64 byte 'tsk->real_comm' Message-ID: <20250507132302.4aed1cf0@gandalf.local.home> In-Reply-To: References: <20250507110444.963779-1-bhupesh@igalia.com> <20250507110444.963779-4-bhupesh@igalia.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C655C1C000B X-Rspamd-Server: rspam04 X-Stat-Signature: w3jhzas1m6nqgbe5wcth9contcnrfk8u X-HE-Tag: 1746638577-389859 X-HE-Meta: U2FsdGVkX1/aYwV7RualdqjpiEjh2M/1GdSR5Uh/7bx4QY5i4X4EMqKAAhoyLGD8yAkHdkIl6sxt8CnwWvp3TkjoZl9N2D/r40kqymkn/xZK/+7nfXF31XAfvbqOksSyitlxCxQT3cXmB0cAGT2LHohtkDNvp/4TEM9QjfeJHg6RAJBkKX4CKFQHQlyD8/iw8F4uHov5JKfSOYc/pzgqoy0lSuBdIPmnDq2IT5TvHifhQDLGFUQAWVodDqWmQLEfU2gGX4CbzwNygGwo7fR3MJaDwElYAkMfi5JzFqOaeoklHeD9hCpjl5UyPT7wPeoz9XAw9BdXnLIGhUb93eSonsyHoYSnesCPNrVFSzE8ajmg8qgmt+O5GqJzLOtAusK7jGOTr3KsgGM1WU2g7fKxi/pH+wNE4fU/cPvEbtyIMRPgMv9wGAS326iZT76YuhbTvG1LcjmIAFV858WcN37DgREbUUQa/CorvuAegwqK1tcmyx9YLh95yS9ArJEelwHFmv+NtA1IyRFtXEb+MjKAs47bMKlrUFjt2/61kIaLbNLBvys3J22C/qV9OIOpiO90/p1HbwUAMdNiSETkA5F4xLxczd9zvOQdFcEnbqHcnEnzyJ7ExFCQHr9LXWbjSEZZpPiZlz0STYhEdhRh7c9Y58DpW3pEhfHvnpWLdeWAaMBL20+LvGBAhZOQTfivEJ/NwG/2MtzTupDbF5U5adxlND2G+13QWN2mEDns59GT2RU5Xr5K31qfQkJgFvDVdKtyeB25fvoLvxf4YrwIkfkpdo9hOlorYeEYjA3IFCUtQGByKz3R00fBHc8DMUmOVKexB1OYt6FHCvX0dTIkwpRzYqYaTbFOr1GSMlDDGjLR5fvIbuJMj/VpF9MO4uHJK2hzoOi7SbfRgNdMmBp/cIXqTI/hUkUK+JmaHvP49EArHilxB7dQDZlFTC1B+TPv87sjujlo7waos1Wh73ySNfD cJ+3ST9J LznFVjRqeBcHdzg1Mu6F61CT7r+EP5v3vDgOmZq8GhR3HkKk57rBAlFJULsWSSMPrj25fU1gievybPOHUA9TuUTG4rpWko2SawHfj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 May 2025 14:54:36 +0200 Petr Mladek wrote: > > To fix the same, Linus suggested in [1] that we can add the > > following union inside 'task_struct': > > union { > > char comm[TASK_COMM_LEN]; > > char real_comm[REAL_TASK_COMM_LEN]; > > }; > > Nit: IMHO, the prefix "real_" is misleading. The buffer size is still > limited and the name might be shrinked. I would suggest Agreed. > something like: > > char comm_ext[TASK_COMM_EXT_LEN]; > or > char comm_64[TASK_COMM_64_LEN] I prefer "comm_ext" as I don't think we want to hard code the actual size. Who knows, in the future we may extend it again! -- Steve