From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE8EC369DC for ; Wed, 7 May 2025 07:16:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBE236B000A; Wed, 7 May 2025 03:16:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C356B0083; Wed, 7 May 2025 03:16:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0ED26B0085; Wed, 7 May 2025 03:16:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 958726B000A for ; Wed, 7 May 2025 03:16:16 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 92BDCB9C1C for ; Wed, 7 May 2025 07:16:16 +0000 (UTC) X-FDA: 83415253152.28.D781467 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id E044E40004 for ; Wed, 7 May 2025 07:16:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf04.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746602175; a=rsa-sha256; cv=none; b=fUk9++7G052tJdgqLoBDRt8QKTneMirbrgS9Ozi6Lx8K/D/kvyE8pM3snoKJT25b7vaGAt HnH0Ld8dG1Jmh59KksUXs95mAJmwdHDQLUpKYSzrlmAoUaAakpS7rYOpdbTgeHq7bBkuK3 gJIGvH8IsTSGeuFU+Uuu0LCjwj1qkd8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf04.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746602175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JsCPSMGds5SjnqmFW4633Rzm2hBuTiek1kY1irD4AFw=; b=NLdUU18PzkwZE+1G5YgngjewP18gA60GyrzcWieKgMTU2fzxnZqUMVg1FeaXMxf4/u2qMW QR4Dh38y/jkYQNe1LPsJzwSWGcOVVE5YZ1mx1+apXvh3EDPjhcSEWmyP07YCjX7xzVjHd0 D/6oa9cGLYznZagw6Kn+n6P+WEEasH0= Received: by verein.lst.de (Postfix, from userid 2407) id BFD9768B05; Wed, 7 May 2025 09:16:10 +0200 (CEST) Date: Wed, 7 May 2025 09:16:10 +0200 From: Christoph Hellwig To: Caleb Sander Mateos Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Kanchan Joshi , linux-nvme@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/3] nvme/pci: factor out nvme_init_hctx() helper Message-ID: <20250507071610.GB1413@lst.de> References: <20250426020636.34355-1-csander@purestorage.com> <20250426020636.34355-3-csander@purestorage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250426020636.34355-3-csander@purestorage.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E044E40004 X-Stat-Signature: mwurthdnzgyq3135da4ehf3jf4ken3qx X-Rspam-User: X-HE-Tag: 1746602174-988037 X-HE-Meta: U2FsdGVkX1/HW6WdCW096ExOs+xAitlBUJxJxcGgGuwuSOjfoykcP8osXe61qejOB8+yrEJwByi8no8YYZNIeSAWK88mzcrKefuzZsE08iWCr6jsVHRofUgIfNodZWfMsX7LegBr6g1/WaKSTqFh/9XkAB/AAj0msDqKbb4ubiaAzlZ+uLFwkwUw9BxX1IUlXqG2IEjig4RJjtgZMIfFoCtr4ubVNjkGs3PzjOp0VN/UF99d6uCHM/9YxcMHS032QeyoA/yxOaHi6lcjQCt9kKnj6TP2yXWgoT66Py9wRwXMoxIdbzJBMGIQ3R3koliIJfDt6mLzZYaPkqFAaqIjT0xxUSLzfEoaVOJJJlX3RHAnyjSCS2RoQNc3SC5DI+jwoQIZysR4ey+FBgVtUNtMZyYW5c+NrVzB0ZtiM6Hgsgnh6XkpKXAA1zpw0QJeec4PiEZtW120qklVduvc+YxWqAel1kraMQrYpEYW6a2umOUTmJlGOCNLRwYNhJpC+X682l1iFs5bapyUPel/7cBpQ/IXMuazj6d7mYM0CsPBq7FYD1RnUw2VEzDmv/GpOpA0dS3OqrXcJ+4JCIDEcs2FPxycwNxiIcN2HTt35bRZ5zD2f7U+avDxmt9a9ZsfEibT43dMS64jR06t4rWQ2i1/IKnGPOsaZh9GFW3hLe7HR4lRNFRCJBn9uPQEzKsav1/ToNeTD42iI7DjA2oXifD9ycy9ZXcltkchD/8KomUR6HgvUL2w+vy3nsHvfsUhqw/aymTrACpOvf6zYTsK/qv/umbldsk+/jQh1K5vtLafXMNPqZrV7fBwOxLgCzwRHshfejEJ80226AGhEPIuesLGBiRIxivGsPZlryKXhZ3CojM+rMJxBekwuHML5lgCqZdj/gqSOvphEhttjn8pRroIDxuef2FxJaCyHfVtjaj5Uy7sz8G8hjnyw9G/Y8nhVQ2un1AVF1uq5o6Riraxfdm FgB3C9ks mPwKUmEDtUaCfYKp6D/YUztZX82tQD704cm9EUXeC51pcRGa8yHGKoRskvWaBZsKE0kJcbckuPhE4JyHVB57tZGx/FvxvCEil7BV/Kg4L7JpIJq2RLf1oevIMeSuxZlSR7wMoXldNI5bMempK2MLHa77o0T0MoNX6lusV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > - .init_hctx = nvme_init_hctx, > + .init_hctx = nvme_io_init_hctx, Without an overall rename of the methods I'd rather avoid the _io here and pick a _common name for the common helper. I can fix that up when applying, no need to resend.