From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840BFC3ABBE for ; Wed, 7 May 2025 00:00:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 959326B000A; Tue, 6 May 2025 20:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 906E96B0083; Tue, 6 May 2025 20:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CF386B0085; Tue, 6 May 2025 20:00:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5DC146B000A for ; Tue, 6 May 2025 20:00:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E7EE48055B for ; Wed, 7 May 2025 00:00:38 +0000 (UTC) X-FDA: 83414155356.11.96B22F7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 0E2BC20013 for ; Wed, 7 May 2025 00:00:36 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vNhGJci5; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746576037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qX8U1+R1exo0JApE3RUBAMCIUh9CD0PkeRTcUooaDtg=; b=kM6bK94a/NQSMbrFWG76Aie31+MAV4NU/N8fLWoMwD5DeyvusHom7echbQhUdCf0gGee+N zbasTpsWX3+hJKdcBiF4VByB+Kzw9zytmEIsL0q4SOsADsdZy9FKLhgPCdUBr7sMmq09Xa VDNvr1QLcq2uFPbgP0y4B+g0ll2dato= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vNhGJci5; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746576037; a=rsa-sha256; cv=none; b=PT0z7CnaNDi55aNkhuL4gzSHQN2BIM70JbWx36Sa6MP1gesSygklgvdESLOVR0BTLuWVUr XlA4rJd1Y+nt92V6q9BuB5eRrB390TdU+lLxY9pxzfPJ6qRil4YLCvlx7N0/uTggKHkSid XSg4o2JpAgVg2KxEN4fg6r3qHFv826I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D83E05C032B; Tue, 6 May 2025 23:58:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5559AC4CEE4; Wed, 7 May 2025 00:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746576035; bh=ALYrDOrB4kuaNVu4GIvtF0UwXvPLkIaw599sx0ttPQs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vNhGJci5KF4sUfhQi/F5mgwAbmaQ5IOzu2ZVaggQMEqNVwDKaM4IK0FGeaOxy5Cut PImhvyH+KCjOKzMut9/ehotAytzyVlC6rAfPsqapaHfEZpVO8+lVhOJ3OkCeluw6cS xIH4KsWeRSYlGXQjuCoPFLcdduXIVkXJgR/e1cU4= Date: Tue, 6 May 2025 17:00:34 -0700 From: Andrew Morton To: "Kirill A. Shutemov" Cc: vbabka@suse.cz, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, bp@alien8.de, tglx@linutronix.de, david@redhat.com, ast@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_alloc: Ensure try_alloc_pages() plays well with unaccepted memory Message-Id: <20250506170034.2c6cb08808e60772c207233f@linux-foundation.org> In-Reply-To: <20250506112509.905147-2-kirill.shutemov@linux.intel.com> References: <20250506112509.905147-1-kirill.shutemov@linux.intel.com> <20250506112509.905147-2-kirill.shutemov@linux.intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: apdpt63d9yrraqqp383edmi4qjt1dw3n X-Rspamd-Queue-Id: 0E2BC20013 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746576036-982435 X-HE-Meta: U2FsdGVkX18GvVH3LAMyYJMF6TmQFsaeCP8rMuy2rEYvMLowITgputAEotSCR0N53ssJOH01evmk5xPVD1vtEPpck2MPz9MvbO29p9nyhAsUeVdfDzyTm3BKKODoqD2sKa8QpzA/fkMDy558q9/j4nHyVXik13wpuucngVZsFX+GmHtr4kl5QWqsdJ3EG3tDIqfaeVq9TDBvaJP3E42NFIZgCmUX8nVOtjL0S1pGmtdbV0G5Mz8SO2zJRS8hNUV3I55FR8IYlAuyIqU3X1q29gh7W4tLttg68RcSZM2lirHAbWNw9aWes8ulBdkdiUUe6L140PpuQS10n4JDlqUz8gAS32k5ugtkz8dJFP9owO9nnjzl1OOAounluweX4aPNeArMysJ3kA1fyGlme5Ued6l9IqMy8k0QuOrcnmE2dVR6KNDDnEL1A3FyLh8Rdb4YqWvGtlDyqUsjRmRjNBUL+MHAUzf4JRT2kVO7CypK9bMmVz94rmsLV1WbINl9Mg+UiF76HWXgc1vNryRnvGmzIOwH3W+EMxDbrvhDsg1247aZB3NHN9r3Fyb/P36CziJKqY0A/fa6CNELKLADZfMTxeZttLSDHvKcTH7DhOkSgTb4EVUH8r+4sc8GbkxeA11V5QwE6ndc+buZW65MnWfDHttTTKZpB1fNbxJes3KCINdKRFzoWli/yTK2jt8cEdcYmoKbUycfaK8xdR7Uck7RfD6tXkdxcP6XM1JrlJQeSgW+VOjGyWKMYPyewfAKTKWFAbWvilVxwLH8FcWzBe1/9zqiqDF36wxfWjJL6Ureov30oVw95ksBCa4tWfz7i4MAfNvqK+hWzz56HRyp++u/1ZaqzQbLTxrX9sl4p6i1OXGloYW8eK9ZTAdFQpLxibu0iVjOiWASEOdFZFsiCP+55BboCU/cOJxNWic6lAjpilwcTJqZuc8wPKPkGq9fnDPK1MKvY13NvCOcVi1npcJ /xJNaQCO Fock/ztlUKvoZ8o/qlNLiSJuhm8e1qSmRGojjO4JSk2/NUwFliQKMIK89b5MhzR0044HDb7MM882xWithvsGYc7xO474TrdJUJAKg1yRd6LKD9rEvyOYkKW7a5PNMiXDSv0JS6GjtUHi+8Ymy02/TB2fS1aHLdl051fgJRjxCvL6O9OvzLf+jvLHt6wTi/zi699VUBANQGru8az7soC0Wr+wNGD+lf+GyWw+UvJowLR7h8gXiarvW1GIPRm21bp1HqvMNSHdeqHAeIFov2nwf015TkgUv3Ly5sBsG594ZxuF7kuPv1oRVS3nSr4kgA1p8v+4Ms8PwimfzAc4EIuNmeGKshhYEAUM+BvKe8XLEgaYKp+U7yP0qb+5KPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 6 May 2025 14:25:08 +0300 "Kirill A. Shutemov" wrote: > try_alloc_pages() will not attempt to allocate memory if the system has > *any* unaccepted memory. Memory is accepted as needed and can remain in > the system indefinitely, causing the interface to always fail. > > Rather than immediately giving up, attempt to use already accepted > memory on free lists. > > Pass 'alloc_flags' to cond_accept_memory() and do not accept new memory > for ALLOC_TRYLOCK requests. What are the userspace-visible effects, please? Was the omission of cc:stable intentional? I cannot locally determine this without the above info. If the cc:stable omission was indeed intentional then it would be better if this series was presented as two standalone patches.