From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C97CC3ABBE for ; Tue, 6 May 2025 23:50:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E339C6B000A; Tue, 6 May 2025 19:50:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE2D76B0083; Tue, 6 May 2025 19:50:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD1556B0085; Tue, 6 May 2025 19:50:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AFA726B000A for ; Tue, 6 May 2025 19:50:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 15B1B1CB2B7 for ; Tue, 6 May 2025 23:50:17 +0000 (UTC) X-FDA: 83414129274.21.03AC5C8 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id 752B840005 for ; Tue, 6 May 2025 23:50:15 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=spaUvWo4; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746575415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=deVvTHxe2Ht1NrpO1ggUahvK9Qb97ygTkoP6RpWN70Y=; b=mUstDwBDtpro0EHn4zrTHLl/PmzgV7SA3PvIscEVkZLn63oQ/7ypMEfb2fg7yD0CMSonXC Fjb7CE+lhOEuXMF7lxfl/pTZrCAsKJ8+o7b011herG+bRLQTmBmFcLV/3wcMCP/cLUUJ8V idM4b3fdsyICUaq2bG4kaD1JV3D5yYg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746575415; a=rsa-sha256; cv=none; b=e7NMLfffaupUkXAbu9bIf+dBTjLpguao0KKBw0svz/sNFWc8yP3zkzBnLxBEjaCWkQLIPZ tJleon5jx8MeeF/Ua0UYYicCEQRPArobkJ11zvNegLk/WI3nasBqZtya1X8YEXcfzW+oQA xP5x0HOOo6Gw8xt5xBK9eHrhyulHpEI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=spaUvWo4; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5E68D43786; Tue, 6 May 2025 23:50:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3D2AC4CEE4; Tue, 6 May 2025 23:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746575414; bh=W/TFAeZfFS7VZ2Whby13swcOwpYaxUdhL025szOJPWM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=spaUvWo4mjg3LS8dif9YOHepQ5BCUFreEbD0UY4TxYAhfHY8laGzPdfBKRZDzaF14 M8lnb+Nz9WcDqCmOxDvJ3c3Mx0J+blqlJTKzC3Tz2X0yuM7RSZaFrLxzRbjn89yY7e IjkUu7WS3R1nrd/3p1TLe6ExH2cm4atnBIRDPvOg= Date: Tue, 6 May 2025 16:50:13 -0700 From: Andrew Morton To: Vlastimil Babka Cc: Juan Yescas , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Minchan Kim Subject: Re: [PATCH v3] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order Message-Id: <20250506165013.4d48314b6d52d76148cb51f2@linux-foundation.org> In-Reply-To: References: <20250506002319.513795-1-jyescas@google.com> <20250506000133.ba44539dd517e4f54515751b@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 752B840005 X-Rspam-User: X-Stat-Signature: bbazc1gm4n7k77y9pz9499hdik3tyoq4 X-HE-Tag: 1746575415-190056 X-HE-Meta: U2FsdGVkX1/1FhlcCg6kXrk6KkiQJFEQsrkKRR+g/AVR8RW4mzPHRKWFRzWUzYAZkWQs2/wIcr1znUo0rGrirqw9BP77kckXU482HuPkrsaLQVAQQjk6YRdbG80DNxpX9zrvUOWRmz5ktU4NMEkX97j3+kMiwbYFGQVNkajkPIvP3MZQXOa+Civfl3JTNcJNLavAWsFTlUFL1c0FiH0BG7Cmi4Voa1niLKx0vniHkfaTZyu4qk9OnKTrwHMidWnTWhgVwTXY9h8Xwc3Hs/LfqUQZ3K44jEg5oStvpY2TBVK8m2hhKX1c0dZnmS1oqA2kfiXZ3K86pXW59yDs1G0sBHyx68RxIa2rvk6OCvkQyTLwpxJSSns/rzgUQlqIcXrZ8Cxypx8ugaKw6r1MWhqQyYtX3nzaCXt8Ay+zlOQfbOVkkeO/fqQPNgCtFsOtzKz7mKeQh9mCGycKWHs2YNo0oGvmLIi5EUgkdsLKcMbRiireOG2WcJk1KxYoSchePV4J2RMTWc2vSn8WoxvpCLB+tqPzRLA99zuhwyegtkui3AAvIUH8CvuJk4T9yWdIiSA9phJI6Q+/jqWXVI7qr4SnV68zpNBu7q+1Fu3F7K0MzHmSd6wMjikkBHkIs0ba3lVYvy9r/zvPMKEi/s1RlfXunBKz6ZtqXhbNN3VfiM8cRRGC1a/tNHZ2+3JxDUXmY0DdAyMn5MSykxUCBzTMn3HmDQ0HqbBzS6Lu6mpzkjGRL355cptqfmoISOE3IM+hM6dSpk/u+5CxY8HJAzAqVxe49Nbtn8i2C5cZKVGHUTIzuRHnVxdySr6qBtfjSBP3Dz7QAHjyg9vdNXonIFy4lfNnYaOEFAWtSQzowITDMViw+kJRQBG0DYbqzOTvb9vtn3A/RjFidGU47GQ8T5p54U6E/5J75rGWDl+IppLLlBFhjtMgZqpnqd6WafU0fmJyERCPdG1ZchP4D42JPipd2FI gp2KHSRS UJoYB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 6 May 2025 14:48:19 +0200 Vlastimil Babka wrote: > >> +config PAGE_BLOCK_ORDER > >> + int "Page Block Order" > >> + range 1 10 if !ARCH_FORCE_MAX_ORDER > >> + default 10 if !ARCH_FORCE_MAX_ORDER > >> + range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER > >> + default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER > > > > Do we really need to do this arithmetic within Kconfig? Would it be > > cleaner to do this at runtime, presumably when calculating > > pageblock_order? > > AFAIK pageblock_order is compile-time constant. So it is. Why the heck did we make it lower case? And pageblock_nr_pages.