From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB3BC3ABBC for ; Tue, 6 May 2025 23:24:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADC5D6B0085; Tue, 6 May 2025 19:24:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8DB26B0088; Tue, 6 May 2025 19:24:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 979966B0089; Tue, 6 May 2025 19:24:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 791646B0085 for ; Tue, 6 May 2025 19:24:42 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C4D721A0192 for ; Tue, 6 May 2025 23:24:42 +0000 (UTC) X-FDA: 83414064804.16.2199637 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 1459E1C0009 for ; Tue, 6 May 2025 23:24:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hrdcBhdx; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746573881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oXVuK2EPV+AYtizYmrrkUwfwp9kyRIveLaYapv3MTc4=; b=E4A8Cxa7a74Ii76UevvK/E6oi/DdVtAyVqQ6YvZ/GDW4ugFOBAsP/mETBfC0IkeZeDECCW 5eVCerjgfQK9BIiE4Z0gawarbh2eckswZ16TjxTCnIwb59JUtwGxdZoVloBCok1SUKh0cR 0hxwfm8v7VyhFiwOgS4EDQBmbm6X3/A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746573881; a=rsa-sha256; cv=none; b=kkGvK0sf0Z9BdZmtK241BLd64H8mjJ0OnzvuT3sq7DP3ik0gmGwchN6laDcCE9NWCvRqB1 2oz7Adqr9ADKNSHw0QzO9Od9qK5TTtng5vgIoEopq5WVlyfM5TNIdTmyiTRGs+kRurU+B/ LlPSV/TJ12TUKtBnlSAtVojFsi7mnqI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hrdcBhdx; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A6F935C588D; Tue, 6 May 2025 23:22:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E6EFC4CEE4; Tue, 6 May 2025 23:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746573879; bh=fTXalGwAI3Umzmf4OwP7C0YEGOkcPxF1NhpPFNf918s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hrdcBhdx0ZL/pg1xA5JGU4awQC0fMA9gDfcJZrDvQ8ur3mLy9QnOrkCNalDquG5wf D0Fjn/KWL7Yf8WEoEPFBlMTKu3lRJCFmRZrVNZvq73r/j6uLV5VAMQEFvYCOlf8099 Xn+mstsKjvyA55T5IqLgUuYRAnPohKB2I0MUioVM= Date: Tue, 6 May 2025 16:24:38 -0700 From: Andrew Morton To: WangYuli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhao@google.com, stevensd@chromium.org, kaleshsingh@google.com, zhanjun@uniontech.com, niecheng1@uniontech.com, guanwentao@uniontech.com Subject: Re: [PATCH] mm: vmscan: Avoid signedness error for GCC 5.4 Message-Id: <20250506162438.91fffc7ef924d9653ed0f503@linux-foundation.org> In-Reply-To: <85050791B887DC13+20250506160238.799984-1-wangyuli@uniontech.com> References: <85050791B887DC13+20250506160238.799984-1-wangyuli@uniontech.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1459E1C0009 X-Rspam-User: X-Stat-Signature: ho4ihddos1bfp9xnakyzsorn6e4r1euf X-HE-Tag: 1746573880-319192 X-HE-Meta: U2FsdGVkX1/jgaH2FHf9jzOUtR1P3nyZQp1ciJ0fKssf+dEA9Nw629dyp4LWaUPLjO86iLElrRc4d7ecLfaNhfiK+FzuRAtMY4Wu0ksfXRHqiTqTDjZLMiFgipsiKs/E/XyV4qDQZ10FbRkDA9vBs3UH3SO3sEgaqIkq34GD2C0X70jezJluvvPEu79td5RKhn9qrLCGzVODmwAozJMrv4oS8W0EIUt51txvMXR4XCjPUJv8eH3dh+D3Yyhqlj1s4BIZBeHAUqHxZuyDlNIm7CEleLz8mMRRm0KAMf5Ugc5t7pXkctQQhbr0yj8GWbSPT3avlsaXMYLz+NchKKkyhCYAyeqwAtKFnccT+9EOaGdmMDQu47b/Wawu85K2A2B+KQKgyrCKp+SZHiYB/XZGte6qRsq/zQDv74yyLzZNJPJqD3Yt9EFKHJhnYPjK+6J2aqJF9B/8+bALjgL/cImHEv1WuiWr3h94xLu/x8Ghzrwlu8AU1dBA+UZQPfwGuStsUPKrBOewC0fO+vWbNheC5RNpOeH2MM8cq8qeH1Snr+x8nBSL/SZQBcw7Mkg6JIY9FN130lM9IvmSnwA/tmTSgSzB1f5uITv8CXReOMLKG23lqDkZDjJQ/76WcLlUjH61CgP6kICDwvxQSBhFdUOfuRR2D6FWMTjHVEJCSLsIQXmVkCp2T8Ioo32csrsJSYKHB6soa4h3hICqKCUPqSHNs95VlFgu/lorbZKFdg84jb7zGgzHfKC7broUSgoNmZZ0ITIndQhI85FcNEtFm2F3mUmobaFfORBuxtCeZKvfdOTAiy4WOJdC8SzZCXcW5t2j6hx2njDk2kfDZxjZY/+Yjc+MVNWEjdAVjw4dcATtiutS1MGcIo+kjMPbWy0gY5Lt2+26CZAK5D/5iqYhlgqWedUDh59t50UibHBQGFDayOiZYchBcHPsBhzP9zS5S38bv3LN+944U5tpU2KL8cu Dms1nBEE c8ufs+RDmovxfc/37hqPsPyFsZUvZiHOLcgiqXlJp4oG5VoAH4phK8GcCVjjNbSjrMaRThs7Ztf69dFJIoeT4bbjAsUiXTv0JuizsdjeGYObNFJ43gZ4LM+K0bxPeDpmSkgKTNFrbaOYLdbxZrcfKMx5PB7vYWgHEMxSVS3Odo67nhmuSz+Tp0E2PpnbsU7cdriWsCaMroTx9ooDX2i4XnUVsSQAd/Kgm5O1XY5WvagND5JKDg2wCQFZNi2ookj91JKm7gJi+8U1Sk/Nx7t5X/zsEBztuJmoWEZb+w/6kaj2UjNBCeo/jvGDuRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 May 2025 00:02:38 +0800 WangYuli wrote: > - for (i = tier % MAX_NR_TIERS; i <= min(tier, MAX_NR_TIERS - 1); i++) { > + for (i = tier % MAX_NR_TIERS; i <= min(tier, (int)(MAX_NR_TIERS - 1)); i++) { Make `tier' unsigned? After all, negative tier numbers are nonsensical.