linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	yuzhao@google.com, stevensd@chromium.org, kaleshsingh@google.com,
	zhanjun@uniontech.com, niecheng1@uniontech.com,
	guanwentao@uniontech.com
Subject: Re: [PATCH] mm: vmscan: Avoid signedness error for GCC 5.4
Date: Tue, 6 May 2025 16:24:38 -0700	[thread overview]
Message-ID: <20250506162438.91fffc7ef924d9653ed0f503@linux-foundation.org> (raw)
In-Reply-To: <85050791B887DC13+20250506160238.799984-1-wangyuli@uniontech.com>

On Wed,  7 May 2025 00:02:38 +0800 WangYuli <wangyuli@uniontech.com> wrote:

> -	for (i = tier % MAX_NR_TIERS; i <= min(tier, MAX_NR_TIERS - 1); i++) {
> +	for (i = tier % MAX_NR_TIERS; i <= min(tier, (int)(MAX_NR_TIERS - 1)); i++) {
	
Make `tier' unsigned?  After all, negative tier numbers are nonsensical.


  parent reply	other threads:[~2025-05-06 23:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 16:02 WangYuli
2025-05-06 16:22 ` Matthew Wilcox
2025-05-07  2:55   ` WangYuli
2025-05-07 20:46     ` David Laight
2025-05-07 12:06   ` David Laight
2025-05-06 23:24 ` Andrew Morton [this message]
2025-05-07  4:06   ` WangYuli
2025-05-07 18:07     ` Andrew Morton
2025-05-07 20:49       ` Matthew Wilcox
2025-05-10 10:24     ` David Laight
2025-05-15 15:11       ` WangYuli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250506162438.91fffc7ef924d9653ed0f503@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=guanwentao@uniontech.com \
    --cc=kaleshsingh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=niecheng1@uniontech.com \
    --cc=stevensd@chromium.org \
    --cc=wangyuli@uniontech.com \
    --cc=yuzhao@google.com \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox