From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FA0C3ABBF for ; Tue, 6 May 2025 00:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D9746B0093; Mon, 5 May 2025 20:38:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5276C6B0098; Mon, 5 May 2025 20:38:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20CE36B0095; Mon, 5 May 2025 20:38:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D3B986B0096 for ; Mon, 5 May 2025 20:38:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AEDFE140EFA for ; Tue, 6 May 2025 00:38:30 +0000 (UTC) X-FDA: 83410621980.10.9C54BEB Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf05.hostedemail.com (Postfix) with ESMTP id 2D6BB10000B for ; Tue, 6 May 2025 00:38:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746491909; a=rsa-sha256; cv=none; b=xGsAdCgn15WmDQQAsvbGRlfQZgTp5B8u22Vy5nD32X30ByWxAdpCsSkAO2fcf0dC+jRT+Z tplMrLQ3If2RQsmptUPWMIC5N2KVfo5tqK32uh446p4QRJmYjEmDqTaxNxM/VrWlZ4anjq ExWzGXGU5Dlq/zBT+F76bPAPFfG2Fug= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746491909; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rIrT894mYFPddGI75SeZC+Dr07QoIPjvN23IRr+cSTM=; b=MkyR6l5d+StuZ5jlIQPMHkdrVrqSCWTLlwLkmH1KEnkeGWdtNr9JmHylb2TXQPSjJLFPkl HXyq42NXTPEEn6evf/ZKXbLkUsx7OmbnuSnwwJim7NYnJkSOl6nqGqstaPQRJrXONX1p6v I12GwzJ+APQDd8CU1m1GwGGNCZda+44= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1uC6K6-000000000IF-3gGA; Mon, 05 May 2025 20:38:14 -0400 From: Rik van Riel To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, Rik van Riel , Yu-cheng Yu , Rik van Riel Subject: [RFC PATCH 6/9] x86/apic: Introduce Remote Action Request Operations Date: Mon, 5 May 2025 20:37:44 -0400 Message-ID: <20250506003811.92405-7-riel@surriel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250506003811.92405-1-riel@surriel.com> References: <20250506003811.92405-1-riel@surriel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2D6BB10000B X-Stat-Signature: dwrs3t3y5rf8y6hpeu3j1g6ez7n5i1tw X-Rspam-User: X-HE-Tag: 1746491908-709400 X-HE-Meta: U2FsdGVkX18+XB3MlA3K1lfNKIIDx70CAPgVfSvjyL8gy9EdWsBesf9qFORA7i4G/IC/w2z18PPe8aYY+8Hwq7G/R9WwStMCeAWlE3HSTNlBz6KdGpkrRYgFFMKoFYH+RCSqvgU6Se6tJLbnrUEG5xCf4LSc/spF9rTl6UV3OvZVqeSEXkATugUMziiwGc7HwNIw+N0afInFDBGp/HP2vZldzyKJUNppjlrH6UV/vOyHL0R+CZBDQD+HTHvXCqBt0BC0hdNXYpsNLpJhOzhVXif035qthw1RZdcY5hSKkhQN9gqdlaRd23mL8ZxxcyC2XmWRIs5HbIPx26Qv91Y2l+py6umGl5yHrx2nh+XsgFMVAR+sI9oPbY7fxyO1o0+4i25sdTZlNO3GZlGZrtHEajfPk6k1oyJp39pW2Zy4r/9EdREZ5OsoQ926DuUlel6XpR/d6XC1dmGqQvOeZH/GVd117fTzWdyPpihdS4lRR1QfErIviAWQ/Mnj3+7iqoTclQI9pt1QZgtiksFdG1cpwTnMDf4FMGmNWQakpNWQl+45By9FtWk8rTWnxADKR7mYuhXL3sx110CtXUc6TdIns9T5XIzmM67Q4nnyCHaDyGWg/qFAyOf/wTHCpWzEyDyACtFALM76oXNHCgv00al5AW7E5oKYWoTMgY82qfr+yc7c6IcD1s9opYcTYde82GfQbIPWaJ1AqF6CHtee1RLuafXrGiBabfKH1xXbJr9QZvuPT+vg2KlDIAU09Gtc/26Z3x26f2SiN7loHL95JIBFYvZqy25WrCL2hCdrIpFJYf7rFEjtXRl/Vx4GFJya5Nq6sxySvhsa59CWXP0WibpeOUhhvk7XrgxyUQf/Wt39F0Y8F758Yyif+PZrur8n3sPQDwWOil6ZjI42Wno0Pk3n9F7GHicd7Ym0IX0RKfk8RIdC/ShCkSTUVv4HuC9BmVs8q/XD/R+E9DUXqwR7x8r wHHQtMLJ qtyqpcaYd9vVHySYkPIEdhqmyggP0shi4viLWlxjTE1W7yPJsiPwK91wiPWf8GNn5+JzA5gUOVki5MlsO/F9R8KP+TCg5cJdbN6pXC2r/m4NUKiv8slkYsHUyp1nlgRjomWsmt77foyo200w5k2KWl529R0eY9DA4stJeJBqE74QW3qIvZO0PjJT+2Cus8z+2jSg/rqy7rVqK/JEEdeMCSCp9muM+iQomFSQIBPsCoZgMlJQTKcLxSSlYUxsIT2wmA0vbSfaMZVvKxqYL+6QkxNFT4ZzfzXNipMfnjJFzHJHtTDrDDJrzLC6OE5tAGOxjoBGAVDC7u4KPI71f/It4dVbp/p5A3ulMyx8KuzmheZ3TyAY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Rik van Riel RAR TLB flushing is started by sending a command to the APIC. This patch adds Remote Action Request commands. [riel: move some things around to acount for 6 years of changes] Signed-off-by: Yu-cheng Yu Signed-off-by: Rik van Riel --- arch/x86/include/asm/apicdef.h | 1 + arch/x86/include/asm/irq_vectors.h | 5 +++++ arch/x86/include/asm/smp.h | 15 +++++++++++++++ arch/x86/kernel/apic/ipi.c | 23 +++++++++++++++++++---- arch/x86/kernel/apic/local.h | 3 +++ arch/x86/kernel/smp.c | 3 +++ 6 files changed, 46 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h index 094106b6a538..b152d45af91a 100644 --- a/arch/x86/include/asm/apicdef.h +++ b/arch/x86/include/asm/apicdef.h @@ -92,6 +92,7 @@ #define APIC_DM_LOWEST 0x00100 #define APIC_DM_SMI 0x00200 #define APIC_DM_REMRD 0x00300 +#define APIC_DM_RAR 0x00300 #define APIC_DM_NMI 0x00400 #define APIC_DM_INIT 0x00500 #define APIC_DM_STARTUP 0x00600 diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h index 47051871b436..c417b0015304 100644 --- a/arch/x86/include/asm/irq_vectors.h +++ b/arch/x86/include/asm/irq_vectors.h @@ -103,6 +103,11 @@ */ #define POSTED_MSI_NOTIFICATION_VECTOR 0xeb +/* + * RAR (remote action request) TLB flush + */ +#define RAR_VECTOR 0xe0 + #define NR_VECTORS 256 #ifdef CONFIG_X86_LOCAL_APIC diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h index 0c1c68039d6f..1ab9f5fcac8a 100644 --- a/arch/x86/include/asm/smp.h +++ b/arch/x86/include/asm/smp.h @@ -40,6 +40,9 @@ struct smp_ops { void (*send_call_func_ipi)(const struct cpumask *mask); void (*send_call_func_single_ipi)(int cpu); + + void (*send_rar_ipi)(const struct cpumask *mask); + void (*send_rar_single_ipi)(int cpu); }; /* Globals due to paravirt */ @@ -100,6 +103,16 @@ static inline void arch_send_call_function_ipi_mask(const struct cpumask *mask) smp_ops.send_call_func_ipi(mask); } +static inline void arch_send_rar_single_ipi(int cpu) +{ + smp_ops.send_rar_single_ipi(cpu); +} + +static inline void arch_send_rar_ipi_mask(const struct cpumask *mask) +{ + smp_ops.send_rar_ipi(mask); +} + void cpu_disable_common(void); void native_smp_prepare_boot_cpu(void); void smp_prepare_cpus_common(void); @@ -120,6 +133,8 @@ void __noreturn mwait_play_dead(unsigned int eax_hint); void native_smp_send_reschedule(int cpu); void native_send_call_func_ipi(const struct cpumask *mask); void native_send_call_func_single_ipi(int cpu); +void native_send_rar_ipi(const struct cpumask *mask); +void native_send_rar_single_ipi(int cpu); asmlinkage __visible void smp_reboot_interrupt(void); __visible void smp_reschedule_interrupt(struct pt_regs *regs); diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c index 98a57cb4aa86..e5e9fc08f86c 100644 --- a/arch/x86/kernel/apic/ipi.c +++ b/arch/x86/kernel/apic/ipi.c @@ -79,7 +79,7 @@ void native_send_call_func_single_ipi(int cpu) __apic_send_IPI(cpu, CALL_FUNCTION_SINGLE_VECTOR); } -void native_send_call_func_ipi(const struct cpumask *mask) +static void do_native_send_ipi(const struct cpumask *mask, int vector) { if (static_branch_likely(&apic_use_ipi_shorthand)) { unsigned int cpu = smp_processor_id(); @@ -88,14 +88,19 @@ void native_send_call_func_ipi(const struct cpumask *mask) goto sendmask; if (cpumask_test_cpu(cpu, mask)) - __apic_send_IPI_all(CALL_FUNCTION_VECTOR); + __apic_send_IPI_all(vector); else if (num_online_cpus() > 1) - __apic_send_IPI_allbutself(CALL_FUNCTION_VECTOR); + __apic_send_IPI_allbutself(vector); return; } sendmask: - __apic_send_IPI_mask(mask, CALL_FUNCTION_VECTOR); + __apic_send_IPI_mask(mask, vector); +} + +void native_send_call_func_ipi(const struct cpumask *mask) +{ + do_native_send_ipi(mask, CALL_FUNCTION_VECTOR); } void apic_send_nmi_to_offline_cpu(unsigned int cpu) @@ -106,6 +111,16 @@ void apic_send_nmi_to_offline_cpu(unsigned int cpu) return; apic->send_IPI(cpu, NMI_VECTOR); } + +void native_send_rar_single_ipi(int cpu) +{ + apic->send_IPI_mask(cpumask_of(cpu), RAR_VECTOR); +} + +void native_send_rar_ipi(const struct cpumask *mask) +{ + do_native_send_ipi(mask, RAR_VECTOR); +} #endif /* CONFIG_SMP */ static inline int __prepare_ICR2(unsigned int mask) diff --git a/arch/x86/kernel/apic/local.h b/arch/x86/kernel/apic/local.h index bdcf609eb283..833669174267 100644 --- a/arch/x86/kernel/apic/local.h +++ b/arch/x86/kernel/apic/local.h @@ -38,6 +38,9 @@ static inline unsigned int __prepare_ICR(unsigned int shortcut, int vector, case NMI_VECTOR: icr |= APIC_DM_NMI; break; + case RAR_VECTOR: + icr |= APIC_DM_RAR; + break; } return icr; } diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c index 18266cc3d98c..2c51ed6aaf03 100644 --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c @@ -297,5 +297,8 @@ struct smp_ops smp_ops = { .send_call_func_ipi = native_send_call_func_ipi, .send_call_func_single_ipi = native_send_call_func_single_ipi, + + .send_rar_ipi = native_send_rar_ipi, + .send_rar_single_ipi = native_send_rar_single_ipi, }; EXPORT_SYMBOL_GPL(smp_ops); -- 2.49.0