From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D51A6C3ABB6 for ; Tue, 6 May 2025 00:23:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0563A6B000A; Mon, 5 May 2025 20:23:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 005376B0082; Mon, 5 May 2025 20:23:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE7B76B0083; Mon, 5 May 2025 20:23:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BCE196B000A for ; Mon, 5 May 2025 20:23:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A1F2E160E7F for ; Tue, 6 May 2025 00:23:27 +0000 (UTC) X-FDA: 83410584054.21.E4C3FF1 Received: from mail-ot1-f73.google.com (mail-ot1-f73.google.com [209.85.210.73]) by imf15.hostedemail.com (Postfix) with ESMTP id D9D4DA0002 for ; Tue, 6 May 2025 00:23:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=37Ky7kuG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3fFYZaAcKCNUAP5J31J7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jyescas.bounces.google.com designates 209.85.210.73 as permitted sender) smtp.mailfrom=3fFYZaAcKCNUAP5J31J7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jyescas.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746491005; a=rsa-sha256; cv=none; b=p5kOAMUdwKAWEYGMHGyRmKsAQ9u5HNTenqpNwbe4PD7LE+XjKDv0LGJJSfQWakcxmY7lEn NnfbtVKm+Z1eotG1H+KcOivrZqlGLBnVvtTW4LU/PzD6PVwOyfIMyciM+WzYuVhLfVd7Wg TbPYPzjOdXoZ68P5uaWYYN+8Kj2SKQE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=37Ky7kuG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3fFYZaAcKCNUAP5J31J7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jyescas.bounces.google.com designates 209.85.210.73 as permitted sender) smtp.mailfrom=3fFYZaAcKCNUAP5J31J7FF7C5.3FDC9ELO-DDBM13B.FI7@flex--jyescas.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746491005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Ky7Ox4614Ju9ch/TWPsIUc4fTfh+nlNJiyC+j1YiieA=; b=U3rkhfv7z+NN922OSqtxhdplbvWRhq8UI/VY+mUKogTo8Ljj0a3oOVZJkNMgXKoot2tI0S UoBA2pK4jTTFPQDK0EPwfnqVWdWWtVMd0p3cVZP6ZlQBewQ+7zfY+rrUX5b+E3TNwqQD5d bJhiETLLrEuT/b1Ob9oqou9R5Pn+buQ= Received: by mail-ot1-f73.google.com with SMTP id 46e09a7af769-731e2cf219eso716276a34.2 for ; Mon, 05 May 2025 17:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746491005; x=1747095805; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Ky7Ox4614Ju9ch/TWPsIUc4fTfh+nlNJiyC+j1YiieA=; b=37Ky7kuGyy1JZnek5KeJdB8veeKow9ab96hOa1coH/lUXtcj5ErSwTCw6I+2v5LyKZ KntjNJUUzbIT8MCy2HWKa5JaRmI0NaRrR9UIEW6H1DpMDrvKZxaL17nr1OIgPUYcV1Pq MeyfGwJtgjgmm7RpL4ZObNK2lAHmlG/fnL+aPR0kTKHVcVWzAvpXTDbbv5UBWpXbkppV Ll5KTAdXVufsILIDCv6a9HqH5CX9AjrCX7a05C68zamREfR01yqFb/7cXTF8FtMGbuaX 76TpO/yPEl2/sk+FbGBu9csBUyt20vOUCug1gP6CqVvvzub2ZACqSJzEYnSaHMFAuVGm l9Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746491005; x=1747095805; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ky7Ox4614Ju9ch/TWPsIUc4fTfh+nlNJiyC+j1YiieA=; b=EvQciEzrbkTWGlpdMH8D86nIUgm82+NsHQ9EjHfvNpx7OXJgYdsbMPjURqqg/uyaat kk6bR8IbUbfs4iTYm3ltkmMmIUcQs4H7MnAUU14MkaDpbj5qNxJe1AMKS4rzC7mjnZVP iAQBxBIDc18YBgvtbA5R9IzXgKVXPTPrRFgnG/IKtQ6t0hKOhkiLlL5iDSWQmXsV3vxI xjgj/hWi1u1R94SVZyUzebCS5+CIwvFGWw8roxtg0Ir3O6MLg8gHyRnwH10T2UvKtCnV MMpzB24YiskzqcFEB0ibQqyywYfqpHDYPSnmbegSUHd2oQTxbFA7OtWwQY9ELRZnD6qB kS/w== X-Forwarded-Encrypted: i=1; AJvYcCVjVcuguIMDngpdzXU9Sm3Sveh3SyjQ/O/vflQGXVoHOpQg/xuQ/U1iCVWnlq63YHFaC3LICnak/A==@kvack.org X-Gm-Message-State: AOJu0YxxrOUmy9HUytDIZowKHSgd9EFVMYyGX06+JwRwIVlWJ3gykEcV p1MyKRdlmAojYcN5yQNR5A40K+Rn37Vs5z6910OBOfyq40V84tbOPFVviHs64MTdBYc6Fgd1G3e UP6KuKg== X-Google-Smtp-Source: AGHT+IGTYWrQCtVFnG6Sm8ybMYB3XLNPBp4NAwjj+gz5NG9EEwQSQh0InXP3Bp6+FcM/pbAkgkD7sZ0K8zNF X-Received: from oabwq2.prod.google.com ([2002:a05:6871:aa02:b0:2b7:fdc9:21f4]) (user=jyescas job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6871:6aa:b0:2bd:456c:92a with SMTP id 586e51a60fabf-2db38be6b1dmr1020715fac.10.1746491004738; Mon, 05 May 2025 17:23:24 -0700 (PDT) Date: Mon, 5 May 2025 17:22:58 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.49.0.967.g6a0df3ecc3-goog Message-ID: <20250506002319.513795-1-jyescas@google.com> Subject: [PATCH v3] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order From: Juan Yescas To: Andrew Morton , Zi Yan , Juan Yescas , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, Vlastimil Babka , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Minchan Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D9D4DA0002 X-Stat-Signature: 4wpg3r6uq5hpe1z8cyjygdo8tmzqs6t4 X-Rspam-User: X-HE-Tag: 1746491005-802956 X-HE-Meta: U2FsdGVkX18TrTQ0vaQ8D+vMrc60NuIaDsMEgbZIGBto3vXMmS4gLcKQouaOSwZDxnbTQD+mhRZmuzPhjk7djW91cIjbGZ1oCxO96KLCTqekXC02/IOurBT3qn1inGlEa2Y3tN4zMJHFG8vRAacTxgvJGnQeJp2xQcA35A/3M1C3nRMciAvlzInp6t/oyio0/HA1hR/JBBbIqPJXfK01i7jBFSZhcG9EE9n9eQTbosiJUdEnnqBfiYfAjbLvISNdRAKpRP73qY7wGW01k723aw8PfBdNXeu1EWY2+Tb2im8Su8HUgKhvrfhIZgytQzLm9fL+t/Ze2Yiie9/zxjRE7ZBKOQUESpMFE/WcrVOrh4wpoU+vEdTOlFsvB2agJzbg2mbGyPvGDOCgDaYuOHXf0RBEZjOdwJZwbxauvscbSwHD3zCwwa44NYs64PPl2ZfpKUe1nizn/BveBAsHRkNttfO31Gssnp8F/ByRUFchS9S+MlI2okpOon2XTns4M07BSj4CI4oBgi9haf1juLF6n5Vrbn3TjMKxYPMbptpZTRb4gvmMCW/5dK7S0RvAAzRcG3yOwswykQSN8x3iQ49Bxmn1BksQoaY7zG8XO5sC5qnZjx4iFcrfbQ4Mhjy03X8CrzcYzXYWWT+lNC6hCPRW9WdpVc5x5CPAU4sZhjIB3g1x35yaxD16J47DyuGbQe2poauXgl0IIK/lhPDXjw3090zZm6YmeUAyQtJMoN4TLgS8ZeJFSrg1bg7OhGd58L6WXy277gEo52LUelC2iF7YZ86x7LRCWaGkrXGbGODB/cSdHoB+lcykH1pPvjxzZDxg+j4G0E7mHOFeu+RddUXkLMcHjHatubFD8I2mBsy9TDVDdrQJqHf6fjenyRqmN6ZfJFZHldJf1VKz/6QDb0mqFzAzmjGajd1Gtl9HS/bGjhdYuT6bQxw5yF0qCRjGkc7PpnlHLSrPQp36/spYd4R OmkRGhl7 c9Oaui/UTX0A2pLzauhAJVhX8tPd7Wrlgw5YiOt+jzcw8MfU+cTe5TOeQL8rje5ej8T0gL1yd9lydHXhKwP7u3OyE+FgFPqtESjTUA1OElEfLJw+TKjOsSwBDrvdEXqv7uLo8EPjano8QZknRqs9KzScbihSb276zlx1c1FqYRIhosxZMN1JgfV+pe7UIHDj6ZrUP7oEnKyjCu6a1mae7wzT/g5xS9juQL5PNOZgYfWopvcN/AvWs53gq6hPzmud7nweNXoaRR5yEcyy4LVF24LMmGyejfDig02I6vBzXdhYhFFer/8X1l9yfCq5dfxD+R/U75tupzNIi7ch9WqpQhBL5dMPGQIbuCGO7UOtY6p0QyYSe8rQgJKjjMK/9uKeFjB+wz8qw6uYZX5ODpt8KaYgXkR6HTqubygD+InNakJUcccTIpmMb6b2TRPQTeHTj1URsvTIlx44R0xfkOkK+1iSn0VkUxX6KvccvfSKClGojJuCjSKb18sF4tfF8iJ1cYBamzYupZlU0gSwbz608sddADcFBLfPfai0LreS0vVs//of9AOts2FvvWFFA0Wj6/rAIS+p5seqnKuS/mIKxY06h7+rp5rd4APUPbMYhkpR3DH5Takql8yB0DTDDJmkqKOlsYSiczhyVn4bYOkeLyoHYvR69+83tCByL5gajroUvAlbMyaxrHhgEN4mHL5kBeMdJ4jGuOk3wLDak4m4SlOzfOx8S25QjKz+lVXKHk5RECKUChRdylqeG5QiA9pKmY5AYubaTukpTslqDRqHvlDO+gj3vlKX/U8HuIE5znrygdVjUFAa+pEzVzPiliRh65Kb1po+ZQ6Lf8KQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Problem: On large page size configurations (16KiB, 64KiB), the CMA alignment requirement (CMA_MIN_ALIGNMENT_BYTES) increases considerably, and this causes the CMA reservations to be larger than necessary. This means that system will have less available MIGRATE_UNMOVABLE and MIGRATE_RECLAIMABLE page blocks since MIGRATE_CMA can't fallback to them. The CMA_MIN_ALIGNMENT_BYTES increases because it depends on MAX_PAGE_ORDER which depends on ARCH_FORCE_MAX_ORDER. The value of ARCH_FORCE_MAX_ORDER increases on 16k and 64k kernels. For example, in ARM, the CMA alignment requirement when: - CONFIG_ARCH_FORCE_MAX_ORDER default value is used - CONFIG_TRANSPARENT_HUGEPAGE is set: PAGE_SIZE | MAX_PAGE_ORDER | pageblock_order | CMA_MIN_ALIGNMENT_BYTES ----------------------------------------------------------------------- 4KiB | 10 | 10 | 4KiB * (2 ^ 10) = 4MiB 16Kib | 11 | 11 | 16KiB * (2 ^ 11) = 32MiB 64KiB | 13 | 13 | 64KiB * (2 ^ 13) = 512MiB There are some extreme cases for the CMA alignment requirement when: - CONFIG_ARCH_FORCE_MAX_ORDER maximum value is set - CONFIG_TRANSPARENT_HUGEPAGE is NOT set: - CONFIG_HUGETLB_PAGE is NOT set PAGE_SIZE | MAX_PAGE_ORDER | pageblock_order | CMA_MIN_ALIGNMENT_BYTES ------------------------------------------------------------------------ 4KiB | 15 | 15 | 4KiB * (2 ^ 15) = 128MiB 16Kib | 13 | 13 | 16KiB * (2 ^ 13) = 128MiB 64KiB | 13 | 13 | 64KiB * (2 ^ 13) = 512MiB This affects the CMA reservations for the drivers. If a driver in a 4KiB kernel needs 4MiB of CMA memory, in a 16KiB kernel, the minimal reservation has to be 32MiB due to the alignment requirements: reserved-memory { ... cma_test_reserve: cma_test_reserve { compatible = "shared-dma-pool"; size = <0x0 0x400000>; /* 4 MiB */ ... }; }; reserved-memory { ... cma_test_reserve: cma_test_reserve { compatible = "shared-dma-pool"; size = <0x0 0x2000000>; /* 32 MiB */ ... }; }; Solution: Add a new config CONFIG_PAGE_BLOCK_ORDER that allows to set the page block order in all the architectures. The maximum page block order will be given by ARCH_FORCE_MAX_ORDER. By default, CONFIG_PAGE_BLOCK_ORDER will have the same value that ARCH_FORCE_MAX_ORDER. This will make sure that current kernel configurations won't be affected by this change. It is a opt-in change. This patch will allow to have the same CMA alignment requirements for large page sizes (16KiB, 64KiB) as that in 4kb kernels by setting a lower pageblock_order. Tests: - Verified that HugeTLB pages work when pageblock_order is 1, 7, 10 on 4k and 16k kernels. - Verified that Transparent Huge Pages work when pageblock_order is 1, 7, 10 on 4k and 16k kernels. - Verified that dma-buf heaps allocations work when pageblock_order is 1, 7, 10 on 4k and 16k kernels. Benchmarks: The benchmarks compare 16kb kernels with pageblock_order 10 and 7. The reason for the pageblock_order 7 is because this value makes the min CMA alignment requirement the same as that in 4kb kernels (2MB). - Perform 100K dma-buf heaps (/dev/dma_heap/system) allocations of SZ_8M, SZ_4M, SZ_2M, SZ_1M, SZ_64, SZ_8, SZ_4. Use simpleperf (https://developer.android.com/ndk/guides/simpleperf) to measure the # of instructions and page-faults on 16k kernels. The benchmark was executed 10 times. The averages are below: # instructions | #page-faults order 10 | order 7 | order 10 | order 7 -------------------------------------------------------- 13,891,765,770 | 11,425,777,314 | 220 | 217 14,456,293,487 | 12,660,819,302 | 224 | 219 13,924,261,018 | 13,243,970,736 | 217 | 221 13,910,886,504 | 13,845,519,630 | 217 | 221 14,388,071,190 | 13,498,583,098 | 223 | 224 13,656,442,167 | 12,915,831,681 | 216 | 218 13,300,268,343 | 12,930,484,776 | 222 | 218 13,625,470,223 | 14,234,092,777 | 219 | 218 13,508,964,965 | 13,432,689,094 | 225 | 219 13,368,950,667 | 13,683,587,37 | 219 | 225 ------------------------------------------------------------------- 13,803,137,433 | 13,131,974,268 | 220 | 220 Averages There were 4.85% #instructions when order was 7, in comparison with order 10. 13,803,137,433 - 13,131,974,268 = -671,163,166 (-4.86%) The number of page faults in order 7 and 10 were the same. These results didn't show any significant regression when the pageblock_order is set to 7 on 16kb kernels. - Run speedometer 3.1 (https://browserbench.org/Speedometer3.1/) 5 times on the 16k kernels with pageblock_order 7 and 10. order 10 | order 7 | order 7 - order 10 | (order 7 - order 10) % ------------------------------------------------------------------- 15.8 | 16.4 | 0.6 | 3.80% 16.4 | 16.2 | -0.2 | -1.22% 16.6 | 16.3 | -0.3 | -1.81% 16.8 | 16.3 | -0.5 | -2.98% 16.6 | 16.8 | 0.2 | 1.20% ------------------------------------------------------------------- 16.44 16.4 -0.04 -0.24% Averages The results didn't show any significant regression when the pageblock_order is set to 7 on 16kb kernels. Cc: Andrew Morton Cc: Vlastimil Babka Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: David Hildenbrand CC: Mike Rapoport Cc: Zi Yan Cc: Suren Baghdasaryan Cc: Minchan Kim Signed-off-by: Juan Yescas Acked-by: Zi Yan --- Changes in v3: - Rename ARCH_FORCE_PAGE_BLOCK_ORDER to PAGE_BLOCK_ORDER as per Matthew's suggestion. - Update comments in pageblock-flags.h for pageblock_order value when THP or HugeTLB are not used. Changes in v2: - Add Zi's Acked-by tag. - Move ARCH_FORCE_PAGE_BLOCK_ORDER config to mm/Kconfig as per Zi and Matthew suggestion so it is available to all the architectures. - Set ARCH_FORCE_PAGE_BLOCK_ORDER to 10 by default when ARCH_FORCE_MAX_ORDER is not available. include/linux/pageblock-flags.h | 14 ++++++++++---- mm/Kconfig | 31 +++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/include/linux/pageblock-flags.h b/include/linux/pageblock-flags.h index fc6b9c87cb0a..0c4963339f0b 100644 --- a/include/linux/pageblock-flags.h +++ b/include/linux/pageblock-flags.h @@ -28,6 +28,12 @@ enum pageblock_bits { NR_PAGEBLOCK_BITS }; +#if defined(CONFIG_PAGE_BLOCK_ORDER) +#define PAGE_BLOCK_ORDER CONFIG_PAGE_BLOCK_ORDER +#else +#define PAGE_BLOCK_ORDER MAX_PAGE_ORDER +#endif /* CONFIG_PAGE_BLOCK_ORDER */ + #if defined(CONFIG_HUGETLB_PAGE) #ifdef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE @@ -41,18 +47,18 @@ extern unsigned int pageblock_order; * Huge pages are a constant size, but don't exceed the maximum allocation * granularity. */ -#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, MAX_PAGE_ORDER) +#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, PAGE_BLOCK_ORDER) #endif /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */ #elif defined(CONFIG_TRANSPARENT_HUGEPAGE) -#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, MAX_PAGE_ORDER) +#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, PAGE_BLOCK_ORDER) #else /* CONFIG_TRANSPARENT_HUGEPAGE */ -/* If huge pages are not used, group by MAX_ORDER_NR_PAGES */ -#define pageblock_order MAX_PAGE_ORDER +/* If huge pages are not used, group by PAGE_BLOCK_ORDER */ +#define pageblock_order PAGE_BLOCK_ORDER #endif /* CONFIG_HUGETLB_PAGE */ diff --git a/mm/Kconfig b/mm/Kconfig index e113f713b493..c52be3489aa3 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -989,6 +989,37 @@ config CMA_AREAS If unsure, leave the default value "8" in UMA and "20" in NUMA. +# +# Select this config option from the architecture Kconfig, if available, to set +# the max page order for physically contiguous allocations. +# +config ARCH_FORCE_MAX_ORDER + int + +# When ARCH_FORCE_MAX_ORDER is not defined, the default page block order is 10, +# as per include/linux/mmzone.h. +config PAGE_BLOCK_ORDER + int "Page Block Order" + range 1 10 if !ARCH_FORCE_MAX_ORDER + default 10 if !ARCH_FORCE_MAX_ORDER + range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER + default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER + + help + The page block order refers to the power of two number of pages that + are physically contiguous and can have a migrate type associated to + them. The maximum size of the page block order is limited by + ARCH_FORCE_MAX_ORDER. + + This option allows overriding the default setting when the page + block order requires to be smaller than ARCH_FORCE_MAX_ORDER. + + Reducing pageblock order can negatively impact THP generation + successful rate. If your workloads uses THP heavily, please use this + option with caution. + + Don't change if unsure. + config MEM_SOFT_DIRTY bool "Track memory changes" depends on CHECKPOINT_RESTORE && HAVE_ARCH_SOFT_DIRTY && PROC_FS -- 2.49.0.967.g6a0df3ecc3-goog