From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682C5C3ABAC for ; Tue, 6 May 2025 13:44:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BF756B008A; Tue, 6 May 2025 09:44:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66CA46B009B; Tue, 6 May 2025 09:44:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BF696B009C; Tue, 6 May 2025 09:44:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D1826B008A for ; Tue, 6 May 2025 09:44:36 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 29B391C9FDA for ; Tue, 6 May 2025 13:44:38 +0000 (UTC) X-FDA: 83412603036.02.D96800C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf20.hostedemail.com (Postfix) with ESMTP id 322721C0005 for ; Tue, 6 May 2025 13:44:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JUjCQXcu; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746539076; a=rsa-sha256; cv=none; b=vqpMpV2KKOrBhbCo4r/7H2r9DqC825TrzFgznCybPq/AitgG6YwyzxVLOAd5uqZz7V+xvU 7ulE6t+V5lhgV4DOEC1zLq0vWNG+ZAY2Hy7cBUKFZ+e7dOF7doeT31RnddxbJd5c/XkFUi Vr0zaViAOGBxxDz/Z3gkGP5AY6n8Iro= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JUjCQXcu; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746539076; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SYew6bwTVdEBLftVZRAB2qaK+/+qZdjhjAzLy5UDhzI=; b=n1Li4BFA18rXhpl8SlSvvJFPpPvm8oxlG7atblQU3kFktAL2d2X6LxcIRniPDEaKCvsBIK f1c66/4TITbHUKXZ7bwjfsk1vk2mHu38quGCTaIKuORlWMWwT2JJosP/7R8bcjo3kwtPN4 bEVTT9s8gHWMdmINL4mmqugzfinQ6GE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7AD82A471BA; Tue, 6 May 2025 13:44:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 26186C4CEEE; Tue, 6 May 2025 13:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746539075; bh=DRC3Zo87TXDBJOVIVAvor3EDAyxDRAGUFqYaexF9kzo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=JUjCQXcu2ZaYFEyRY35cZ0MLRW13tZnuZgmIm40SrxJkygGdPaeWOYbLa/I6GFqp7 li+7sIjFIYlxoB2HSYS9XW3HTbZ5LJQTuSIEEpa6F3xRf12CKzUbis1z5dgAI2CvXb N7Agff+VENIv6pu+K1EvgwIThevxkXXUoV/9t5vVKcXzgpwtkVD4m8jBCUCt2AaSFx R9g3Hs3zlHrr2taoOtQ+NTiZ93AatLOIZ6bQTSEGht/ZeAd0a5Jtvh+YzquL3JMCzs p+FJ3PSTWp9OT4rACqIzP30O3sddifFnIb88MvkrRORPgiPjA9ffO5DOzAHPSs6fYq rH/jDhqUXj+cw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17672C3ABC3; Tue, 6 May 2025 13:44:35 +0000 (UTC) From: Ignacio Moreno Gonzalez via B4 Relay Date: Tue, 06 May 2025 15:44:33 +0200 Subject: [PATCH v2 2/2] mm: madvise: no-op for MADV_NOHUGEPAGE if THP is disabled MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250506-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v2-2-f11f0c794872@kuka.com> References: <20250506-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v2-0-f11f0c794872@kuka.com> In-Reply-To: <20250506-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v2-0-f11f0c794872@kuka.com> To: lorenzo.stoakes@oracle.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ignacio Moreno Gonzalez , Matthew Wilcox X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746539072; l=1361; i=Ignacio.MorenoGonzalez@kuka.com; s=20220915; h=from:subject:message-id; bh=mZUe80SjjB0V+4EVN/Y+dsF/fiezXfRRXC2NP5J4EHM=; b=jxT00NHjKAHXYvlci1kq/Iwg3Nujh6KnKh0VA1tFn9F+W21DkyxkRefWe7O0qebY6rwyQ0h6L FbxTdmx1iQBC9pqJTsMVAUZvGQdsPZvrTI/h6+7B/GrzTFUVZwsbaWg X-Developer-Key: i=Ignacio.MorenoGonzalez@kuka.com; a=ed25519; pk=j7nClQnc5Q1IDuT4eS/rYkcLHXzxszu2jziMcJaFdBQ= X-Endpoint-Received: by B4 Relay for Ignacio.MorenoGonzalez@kuka.com/20220915 with auth_id=391 X-Original-From: Ignacio Moreno Gonzalez Reply-To: Ignacio.MorenoGonzalez@kuka.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 322721C0005 X-Stat-Signature: n9sh8tkqcse6tux6ehaus53arezks9sz X-HE-Tag: 1746539076-282477 X-HE-Meta: U2FsdGVkX18+qNJbQ10O1USh8Ura/4RHR1i+vymCSbghHwjhAp2e0kX7Y9toIzjmB30cdbFaRrro3XVBs9jRPl0EqHux1XiNHR5n8zO5ENCKRbkBaT/JWuPaWzVNR1TskEEDvGujbKKP1gTlA6o3uuHa812XAs6L2MoauP7Rk2mkFrV23n6uQjyftPKdVtC8wniPkPHxoztHjfK8UnEvIr7DWjECVRr/IZksCRmiNxaTiVF8F7EU1NnWrPOc4pjAzFPDp4SOY2wJxE0dg2vYfyd3dqOvuyWN1fXe3mOcaFeeJm1tgjgIE6FlH4ZUuX502BwVKmKnJmyCH7Heho0Ujh3d8F67+Q6vblbHjhpXOZ9+rzs7f1SQY4qO9wk3YdTSo0axJuNgpG7ABya7fQL2cNd048I9cJiYjIwWh9VWM+tgfScsKNcNDA6bNFPdyNJgBaUIGUaFBZv+FBYmHDPFWNI/np7WXVRG/OSIpNGW/CGL0v4V+ZWoW5GmqdCJdrZwkDB49xQ9WYxoFyZ4kJJcRtZ4f+ieblzn6J9LdnLuUIImXjj4j7sgoRwUi/j8pdFvoJwdemOGkNpUTPpp72xPqBoDC3KzCieaM2GlxtIKr2jPbclKjc0f/sw+ARelbrfQqrLygf5a3jJgCPMR5GV7M+TgCzPJ8fccY+GbPVhjtoW47IYHXXqoehX77sITcfP18zPpvHOwnkozgMAGJ6yF/URdqo5EHtZpQQ5zxKojXCc8XKNHu/NAMO+79XzWaiCgHYBj43gqLx1/oRoh75OdQh8ke22fQeYG0XMG8HJxerCzhY1GqIwPrfof50AQ+Lg7qxHjW48oND65xgQ7tqJlj7YKji2RHfvqtReoUFfZCCKuWme8spA2URFCauVKx+MsNIBRI3S4TDdMFpJHWlIMK4t05OudaGPi/9bOh3pJRssD/yTtCHTg8iX8sDkCRwRRGj+37nL9BqsX4z1Fnlv 5aC/3b33 iO4JaDJNslefszmouMXv2HMckQeOKp+DR8ojqsunNN73Z1BWQs7kqjHFZfBJU3XiZ1GCThsltPe7g+knWl+3CQK3ZrUwnncqyhVfC8S8g7y2tJ8BSxhxCyZ3b94GyHnPnkyjEzRGybriaXAIfezMa8IznfeLoJrqaMaJH9kdl3bbFih3zydl+OI1DarGsuEA70sUElV4tUl0vuMJZHaaFqy03xWy/BMhYiod5JeM0TcsqONljEGFtc+68bBfPtf0x0h88GWzHWM6N7/ercjogbxNr2TzcbceRfGmRIu4H+K190qBNaapS+lxjFUJyJp4qDkMyzdbhw3Z7JGEwF5TYKdj+znOHcRK4VtfprjS9GlfqGqETAqm3z+ht1oxd22/D99Jh6Ax2zKDJLcie4XWkE3KJuRy/FZCQrCj0VigrSvWZHar4K3/g7D5V55+qqs0QdQ8+RUyjipYmcYPTX/2QYYo6wzTE7VTCqv41nZv53/aRUqUySiQciBBh9ktBDmjqyDgAW0NW/CskpHeCeIq64vAb3yiMsRhFnsaSh2wXv/sKl8fGFnOV8rObzGO0KHHu3HazlT4Dvaoa6VEm6k88u1P02ICMPGDaTwNIPpocbyxcK7IYCHrNMm3Zrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ignacio Moreno Gonzalez VM_NOHUGEPAGE is a no-op in a kernel without THP. So it makes no sense to return an error when calling madvise() with MADV_NOHUGEPAGE. Suggested-by: Matthew Wilcox Reviewed-by: Lorenzo Stoakes Reviewed-by: Yang Shi Signed-off-by: Ignacio Moreno Gonzalez --- include/linux/huge_mm.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index e893d546a49f464f7586db639fe216231f03651a..cdb991f9be918182f94003394cf793654a080224 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -7,6 +7,10 @@ #include /* only for vma_is_dax() */ #include +#ifndef CONFIG_TRANSPARENT_HUGEPAGE +#include +#endif + vm_fault_t do_huge_pmd_anonymous_page(struct vm_fault *vmf); int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, pmd_t *dst_pmd, pmd_t *src_pmd, unsigned long addr, @@ -598,6 +602,8 @@ static inline bool unmap_huge_pmd_locked(struct vm_area_struct *vma, static inline int hugepage_madvise(struct vm_area_struct *vma, unsigned long *vm_flags, int advice) { + if (advice == MADV_NOHUGEPAGE) + return 0; return -EINVAL; } -- 2.39.5