From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D257C3ABBF for ; Tue, 6 May 2025 13:44:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F04196B009C; Tue, 6 May 2025 09:44:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C89BE6B009F; Tue, 6 May 2025 09:44:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADED36B009C; Tue, 6 May 2025 09:44:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 776776B009D for ; Tue, 6 May 2025 09:44:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A5E05160302 for ; Tue, 6 May 2025 13:44:38 +0000 (UTC) X-FDA: 83412603036.24.8A227A6 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf09.hostedemail.com (Postfix) with ESMTP id 94009140002 for ; Tue, 6 May 2025 13:44:36 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PhQoYpk7; spf=pass (imf09.hostedemail.com: domain of devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746539076; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=IXN19Z1KVYCENsSXINti/N0QzDdUim28rVJiK/RtSCw=; b=Yn1FGGeg8sp8ZgfdB3S06fY9C6JrGL/Q8U5Nqx/RrKWGiyghrFARFAxWh7jObv8VogMwA/ DMIYP1WQB2FfMx1+CIpa8wQBW6avauaH3z7d6zDOP9n2D9hx3flLVlk9l97XiJQWrTN8D+ Q9CZ2nJVTY7f4umLKnwCGl2nbglcUT0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PhQoYpk7; spf=pass (imf09.hostedemail.com: domain of devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746539076; a=rsa-sha256; cv=none; b=mQPy+aSUPylozXOfhG0KepDvyHa+VIT1MlUKG3QyAwRNSlNxq0CAh5YOfBS3Nv2AuLyj1K f8BERCc8AXV7hI7MV6gkpqFMV5sLR7g/kF7xA+UHmCIdmQHpZrwu/rtsO4pMGN8DEpRu10 hXOr9lP1Hwjt4LIJUoNqN0rBCZi2Irc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 342B44A5BF; Tue, 6 May 2025 13:44:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 0FC87C4CEE4; Tue, 6 May 2025 13:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746539075; bh=ilPU3kHXp7rUlXp/tVdwQH8b/OLryQpTRvXT0OKoe/o=; h=From:Subject:Date:To:Cc:Reply-To:From; b=PhQoYpk7kvk06QyLdg8METHb3TDGTyRGwdnPmDzQkZ4B637EvOnJ1K8WfdbshMmS5 PogY7RBbpqik8zQtFrWv6LWa1o4EJHP5g5CjrfsxgPjfzP797aHxmJ9Vy1Ayfhbhqr Dcukm/WWLUK6eUngDRGVwdaCXYljAx2lA3Hf7cFtH2639qPfsc53HSou3F0J1KkwRt 9Zlr/4KMFta89GgsNjuDC9KbZUCXKGUBcteazlUnwb/mPjV5EQ2qmIqE7ZbZw7Tjc1 YNPgpq1XOkQ57leZr+1X2LzaNsYu0VnfGa6Zptycxl31xyw0SIuCf3Jyb+zPc90G1n grawZ+jaW7ZDg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3AEC3ABAC; Tue, 6 May 2025 13:44:34 +0000 (UTC) From: Ignacio Moreno Gonzalez via B4 Relay Subject: [PATCH v2 0/2] Map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled Date: Tue, 06 May 2025 15:44:31 +0200 Message-Id: <20250506-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v2-0-f11f0c794872@kuka.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAD8SGmgC/52OQQqDMBBFryJZd0oStbRd9R5FJE1GHaxJSFQq4 t0b7Q3K8BdvGP6blUUMhJHds5UFnCmSswnkKWO6U7ZFIJOYSS5LXsgrDMrvqeOodA+jg3moreu mFr1K186+F6AGxs4DRUCrXm80oLHgShjkt9Kw1O0DNvQ5vM8qcUdxdGE53pjFvv0ZSy7/NM4C0 ohc60teaFOKRz/16qzdwKpt274ztqPr+QAAAA== X-Change-ID: 20250428-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-ce40a1de095d To: lorenzo.stoakes@oracle.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ignacio Moreno Gonzalez , stable@vger.kernel.org, Matthew Wilcox X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746539072; l=1539; i=Ignacio.MorenoGonzalez@kuka.com; s=20220915; h=from:subject:message-id; bh=ilPU3kHXp7rUlXp/tVdwQH8b/OLryQpTRvXT0OKoe/o=; b=YUAyBvIkP4DkqhnQf03JeOpLsT887STIasmrXklw3hNcbYHWZSK/cPM1iclzn05/yf40kFG17 lWLf5vFUOilCBLR+PlXFl2odw5ukLe/nHo8dQFyt+ou8jr8/8rdsO8u X-Developer-Key: i=Ignacio.MorenoGonzalez@kuka.com; a=ed25519; pk=j7nClQnc5Q1IDuT4eS/rYkcLHXzxszu2jziMcJaFdBQ= X-Endpoint-Received: by B4 Relay for Ignacio.MorenoGonzalez@kuka.com/20220915 with auth_id=391 X-Original-From: Ignacio Moreno Gonzalez Reply-To: Ignacio.MorenoGonzalez@kuka.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 94009140002 X-Stat-Signature: mpsz4d67ikhyy19wysp71adxm85aygmf X-HE-Tag: 1746539076-575248 X-HE-Meta: U2FsdGVkX19SGfXIH1An4/lcqSTWOfudElNiG8gl51UkyXa9rGgZjTA8PoTBvVgsHOY0l2ptfMrsP0xqtCxnfvJvgZHKUG27TGXdFR4rx4qRzm0UwpMu2kb/9m6P3ya4yi1V0kcsyrMtsAPHsfcl7AWDmOfWEjih8JzuUPY7xmyiX+7FYFUm1r0rTSSrCsT9/7dotTcpha0kcZlhDnGJSgCkaS6bgGmrBF5/ZYJLaYw4TkphXkZGInukZWCdef+D/S44ryVnDHYo5/oyihJyzGk6gwCSVH/ZlEBaCEKKSG980byGaRM+/WShDyBl6bb/D/WoIrZetNyS/wxbLdUVBNSS5h/8ikS8hEM9iWvGA4siBd6QydhXPL+AnxaUw+3KvYZzhYvnN3AnetWMt/N1N39SA8kgh4kGQykZZJsheob6yetEd6tSWjrztS2v0wWgIsvyQFlk6bUDok5O9vC/rKOT0VHVRp89dAewt7UwKwaoMnzE5t11Rm+zxH7fvPdBFgF5p77C+XJHgBnYZ2ChrRj1w8lhCT30Im25UjNXAdOfm5JPyqUT/mOzgDu3hBfeAOBGrNuKD0jLHOpzghlr3ut8Ca/9iLoREl/YOcmblsQcme6aHoye3WdF5sb+h8NeW2ynst3+ualop78Y+ACAGiR8uMK7UwM0HvZLqTvCCDLUfaG7fNe62DVmHavHL2JUs+4lXBjEOxWfAffTVnKbkvCF5uqjb1vDTvWf/tCoN7V03zp1biN5yHGQvg0XxXLmwVHvmMMzCG2WI1t6oB1hEi1t0VVvLSfo0EF+SsdMXcZh8V0NE0Y3/QknSU5L0eGp1X7H66MD51v7pdblqnTg1QkSWV7M0N4PXTIn+rdChirt707UUR/VtsuzgkDF0z5rRNOi/lAc6IwlH0yptULE7BJx9WERrm2wuxubmMVu43Yw+6OYli19OucLinBHx0gyrfYZj0b+6eYhz8Th9fz UJG+916j miQry6Qf6OYjt9cOKn6qwSVZcfJa0Rm5y9YehTU3CGDMco5HCt/dw7OonoVXqOINZQt7nmD4IDcnnQlZn9OtOSoVCVvn5GsaQ0gy8RnrWKB+zueU+lo6tMdFyFsnl2Xc9eiRBu4k5gGXyTGf3IXgbCGruBGAevcgHZt9ewY8+Qs6Owa2IBy+FsQXHx3dT0lN6BVHeDte0oLxJXShsn1AsTAqh1n/UA0CSzVsm42MDHY12s4OqLHYdybLZAnNQYlN1rJQfuWbMQNF+DITM8ExZ2ybFzUE6mBKIa9BCytCdUHDe7c9wIUYq0x5R8//n5wHg5HSImwehOUb4OCezR6yioYdfdNM0D8BhuL7YO0ADYf8BmEAXaanAzJhhwLyzYnmAL+PKM7SmSI4ufmWG7Mc1No6ulbhP73FpIbd7445HuPFFgFyZ+P3qQlBqP80WbIVBnQQdPkD0ncDBazabLmZ1YTkABDd3kH9ZqFMAIidY7mqDr0Ikk1xHEbHeHJSHLlIqZg/T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ... and make setting MADV_NOHUGEPAGE with madvise() into a no-op if THP is not enabled. I discovered this issue when trying to use the tool CRIU to checkpoint and restore a container. Our running kernel is compiled without CONFIG_TRANSPARENT_HUGETABLES. CRIU parses the output of /proc//smaps and saves the "nh" flag. When trying to restore the container, CRIU fails to restore the "nh" mappings, since madvise() MADV_NOHUGEPAGE always returns an error because CONFIG_TRANSPARENT_HUGETABLES is not defined. These patches: - Avoid mapping MAP_STACK to VM_NOHUGEPAGE if !THP - Avoid returning an error when calling madvise() with MADV_NOHUGEPAGE if !THP Signed-off-by: Ignacio Moreno Gonzalez --- Changes in v2: - [Patch 1/2] Use '#ifdef' instead of '#if defined(...)' - [Patch 1/2] Add 'Fixes: c4608d1bf7c6...' - Create [Patch 2/2] - Link to v1: https://lore.kernel.org/r/20250502-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v1-1-113cc634cd51@kuka.com --- Ignacio Moreno Gonzalez (2): mm: mmap: map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled mm: madvise: no-op for MADV_NOHUGEPAGE if THP is disabled include/linux/huge_mm.h | 6 ++++++ include/linux/mman.h | 2 ++ 2 files changed, 8 insertions(+) --- base-commit: fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2 change-id: 20250428-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-ce40a1de095d Best regards, -- Ignacio Moreno Gonzalez