From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 589ABC3ABB6 for ; Mon, 5 May 2025 22:49:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A36F6B008A; Mon, 5 May 2025 18:49:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 151836B0095; Mon, 5 May 2025 18:49:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 040366B0098; Mon, 5 May 2025 18:49:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DA35B6B008A for ; Mon, 5 May 2025 18:49:06 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0429ABBB0A for ; Mon, 5 May 2025 22:49:07 +0000 (UTC) X-FDA: 83410346376.10.1845B4A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf02.hostedemail.com (Postfix) with ESMTP id 49DB980009 for ; Mon, 5 May 2025 22:49:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qiSv/zCH"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sashal@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746485346; a=rsa-sha256; cv=none; b=RZxOE8YIXxnm6ttfnjKtRS2bvElCwQo6wV9kMjwUSFoeEds5v9yaMpLVg8EO3cChEbi3VE cdH33memDx8vZUIkbjxmneSXHMwXgXFGMP37G3bh52hy16GpmHRFLt/7hoFLUy5HrJKEXx MIaGs4d5ELEA5Czt/SWjiFB/LoOQbuk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qiSv/zCH"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sashal@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746485346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uY6rWqg4G6RyLB2Aj9Fl+RtgIMU8cU/gUrRvW0YrGA4=; b=h97+bvmmNZwzOfF/uwXBry+vKg5qcDMUDkobVknsBGbyJQ0WAw6QZoRca0r7R0yCKezFQ4 7V37tPC3nmdzeQn8lcidr7x68+ZPrwEbB6U6Y7wuag8RQr+PsIxl7bfhxYjnLVjVqTnCJ2 LkHmyw/Urw0af65fskTWN25j81redRY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9AEE9629C2; Mon, 5 May 2025 22:48:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A6AAC4CEEE; Mon, 5 May 2025 22:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746485345; bh=6OcSanAB1MDnq10VVZ/IraBnmb8NqcMQqhsFA04BXu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qiSv/zCHb6zrQCLwe5ShQ5oG0O2UNc5Uob4gKfK3lPULRfwS/9e9ajooAoaEMoQYz sJLduKdAhvkU+40faw8V1dNvqBYJXDY32MXG3cYmBeg9fAi3wIZp3Bo8dwejY3qp8R NcYV7erR2Fw3vua1UGWUenv8UwnVVyrs95TlraYrURmBi2dQT4/83ixDisIqgGyFW3 e75oXkUgGKIPvKVbk+zBgE740WhzdAsBCdUESJwpRq5GCIRVr7iTXsOULdgPAR7hO+ E5hFnqy2UfI+1BdS8lpwI28BaiKUNtyL3elhJpK5mQmWM5Ru9R6FDLMR5MyootzEc8 CK5atFrh9CEug== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Uros Bizjak , Ingo Molnar , Linus Torvalds , Sasha Levin , dennis@kernel.org, tj@kernel.org, cl@linux.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, linux-mm@kvack.org Subject: [PATCH AUTOSEL 6.12 278/486] x86/locking: Use ALT_OUTPUT_SP() for percpu_{,try_}cmpxchg{64,128}_op() Date: Mon, 5 May 2025 18:35:54 -0400 Message-Id: <20250505223922.2682012-278-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505223922.2682012-1-sashal@kernel.org> References: <20250505223922.2682012-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.26 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 49DB980009 X-Rspamd-Server: rspam04 X-Stat-Signature: 9936z4juepng5jmecrsd13g3q5fnsys5 X-HE-Tag: 1746485346-571781 X-HE-Meta: U2FsdGVkX19wJL5Wwr+mvA1h1pCF/psnKv1BZwQUwJthsWwFgdRNEV4z5WP8NbxlyhOkPR+iSxEABo6YWJ1UCgLWsstwAau9yJhNOaK177JQjtyOeoRgwcHpuS7274JmadvVeuMNW927jnXL9GufYxE2bKdU8K193i4F9X8jOk+2LlUccN8HSdyy+oj+b1xMMY88siqzqyhs4i2dkYtiSsK+F5b9fbDtEPN2pe3CN+5a5Kh2yPLHkrCZxbvJZk0zXJDUfuHe1wrHBtfNDB95KN/3tEWEvQz9jrzcRefoiw9ztmlJ+mqUo2DnXHxrfXLpUui7JIcuPbYm+8bhG8ZFQGzer7lJKC/Um3w2eck5hLN614Ff8lizH76UUlmvrexG14G0Wtn1y9pkI8orc18PkLb8LK6MjyR91f/HiF4tvhGMPmlkarfeS/oIDEwZrwSMQCShkaVGPjN0TfT2736NfCXv1ssfAbvVzA+fOyatTBD2WJxsnddBpvzxNIrwyDcKnJoXrYtZ3Ow7SlKVQWsV6hmIhhjIg1dqV2+YNQBvC+2sugIdR2WVVaLIaaITTKLOEFwC99IDE3INL9/ntmw2giW9+pptan9+00h1bJKdy9tswqyYQ4bvxl0/vPGD+3/sXXTzriJ1KJdYD9kdu1pZemZB/Xs79xdXN2HMKkvGxQjGJl6Tcv/WuOOeg0BiUP8/5MmyvwIuSEYFZRS/2PGca93ak1DXOS9fuhK3wSzN0kO79GWnZTQK0UdclTYA8I5Vj4FMxCuQnjKjoioT1UHeI95qoX2VfQFvAA3FLQsyH506iImz6vxrfwTpK873L/qJ9JpI/8ZXJUZfct5Az5zgv68YzEHrBLygnTjIKABNswoQ/kyTgopVYDq640QekzpRt7F8hQaC4pwyUeweg407DFNt8TyYzZVObsnXlf0fRSK5zOO5UHOFaKYOHkAaV44A2d7sBx1a4lrVb4sE4RU f4BmNk8o rsRqI/rw6PRbo+A+CPfIFQ+aSzHCuY6ujDOThkxSXP7KSv3iYKC0XxeDPKLFnwiaIwBpMp38QMqO4RTySQdVD1pHglupE16enPsn4Xm4K37nav8EL7EFUYgVHIG4wloP24ZhanQf1V8yt4MflORkul7Y9pWb3FnbSAT1qjI7yEQNoHQdzbrkM/wQdTMgsv1nAFJ+0A1Y01Y74QjeR5xqz+AabaiJ+WGzYxuX5nlIKjLcDcsTixzThicRF0tS0/SMIVKKaVCQFfgFtGEILBDOBefxgd/UXBB6JfFKAZ13Uact0ctD1oImDktERgWRcOV2P+lMzmEpb2ziPrkCtOIs/yH0NsozZJY6snbo4HfBkFsNSp8I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Uros Bizjak [ Upstream commit 4087e16b033140cf2ce509ec23503bddec818a16 ] percpu_{,try_}cmpxchg{64,128}() macros use CALL instruction inside asm statement in one of their alternatives. Use ALT_OUTPUT_SP() macro to add required dependence on %esp register. ALT_OUTPUT_SP() implements the above dependence by adding ASM_CALL_CONSTRAINT to its arguments. This constraint should be used for any inline asm which has a CALL instruction, otherwise the compiler may schedule the asm before the frame pointer gets set up by the containing function, causing objtool to print a "call without frame pointer save/setup" warning. Signed-off-by: Uros Bizjak Signed-off-by: Ingo Molnar Cc: Linus Torvalds Link: https://lore.kernel.org/r/20250214150929.5780-1-ubizjak@gmail.com Signed-off-by: Sasha Levin --- arch/x86/include/asm/percpu.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h index c55a79d5feaeb..2d9c250b3c8d8 100644 --- a/arch/x86/include/asm/percpu.h +++ b/arch/x86/include/asm/percpu.h @@ -349,9 +349,9 @@ do { \ \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg8b_emu", \ "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \ - : [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP([var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -380,10 +380,10 @@ do { \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg8b_emu", \ "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \ CC_SET(z) \ - : CC_OUT(z) (success), \ - [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP(CC_OUT(z) (success), \ + [var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -420,9 +420,9 @@ do { \ \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg16b_emu", \ "cmpxchg16b " __percpu_arg([var]), X86_FEATURE_CX16) \ - : [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP([var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -451,10 +451,10 @@ do { \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg16b_emu", \ "cmpxchg16b " __percpu_arg([var]), X86_FEATURE_CX16) \ CC_SET(z) \ - : CC_OUT(z) (success), \ - [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP(CC_OUT(z) (success), \ + [var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ -- 2.39.5