From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F449C3ABB9 for ; Mon, 5 May 2025 22:28:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A6426B0095; Mon, 5 May 2025 18:28:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 754EC6B0098; Mon, 5 May 2025 18:28:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61C756B0099; Mon, 5 May 2025 18:28:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 439686B0095 for ; Mon, 5 May 2025 18:28:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3389C0BBE for ; Mon, 5 May 2025 22:28:37 +0000 (UTC) X-FDA: 83410294674.12.2CDDAB2 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf08.hostedemail.com (Postfix) with ESMTP id EDE06160006 for ; Mon, 5 May 2025 22:28:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Fy7BeEla; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sashal@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746484116; a=rsa-sha256; cv=none; b=Nc/DPfo6S9rxVherSQD8i4O3ZNiP1IBqhW3fPfzqPh0FSZ0ACvETtAbj+XhZHvh0AQV4O9 Ay4GlocH9s4WdAVDgWC8VrRcTJdGAP+kqnsE8J07aWhs/6g8pVkvAsBNy14m0gOKBiwPk6 Lmf3Mk+tX+P60YzKTrXDU/za7yg9NSk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Fy7BeEla; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sashal@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746484116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TDWOGqWj8AfOkcDXx+zvgCAmfY1DVoUMYlWy/c2qFQo=; b=HG9B8w38scCvfiXp1mRHrTYnG8zG4hKqVyX32Jtza83P/FqNzjqCfWQG1jAgdl/+K1DBlp 2HBFgnCEIRjZbRXYMsVZPV13oT7Zr+9BSn3B8C900P/xtL44I9SweTuIp6AJvFuBGaDKjC h5bQhZMkM46sJqRNdmCliVux9IzIDIk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 40F054A7EC; Mon, 5 May 2025 22:28:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F70EC4CEED; Mon, 5 May 2025 22:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746484114; bh=WP35d/4m38nRJ62cheq/fW1IANnFk6qfyJ9WtRpNFHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fy7BeEla0FyTWKlNCaUmk37N3qJIpnngMi+5fDu+ZBjq4OOkaH4rl5b/t5Q5Ks90L 1HScWQCudSgOwWKZYti/Bok/Hp84A5lWQ+1gQ5meC3HfOqwlU3NejvB2d/yjBPcx1C 5XeBBhxRXpwgHdTk4ASVgfRPzbV9J30bBbF8znnNwDaa72WYvNqnuBq+CdrftC5MNW feNpYzAky8zV3FMnGZ5zUSGSbkHKsLkniPlufqpgcrcXMJnubZBMJKUASwpq6vV7l/ v1vaQvc9zTwPURFZ5RAh6opXa9sCkGhGSGEsb/56dm1SeFulT9DcLff2d8D7qAewMp KaHuBZVfG/14w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Uros Bizjak , Ingo Molnar , Linus Torvalds , Sasha Levin , dennis@kernel.org, tj@kernel.org, cl@linux.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, linux-mm@kvack.org Subject: [PATCH AUTOSEL 6.14 357/642] x86/locking: Use ALT_OUTPUT_SP() for percpu_{,try_}cmpxchg{64,128}_op() Date: Mon, 5 May 2025 18:09:33 -0400 Message-Id: <20250505221419.2672473-357-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250505221419.2672473-1-sashal@kernel.org> References: <20250505221419.2672473-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.14.5 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EDE06160006 X-Stat-Signature: mf4coxirrtorfymwm4i79z5qupzjn4mp X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746484115-174033 X-HE-Meta: U2FsdGVkX1+axUM86u7OEqv72l3F8SnNaXOwBzsvU3LWuwS9z0QY1T3D7lOGTaSTfNxCClwPvMA/D5P6ON+DwaymCKGH2LoOQthC4K/5CMWCWtHtG5ov4H8xyW6y5/OC2IaESEcJc3fPTPtdE0PCFJkHDqHOdSwNx1j+1e3CMt9OXArtI6BEqSOmI2G7+TNGsCzV9H+VrfMIq/bjdgt7H7KZPRmD4ZA3E0ujnz2t7IZtwVCMHeYJzZHTLU4bOYLhPF5jD6/S2J5gKEuCBFACREKm4HaVBgyLl0qDlcYZVAV9VO/WUNd1Am7MHk09C9tXiqepbrzUknOhBFchPDG2qbMxICsjRLRouJEvhE7BLGavyTeUk6Bhv4ScbCjno4zUYxMsgGNpNqWYPC5iwr4yzvm+6AWNRePBovcA/cOcMjiavwYXf/e5sRW7vjW1XsnVQ8XKXDIL2FdKumhgbhwHNj6O1gK8G1G5GgtCxxtUkZysd/HEyWtUvQADqXYVbVcpHoDclJ8AVt7Zt1iJ8JHNNdw5g4zMBz13dL/FeVIdRBqPxPCWrQZ516rr2dtQagho7cYoXc31onJW2LG0EaBpsrSqLoGpz2Oi0T5yIuyX1utr+tj/UAL7vllTDDM6t0vXHJS8OgmjI258149fHnKJ736WbuaiA516LKtgy5xVijH7kSSTrYM1xbmQW3yeBQnQDtBcv6Ynkbp8K0t9EsqPvu30Rkuupp1WpzODDk/7LanaecgE0GXpMEpdzJvkiPfPyPI4pe+b6DVsK+BWQZNmmpGvrmKxBDE7C+qzwi0Y+WZZRzEHWw98DvIkbNkQmDV+diPq2XJR0CVETfqIZmp1erIGQB+K4xJxbZph25Gcpwfg9kO5Ng/e6+Vxc3jf0a4SFgzyTcSBwHdv5/i3bqek94yOT4BqLC7LMe0KS/M1vPU33iO8jGJclFR+n8ywkQRM0sXLoZX4KYyM+5XuGmD SSWdP7W5 Hvuj7+9E2bCCcaLMRZ+AMpYqTJdTeqHeFKNFCcfPbDdbH7flsYBamH7O525nLWmdU41t9Ldmg/KUUt4FEoNPmKG/iIOOGlX2vj9qG44WZiwnmTMZ//6x/c/I+yQ8B531krA06qs/0LAGiwfKyiodRD72C49AswLA9afoJxMnxyCzKu6g7PNAJwb5YhJNL8UO4EvA4HmJ9KTbJyT4Dhw8J4Sre9LSQ4xrL9gZ13qW0shyd/gNAiUQdcDk605QzSopHXfVmrCvcV8nLYY0wMoBsnbTUpaephw9EA18APnLAXqp2o8w32jwi1FzxbwN/Dh3rkzTiDNZu75LNTZGuP6Moa7RR6ZWXiSRsPK1zMzFt/l3MDrc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Uros Bizjak [ Upstream commit 4087e16b033140cf2ce509ec23503bddec818a16 ] percpu_{,try_}cmpxchg{64,128}() macros use CALL instruction inside asm statement in one of their alternatives. Use ALT_OUTPUT_SP() macro to add required dependence on %esp register. ALT_OUTPUT_SP() implements the above dependence by adding ASM_CALL_CONSTRAINT to its arguments. This constraint should be used for any inline asm which has a CALL instruction, otherwise the compiler may schedule the asm before the frame pointer gets set up by the containing function, causing objtool to print a "call without frame pointer save/setup" warning. Signed-off-by: Uros Bizjak Signed-off-by: Ingo Molnar Cc: Linus Torvalds Link: https://lore.kernel.org/r/20250214150929.5780-1-ubizjak@gmail.com Signed-off-by: Sasha Levin --- arch/x86/include/asm/percpu.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h index afb9099fba9fc..9c47da5b0a2a2 100644 --- a/arch/x86/include/asm/percpu.h +++ b/arch/x86/include/asm/percpu.h @@ -350,9 +350,9 @@ do { \ \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg8b_emu", \ "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \ - : [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP([var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -381,10 +381,10 @@ do { \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg8b_emu", \ "cmpxchg8b " __percpu_arg([var]), X86_FEATURE_CX8) \ CC_SET(z) \ - : CC_OUT(z) (success), \ - [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP(CC_OUT(z) (success), \ + [var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -421,9 +421,9 @@ do { \ \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg16b_emu", \ "cmpxchg16b " __percpu_arg([var]), X86_FEATURE_CX16) \ - : [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP([var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ @@ -452,10 +452,10 @@ do { \ asm qual (ALTERNATIVE("call this_cpu_cmpxchg16b_emu", \ "cmpxchg16b " __percpu_arg([var]), X86_FEATURE_CX16) \ CC_SET(z) \ - : CC_OUT(z) (success), \ - [var] "+m" (__my_cpu_var(_var)), \ - "+a" (old__.low), \ - "+d" (old__.high) \ + : ALT_OUTPUT_SP(CC_OUT(z) (success), \ + [var] "+m" (__my_cpu_var(_var)), \ + "+a" (old__.low), \ + "+d" (old__.high)) \ : "b" (new__.low), \ "c" (new__.high), \ "S" (&(_var)) \ -- 2.39.5