From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C672C3ABAA for ; Mon, 5 May 2025 18:56:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D862B6B0099; Mon, 5 May 2025 14:56:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D33176B009A; Mon, 5 May 2025 14:56:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C23376B009B; Mon, 5 May 2025 14:56:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A41936B0099 for ; Mon, 5 May 2025 14:56:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 491CAB9A0A for ; Mon, 5 May 2025 18:56:50 +0000 (UTC) X-FDA: 83409760980.27.964B1A7 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) by imf28.hostedemail.com (Postfix) with ESMTP id 78D81C0007 for ; Mon, 5 May 2025 18:56:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="b/3jOnR2"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of 37wkZaAcKCK4XmSgQOgUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jyescas.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=37wkZaAcKCK4XmSgQOgUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jyescas.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746471408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=6BNCNLNBqTLFiZABlKrrM/g6NMQdulKPbXBoMUL/JjY=; b=Kt2shSABrLFiAmAoGd7VVOM9fQ0HfVrFl1/oPME94jEyU5cwhyWddihxiIF6FaoNTZEXjc qEpJRwqN+RhtPJMlp38w3E32IfhbY1QS4+yQU+5NEVh3Qtz8Wo1G9pOrNX2F+VKbFTwzFo tmHqpjgTRftUjmYoI1znmXywBoZL6p8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746471408; a=rsa-sha256; cv=none; b=UvDAOT5/N2AO6yIwIx62P8FEp0KKsf7xkxlK8Dz+5DD/dfB04kqvbjItl0NsfhVv+GUbE5 1Dc34RKg3BqUZ46+bUIjL8FW8nYJ54I8wov61jvj3KwrlkADiZvZtI/UXxAvLVceCmKizc rnun7jbauS0Cy9dbwBjEU0xsLrXAS18= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="b/3jOnR2"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of 37wkZaAcKCK4XmSgQOgUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jyescas.bounces.google.com designates 209.85.214.202 as permitted sender) smtp.mailfrom=37wkZaAcKCK4XmSgQOgUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jyescas.bounces.google.com Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2241e7e3addso43408665ad.1 for ; Mon, 05 May 2025 11:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746471407; x=1747076207; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=6BNCNLNBqTLFiZABlKrrM/g6NMQdulKPbXBoMUL/JjY=; b=b/3jOnR2zQGv0tGUbX/51QqjEV6dUajSaW8UaKmTs/qCs1NYs9N4jdy9s7IMj0kIyp vsqucvHasnJVLo2bPk41XEU5goEBSAKvcBPWcW+32ejVkIr0FnMo9wsg7nQLjdLp1rBe UxTJUNcsb1ApoBIJzHdgyWc8WqrcFfgfEAzk/0mMsl/uvAcmyUOGmwklRqoMJAffxwQa FOHBIIcsU68xNWpvwCXsmJj9i4270CoUMXx1K6FhxXFXm79flFb+topdkM8folPaCzPP WlSmggwCatiqBN0tuG0PuW2nIwoHWP1n/JGTzDRsOwfysp7y2slR7/+3A0nz61HEY+zt tO9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746471407; x=1747076207; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6BNCNLNBqTLFiZABlKrrM/g6NMQdulKPbXBoMUL/JjY=; b=tKjYAuVRwgMg2qW/0NGEo0h57OJqKS1Fbbr4o0hdB4WgY5zGuO6QH7tJYyugH4OcGx u8v8wAjR1e98DTUj8qierNNZXVbuWA4N3PQRum052ov/+pnxKBEFaWut7UkAFDghCs2p 6Ev7/tQBlTS5yC0WJzPlbdnxEQpAHwfsid58plEG+ON1hExW4l2OIWVM9SIaglSGrDlV DNEX1iTPPLlqp56LK8f/VOHdEsP7lnbF6dFJRxjaGCl3v/NmN7Z+gKnLCgDN6eV9pk9B mN85D4qV0bO8WzIBnAEeruOJEaqnTt+d2S67i5Zfzu28le8//UTf/6FBVaTHKHPCusRB YN0Q== X-Forwarded-Encrypted: i=1; AJvYcCU+quCKhe2MM2+RGP+VTlY+6GqUJBq8TmQAS4Lm2xZh/xddKft9/rJmS8j3FyRoiits+xGKSTDxdQ==@kvack.org X-Gm-Message-State: AOJu0Ywr8cLYQBMbmhzqpINP4Wki6Zqa6V/cnPfDHAXyf+55Zd8dPG+g vpjD7FYR2rFRvgMQubUURO5hBTb52DF15XbNei7/nSVqeYzKtI6+/utIqU1/zv4fAP8owE6NBy/ p52+31A== X-Google-Smtp-Source: AGHT+IHbATH+UFKHmuflnNXF6L3MKgptfzvwV0w7sgXiMV/YNyXmoNWn04iFlytUbCgy7zpCzKr6OoOJpDdR X-Received: from plrs15.prod.google.com ([2002:a17:902:b18f:b0:223:49cb:8f99]) (user=jyescas job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1c3:b0:223:7006:4db2 with SMTP id d9443c01a7336-22e1031fc0emr257429655ad.31.1746471407328; Mon, 05 May 2025 11:56:47 -0700 (PDT) Date: Mon, 5 May 2025 11:56:21 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.49.0.967.g6a0df3ecc3-goog Message-ID: <20250505185642.2377724-1-jyescas@google.com> Subject: [PATCH v2] mm: Add ARCH_FORCE_PAGE_BLOCK_ORDER to select page block order From: Juan Yescas To: Andrew Morton , Juan Yescas , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: tjmercier@google.com, isaacmanjarres@google.com, surenb@google.com, kaleshsingh@google.com, Vlastimil Babka , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Mike Rapoport , Zi Yan , Minchan Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 78D81C0007 X-Rspam-User: X-Stat-Signature: 8ywrty16d533ihuaia39xfnn7owxwwhz X-HE-Tag: 1746471408-615007 X-HE-Meta: U2FsdGVkX1/zu+5jwzFDmBrlX+SjBeIDLgDoU5W7n3GFvDjlWON24dKtyMZfAZvv/GN82Y11CFUYISsVO/EkmJpCI/AW7BXgBqAQ2e6vPWcpt8wnBOYVZjguvluCC8YIVmXKBcavPuwPJ98pKfx8wGh7pS+jqLS6nPhs1dY68kl5KdPy2o6yueT2LDhYnz8HO08lp3rXGJtThBvX9ulHcxvfcFZ63NWoG6rhLECzK7Oneb4uc+ID9AOKh384DIrI6cnN2Qx0U65dkLFBjTSP/gE05KfTNJMmLLn3MCLuyHGkOugA/3OMZ/L0UfSI8n20xPcoeSxT5WszwZiIxZqSZQbFJU6iL0P6LOPieuiOK+YC+ZhCD+lAsb/l6m+F95RrCb0XCl1Iv21cc0yWSqNt0/em4CVdCH77CZlhMtolqc6RL0pigNE7rXGniAKkP0pZTjwLhBWVaqdAySlVjRYx72f981daeBXNShX6VNNVkmtphSIKaIVekAzksMTsJiV3c8YN6GIam9cyxOGaMTL9Ftx5/3MMfpYvHr1lqRXO0lBQ5BAJMjLNK/W39TVT+5sH8mHmrQwN07dO1USMK1ooj/xfwe5fCzvZIuW8JhROQc0vYkk8GoxmEJ4hRjTxJeZtvIJxbzTTJ4Pe1EItqx283MezMbSXWmC//N4+buv7Mk9VcNtJB2k+OvsuOBNTVcNsbxYEgLEehwKtiyHkO5n2I/6RMgGMHI7O4GdJIVWxJHZg+JUdjvLgbvfSoEXlwZCpj6g5qhnpPo6RKHbNUIb3EjZMCZgrIsP6TsNyy60eetHq5fnoYTXE1fZvJtg/F16Zjf7J47o1xZXKKT8+rCB0aPTwipCzP7uXEVQr8OfTf2ezVy01UMAfuBSieim1A7OnGVeYjWnnrFCguEdORO09T2+HWO5Z3mHLpeKFaGArD3alEMPMQtBWvIzA5FvKHON3qZ1mL5fM1L78eWFNsD9 GEUl8PDb UM8EGQtsxRLMl0GMuylKq1xQPpXaSstMyfrj3EVcJ4cL9fILtlu7N6LD38399qh4KQe1YSO9P6QovpqNosb+lYybhdQBCxmBIFFcOBQWQEqz72NlFrax0E+m+37DlTJiqU0kE4oe33uaybyNkAqFD8qXHdacYK0PJf8dAp+ruxIO8bneOPmLWu4Jvn6VHlKFTFaTUZeMRLQdffFiqZmuG+78Ja2ofVuFM4PpsX2OYSop5mkhpS4q6Eqb5LrgJVZkw2E6/u2bHwhIMCsJCiVi+g8HurDEyh8dbt8yfIk/muiR0bhDc8fRyrVEW38RtwTGUFJjbRMZFsjDVQqPC20TiO1+RJd5GkUSVcrHZnkE60S/wybA7pvYx7uyylmronXyZ9u6T72C0CQ/1Ml3VrTvduKx1WTsmJKvnrTsbb1ZJNZq6ZFnBpbs2rL0IpaKubd/FnTsDuMv8EtetgowWdzffmmuwBdIPRwlOrDvtc8/gdBlcowHlPxMmEb4mmTvpS8HzywKWUN5CFWGYsxZ0kAjtnlFscbXl/NJYkVT0mAWfc7KF8ELmSlJrHCe2rWXJ6JkGEZqDptOep9zy3HIR8ucAYNOu+Q1l66K+0/bLPmGv3lt6DL+TwqibBob6IwT/5z9ePbAKTrrEWY08ntordeFOmGHv+xCpMhYS9TE2k2LD11ctABlchTeOzOITapyZ/3CtK3cDo/xc832pmDNLkgkFCr1O/8ef+DkvObbDRPtLkrIg1pZN0FVEAcWxnFAOVDX6h/G0Ohz4+gDcbPYJmh0d99jgXQ+mV4YpEwFW0p+p0xG15jj0WGf2kC4LP2dOhyDtqB9xKM5Soig3LS0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Problem: On large page size configurations (16KiB, 64KiB), the CMA alignment requirement (CMA_MIN_ALIGNMENT_BYTES) increases considerably, and this causes the CMA reservations to be larger than necessary. This means that system will have less available MIGRATE_UNMOVABLE and MIGRATE_RECLAIMABLE page blocks since MIGRATE_CMA can't fallback to them. The CMA_MIN_ALIGNMENT_BYTES increases because it depends on MAX_PAGE_ORDER which depends on ARCH_FORCE_MAX_ORDER. The value of ARCH_FORCE_MAX_ORDER increases on 16k and 64k kernels. For example, in ARM, the CMA alignment requirement when: - CONFIG_ARCH_FORCE_MAX_ORDER default value is used - CONFIG_TRANSPARENT_HUGEPAGE is set: PAGE_SIZE | MAX_PAGE_ORDER | pageblock_order | CMA_MIN_ALIGNMENT_BYTES ----------------------------------------------------------------------- 4KiB | 10 | 10 | 4KiB * (2 ^ 10) = 4MiB 16Kib | 11 | 11 | 16KiB * (2 ^ 11) = 32MiB 64KiB | 13 | 13 | 64KiB * (2 ^ 13) = 512MiB There are some extreme cases for the CMA alignment requirement when: - CONFIG_ARCH_FORCE_MAX_ORDER maximum value is set - CONFIG_TRANSPARENT_HUGEPAGE is NOT set: - CONFIG_HUGETLB_PAGE is NOT set PAGE_SIZE | MAX_PAGE_ORDER | pageblock_order | CMA_MIN_ALIGNMENT_BYTES ------------------------------------------------------------------------ 4KiB | 15 | 15 | 4KiB * (2 ^ 15) = 128MiB 16Kib | 13 | 13 | 16KiB * (2 ^ 13) = 128MiB 64KiB | 13 | 13 | 64KiB * (2 ^ 13) = 512MiB This affects the CMA reservations for the drivers. If a driver in a 4KiB kernel needs 4MiB of CMA memory, in a 16KiB kernel, the minimal reservation has to be 32MiB due to the alignment requirements: reserved-memory { ... cma_test_reserve: cma_test_reserve { compatible = "shared-dma-pool"; size = <0x0 0x400000>; /* 4 MiB */ ... }; }; reserved-memory { ... cma_test_reserve: cma_test_reserve { compatible = "shared-dma-pool"; size = <0x0 0x2000000>; /* 32 MiB */ ... }; }; Solution: Add a new config ARCH_FORCE_PAGE_BLOCK_ORDER that allows to set the page block order in all the architectures. The maximum page block order will be given by ARCH_FORCE_MAX_ORDER. By default, ARCH_FORCE_PAGE_BLOCK_ORDER will have the same value that ARCH_FORCE_MAX_ORDER. This will make sure that current kernel configurations won't be affected by this change. It is a opt-in change. This patch will allow to have the same CMA alignment requirements for large page sizes (16KiB, 64KiB) as that in 4kb kernels by setting a lower pageblock_order. Tests: - Verified that HugeTLB pages work when pageblock_order is 1, 7, 10 on 4k and 16k kernels. - Verified that Transparent Huge Pages work when pageblock_order is 1, 7, 10 on 4k and 16k kernels. - Verified that dma-buf heaps allocations work when pageblock_order is 1, 7, 10 on 4k and 16k kernels. Benchmarks: The benchmarks compare 16kb kernels with pageblock_order 10 and 7. The reason for the pageblock_order 7 is because this value makes the min CMA alignment requirement the same as that in 4kb kernels (2MB). - Perform 100K dma-buf heaps (/dev/dma_heap/system) allocations of SZ_8M, SZ_4M, SZ_2M, SZ_1M, SZ_64, SZ_8, SZ_4. Use simpleperf (https://developer.android.com/ndk/guides/simpleperf) to measure the # of instructions and page-faults on 16k kernels. The benchmark was executed 10 times. The averages are below: # instructions | #page-faults order 10 | order 7 | order 10 | order 7 -------------------------------------------------------- 13,891,765,770 | 11,425,777,314 | 220 | 217 14,456,293,487 | 12,660,819,302 | 224 | 219 13,924,261,018 | 13,243,970,736 | 217 | 221 13,910,886,504 | 13,845,519,630 | 217 | 221 14,388,071,190 | 13,498,583,098 | 223 | 224 13,656,442,167 | 12,915,831,681 | 216 | 218 13,300,268,343 | 12,930,484,776 | 222 | 218 13,625,470,223 | 14,234,092,777 | 219 | 218 13,508,964,965 | 13,432,689,094 | 225 | 219 13,368,950,667 | 13,683,587,37 | 219 | 225 ------------------------------------------------------------------- 13,803,137,433 | 13,131,974,268 | 220 | 220 Averages There were 4.85% #instructions when order was 7, in comparison with order 10. 13,803,137,433 - 13,131,974,268 = -671,163,166 (-4.86%) The number of page faults in order 7 and 10 were the same. These results didn't show any significant regression when the pageblock_order is set to 7 on 16kb kernels. - Run speedometer 3.1 (https://browserbench.org/Speedometer3.1/) 5 times on the 16k kernels with pageblock_order 7 and 10. order 10 | order 7 | order 7 - order 10 | (order 7 - order 10) % ------------------------------------------------------------------- 15.8 | 16.4 | 0.6 | 3.80% 16.4 | 16.2 | -0.2 | -1.22% 16.6 | 16.3 | -0.3 | -1.81% 16.8 | 16.3 | -0.5 | -2.98% 16.6 | 16.8 | 0.2 | 1.20% ------------------------------------------------------------------- 16.44 16.4 -0.04 -0.24% Averages The results didn't show any significant regression when the pageblock_order is set to 7 on 16kb kernels. Cc: Andrew Morton Cc: Vlastimil Babka Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: David Hildenbrand CC: Mike Rapoport Cc: Zi Yan Cc: Suren Baghdasaryan Cc: Minchan Kim Signed-off-by: Juan Yescas Acked-by: Zi Yan --- Changes in v2: - Add Zi's Acked-by tag. - Move ARCH_FORCE_PAGE_BLOCK_ORDER config to mm/Kconfig as per Zi and Matthew suggestion so it is available to all the architectures. - Set ARCH_FORCE_PAGE_BLOCK_ORDER to 10 by default when ARCH_FORCE_MAX_ORDER is not available. include/linux/pageblock-flags.h | 12 +++++++++--- mm/Kconfig | 31 +++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+), 3 deletions(-) diff --git a/include/linux/pageblock-flags.h b/include/linux/pageblock-flags.h index fc6b9c87cb0a..ab3de96bb50c 100644 --- a/include/linux/pageblock-flags.h +++ b/include/linux/pageblock-flags.h @@ -28,6 +28,12 @@ enum pageblock_bits { NR_PAGEBLOCK_BITS }; +#if defined(CONFIG_ARCH_FORCE_PAGE_BLOCK_ORDER) +#define PAGE_BLOCK_ORDER CONFIG_ARCH_FORCE_PAGE_BLOCK_ORDER +#else +#define PAGE_BLOCK_ORDER MAX_PAGE_ORDER +#endif /* CONFIG_ARCH_FORCE_PAGE_BLOCK_ORDER */ + #if defined(CONFIG_HUGETLB_PAGE) #ifdef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE @@ -41,18 +47,18 @@ extern unsigned int pageblock_order; * Huge pages are a constant size, but don't exceed the maximum allocation * granularity. */ -#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, MAX_PAGE_ORDER) +#define pageblock_order MIN_T(unsigned int, HUGETLB_PAGE_ORDER, PAGE_BLOCK_ORDER) #endif /* CONFIG_HUGETLB_PAGE_SIZE_VARIABLE */ #elif defined(CONFIG_TRANSPARENT_HUGEPAGE) -#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, MAX_PAGE_ORDER) +#define pageblock_order MIN_T(unsigned int, HPAGE_PMD_ORDER, PAGE_BLOCK_ORDER) #else /* CONFIG_TRANSPARENT_HUGEPAGE */ /* If huge pages are not used, group by MAX_ORDER_NR_PAGES */ -#define pageblock_order MAX_PAGE_ORDER +#define pageblock_order PAGE_BLOCK_ORDER #endif /* CONFIG_HUGETLB_PAGE */ diff --git a/mm/Kconfig b/mm/Kconfig index e113f713b493..a118d187a3bf 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -989,6 +989,37 @@ config CMA_AREAS If unsure, leave the default value "8" in UMA and "20" in NUMA. +# +# Select this config option from the architecture Kconfig, if available, to set +# the max page order for physically contiguous allocations. +# +config ARCH_FORCE_MAX_ORDER + int + +# When ARCH_FORCE_MAX_ORDER is not defined, the default order is 10, as per +# include/linux/mmzone.h. +config ARCH_FORCE_PAGE_BLOCK_ORDER + int "Page Block Order" + range 1 10 if !ARCH_FORCE_MAX_ORDER + default 10 if !ARCH_FORCE_MAX_ORDER + range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER + default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER + + help + The page block order refers to the power of two number of pages that + are physically contiguous and can have a migrate type associated to + them. The maximum size of the page block order is limited by + ARCH_FORCE_MAX_ORDER. + + This option allows overriding the default setting when the page + block order requires to be smaller than ARCH_FORCE_MAX_ORDER. + + Reducing pageblock order can negatively impact THP generation + successful rate. If your workloads uses THP heavily, please use this + option with caution. + + Don't change if unsure. + config MEM_SOFT_DIRTY bool "Track memory changes" depends on CHECKPOINT_RESTORE && HAVE_ARCH_SOFT_DIRTY && PROC_FS -- 2.49.0.967.g6a0df3ecc3-goog