From: Andrew Morton <akpm@linux-foundation.org>
To: Juan Yescas <jyescas@google.com>
Cc: Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
tjmercier@google.com, isaacmanjarres@google.com,
surenb@google.com, kaleshsingh@google.com,
Vlastimil Babka <vbabka@suse.cz>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
David Hildenbrand <david@redhat.com>,
Mike Rapoport <rppt@kernel.org>, Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v3] mm: Add CONFIG_PAGE_BLOCK_ORDER to select page block order
Date: Mon, 5 May 2025 18:14:42 -0700 [thread overview]
Message-ID: <20250505181442.898f17e6edfce39bc9c4cde3@linux-foundation.org> (raw)
In-Reply-To: <20250506002319.513795-1-jyescas@google.com>
On Mon, 5 May 2025 17:22:58 -0700 Juan Yescas <jyescas@google.com> wrote:
> Problem: On large page size configurations (16KiB, 64KiB), the CMA
> alignment requirement (CMA_MIN_ALIGNMENT_BYTES) increases considerably,
> and this causes the CMA reservations to be larger than necessary.
> This means that system will have less available MIGRATE_UNMOVABLE and
> MIGRATE_RECLAIMABLE page blocks since MIGRATE_CMA can't fallback to them.
Thanks, I'll add this for testing while we consider the proposal.
> +# as per include/linux/mmzone.h.
> +config PAGE_BLOCK_ORDER
> + int "Page Block Order"
> + range 1 10 if !ARCH_FORCE_MAX_ORDER
> + default 10 if !ARCH_FORCE_MAX_ORDER
> + range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER
> + default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER
> +
> + help
> + The page block order refers to the power of two number of pages that
> + are physically contiguous and can have a migrate type associated to
> + them. The maximum size of the page block order is limited by
> + ARCH_FORCE_MAX_ORDER.
> +
> + This option allows overriding the default setting when the page
> + block order requires to be smaller than ARCH_FORCE_MAX_ORDER.
> +
> + Reducing pageblock order can negatively impact THP generation
> + successful rate. If your workloads uses THP heavily, please use this
> + option with caution.
> +
> + Don't change if unsure.
> +
I messed with the text a little.
--- a/mm/Kconfig~mm-add-config_page_block_order-to-select-page-block-order-fix
+++ a/mm/Kconfig
@@ -1028,10 +1028,10 @@ config PAGE_BLOCK_ORDER
ARCH_FORCE_MAX_ORDER.
This option allows overriding the default setting when the page
- block order requires to be smaller than ARCH_FORCE_MAX_ORDER.
+ block order is required to be smaller than ARCH_FORCE_MAX_ORDER.
Reducing pageblock order can negatively impact THP generation
- successful rate. If your workloads uses THP heavily, please use this
+ success rate. If your workloads uses THP heavily, please use this
option with caution.
Don't change if unsure.
_
next prev parent reply other threads:[~2025-05-06 1:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 0:22 Juan Yescas
2025-05-06 1:14 ` Andrew Morton [this message]
2025-05-06 6:53 ` Anshuman Khandual
2025-05-06 12:59 ` Zi Yan
2025-05-06 16:08 ` Juan Yescas
2025-05-06 7:01 ` Andrew Morton
2025-05-06 12:48 ` Vlastimil Babka
2025-05-06 23:50 ` Andrew Morton
2025-05-07 0:02 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505181442.898f17e6edfce39bc9c4cde3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=david@redhat.com \
--cc=isaacmanjarres@google.com \
--cc=jyescas@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=minchan@kernel.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=tjmercier@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox