From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80EC4C3ABAA for ; Mon, 5 May 2025 14:29:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB8BD6B008A; Mon, 5 May 2025 10:29:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3F206B008C; Mon, 5 May 2025 10:29:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE0EA6B0092; Mon, 5 May 2025 10:29:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8DC4C6B008A for ; Mon, 5 May 2025 10:29:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2985E1CBC70 for ; Mon, 5 May 2025 14:29:57 +0000 (UTC) X-FDA: 83409088434.27.072C055 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf23.hostedemail.com (Postfix) with ESMTP id 3598E14000F for ; Mon, 5 May 2025 14:29:55 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=vB4M2yLq; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746455395; a=rsa-sha256; cv=none; b=U+3Q1c3MPkpcAnoWSXs9s+7al9kkhBc+PyOPKKsOIAHWjpW3CDR4iN6NL2oHcH4iSJOkK8 Me93nEdXcqsGLy9xv7+acrYKmNcONOwixDPW+PhkRL6j7RtML8Yo/m1ecu/imjX/V1kO93 Vt7JVNWRrUk70xnYLmPnWvuQDkL/YKU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=vB4M2yLq; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746455395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YI8/2634Nw/dQ8gDrL9YbXV+Mn+GWRh9uG0ypiDuisI=; b=gfYDPPZMP/EgirxAhPOjVzN80gM0Cl9ZSZChKeCs3hlqHAs+tiKmadUnFNiGfJRCuxxIUR 5wRLPtx3IFwlD3AKyjq+xQdVonKPbd6NJtvnfK5QuW8pks+VVpAQUXthLyuE8FUi7DsLAH NjhQOfhp4HRY+Up/PrEdglF6OVvtER8= Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7c96759d9dfso457177085a.3 for ; Mon, 05 May 2025 07:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1746455394; x=1747060194; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YI8/2634Nw/dQ8gDrL9YbXV+Mn+GWRh9uG0ypiDuisI=; b=vB4M2yLqlB7IndE7eG6+LtM4Cv05/OY9iFrR3OPxDUm0uXuCLlqSohVmsFSrkVODGz zqUQXWD3yl+mDDmoPSPQWalsx28pCAGd73DzcK8bNhPD8a5pVplzPij+AXfxVy0chn5z lYNs/CNpphz/eYCdrWcq/Prg1mGtOEfm4RHJC3sLGGLuD/5NaeWznRZS3XdzlKXRUp2G VfaZoKIl7oeOiggi86fC4c9n5rHY3hXjgDu+dB5532TeEWayQ52TK0bJJcqAYvXSM/o1 7o2GQEpIq03JMdWdqOIDwlVHAl87nwvH2WYsEturSCtLeyGFxjc2xixJn+25UwALgMfC ig8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746455394; x=1747060194; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YI8/2634Nw/dQ8gDrL9YbXV+Mn+GWRh9uG0ypiDuisI=; b=gGClYllxa2cAtRS0r5R6U91T4vHuUjSAVfoJZC4z18PvdNodFckjzIYrPpt96R74h+ I3HSzn4iYotn3CoTUwABzsC3U2x5pX1jWsrZK/NykjAZIWMWWXwPSqJNOLrzxoGrJHgr fAexilgFXlvHgB403zX/iAK7siXnEeYVkW9e4iOVlfRLTcwAROgA42TyeP4vBSGctdxq dVyWeP40fE5k02wnGzLuIvPwavuLKgIGKpA1otWil9/gPLiHfBKJzOqM/9jzN+II79vu dejkof+XT3sHg/jMgZMEZOaBtnJrnoUaTOPcXK+D4Zq0dyIWw/GfzBj6hGlA5RVhVoZ2 3Kng== X-Gm-Message-State: AOJu0Yy81AmZUsU4jtkXpd5hjVPrgp2Ymu2N46JKf71+0BVs+M1ZBl5R UQhR8e2IynkXGuDu/6vuV5NKCrN3FnDwKZYP/gnRw5kbJNJthk0/vkr0WOFGsGs= X-Gm-Gg: ASbGncuGd+SxWz7BIxGdJx38kY2OeYTqhXC9FL8D+Klp8JN+iG4FnEREeQAdHqn9Zzq 1xnMRcTgfC7G8V7Cm2cw+cqUzwqCoh9kdXHRjydyIa46RL/iBNHd+tZAC41S9JqO9Y2ykUvxvKl klsdoaDZ8dFp3BzXe/HkJkmM+6TmEVJYCqAYczwfEdrPG9MhfUclHF/kIqy2Icvd1GZU4tX+A4Q JdzpShniWu6qnJLOQ4xOyhOXe99fOFLeeaKrDW3nIeNXye554iWLwqXIuPXDuLw3L0Mc/Fx/C7P MEKaHN9+VaGiR6WdcjWNm8GZFqToGPC52rkvlQM= X-Google-Smtp-Source: AGHT+IHJEg/hzySYg6+JWlkAwj0DS0qxu7+Xu8xCTzoYz+Qk5R1OLuNOPT5RVk6Enm6pqqr2508HBg== X-Received: by 2002:a05:620a:460b:b0:7c9:2612:32d3 with SMTP id af79cd13be357-7cae3a92c34mr867371185a.20.1746455394233; Mon, 05 May 2025 07:29:54 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7cad23c40aesm576065585a.35.2025.05.05.07.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 07:29:53 -0700 (PDT) Date: Mon, 5 May 2025 10:29:49 -0400 From: Johannes Weiner To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Nhat Pham , Shakeel Butt , Yosry Ahmed , Minchan Kim , Sergey Senozhatsky , Igor Belousov Subject: Re: [PATCH] mm/zblock: use vmalloc for page allocations Message-ID: <20250505142949.GB30814@cmpxchg.org> References: <20250502080156.1672957-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250502080156.1672957-1-vitaly.wool@konsulko.se> X-Rspamd-Queue-Id: 3598E14000F X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: yyr48w5yjfjoqcnyz7y33a155g45g4x6 X-HE-Tag: 1746455395-792595 X-HE-Meta: U2FsdGVkX18Jobymq8beZzyoiedpWhVtnGdgGmkv/EB3oN/aDsxHSmlWavv9D2DvUiFuOrUuqzJCiqwIqoXFevxWkBn2qDjTee2ERWtN+sTh+NIq5BQ/6YPZX4xAKk5k+pxt+9t5WtB1bd5mlikGuOQbXGPT/dbMQIv/eZ7WKVsfp/nlGD5qMSXQn2UkkLCy8vVmJ6FFigDm/vI9gJrDdUyRunWgUGl7T0NvwW2NZsg9ypy7V7sIcA71rZW5PplruOksgZLF4qPjB+oSVlSCD+GYTfdcQrF4MFYuybh6itFa8cl5DMzjbkKYi8DWq+swzrXwgVU2Tt0z1J6eYF/9LzniPxbQ/Fpa2FSYTfaUWf0nnYq4FMTbg6kHGmGbAGSMvtZ6ztaNPct+NJru0yCnzqNUZDiQxsHnOWSG8ln+hmVNF7ucYldhMJXkamtspZG+3V/T9N/ZdV62WLmrZ0QRApNpa3GlJDS3WjoE0BiH0BouBz4czcZEWIgZEKZHBObzpXFq7cs/ht8c2FvfXvLF/BqH/+Xl8XCcKfmDYc1NU8EwYOLUu1VcoaFjVfGyhE5I/wgIUSSHzJXtzvbOoC7sXvahuP5b+aezYqUlJaWXmCmHfXI2L2RqCm2hSIi4wPpe8+Q7lwsPNoFjkPUfFWrAi2juqcq1rXao8oXp9CC3VDTP/WYWDWB4+O1hHjWU3Mvf4aA1NkKNiwJH4mhFts8ufv5gCt377bXV38AWiSBf1NRiVqxCxLoZ+W5K9bzYV7uP3vMfTmgiNKHfc1uqHmcHL0IYy0BDOAgoIdWEPQkCExpSpB9iM5qCyOn5nCRn0MSS+w99e1VyvrNIfRurjS9ktPB+R8N4beAVNziesuGZXnkgtyYjtOJ7w2XA7N5MmMTv0SDvWm9yo6wBRKtZs4uJhDvrGkDI78PLiKsqZXBaE8rF35yiHrFE9Wz9zlzIo5N6f6YBEQg5/B6Ao3eAh14 LVKK8VxV AKBCy+t2rHmW3dzzj7geTAVNOx7Gg/GNyHdL/w7HyJl8AcgttT1vLqrZPsmTK1KDWSoaWfBR9ug36MX5I66RKQbVFeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 10:01:56AM +0200, Vitaly Wool wrote: > static struct zblock_block *alloc_block(struct zblock_pool *pool, > int block_type, gfp_t gfp, > - unsigned long *handle) > + unsigned long *handle, > + unsigned int nid) > { > + struct block_list *block_list = &pool->block_lists[block_type]; > + unsigned int num_pages = block_desc[block_type].num_pages; > struct zblock_block *block; > - struct block_list *block_list; > + struct page *page = NULL; > > - block = (void *)__get_free_pages(gfp, block_desc[block_type].order); > - if (!block) > - return NULL; > + if (!vmalloc_small_blocks && zblock_get_order(num_pages) >= 0) { > + page = try_alloc_pages(nid, zblock_get_order(num_pages)); This is broken in several ways. The function is meant for NMI contexts - the "try" refers to trylocking the freelists, in case whatever got interrupted was inside the allocator already. This will fall back to vmalloc unpredictably. It also doesn't take a gfp parameter, which ignores the zswap ones, and substitutes a set that doesn't make any sense in this context: __GFP_NOMEMALLOC is counter productive inside reclaim; __GFP_ACCOUNT wreaks complete havoc on how compressed memory is charged to cgroups (double charging the wrong groups for shared blocks).