From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A117C3ABAA for ; Mon, 5 May 2025 14:23:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DA6A6B0095; Mon, 5 May 2025 10:23:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 589B46B0096; Mon, 5 May 2025 10:23:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 402E46B0098; Mon, 5 May 2025 10:23:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 217D06B0095 for ; Mon, 5 May 2025 10:23:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 06D1D1207B0 for ; Mon, 5 May 2025 14:23:40 +0000 (UTC) X-FDA: 83409072600.05.4BFBB7C Received: from purple.birch.relay.mailchannels.net (purple.birch.relay.mailchannels.net [23.83.209.150]) by imf14.hostedemail.com (Postfix) with ESMTP id 5188F100009 for ; Mon, 5 May 2025 14:23:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=coxYwo8o; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf14.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.150 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1746455017; a=rsa-sha256; cv=pass; b=au8z1D0fQZ8Z2xCeBobiXQbVU9ve3J1QCe1AJ+Mh5W4/151P4utYZn03NGwZVUPjWlbHXh e38uqiLlGibBZ9EuA1cPUc1My8VS/T+KgyPFQlfQYhv/++O8eK8OuCIv9KNWV40rgPLr/6 WYDAN2QXUeHMWLmQBFs+2kUD9QlBHnA= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=coxYwo8o; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf14.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.150 as permitted sender) smtp.mailfrom=dave@stgolabs.net ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746455017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tfgFRM0yaj0g46AzYF3NijLfJIsLuc+Vth2bLGQkFKk=; b=kQcHeRYaCLbO28GSMsHswRn2VC3i87vhhnK5vCbdmiMYoCDE32KhaRudq4NhYJxU/hS2Jw Q7kXSEm7RiSOQeZW2qSJ5PS3/qiBckPuUVE8TkAa/MjWSXREEQK6gG+u2+EpauMYlilZYv 6QsY01PVq1g2IbJ/PxPdm8c73IFBV3U= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id ABA3D1619CC; Mon, 5 May 2025 14:23:35 +0000 (UTC) Received: from pdx1-sub0-mail-a256.dreamhost.com (trex-7.trex.outbound.svc.cluster.local [100.116.213.248]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1A0FF160ACB; Mon, 5 May 2025 14:23:35 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1746455015; a=rsa-sha256; cv=none; b=SlT41qqhU9E2nczyzt9w5L2O4hyihXK4gSzXFIpuP9pNX3vNSQYn7xxUc0GXO4f5wqXU8g z8HYJehTZyFzM00i7/BXaZJBcNSa5+ePTqn4MnK8LxV7s8FK3BDo438lLv6x/O/Wym3yIR 6IrWrvY9HM7+4HjXOTaBJgPAeNj4dmIN+3R/cOXTNkGq5Ju49ci/Ijx4RIaSSt0tbmXMug gzlHGcP0NtKDQT4ceTjAC0HzCcG72XC33EGDgGRDU/ZSJwYFNbALmdGoC8pJlDYArE/VOU nowQ24w+AeWa4uYxrNQRqK1j5QtMBcywY5vXNrIR8uCaV5Y62SgfWxVKkn8UNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1746455015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tfgFRM0yaj0g46AzYF3NijLfJIsLuc+Vth2bLGQkFKk=; b=FZpytXL+bMg/VLc58cxa7ZmSjVGomq/msG5WHYou5gLf6DTrZjVd7Uug9k+y7KM2/QVc0x SQKbLH/TjKUvC0HNdtV66JCcCo/HX/N/lEthFLElEubTacCj5QGNVfsflT3XqeynyTU8ko nWDw1PiTStfSIaqc3FpL6gaDkuMIsvc9SNxsHHzRZ77jvZsAO1Q+0VEQJiy9JMOIdjrthD MPkhJJtEKmBbVW5Z/X6nH5BXDPUTwQtHVg/MvE+AuhE1A58wg02AedHLZC4lRAmFlK7uLp HJxOrfAznrwLIfkxGzaBJ+j6fjtXe2czUW0wrkPOYgmbn1LWR71IMVvN8sCNLA== ARC-Authentication-Results: i=1; rspamd-684646cf5b-fjp5w; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Vacuous-Reign: 4be0c7494ed3ef64_1746455015380_1102965967 X-MC-Loop-Signature: 1746455015380:4143739855 X-MC-Ingress-Time: 1746455015379 Received: from pdx1-sub0-mail-a256.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.213.248 (trex/7.0.3); Mon, 05 May 2025 14:23:35 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a256.dreamhost.com (Postfix) with ESMTPSA id 4ZrkKL3gj2zBF; Mon, 5 May 2025 07:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1746455014; bh=tfgFRM0yaj0g46AzYF3NijLfJIsLuc+Vth2bLGQkFKk=; h=Date:From:To:Cc:Subject:Content-Type; b=coxYwo8oc+JenPWz6DEIFM1Y2cTn9OesB1pgYt1Denrvh4f2ow/ef95/jo6YUHC7C 1swFmgq0/Z+z8CbAxNq7HfNgMnackTBxpb0OxPeKgLdnpCApmy0ccgq0Cd2WUo9wij UbSPYFvPy7gLz/s0UFhueYACc9Be6fD/5nNP2tXhhiJIKQ9T1pNpMgXUDVxeyLm7QT jJ05rPtJ2mCPdoRayqWMoCsFBPAoi0qBCwzR5llFmy1aIKkOKGp3BgXz5sxmdjeCYj KnASkIEG7pI/w4vcMEtimtAKo/7rWb94jJsUBgMZURAhTos/beaY/fRFOdVBmJo54+ YO5oMUvdtdQsQ== Date: Mon, 5 May 2025 07:23:31 -0700 From: Davidlohr Bueso To: Luis Chamberlain Cc: brauner@kernel.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH] swapfile: disable swapon for bs > ps devices Message-ID: <20250505142331.ltfjwwateqjgowab@offworld> Mail-Followup-To: Luis Chamberlain , brauner@kernel.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com References: <20250502231309.766016-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20250502231309.766016-1-mcgrof@kernel.org> User-Agent: NeoMutt/20220429 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5188F100009 X-Stat-Signature: fqks584fjkewua3pikquin35gknfrpga X-Rspam-User: X-HE-Tag: 1746455017-558401 X-HE-Meta: U2FsdGVkX1/pvBw3DunuSWX3qtANdZQlOEFbErJ9t1hzfwvYQOcXdBwOG/9A+MY0F95XfjUIKbVglYzAZiXyVGpwFa21tScbc+wtLLk0wsbAsNbigKFRlktra9GLDNORxV+U1lrZ/ArnSsvfehcu7LppVC+Ae1OEAV5d/mcZxCTj3P+H5wtqSFMu2+GB8WZqHjuUPinmMTSAp7n3MNosadEbngCC+o5SIYgctk7NH6fP1kyZAAGRy2faI2/yJPY8DbEh9hx9agy49lHwlA1I0WxVo/jw4LbUljYuiUvpRsE8Is1b1X+rSpQ239SagAODJF6bgzvGpNXT5dqbDjV707E+3mG+Doi0DPmMEB+3mlQDAO4JuIQkRg/w2CuLvGTHSgTPMQZvg+UArTXro8B2EtsYgqWp0j1aYYzGMoBNPBLKFmtvgryA3Ajj2T5/ZQ8qvVZcS185JDIS1XqKCXQzApnDv26sH9AmXNalwA/6OhnaRPlnaPvC2maYOcuixFJUP3gPEUfSfJ9mhT2tbKlrYdpoS1txBD4Um0wEeh1+pxvY1uMuvgxYk1Tu1mkCCQqRzk6iiYtvvfwT3lUldWlzhZ1+qisklDb9mxftHetBONlASl1wjLqzWFcfRGDIfnEmPw/c1SCYODCvWS2Ou4pIeGHCj8Eop1OUsF7aCeCwOOsbDLwsOu5lMR+loqO9Z/XnB+iodJMRFZ0wgYBLejMmj8sevgpxcGHNh0UmNZ14Qq8ZGHswoxkGTuJ1mvWAcoYwVf+63VYHs2sCdyMKuRH/tBrliLNMnHoDrgXoDqsBgfhHKk79tdzNay2Ykbtgt+lTrqt1oQGEb8HhE3E33mUQ+NpB7l+imF4K8mxXUARQFNPgKBM1DWQYdi8nXBELXzElBykqOvAyCHBTUyd+mBXayt0fIEFygGu7ZXmcJ3prn7w3/jOLq9pan9xZE7kFRqQm3tVFOoVEKcfHUOXWckx Snbk4F8T o6DcPU0pKKw8ESAtIukLHnvA1fazKGw/jT8zbB1WvmQzAjQW+E/ecbjDTHkSvSSJsP9usaaQ7L7/uYsQqZ+/gEvDO8jyjIAyiXLR8lQPHGR2uRV8EEKul348lVY7MByLTfWI/I6uFflOlUTw4W17Ttjq+6MPTEDii5q+V2lcp8p5K5HYv4PWpce9EHoqY9y/f1me2FJEPB4FseWxgX3XCEXtFX9VwqIgtggQN0uRzvtz/VvYsPY39t20OOBSh67rGuPeO0q6CQoLwb18KLi9YaIjd91hEYRFF/EdmJP04WmfzQ7iw4xTV0a86aFH3L9APZR7/bV71m3/G8RnHQM3r26w1Cc//vKc1JHcnHQTwM4KNd4SQ8CiEBwJj0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 02 May 2025, Luis Chamberlain wrote: >Devices which have a requirement for bs > ps cannot be supported for >swap as swap still needs work. Now that the block device cache sets the >min order for block devices we need this stop gap otherwise all >swap operations are rejected. > >Without this you'll end up with errors on these devices as the swap >code still needs much love to support min order. > ># cat /sys/block/nvme3n1/queue/logical_block_size 16384 ># mkswap /dev/nvme3n1 >mkswap: /dev/nvme3n1: warning: wiping old swap signature. >Setting up swapspace version 1, size = 100 GiB (107374178304 bytes) >no label, UUID=6af76b5c-7e7b-4902-b7f7-4c24dde6fa36 ># swapon /dev/nvme3n1 >swapon: /dev/nvme3n1: swapon failed: Invalid argument > >Signed-off-by: Luis Chamberlain Reviewed-by: Davidlohr Bueso