From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56147C3ABAA for ; Mon, 5 May 2025 14:21:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3F556B008A; Mon, 5 May 2025 10:21:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEE3E6B008C; Mon, 5 May 2025 10:21:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDD5F6B0092; Mon, 5 May 2025 10:21:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A121C6B008A for ; Mon, 5 May 2025 10:21:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 326401605A3 for ; Mon, 5 May 2025 14:21:15 +0000 (UTC) X-FDA: 83409066510.27.F61B762 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id CDEE1120011 for ; Mon, 5 May 2025 14:21:13 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r0wSIYBb; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746454873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EbMZpPEYkdjGeocBtqdDlvde+0xAuhLV3vpszE95Ny4=; b=KxLQr+gABM40nhjYpbLfj/YqnDoSL0j5pmWIoZIl6VbL4gEKq8b1C1MJByFd63QmaAeNtM lBQHQmJASWw7sx176xK41JHmdrHFGHMPsa5D8Egj+m3BzZULxk+USZo7CozDIUdEwmeSBA SWHBisd2jG1Kg32+wvoFte4Or5aE4C4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=r0wSIYBb; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746454873; a=rsa-sha256; cv=none; b=CkU293cFCQhuPfM5q0Go3H80+kTRnHA5Ad7+O5wEXDE8LcfVCDRTQFqntYm3XhAV/Oaxxg ERJBdx7wJyW3JO4M6yh5E4zUnVhRRv3ifgWoBPvKPqTHtQZyICyglQk+WSvm/pS90i4VcH 8B/c0cNpxQ7EucwhNCfTkyeI4XTIiNQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7D73EA4B7FF; Mon, 5 May 2025 14:15:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 019ADC4CEE4; Mon, 5 May 2025 14:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746454872; bh=94MZILw8BjtHmyqJf30aTndYbQiQoKqn4L/9ITuUj1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r0wSIYBbPqtAFUY+a2rfAwqjhxZmnLQJseVAPHQka/nM+qn01NBrgqHj9EdPPdyR2 P0k9ddaJnDWhprrAO2Rc4EjFFnU9KvmgWz7BvjcQW1DumlWDq5S245r2NZT3BnJae+ wIvQ88odJaC6oNiKOd2YZKJ2uTx8QPLeg9kOZgzQ0XEGbOdyMaQUo8sbfuFD5JKo76 9D6uXQALEzeb3vdXnG/KlLeXDB/zEVtoRyMJOLuC+QgiNEXEY8WCaP/B9XwVIjHkDl gF0GALyFfmuivK8eRC/YqKpsmtkxedOPfk5IT1sR0IId0SMUSRkO2PTErY0VBkqz5l VkOI5RTHG2HHg== Date: Mon, 5 May 2025 16:21:08 +0200 From: Christian Brauner To: Luis Chamberlain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH] swapfile: disable swapon for bs > ps devices Message-ID: <20250505-schildern-wolfsrudel-6d867c48f9db@brauner> References: <20250502231309.766016-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250502231309.766016-1-mcgrof@kernel.org> X-Stat-Signature: wo71mg11zjjwo6c5yun5awpkg5tdgg6p X-Rspamd-Queue-Id: CDEE1120011 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746454873-79155 X-HE-Meta: U2FsdGVkX19/r4cAIDsvTZ0ybxXMsqY0AAaLiLuCC7YDgAKUIJ3CoIIB/oJG/TKjYWHbbSUJFukT4r7DgBr3ydhcaZOYy+HbQ2QJpGlM1BwbDGLuIYictnR9WnCyhL2bKf54GdqadSXihByWVrz65XJ6eCojTBqWR5JfEMa4hwA5pvzBvv3kJe6X5UkK/mPNtvwiGdPoX+hnrRAXQtKmQDXidwhM1wrW+slIEjTX/futhFA6ycTxZrATrR/ZJ3ko8tWs3vzwSlqF5mPZtQdsCNqEuSiSDq5mPnOtjLooTThDG/iWTBsaEaP+XP3chD9NUJAPHJzg5lqRuebTn8Tl/FrEe+5JTsELkaWo04QCYKLQyoSg5TZnnFgL02CODAZ4knON2gOslDLRKa+MuuBgRySfrCVGvcYjBOfO/8MMrNo9uAXrWonjAYLmT5zmF7919TkmXTe8Xmgb9nfB72l6Ysct/CS1vWVokD4xOeJOzkl+Ak/xOjWur19aArtsY+kVriDqcQ4aio/aixmMqfyEUY+6m5kBwI24zKO8RsIhcS10ekzox1CvEE5vClZyUg5ZHCEbLCBx7AkZw/ht3UEja/ouAVfTluV3dIczBcc6rtLJuruma2qSgtDvyC4lPkgXVyby9+gZUwhfie3h+I+Zea3JimvEWmf95hHrpYbgzXYJGv4mCD2ho4e7N13FixDQnrV3ph5vINk8Meb+Chd4oyaEVilVovV+Y2uG5VwxOKYr0y34ZJZ3LELmbMzwcbDSgMN6r++wGv2I+pQ1k2EjGONR2xf+541WRIglcmO69Qj+NoHad0lq8EkA7XV4B2f0hCDHB3nqovb/Bnenwy+kqb5EK+uO9hNSbqMjGeeGSGz7iChcBVhpUubnOdHY5yNn4M7FrZE8290wAHs+OJSVkvjZgnzYP0Vub43HqRBISUEoRTFnUUFwABuIN//dTUx4T5ru8ggLZ5ZbjLJNEAg HcFxxU/t HlgHD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 02, 2025 at 04:13:09PM -0700, Luis Chamberlain wrote: > Devices which have a requirement for bs > ps cannot be supported for > swap as swap still needs work. Now that the block device cache sets the > min order for block devices we need this stop gap otherwise all > swap operations are rejected. > > Without this you'll end up with errors on these devices as the swap > code still needs much love to support min order. > > # cat /sys/block/nvme3n1/queue/logical_block_size 16384 > # mkswap /dev/nvme3n1 > mkswap: /dev/nvme3n1: warning: wiping old swap signature. > Setting up swapspace version 1, size = 100 GiB (107374178304 bytes) > no label, UUID=6af76b5c-7e7b-4902-b7f7-4c24dde6fa36 > # swapon /dev/nvme3n1 > swapon: /dev/nvme3n1: swapon failed: Invalid argument > > Signed-off-by: Luis Chamberlain > --- > > I had posted an RFC about a heads up about us needing this less than a year > ago [0] and well, we now need it for v6.15 since swap code is just not ready. > > Christian, this should probably go through your tree. > > I tested it on a LBS device where the logical block size is 16 KiB on > x86_64 and confirm that while mkswap would swapon would be rejected. > > [0] https://lore.kernel.org/all/20240627000924.2074949-1-mcgrof@kernel.org/T/#u Thanks Luis! Did you plan on adding the comment that Christoph requested?