From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA1E2C3ABAA for ; Mon, 5 May 2025 13:35:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4C306B000A; Mon, 5 May 2025 09:35:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFACF6B0085; Mon, 5 May 2025 09:35:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C0A06B0089; Mon, 5 May 2025 09:35:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7FF956B000A for ; Mon, 5 May 2025 09:35:21 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 670DD1C8955 for ; Mon, 5 May 2025 13:35:21 +0000 (UTC) X-FDA: 83408950842.26.412B7C2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf30.hostedemail.com (Postfix) with ESMTP id D3B8C8000F for ; Mon, 5 May 2025 13:35:19 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qkF1cTFv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746452119; a=rsa-sha256; cv=none; b=D3JruAEXup4sPRJuUE09WaGf9VpUFt1GuF+tk2giVKkhSoN2MYq3GacXzAE06JPqNpjCXf xLyX2fAhmJvoZfn58WO4nY7ly0MyH1LQ6vVmZr7p0xryyIWn4yhPHrw37rnNRXsgYtFLWe DNV22xf22VtFnIawZS033OhcBSrfK5I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qkF1cTFv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746452119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S+l1t/COayn8KbX/n5f0TMVJmNfhdm21PZYcCPJXw1Y=; b=J8XKPJiWhnUqRYIncCdN+lyzn9lMjkDdRHBBM2hDryOGhyrNLZ0u85J9NLoNFTJYPN1tO8 RlOLskR6bTm9OP2sjhNNAoBhBwu102+kLeRNy1WwIR0v1TzqWgdXh8A6f3VH2S/mLX/LKs xRsKpFvTe9uukduSp4moGFP54EGLd3s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9C2D861137; Mon, 5 May 2025 13:34:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4726BC4CEE4; Mon, 5 May 2025 13:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746452118; bh=lZYJj5+RvlpcB3C/3nThNIVF+4ts/zwD2yTL3wPkp6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qkF1cTFvbhP4Ye7NeV9917c1PkBLXuYnLDbiOErKUKsUumdsSQbOSMNV+zqY18Rek iMgcsmDQnKKTGn+zuxvwpTgU95tKAC7axgb/oimBwIeWBH4Qdl//jsdS4phegc4QB6 Od8s6UqytlBBSYBU6sYpgrW0+Xp5QP9sPiVwNULR2e9TANRtMUkmw+uXdjg01d79Ln oApceD/DookzKf4fYwsDQNTRHGg1JtviuRWBg02Cwd5WEcQ0XvCA/LXEG/YJP63KIn sUWf6i8bS2nrfk6KNE3ZE7xDcac83jrNRzGftJ/nnH7mqWNvilg2dKT7aNvbAlNFVZ 3fsRCjlhW9PCw== Date: Mon, 5 May 2025 15:35:13 +0200 From: Christian Brauner To: Peter Zijlstra Cc: John Hubbard , Lorenzo Stoakes , Shuah Khan , Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , seanjc@google.com Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* Message-ID: <20250505-postablage-drinnen-ddaa539abc18@brauner> References: <5b0b8e1e-6f50-4e18-bf46-39b00376c26e@nvidia.com> <20250501114235.GP4198@noisy.programming.kicks-ass.net> <20250501124646.GC4356@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250501124646.GC4356@noisy.programming.kicks-ass.net> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D3B8C8000F X-Stat-Signature: imyresro8ibhipiyd5g5gmwwjgbi6rmh X-Rspam-User: X-HE-Tag: 1746452119-743680 X-HE-Meta: U2FsdGVkX1+Lo4Rq4AHDkGDS3H9aF54uop0ERf5kdL2JSUjh6J61Rh5i3wCe4q3yDRsRsmTZz/T6rdWOc417a5ea72uo0B/42ckPoeUovjEFLGx1ZgsNa46o4CkuQBdbHG2jvrhpPwPawP2Raz5RggrcBYDBdPukjiZXAcezZOych5S5nknCnDLgqIpzPU6r2OpZ5Ab2BeQE5hfbFFSXPMuzfHkRMoKLwMWYjEyFYObcKOZMtGcbYyL6wBunoba3jMU58/cOoUy8Gg6w89Gk0mpqs21mAbBWUf2F5kLNm8l7oNqjbhpJ3jYPVm9RL1clFILAX7cD/lQEY/kGj3rez9SbrSFHDhfJfz2/Lu2ZG66UIyuIhZPlLbG5xJaaZ+H7ksUuHzaSZB27RHYVcRNNms109oRDE36rvF00/n50lYwoBrihkVj5fpxsH6G0OsoxlHoe2mqreAVPBHYElI5g5DlzFkdAJJasf/ZQhQm97oGxLt1yuzi0JmeF263VofJMdNVk4skOlBiJLxUxlxtMkzxe3ZX5VrMMxUSVfM04r+OEmXoL9BekQTggVU5fp4banWZqq0SayorNd/699OSTUgqXgblL4iEhWTeeMD8SqwWPXAYVNOVaGgiuymvHXrjkchzBNFMF0e70iYd/E43rNcOfmteuRhcOykcCESl4IQ3zPSGIJzpVEY4lXLFYZsc1b8onGrrIHUCvXhBw/fg5KHc+F7zmEy655zxM/beZJP535RImOhXXPwV5cvDgoCaP3bL3NFsQ7uN0FpieLAGxoAm5Gth7xOmnXVNANe3vevzjmNSbr7yii0+TVBvTtbboMh6Q6jGkEFs7s8j8wqoMPhmFwLu+be+P03FzwyjKzquV4qErQUEhELGFwE2cU3NkEXVFG5nr4tQh7+nMAe2AS7cMC+562ohqofwmm4xKDgNyVA88A/SmBvDFIsgyAIeRF1K3OcJ78hnoa+KSjZn sU/n7EUZ C3hpxkKRPWOTOh3kB+/EnqzGSNZzwjbOuB/CDvSDJn79N0SQgBNDwvmzj38XlJ2eAUj8zPxtVDmJGsQa1eURwW5TBYnkPoxJdi4Dq67n0uJbKbT9wuTeGYwaRnL9SlxrMCva5JB6MvzjPDwK9GiGRzDxfJPcobfAPu0Z9nTAUX99igChi4gt/3Y1TFsILG9gQFlDURHEZsMXfAU6+y2vI7r6KKswf8h31/iild/znEeG1U+fa3qCGfrNslVSnw8MZr/NEA8YxGZevwpjUsKo1ntvItu9nEvsOHME46m7heOCE68igdEbuwQYT0UxJuLleSAKGZvovHAnaM3zNWG16cU1oeLeL4Y9EQgtl0SUk5CfSrPMUhWQCNZGYkMtf4EuJiQYiCZS2R+UNuqaCfTMSzNNAYoBr8EBinDNdxrondIWgsm0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 02:46:46PM +0200, Peter Zijlstra wrote: > On Thu, May 01, 2025 at 01:42:35PM +0200, Peter Zijlstra wrote: > > On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: > > > On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: > > > > On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: > > > > > On 10/16/24 04:20, Lorenzo Stoakes wrote: > > > ... > > > > > > diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h > > > > > > index 88d6830ee004..1640b711889b 100644 > > > > > > --- a/tools/testing/selftests/pidfd/pidfd.h > > > > > > +++ b/tools/testing/selftests/pidfd/pidfd.h > > > > > > @@ -50,6 +50,14 @@ > > > > > > #define PIDFD_NONBLOCK O_NONBLOCK > > > > > > #endif > > > > > > +/* System header file may not have this available. */ > > > > > > +#ifndef PIDFD_SELF_THREAD > > > > > > +#define PIDFD_SELF_THREAD -100 > > > > > > +#endif > > > > > > +#ifndef PIDFD_SELF_THREAD_GROUP > > > > > > +#define PIDFD_SELF_THREAD_GROUP -200 > > > > > > +#endif > > > > > > + > > > > > > > > > > As mentioned in my response to v1 patch: > > > > > > > > > > kselftest has dependency on "make headers" and tests include > > > > > headers from linux/ directory > > > > > > > > Right but that assumes you install the kernel headers on the build system, > > > > which is quite a painful thing to have to do when you are quickly iterating > > > > on a qemu setup. > > > > > > > > This is a use case I use all the time so not at all theoretical. > > > > > > > > > > This is turning out to be a fairly typical reaction from kernel > > > developers, when presented with the "you must first run make headers" > > > requirement for kselftests. > > > > > > Peter Zijlstra's "NAK NAK NAK" response [1] last year was the most > > > colorful, so I'll helpfully cite it here. :) > > > > Let me re-try this. > > > > This is driving me insane. I've spend the past _TWO_ days trying to > > build KVM selftests and I'm still failing. > > > > This is absolute atrocious crap and is costing me valuable time. > > > > Please fix this fucking selftests shit to just build. This is unusable > > garbage. > > So after spending more time trying to remember how to debug Makefiles (I > hate my life), I found that not only do I need this headers shit, the > kvm selftests Makefile is actively broken if you use: make O=foo > > -INSTALL_HDR_PATH = $(top_srcdir)/usr > +INSTALL_HDR_PATH = $(top_srcdir)/$(O)/usr > > > And then finally, I can do: > > make O=foo headers_install > make O=foo -C tools/testing/selftests/kvm/ > > So yeah, thank you very much for wasting my time *AGAIN*. > > > Seriously, I want to be able to do: > > cd tools/testing/selftests/foo; make > > and have it just work. I would strongly suggest every subsystem to > reclaim their selftests and make it so again. > > And on that, let me go merge the fixes I need to have x86 and futex > build without this headers shit. I'm completely lost as to what's happening here or whether the test here is somehow at fault for something. The pidfd.h head explicitly has no dependency on the pidfd uapi header itself and I will NAK anything that makes it so. It's just a giant pain.