From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB58C369DC for ; Sun, 4 May 2025 09:26:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9F936B0085; Sun, 4 May 2025 05:26:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4D436B0088; Sun, 4 May 2025 05:26:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62F46B0089; Sun, 4 May 2025 05:26:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B77F26B0085 for ; Sun, 4 May 2025 05:26:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF9135FC8E for ; Sun, 4 May 2025 09:26:06 +0000 (UTC) X-FDA: 83404693932.26.2AADD18 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 273C4180008 for ; Sun, 4 May 2025 09:26:05 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=N9Tmqr5O; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746350765; a=rsa-sha256; cv=none; b=JmxPCj6Nzz0i3xQz/xNAJbw+L/iySZS23E47vnTewZ7vNkxB8Z2ydC0Hz2YyKOiGjsklzH qJsKHSSODSrSaHINvmi+6uqYF1ZosK61pDXamfU7zjGauARPKPRUxNRXwHVUxduhoVh6gH UU9zhwN8eAEku/ZWaTBkV0nKFcJBwtQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746350765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2xjiFm7v1MPzcXhuz3mKHlnw3kvRz+Aep0yXjTEHz/s=; b=OApIpfqlXdV78o46OnSeDooV5/m3s7zhQWsjx+f6nqrdlP4zjoNWYQBaTapMHGKfua9IWc veYcGkLOmddHl+rjtBYzSMRorzfG9BoNBAyPPX/sh7Mkaz/AYNhOowttXDDyNnu5111zPK RSVaUWPWRFFTPAI3+sTab6zEuZUHD4I= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=N9Tmqr5O; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id F286161126; Sun, 4 May 2025 09:25:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5591AC4CEE7; Sun, 4 May 2025 09:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746350763; bh=pvaiVm1SRiewSrbNvJopGE8et9l16ah5O/Zr2OmCb4E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=N9Tmqr5OGM31v/4ZVmNz3ZLREHpZ1p4hFuPFF4IosicfxJAIWyTlnrSyfxuK5mVU0 zeWZ1zD4HEanmQMiHTHLseozpyzUBKHVjJ28C8tvzuDrdqPfM2+MO6J1k4GfKsAUpJ LTJeb+WgKOdcq5gnFdZEwbqYsoXbJ87uMhZP7cg8= Date: Sun, 4 May 2025 02:26:02 -0700 From: Andrew Morton To: Vitaly Wool Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nhat Pham , Shakeel Butt , Johannes Weiner , Igor Belousov Subject: Re: [PATCH v4] mm: add zblock allocator Message-Id: <20250504022602.13fe05f43ceb273e96e5907b@linux-foundation.org> In-Reply-To: <20250412154207.2152667-1-vitaly.wool@konsulko.se> References: <20250412154207.2152667-1-vitaly.wool@konsulko.se> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 273C4180008 X-Stat-Signature: 5mdgzemh31tfoom6en1ysqrzaxz9ptgn X-Rspam-User: X-HE-Tag: 1746350765-803529 X-HE-Meta: U2FsdGVkX1/t0XWxtjIDkS007RrAfqGPfmSEA8KYA8rOLOAV3EcOThxreXAf4AZax9mjimq0Tw6hibQsyiv27uR/oOooSgTRoVrAyk7TS/znUjZdjgJitszK0GOmBttyy0fyF6bPKDUuerPB3eVmSd/XNc5elio58iIjPFvyRlLr4hUn+XZvkJJTD6GqBX8FdVZafB+ZlGLLwYp8tFfpLuxDOWlpBtXTtWW09C8mIrBekuWK9aPrjOYPoYYAEH3TvFjK5Gsj0zaHGW7VFT6keK3uA24v/JB1N4svwIoCTJF9jcLy2cNZ1AWoiQU+HbsCLn9ljroOiq2qsdXJ7C9xDyEaTlQofgMA7EmyDV/2YK6VFrDag4589F+kwDjl+wNJOAJcZTxdEhWOQZOVMtoHrGPIVOr479GOXcce3zZJ72h6jqLDrFeD3xC3b4p9s15N7yFvTqh5SQmpBYR2GCP9UBwfedIXvQy20shFbVlaY4GjkIEFjSmMeIq5oK6Oc00TjoiDj+KxUlF27TjC031PpVv8YJkLzl2Sbw5lGmxkEnW44HQtksCOb7WlDO0GfDyCNCv+zzMBxIto+Kp4lb4wpzyoPViWOPWGzPVPa4lQkxwqBkRlDgB0pDinCm7Uza1MV7F4umVCqXj1nJC+rsKjheSd1eJIpuFtX/IozoB4LgZ+sWIVynVwU/QQddJmY6GTOTYU2FfJkA4Qlxy2ejOjlzOwNXB22w+9zJ+gY6u+HQvDEcn5jEtBo0NV8rbIae6U1mGEaCVC0GTjt8Vkm02CQHOm8wWvGEaWWH7oC+QnORnkaSm5sHXQCtEW731pGdHJXhptwYkDqKgwOvrHOH8c7ZybC80/rINO9dwyrCKWYgPbNm+OsJ5X2nYtIYePrx9U867B3FWoUkOYhLO3qfm/XbpXJ31yiIUx03StgLaCOVqp/wpoOtOY8FSq0/tljU2yy9Zt59I+3eUDjg6AGAh vRhyEM+R xv57fTnouHb+AH0EDFgu0P1lGOI4S6iN2gAzYmMKFvQYhFU4Nj25IvtzFzLzJcafZJbdvax6A7Y0chWwaiKLhs7TnEQFuKz0sVzehbmM8MlYgvObx/D7IqVOOjr3XFwpSU8zjYnPyWaHgBw+fOF5P86ETKDkSHNc4cUh6XrlHKrUfu8/WTxe3MT7OGLZvMEdJMTY8rSdqS2vAUn16vIvSDzNjDXpGhaM+odqW0JSaKmFC/V96iyLqDvDaHKrpj/eFm/26AgVznTRIb1stUfrPHu8IAAziGUYKVizDKjy9GLE1BQHQLFDTWbhM38W4XCFvi8pnM1/SmfVgdGwtxoPcob2PDdgpLf9TmX7zQfuCiZFNyk/8LnmGeq1iEJX0mm+qsOlb2tLqmGHN7aOh2zYH0Ic0agN3FH/irzVy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 12 Apr 2025 17:42:07 +0200 Vitaly Wool wrote: > zblock is a special purpose allocator for storing compressed pages. > It stores integer number of same size objects per its block. These > blocks consist of several physical pages (2**n, i. e. 1/2/4/8). > > With zblock, it is possible to densely arrange objects of various sizes > resulting in low internal fragmentation. Also this allocator tries to > fill incomplete blocks instead of adding new ones, in many cases > providing a compression ratio comparable to zmalloc's. > > zblock is also in most cases superior to zsmalloc with regard to > average performance and worst execution times, thus allowing for better > response time and real-time characteristics of the whole system. > > High memory and page migration are currently not supported by zblock. > My x86_64 allmodconfig build failed. MODPOST Module.symvers ERROR: modpost: "try_alloc_pages_noprof" [mm/zblock.ko] undefined! I don't understand why this wasn't encountered earlier. From: Andrew Morton Subject: mm-add-zblock-allocator-fix-2 Date: Sun May 4 02:13:54 AM PDT 2025 export try_alloc_pages_noprof() to modules for CONFIG_ZBLOCK=m Cc: Vitaly Wool Cc: Igor Belousov Cc: Johannes Weiner Cc: Nhat Pham Cc: Shakeel Butt Cc: Yosry Ahmed Cc: David Hildenbrand Signed-off-by: Andrew Morton --- mm/page_alloc.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/page_alloc.c~a +++ a/mm/page_alloc.c @@ -7470,3 +7470,4 @@ struct page *try_alloc_pages_noprof(int kmsan_alloc_page(page, order, alloc_gfp); return page; } +EXPORT_SYMBOL_GPL(try_alloc_pages_noprof); _