From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F10CC369C2 for ; Sun, 4 May 2025 02:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B79316B0085; Sat, 3 May 2025 22:25:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2AB06B0089; Sat, 3 May 2025 22:25:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A159D6B008A; Sat, 3 May 2025 22:25:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 834FA6B0085 for ; Sat, 3 May 2025 22:25:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C9D228125D for ; Sun, 4 May 2025 02:25:07 +0000 (UTC) X-FDA: 83403633054.28.98D2E38 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id EC1C91C0002 for ; Sun, 4 May 2025 02:25:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sa5Xm9ln; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746325506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q07iLapc6h6t1eJ8c11F5WsiEIvEp4VM0CIjZSYbxv0=; b=gLxTS1vQvDfesoLYvW9JtfqEcOpEyTOTlzCAxdSV7H2r8YqZfecPNJRJFXWt+Yr6B7SQYf 0hLbsZmdTVBsuy8LCs6kIolsCwaIX7306JstjchuoYsUxVNiDEttJKp+4x18/HnyTM6cW4 S7vRGzWE21QuV86Lyu5Q8V8jBccygdk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sa5Xm9ln; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746325506; a=rsa-sha256; cv=none; b=viEZUzUQPV/xa20OXSKZXAtDxF8LN2PtExH0OHmg3kfRMVgbB2W44S5VVTX41rk2ChpLy5 nGaQrQin0f5TipUgVNE1ox2GcUMogki5QudvPvU5KaiXROvtlH3Rr+9GLm++7ZytsypePs zQpDGRAmAv+ByY4zWEQ+zHUZIfm8GRs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A55E15C4889; Sun, 4 May 2025 02:22:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43FBCC4CEE3; Sun, 4 May 2025 02:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746325504; bh=S+OsORA5O5Cv3l1kC9DRd9vjMhq4uhcpcixu095XSQ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sa5Xm9lnZB/lxMkZNAnnZ/pbCpdaYCFuobn5v6LiNaaZf/15Mx0DiiywmSlaBGfCH PlDBlG/Y8WBoW9tum7PDlnY7/KQGQm/Az4CEdWZ6Y03DSIeN9Hr73c+5ZUWpnSs+di QU0Ckqs4mnK0S8tAsYiEhauBQ4dVDgD6btmUGo5g= Date: Sat, 3 May 2025 19:25:03 -0700 From: Andrew Morton To: Ujwal Kundur Cc: Brendan Jackman , peterx@redhat.com, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct Message-Id: <20250503192503.5f057ba5396b3c982ddb2d11@linux-foundation.org> In-Reply-To: References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250501163827.2598-2-ujwal.kundur@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: qtcwwsgkn8h91s9s4yy6zstmaefw6n7t X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EC1C91C0002 X-Rspam-User: X-HE-Tag: 1746325505-599960 X-HE-Meta: U2FsdGVkX1/622TQVT7p0/FAm9lviqdhVcC8isbzo4FHMRd+4ZTKqbUObil+r07W67HZUPiSztZeXT3RGxpPu6z0iuQoBLO8qJEMLjqp2BMyHL63lENZIBM3TVq9V8813KMlZZz7TXgFacO77Dm/NaBR1ay+ItryNb6bdcPzQ0hCbhGbNnpTofjuSnDIYI42FGieIcCstAPbkCRWh5WIcNBFueWNDkdWc9Ijic0YyoUbGncN01swyh54mwd7+QLbriBDQ/6Mr5a/mxzWK4PvBc2VFQOeC8HOfU8ZVWfZwp+BvwtjPW0OIC9iehg3vdsqdslkVKzc6nGmbBW+1FczFNnAu86qBTzcsINmcyVGhpB/Fr6u8aS328S3c7E8p5MhxeozBtLqGIVXRZjQWNq1bkyqCKqvQq/rpSpLkst87SXXGctuQho2eFbuozqXjk4Gmzl8pkSScxqmVozcV6hpFD1r3nMm2xUJSFBCp8LmySLEolnVeBMiJ8mxXf7kNcrm0oP6HKJzvY36PPXRKvdqahF55e2MQSr2/P+JmsonNxZEpfJSxWPXZWbROHE/TFX7zzmacUrBVUVqBhCi7f8Mc4eiYtCEjLB4CRdzwEOLSKaGEROXgAWXesaHj+GuJfVPgp75PEN+wHVMrEB4YW6D/f4MOR2znb/BpdNDY7CwK7c1bzkHatutQixrY+paAo7Ee34Wt4c3wJYEERdEmj4UjQMV8IlS9dVUzeEbDSGPopY2aH1sj/1o+hWf8xpZG+1mIPC3OLCOYN5iIE+OBX9VNlg7syCVPRFGhIjao7lCNEFp+zvUwTaluZs9sM65dHNnOZoYPraB5Bw/bl6Z2ZXz6dBJglFGndLlDF/lOO9qm/SYZ2nduF+nJZaWTSN1sZ2+9rl755s6ElPpCTXtIkkGHLYlC+FkFdc77rwu725M8TQ3N4EXnRYOAbXP7pUzrORLby3OLEqTmfhWElX+VBM XIsH239F gYR7r7oTyuxeUPpVRTn9tYqhcPememCsFYIJw5n/DTBHvGpRAgiVvF0rrm+837YeHcn/Sm6sdlsdaEEYuXKNabwrRTewJrQRfTMcvYsCkifP1z3AAicz+8qFlt+Bg87UKS5ACVrNGAfXRQpJdaFN5ooRvMS0wOsQmfbRQA/ehlfgN86UJ4/rOYrVwxy2USdMl30GB0VCWYbXk6fmu5gnA/lfWmvlqE6Jz87ha4MXw4Gmg3+BXQK9glp3zN5R6ULkn/yNzIuqanirlCRAyLK+Ne96TEN8JJb2ww5DCMIYFqx7hBxZ3JaeNM9NxezTkQ5w7bs+LUw+Y2BWInS1Sp/s13Ipaow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 3 May 2025 23:46:26 +0530 Ujwal Kundur wrote: > Thanks for the review and testing! > > I'll push a V2 with the indentation fixes soon. > > > this deletes the global vars before it deletes > > the references to them. That's gonna be a real pain for bisections, > > please can you restructure the series to prevent intervening build > > failures? > > (i.e. if I apply just 1/4, the selftests don't compile). > > Could you help me understand this better? The selftests don't compile > either way if both 1 and 2/3/4 aren't applied at the same time. > At present uffd-stress, uffd-unit-tests and uffd-wp-mremap compile successfuly. After adding your [1/4] patch they do not. This is undesirable because such an inter-series build breakage makes it harder for people to perform git-bisect regression searches - if the bisection point lands within this series, their build fails. Probably this isn't very important in selftests/mm. One could perhaps change [1/4] to provide back-compatibility defines such as #define test_uffdio_wp gopts->test_uffdio_wp then remove those at the end of the series. But this is just too much fuss and will probably cause other issues I suggest you convert this series into a single patch.