From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD0C8C369C2 for ; Sun, 4 May 2025 01:39:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14B566B008A; Sat, 3 May 2025 21:39:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FAEF6B008C; Sat, 3 May 2025 21:39:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F037D6B0092; Sat, 3 May 2025 21:39:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D1A906B008A for ; Sat, 3 May 2025 21:39:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 708171612D5 for ; Sun, 4 May 2025 01:39:27 +0000 (UTC) X-FDA: 83403517974.21.5F860EE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf17.hostedemail.com (Postfix) with ESMTP id A6B4E40007 for ; Sun, 4 May 2025 01:39:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="Aw/UCkER"; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746322765; a=rsa-sha256; cv=none; b=izGLhaiu5E2hvb1CrQ1EKIn1bAVKPAQXNukAZ1iJ60wyX0QyjV2zuwzmrd+HpOp3IGZiWM kwhK1lET9qQa+nh6ztIK9G7W4gZOqJO3/MjxIvC3sa3Me83YhilczkGD6Xvs12yXA0b3MX TuntmiftqhJhGIE/pxqjc8hSVeQNTn0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="Aw/UCkER"; dmarc=none; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746322765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kl1aQeFs077W3xbJbsJ6oq+fAub0eCs9iU9YU5P9OOc=; b=ZS5M5j10i6B+F6Ix5JWgwc0Zo3+Iv0nbjePt2rHAlIhJbuRPKQHJwUTpRdFGdw+AnurVqs zXLaJzJD9luJrsip6vrh76+lP9aItkTJLZgbMyJG94+CMJIayp15Wb55paL+FV+PaUN62y LW55N3qVzPRTP/fQa1/tOgMafXx41YY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4A56FA40294; Sun, 4 May 2025 01:33:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B080C4CEE3; Sun, 4 May 2025 01:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746322764; bh=pKIqVIqTVkIwGEitRnXf7SQButjyIwLkfB+/Es/jkg4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Aw/UCkER/q3iFDErZr1NcAbqDqxpKzGGEq+oAd9vRy0oZSbERq2hnrjAiZyTn7ksQ cy8EfgebEXLCO54+/5nMC4W+d4DthErmhFIutkCRGYB1Ra7BrkjNppkNu6KZBeUyHC G5gpsWaBgvlAzA0sd3N/QL85TmC/sTPKzfABoYug= Date: Sat, 3 May 2025 18:39:23 -0700 From: Andrew Morton To: kernel test robot Cc: xu xin , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [akpm-mm:mm-new 313/316] memcontrol.c:undefined reference to `ksm_process_profit' Message-Id: <20250503183923.848bd73811fa7127d50ddf54@linux-foundation.org> In-Reply-To: <202505030429.a2GUiRAz-lkp@intel.com> References: <202505030429.a2GUiRAz-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A6B4E40007 X-Stat-Signature: tymirk8nnrbtu1yhrbnpy4uws7b9zu7y X-Rspam-User: X-HE-Tag: 1746322765-582194 X-HE-Meta: U2FsdGVkX1/eTUVBSHbAVGv1mj4vZolA9WEb6BhYnk+eJuYYDcE6POa0KYmInSlHIYbNeATtDaGkBknIaw3WzBa/L6ozsCnYw5zN4YSxHOaFdeuG3A6iqQbM/ahmL+9bWr6KOhG71CJEqG62CbLZGtAf5ACh611paWG2DUFC9Amg4pcV3Y9AqxRwJfHNpMD44/VCCryWhuV/9GPqZcONzCr2JKgj6NBjZ53uRWTtBuV9Pisog2GiKgf+qMsKK6WNcq0hVLw1IeAN67cir362oggMdwYjDj7qIa+1+PcLJs134yiHNVQCHj3zSWCvALhVFATBj7ilW/vARRR058jLlmErt29P0Y0PT85KGoguiNIj2djN/N4KkTIv/TAQeuoO5F981orP9Ti/9HGaKOvfD01c2p4p1JwftvdHUKm+L1iZM2274z6bmXzZjigCK6Z3X8C1R8EO+g8IIPJgfLNGaKOStHBeiSkMC7d5XjNdiveE65OrGzcNn0mMnRwBU52yPk5DqMTkT3c+iukA0rvcxc1V9AIqbc8wQuf5NkLl5AatWtdNsm1ygWMXA7VtZlLVsbm0MchdaRiJVZQ+Sp5yzF/QK9CmTefPRbA2NiNSI4+pgaLj7iPZlHLCDgx/oji54zXytdIrfZJfPognjqvy0EdG5K192dQ8/nx8b0Xc9NkVIqZKevEJ0XI2po7ruamLckpfs4MGHOWWB/xsoHKVX/CWIggG4aF1fQVPZvqEiulxOPyeSkvHefAbqDdlUQBpzR5d5xixR3tqoOJJWXNxsGkP5HIlGq6cqTFo/a9529hgoTExetKLnZUniTErvNqeGpD3srQHVPgMCXuZjHGtXclS/5erYwplxNsBXDbWsHqoWwdK4+6Ylqy1rxh1U9hj/tdXKQvXhD3581gFQW4BNF9JBkcHhNZFx+z1zHUNM7H09JTUe4aB2sb6x4/SyF1TAazYGydAYn2pfGb40iE 8kHMG9eT wCAKyhSFzWohC4s3jAD4k4vVEpPpWTqrrYWkk8hV/625mY91dxlK0XHnC+ktkpKhGk7Oqg5bUSA1tTK6LGQ8d5E4rJ5FNAFwOnq/kfpqX2MbfwesjjvBGjO0n1nTGlbwxEgAhYFC7jKC8+/OzB77vVNAElRp5iaXWG/rJIW7lFE6X8uPCQMmBgAHcv1bzbcYr/1BGJUokshoIs4g/xJ7TfAI35Ipe/P7vYKS9csRUSY0NqvF7YrZGXkKROa3OfIH/yRwUPF0MI3jgbrz26hbvQgkTfYZd+c3OM3O4onfFUboOdc8R/ZjoYPVXehcweiVhm4k4HyIjG9Lcjh8SpJXMQ/s/cs8lyaVICR+9xqoQgS/8CLvnpvfG03j1zp592KvGyGssE2ez7XLt0RxqGIxieU1OgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 3 May 2025 04:31:37 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new > head: 108c0a7e7ceafc00a50d1b2fd56cfc8fa99d4ddd > commit: 94c2f83bdfb95917213b7e95584fc2696c210655 [313/316] memcontrol: add ksm_profit in cgroup/memory.ksm_stat > config: x86_64-buildonly-randconfig-002-20250503 (https://download.01.org/0day-ci/archive/20250503/202505030429.a2GUiRAz-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250503/202505030429.a2GUiRAz-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202505030429.a2GUiRAz-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > ld: mm/memcontrol.o: in function `evaluate_memcg_ksm_stat': > >> memcontrol.c:(.text+0xdb5): undefined reference to `ksm_process_profit' urgh, CONFIG_PROC_FS=n. It was kind of ksm_process_profit() to avoid bloating CONFIG_PROC_FS=n kernels but really, are KSM and memcg even viable without procfs? I think I'll just do this. --- a/mm/ksm.c~memcontrol-add-ksm_profit-in-cgroup-memoryksm_stat-fix +++ a/mm/ksm.c @@ -3268,7 +3268,6 @@ static void wait_while_offlining(void) } #endif /* CONFIG_MEMORY_HOTREMOVE */ -#ifdef CONFIG_PROC_FS /* * The process is mergeable only if any VMA is currently * applicable to KSM. @@ -3293,7 +3292,6 @@ long ksm_process_profit(struct mm_struct return (long)(mm->ksm_merging_pages + mm_ksm_zero_pages(mm)) * PAGE_SIZE - mm->ksm_rmap_items * sizeof(struct ksm_rmap_item); } -#endif /* CONFIG_PROC_FS */ #ifdef CONFIG_SYSFS /* _