From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1943EC3ABAC for ; Sat, 3 May 2025 00:12:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3DDD6B00C9; Fri, 2 May 2025 20:12:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC5CB6B00CB; Fri, 2 May 2025 20:12:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C40CF6B00CC; Fri, 2 May 2025 20:12:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1E566B00C9 for ; Fri, 2 May 2025 20:12:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9F6A81CCE9D for ; Sat, 3 May 2025 00:12:39 +0000 (UTC) X-FDA: 83399670438.10.7F4351C Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf23.hostedemail.com (Postfix) with ESMTP id CC31B140008 for ; Sat, 3 May 2025 00:12:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="kb/kK+4l"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746231157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vZYxaPq1B+YdBJsfwMpJaL6pF8SiJE0xoumVl7AtG5A=; b=CinWPlWPBXiVH9DTaHP8QbNVB353Zc57VJANAXL6EcA3nEOy1N0vnZr74OrTi1qUTBBkqZ 7+OHCVZKEBoE1LZJ9oOoUAg6ujbxMoiVDj/LodUrlaWD0uUfFWt/QVMBcbCJwfQKmPPjnE TrzYuIsk5EkBcK6sgp0UVGAFjQzZsDA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746231157; a=rsa-sha256; cv=none; b=y+4x0xa2j2BhFIw2QXPjrRqxkShTiOxXyelcnB9rLttotXWhmUJRSSgQzU28sZYZdBD/Kz 3IGVKZD7FcJGNACwFD/mX61gO+fZD6gv3PEmFR3fgfU0wR/73OPH/Iw8mQ52JSO9Eywq2+ ntPHT5nsywK7aswcGeGaHgIBeMSj+bQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="kb/kK+4l"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-223fd89d036so32348615ad.1 for ; Fri, 02 May 2025 17:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746231157; x=1746835957; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vZYxaPq1B+YdBJsfwMpJaL6pF8SiJE0xoumVl7AtG5A=; b=kb/kK+4lF+tbf+ILii0QAMNthbe4KIRqgTLow4nbh9DRL3sPDvgRrV+k6B3rP1Pz/P OHhp8eU59y7dQewY0Gfo4YhtENbAtd61TiWUpB1Podal0eAaNFsae4EPKg89pUHG7vCQ XkqYzo2wk984zP1i15ykRpWy2eH/+n0mpRTi5jrEW+UIUfRXeQgLQTWeF+1C1n2n29Fp lIm748V1MagnpAr9HDP7f8joCHrY9EpxIrCUxshR+XGnF7anCafDtADtZdTMCCC7h9RK TwBrXnzdUlqjWQswN13rWxTY56oEWWAL0ep2OnKvyHbf2C5S6RSKoufacuE/LEavFy0w vXYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746231157; x=1746835957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vZYxaPq1B+YdBJsfwMpJaL6pF8SiJE0xoumVl7AtG5A=; b=d8vsYYFMT1wiuc9WS9TqFcDsixxjLcuYxU+zv0SBuGHszqKtob+q5aLZajs53BtGN8 nN1wgvMCvUIeCuXQNrQwL9bd9RXbOScOHsoQjU1flhsDYTRqB3d2TdByUsDr5bfPIJKC 91tc+CWKnMhvkOKmY9spI0DVxMCTGCKssh9hzXL37KHn4ohXjtLFj6YwPcTETCbo1zG1 soxp+tW/Xx261KyacPWY3Jrz7DwBp28knShl2JnaNvXNitOv/zF+I+0/9Il4HteFb5Ff +PrkN36LMIuigVOb26G0hS9jkS/XopoD3pEXjM9s2Pwb96DhEZAu/af7IfBqNHmo5a9L x5TA== X-Gm-Message-State: AOJu0YxXyAQ7bHshTg5QzsvdumqAy7jfvKF1dbmPD/rM693lEbkgyA3R EEdSVWECZ9kt75ABQQjARir7XxIeX+ov1i1McyEgRz5T1N9zS9uF X-Gm-Gg: ASbGncv0B427oWZL5onGZBRPb4MSw2jelu6qFte2V7rdMRBDtsd3EK64ByqTD+ZBZdu iYXrBeBMH1UAtoYRb52AwymGdnh7CCylQIJqPo0Bg5cqlquYntpGNd2HlRUtA3PhMbkMAHjeNtq BMZV30hA2nXd5NJkZJKt7uzKuRwFHtY/o2/3GY/oOCBW2b+Q6J1GmbMoPwDfOJmvo0BbQg8kWNY 1JLIi/yYEJpvcZOi9h+WRI6WpDsflAS3pj95dCssfAd5LE9Wwrf31DRHRfhqkaED7FH67dLnJpb 8f5ZJ85fPNpH5a0iRfdEPhrNoBAxr6lYMLSvlv4WQ8uTFYvTXQfGvrQq11HMupynsGAV X-Google-Smtp-Source: AGHT+IHwzKez5tGLPNTzfpruEhBKr3lxVhFniRAI4IDXjCwGi7kvZMo9l78o5Akn9VeUt75tACXihA== X-Received: by 2002:a17:903:198e:b0:224:10b9:357a with SMTP id d9443c01a7336-22e10382daamr77922615ad.32.1746231156773; Fri, 02 May 2025 17:12:36 -0700 (PDT) Received: from jpkobryn-fedora-PF5CFKNC.thefacebook.com ([2620:10d:c090:500::5:6a01]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e15228f9csm13718635ad.178.2025.05.02.17.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 May 2025 17:12:36 -0700 (PDT) From: JP Kobryn To: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, mkoutny@suse.com, hannes@cmpxchg.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: [PATCH v5 1/5] cgroup: use helper for distingushing css in callbacks Date: Fri, 2 May 2025 17:12:18 -0700 Message-ID: <20250503001222.146355-2-inwardvessel@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250503001222.146355-1-inwardvessel@gmail.com> References: <20250503001222.146355-1-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CC31B140008 X-Rspam-User: X-Stat-Signature: oy6o14iwnb5oa3byuq791afmm1qcdtoj X-HE-Tag: 1746231157-794230 X-HE-Meta: U2FsdGVkX19Egnp8KoCn9MF/YXs4qhPHbSk4vNP/+OuIBLQOGpsA1AkQ7S/rbG3FYSx3pNWn1H3hwh9cyfjUtVJF8Yw7SqUmvGToZKLwjk/WLpeVA91RHcN4q1ukYKvvofo/ITadgqiY/2XRC2i05jvc+8hZh0alwzJ8M6PT0EdKQ0QbB53+9H5vtVN1Cisut6dcmqYH8tmUh0AgrF15r4ff6u1yb9q4/vLak7wy6HcjbZdEz3taySPxQiEEHD5IgGh73kduQnqdWWgflWy1xc6cwhcj3xiO+G6XiVFXEWS56AM1GlGVMxHcM8UOvMKUGnjLx7lYB2CMjYghKrHV5bxCsZ0aK/GLlf8+jkEOJWgWZQAQDRkiHbRqc+XHZA0iauq4kbbJjNKnLHzULrB85DFkTWqX+9ENtfvcw5olQvEGjEpS/kmwJfTy7va8yI9wyE3NLp8nSV4qCEaFGvt63lUnUD8ESw8eMg0b+p7PbIBTxV+6q8QaL00gIXtO2quZ2J1ah7sW805tE9fFpKObHfjbRcAtKaG/YGOpS4tIC60dboZ740EjQJyJIAKxmwulkAHEJU3Qtpo14gNp6d7J6nxSU2LwCOZe/LMgm0UmCRGnUDNh2zwl0+OHhhzu6ZUestO/kiZ6D+MjqHQ93UT59C8JOWUWkDWV+hNmxWZonXlgf86+Zdd9YgqiOgimv4r9TTTp/+XTBf+N8QaS9KA/hJfVcQZnfJs4ZVaB0YivqL0UOB6h29XGrwIKVGaonTtkO7KTAOoyCb5nIC/egHxtJYuUAhDJP0q0FSbt/jVFwnzbEwB34tvFrmPAGiXmC+c7FAlnq6oi3zWJ0adoEXWJsB+8GNzEw1r5WGLaEWxxatuXQPwWIcE0JS8f7ox9pl6sqcss7lrtf2H00Mjgy6ucYu5GVmJ7fPNOLcIRopWAgdK0l54D+GbRNtClhKqpgFkn7kjT9N23ByhdoZoP4yN SPnBlD57 mwg+1r4hOcrqIspCuY1z9MX6Lm539NaoD1n1AX/YmeolTKTKrF/cumukD9+MHrjNZHwTosY7qp++F6TdYrWNBLXJfsL/u1iXbZL1P9W+gr91xI4ASB/QTZGIVyJy4d0joa1CKlH8OY/8ePpHXXfKSinRIzR3RQMPi4riKBhwx4NDudndqUb6zmxKOlWchGJxChWWrjSUZnzrlR17zFoQZPqszA/SSZ5UAMG8DojHodivCvKyUnwTDmBAfb+kOH4WQ336JvSm5Ah+quSUw/ZrdMr8Hr/W+U9xiQ8jWCw62rXOc8Imq4fe0ImuuNLNC0dmbGhGqVDinuofnD9z8Cs8UnDxOxDLJ+s9wBnlsVvJ7YdAROfjXoeZ3ZEZrG853PJGbaH6y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The callbacks used for cleaning up css's check whether the css is associated with a subsystem or not. Instead of just checking the ss pointer, use the helper functions to better show the intention. Signed-off-by: JP Kobryn --- kernel/cgroup/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 7471811a00de..125240f8318c 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5406,7 +5406,7 @@ static void css_free_rwork_fn(struct work_struct *work) percpu_ref_exit(&css->refcnt); - if (ss) { + if (!css_is_cgroup(css)) { /* css free path */ struct cgroup_subsys_state *parent = css->parent; int id = css->id; @@ -5460,7 +5460,7 @@ static void css_release_work_fn(struct work_struct *work) css->flags |= CSS_RELEASED; list_del_rcu(&css->sibling); - if (ss) { + if (!css_is_cgroup(css)) { struct cgroup *parent_cgrp; /* css release path */ -- 2.47.1