From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F651C3ABA3 for ; Fri, 2 May 2025 11:11:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4AA96B0088; Fri, 2 May 2025 07:11:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF9B16B0089; Fri, 2 May 2025 07:11:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C98376B008A; Fri, 2 May 2025 07:11:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AB2396B0088 for ; Fri, 2 May 2025 07:11:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A3C18CC24C for ; Fri, 2 May 2025 11:11:02 +0000 (UTC) X-FDA: 83397700764.08.6814B05 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 289DB10000E for ; Fri, 2 May 2025 11:10:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BIZgde4A; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Vv9F+Vw8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VTnYrFUC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=obJFcnTK; dmarc=none; spf=pass (imf14.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746184260; a=rsa-sha256; cv=none; b=LVbTHoNVCufnshhD5U+pzNR122ke6WricysAWqXnqem3gGc5fkKeOR5XlfNwzz4+AYYC3M vv2z5Se8a0Qqi2HExiB7n10bdLUb/sduMYke+JtJK5MQ/JNe3heAnkNDcf5E8gx4cnIEkI tb2rUbLfySLiydjEaBNlK12MG1NSsRw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BIZgde4A; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Vv9F+Vw8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VTnYrFUC; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=obJFcnTK; dmarc=none; spf=pass (imf14.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746184260; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=68RwN3NuFrSs2yXzuINW3GXKrctQtEUkF8f+0ox5Jz8=; b=wStWZFuSiUUpx6NAxfoieJZc+M2cy9Q/jO4O1eMiMFPg4YiGs3KDP4Tu8MMsB1ViMN2LRb GTBpUOWuykdYOdRdfshJ2RpO08vZGqjFgXiCnvm55jSpM03ULU3w+CrbF6VLp3hMjlXFQn uovuz0HSTn3CFJvXUy6H5Y//6kDkc3Q= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7791B1F387; Fri, 2 May 2025 11:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746184258; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=68RwN3NuFrSs2yXzuINW3GXKrctQtEUkF8f+0ox5Jz8=; b=BIZgde4ASTOu02FQCP4guJ0N8EXhOjprNpzmLfCbtjRifNnT49Zhd2OsWVWK3NtDODCE1L sZ7yli1v8CjHpHOEL4gpuLY1WzhRnOc6/8LzgD4W8Ewcf5zcTKGmF58OZOD4NuBEyt+SJ/ zF4hC+frRR9X+YoxuhtGfR+0JO0hQus= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746184258; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=68RwN3NuFrSs2yXzuINW3GXKrctQtEUkF8f+0ox5Jz8=; b=Vv9F+Vw8ACIJFZOiZ6DrbhdhiG4Fe5gBnEniN8xfX0jZgh7XJYMUVJTeM2lfvdzTC/e0fP D+US2zRhniX3UMCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746184257; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=68RwN3NuFrSs2yXzuINW3GXKrctQtEUkF8f+0ox5Jz8=; b=VTnYrFUCgHIbTcmpbXGumJWvwr+lYUBDw/qYSCnas7LysWK0sgW/w0xxtqBJ5ckfodomGo w76r1e952kQ/FT6uqtoUVfyUnfqdbk3fT898ikGqyZeSk4IB2Ag/lMPPm6/AypJeR/1TcK mPnnqp2DHheBZ6KmO8IYc/iGScGtE/I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746184257; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=68RwN3NuFrSs2yXzuINW3GXKrctQtEUkF8f+0ox5Jz8=; b=obJFcnTK2U27dP3+ZPqoo8i4IK+9zSjDVdPX8eREvfkuvpx9yThmWfVmQQwL9qcEo4e+K5 1eN8y16BJBo19JAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4F65E13687; Fri, 2 May 2025 11:10:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id D9UrE0GoFGi8dAAAD6G6ig (envelope-from ); Fri, 02 May 2025 11:10:57 +0000 Date: Fri, 2 May 2025 13:10:56 +0200 From: David Sterba To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , David Hildenbrand , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Qu Wenruo Subject: Re: [PATCH v3 2/6] btrfs: drop usage of folio_index Message-ID: <20250502111056.GP9140@suse.cz> Reply-To: dsterba@suse.cz References: <20250430181052.55698-1-ryncsn@gmail.com> <20250430181052.55698-3-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250430181052.55698-3-ryncsn@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspamd-Queue-Id: 289DB10000E X-Stat-Signature: w4uk13fa5aff16fkiwpfjuty8aqnb411 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746184259-961011 X-HE-Meta: U2FsdGVkX1+KjqVoWNX0cFYg95ToGP8KKQFd/yIH8POLirAw2t7qMkidSiPK6rZ72cL9M3beqaYRDvx0IHAZcapdIjeh8vJZfHHeqo1S2kmZHP9LP6teg47oxoVvzd7N0nFHN8+wqReQ7d8Iza9jdqWu5UdoWYu7cmBuTcC5YShJLW7rb08RDrW2gJLsIcpBevKAw9Xon0wJWGP102v9lx6whItuY+vNjsSWJJyXc/2JdAiTNHrHeZpvYgEGj+TZHH2MOY0CMhwRviCcgYU3hkXsjJvLwejxze92Vf2j9l1jf/NGAxlfUkg7R+FOPAawhfCdxuKfSsREXYCeXLrrpFFpb2XBK2iDm8V7uCQ6LhADbFuSL6c+mTSBpKeHT9gRYVR4ATJTFNci4v/AkK0i/xfbsXK+mOojH56YgYQtpjTUWKe2NpfIlLId9v0dO4Wflu2NDDRsUtVGXXR8ZVKZbQr/tzKueZEtcPcPJONiCjhC4xNWttwIVkZm7bw0fM5+51t1HiBDlDILxiFTtBSf3tXZ6NBDFjdjejEW4iQUpAVYYtXqL7jPk+XZVwUIqmqlEy+mvI16Pu9a5yiLMq+9jj6+wB9Eg45R3uYZtCmwri+1odlvZTxw0Eo7WKRkJRatT4diFIOD6TKL+VQg94pB68XcmfGkg0H221Oaamvf43O/lTynSAh9o9hsOoCUtvZH6vjHUYGQMO8WAxx8NmOjz2Bx876A5rajZ6+vtwhiJ5P7rV2npuNxCM7rclkGSimY0tV9TAc30uHY6Cq14kjDKM4uum2K8h95bGcgkh8hZexlHXBt6BtgB9xmDWo5B8lG12OfNoMNUsQHt25hemcKBKK/05rpJgZL2wAcA6zYO4gLG5irGAFnfEUGEPb9++81m6ECKS9FVq8cC4VI/BdgdM68Mnx2ThONii/LA/YvDHaWvo7RDL0sXWc7gWxz8y4FPpqF2diTP/vLACf0b/7 jCvFS73V 9us8mX+evIlZNUFIunuJYymRwpIxWOH+R8ArAR1goF3GTBgnUszXs/isD4BAcSmPPQCpClV1o1s8nBeWjzL9we7nrMRAw7opClFYvPT/m0ENqHg67tXnGxOO2npTjlYOxHHsScMrLmLqtbnCMyrKLtHSlfKSMqet0fl+Y0PeorEGWZIdQt530xZEn+VfoS5BGnj80Wkzmq1gOvGiCxoIeTZo+jsShYD4s8o7JbH3jPKMs8eDMEnLQ4RCHRWyVl+EVVROd3jCDYdjTTIpRlLDGP/TcJh860PH5vfqG0DiNUZ/C9SbfUE4ua4wGKX/waa4AynGG9F0PiQy0DpdXGQJzHSUeuiQRAZY3SA4XllQcZUqp7NvC3HKU4ZwmOwK6W1EB7arS5eFdI5a4drhWC6MEnLFivAKtbQua1w/CvIyghsjITCDVpyXeetndJ2FU+SYWkt+o8lxEpYI3vlW9zVXwgwJiU+l7Z2+EKQkDt1+vYl1mGbha8D2ry4QYV6o8/4OmMP/Cv7SSt9Pn8B5vwhfKpzCUEJJd0bPAdk+/YVoH4IZM0OQZf8xuGJHU0lewF0exqo/nORGijRbXy3uHRjKoq9EcDTART02g0VPebTtdCHJZ4fxcscJwTHgUjwHGoOMM2cU/5XxmTxf2+jp0pNq2X6iopGrjGCFo2eonGh2aTnsa58q0JFiO0+y9/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 02:10:48AM +0800, Kairui Song wrote: > From: Kairui Song > > folio_index is only needed for mixed usage of page cache and swap > cache, for pure page cache usage, the caller can just use > folio->index instead. > > It can't be a swap cache folio here. Swap mapping may only call into fs > through `swap_rw` but btrfs does not use that method for swap. > > Signed-off-by: Kairui Song > Cc: Chris Mason (maintainer:BTRFS FILE SYSTEM) > Cc: Josef Bacik (maintainer:BTRFS FILE SYSTEM) > Cc: David Sterba (maintainer:BTRFS FILE SYSTEM) > Cc: linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM) > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: Qu Wenruo I've added the patch to our for-next, so Andrew can drop it from his patch queue.