From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA21C3ABAC for ; Fri, 2 May 2025 09:31:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27CF36B008A; Fri, 2 May 2025 05:31:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B8A6B008C; Fri, 2 May 2025 05:31:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11CA16B0092; Fri, 2 May 2025 05:31:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E76786B008A for ; Fri, 2 May 2025 05:31:51 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 821221CF9F7 for ; Fri, 2 May 2025 09:31:52 +0000 (UTC) X-FDA: 83397450864.21.1B4B5AD Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf15.hostedemail.com (Postfix) with ESMTP id 8AC68A0009 for ; Fri, 2 May 2025 09:31:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sOOyUR9q; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746178310; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=E2bzYEdZENVlHAR2mJqnMuadPcu56hgVTunSk+DxuBU=; b=qwnvm01xpsyeO2sGhC8WwLed53tZYiyjbiyzwXALQub5DzQMv3VSrf17JQ/5R14KM1XD1O dKZI73/gvYNsINBPm1IN+LDZ1ls/xBfQuQYU3LHD3mGQla4QAmIj0+i8irVm2QZeFZ+Vxx hCUqzS6DVFu747wz5rOx1BocIDTAD6o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sOOyUR9q; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=devnull+Ignacio.MorenoGonzalez.kuka.com@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746178310; a=rsa-sha256; cv=none; b=FCKUZtbZBkcxTmWwVzvYRVx1g+CVsfvL7QpG+8FN5co4wB8UvYbzrKQ/DwQPi4F9ZWkCI3 obwZJ+9E3V0iPVryyPGLdgD/Higqvd7rSv8usThLYsTurNuyXXbkAbmHpKj1C4d0F+K8II TKMfnkO/g7ho4x+fAWjseuDvt9OcgVY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 1A9CD68422; Fri, 2 May 2025 09:31:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 3D633C4CEE4; Fri, 2 May 2025 09:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746178309; bh=8O4zIZ9Qzp6mbnHE5QCiNJEo51Ocv0R4T+lUPDYjNlk=; h=From:Date:Subject:To:Cc:Reply-To:From; b=sOOyUR9qy9yXnUUrUaJet7pvQ0Ydqwe/srOrURjzBfnMVBo9fjn7bi39tuI7sWNbs 0ePzM/UEm1Fc4xsSEp7RbJQfx5Z7FCDIlodvYEXgXpHoWo3ZT73TEvd1Efki36wzaG 5XNP/uKHhK3peXA5N7NN5TkyGwR5EPoJxrVCGkNwOI5vC1E6MOyhcLu/hpog64yV7A fwRCt8YP6S1YrD/c00JorF/P8PLNzjd1eCb2BNmnqwt7pTNJ5/mrM6Ac+TCDUW/F3e zcftQWJyOxTpDsxR8mEdmqfOhgdNviIJS0PX0+yPfb7ZW0N2x7+qKX+RlEQAmvBkRq 9YIAfSQC/aVIA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3526EC3ABA3; Fri, 2 May 2025 09:31:49 +0000 (UTC) From: Ignacio Moreno Gonzalez via B4 Relay Date: Fri, 02 May 2025 11:31:41 +0200 Subject: [PATCH] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE only if THP is enabled MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250502-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-v1-1-113cc634cd51@kuka.com> X-B4-Tracking: v=1; b=H4sIAPyQFGgC/x2NQQqDMBBFryKz7kAMCm2vUopMk9EM1SQkqSji3 Zt28RYPHv8fkDkJZ7g3ByReJUvwVdpLA8aRnxjFVgetdK86fcWF4o8hFzJvLAHXZfDBfSaOVOv g5x1lxOIiSkb29JrZouFOUWtZ3XoLdTsmHmX7/z6e5/kF78HTM4cAAAA= X-Change-ID: 20250428-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-ce40a1de095d To: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ignacio Moreno Gonzalez X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746178308; l=1800; i=Ignacio.MorenoGonzalez@kuka.com; s=20220915; h=from:subject:message-id; bh=fqHEYzRVTDCWtppau7rpnlBqweJIa/e1V5D0pJG1Pm8=; b=sORPxW2hJtjJRkgQLgAA4J9V8d632Q5Nhca5+LarntPGbh2i3oJLgDVba4c3Dnq3bRs7F2MT6 n8GBzNgtAK9Dz0klHvfVo09O3Pi8Ku2/OtzI2vIl3lJerwPHelJQUJg X-Developer-Key: i=Ignacio.MorenoGonzalez@kuka.com; a=ed25519; pk=j7nClQnc5Q1IDuT4eS/rYkcLHXzxszu2jziMcJaFdBQ= X-Endpoint-Received: by B4 Relay for Ignacio.MorenoGonzalez@kuka.com/20220915 with auth_id=391 X-Original-From: Ignacio Moreno Gonzalez Reply-To: Ignacio.MorenoGonzalez@kuka.com X-Stat-Signature: kgykbstbr8d4cexo4et37i74agisqzf1 X-Rspamd-Queue-Id: 8AC68A0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746178310-850244 X-HE-Meta: U2FsdGVkX1+PT+O6iFzTC1YfOXYW0ACfwEgPLk93fXAnld5GvUtEHxBHS4MravyaUQ41TBCDch9mIf6cgBlpcj8EBgJ4WQE/siAzYbaiDDRUKqw/QSEIDCgICP9E+/2jWGmrLA1+QAFR+UjgJioQewYK3kqiQSCvA+sHXnM9MAqbcEajWqvV3q0aHrquGi2FhflIOGH5PJO55+ByO4pnjvZdGm4p2B9826rXRDnEexHK6EJcx1Tz6HpyKifhXOoV5kClZm9LhOCZHBNAE4Qji3FmAngVjRQV+bS+LIylQ7CGTyYSfkcLYJqJ0893LAqx4pci2E6ezDb26QksRElUo9fBoCyo84uaq0i7fObygxTOaWOxRwnNCpG5sOfkhKckOBZNt7GRx3G/8iOZMMsV6rofx5olzJKieC0DDrJMaZ8/PCQFEqO0XlKIjBe38CWGCh94vMZYb+3kGV1g2TArfJV5sGMq5Ky3SnYo5L2Tbwb647FxFRiMwsZtTtABNwKvjO83J5jlsh1sk95JBpCNf5GdnDJi0JvFu9vZokG/vCFi3eJ7x0KWsf3AXl3H2icLkUqdTEFYxNqDiAyghkeHce5dBZu6DEAGo3UVnNXq0mRwVCkDFsMfiELc+coWv4mQccge7itorOAeVO3RmfuAVAb1+1vqDAZ3l2+nzmsIg4AUb+6ZbVrb6aH4SNuKR90vW22L8ATWUcmb21eDm9I9ICspI2jq74ZQ5GGtAhIOkW8y6PO2T4LawIRUuNKM4oUJC1cOngKg6Q06desFIPOI/HrlktpdnVlMZh2hTnWOEdxCFlYlCbn2neB9xibkVlvY+LRJRh/PTtxVj3Yge+Ot0S9ysNjsugX1zFr6XsEA7mcGygbHjjQR84+tPZ+I1drL009qspFQk/HMsV6EfqwiK5ekghTegQmeRj/MUifIBCq6Wx0OStWsFtug8MmHsMeMLPlqjJGXz87fQ+Z4QNQ uD3R206o MO2WguHTCRibwz3V6E76tL2660Zr6uCKtH/1SXLYvjZEojutjyDi9Mz3kaR/YyJ+KJL+ZaIhfTdFfKS1BiROUNzgS3Tgeb4GCIpdQYA6A3vN5167ayLu2LxPoKKKqeCiUR3/OMDbdYrWKOGouM/A4m9UJ11bAOOFGmjQQWIvhNfxaO1tnepwtFuRkyayE5qs4eDGCyUmeK5eE+VKFfR+6qscRwj9sCbiARanEpKnn4dSPWYQHJaqra1prCtSUtu49mk3pwhAAeu5vxnoYKgdP4F4bZ1iN3T/8NRHz0m16yqZI5Zgcoavbqdla/ZJ7FpKEi8/NJNoH3nxgRa47ElEa3UZVKYfX4or26MCeno7xsIRiEqATrd1FdIsGOlPu7QrGJEvdcjCSkBVDZjLv6Gmo3VllUvnmhwG7IkvouOHl2cEdZyw3rSK+Hu1VgYaoYn1SJYcbEIyD4GFZR1S00XhSENmab2AchXSitJ9Pyvr75GKk4CWfYZa620VVunEmEy/ry5bfvUkd59LJxqA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ignacio Moreno Gonzalez commit c4608d1bf7c6 ("mm: mmap: map MAP_STACK to VM_NOHUGEPAGE") maps the mmap option MAP_STACK to VM_NOHUGEPAGE. This is also done if CONFIG_TRANSPARENT_HUGETABLES is not defined. But in that case, the VM_NOHUGEPAGE does not make sense. For instance, when calling madvise() with MADV_NOHUGEPAGE, an error is always returned. Signed-off-by: Ignacio Moreno Gonzalez --- I discovered this issue when trying to use the tool CRIU to checkpoint and restore a container. Our running kernel is compiled without CONFIG_TRANSPARENT_HUGETABLES. CRIU parses the output of /proc//smaps and saves the "nh" flag. When trying to restore the container, CRIU fails to restore the "nh" mappings, since madvise() MADV_NOHUGEPAGE always returns an error because CONFIG_TRANSPARENT_HUGETABLES is not defined. --- include/linux/mman.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mman.h b/include/linux/mman.h index bce214fece16b9af3791a2baaecd6063d0481938..1e83bc0e3db670b04743f5208826e87455a05325 100644 --- a/include/linux/mman.h +++ b/include/linux/mman.h @@ -155,7 +155,9 @@ calc_vm_flag_bits(struct file *file, unsigned long flags) return _calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) | _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | +#if defined(CONFIG_TRANSPARENT_HUGEPAGE) _calc_vm_trans(flags, MAP_STACK, VM_NOHUGEPAGE) | +#endif arch_calc_vm_flag_bits(file, flags); } --- base-commit: fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2 change-id: 20250428-map-map_stack-to-vm_nohugepage-only-if-thp-is-enabled-ce40a1de095d Best regards, -- Ignacio Moreno Gonzalez