From: Changyuan Lyu <changyuanl@google.com>
To: linux-kernel@vger.kernel.org
Cc: changyuanl@google.com, akpm@linux-foundation.org,
anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com,
benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com,
corbet@lwn.net, dave.hansen@linux.intel.com,
devicetree@vger.kernel.org, dwmw2@infradead.org,
ebiederm@xmission.com, graf@amazon.com, hpa@zytor.com,
jgowans@amazon.com, kexec@lists.infradead.org, krzk@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, luto@kernel.org, mark.rutland@arm.com,
mingo@redhat.com, pasha.tatashin@soleen.com,
pbonzini@redhat.com, peterz@infradead.org, ptyadav@amazon.de,
robh@kernel.org, rostedt@goodmis.org, rppt@kernel.org,
saravanak@google.com, skinsburskii@linux.microsoft.com,
tglx@linutronix.de, thomas.lendacky@amd.com, will@kernel.org,
x86@kernel.org
Subject: [PATCH v7 14/18] x86/boot: make sure KASLR does not step over KHO preserved memory
Date: Thu, 1 May 2025 15:54:21 -0700 [thread overview]
Message-ID: <20250501225425.635167-15-changyuanl@google.com> (raw)
In-Reply-To: <20250501225425.635167-1-changyuanl@google.com>
From: Alexander Graf <graf@amazon.com>
KHO uses "scratch regions" to bootstrap a kexec'ed kernel. These regions are
guaranteed to not have any memory that KHO would preserve.
Teach KASLR in decompression code to only consider these scratch regions
when KHO is enabled to make sure preserved memory won't get overwritten.
Signed-off-by: Alexander Graf <graf@amazon.com>
Co-developed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Co-developed-by: Changyuan Lyu <changyuanl@google.com>
Signed-off-by: Changyuan Lyu <changyuanl@google.com>
---
arch/x86/boot/compressed/kaslr.c | 52 +++++++++++++++++++++++++++++++-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index f03d59ea6e40f..25de8c3e17cdb 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -760,6 +760,55 @@ static void process_e820_entries(unsigned long minimum,
}
}
+/*
+ * If KHO is active, only process its scratch areas to ensure we are not
+ * stepping onto preserved memory.
+ */
+#ifdef CONFIG_KEXEC_HANDOVER
+static bool process_kho_entries(unsigned long minimum, unsigned long image_size)
+{
+ struct kho_scratch *kho_scratch;
+ struct setup_data *ptr;
+ int i, nr_areas = 0;
+
+ ptr = (struct setup_data *)boot_params_ptr->hdr.setup_data;
+ while (ptr) {
+ if (ptr->type == SETUP_KEXEC_KHO) {
+ struct kho_data *kho = (struct kho_data *)ptr->data;
+
+ kho_scratch = (void *)kho->scratch_addr;
+ nr_areas = kho->scratch_size / sizeof(*kho_scratch);
+
+ break;
+ }
+
+ ptr = (struct setup_data *)ptr->next;
+ }
+
+ if (!nr_areas)
+ return false;
+
+ for (i = 0; i < nr_areas; i++) {
+ struct kho_scratch *area = &kho_scratch[i];
+ struct mem_vector region = {
+ .start = area->addr,
+ .size = area->size,
+ };
+
+ if (process_mem_region(®ion, minimum, image_size))
+ break;
+ }
+
+ return true;
+}
+#else
+static inline bool process_kho_entries(unsigned long minimum,
+ unsigned long image_size)
+{
+ return false;
+}
+#endif
+
static unsigned long find_random_phys_addr(unsigned long minimum,
unsigned long image_size)
{
@@ -775,7 +824,8 @@ static unsigned long find_random_phys_addr(unsigned long minimum,
return 0;
}
- if (!process_efi_entries(minimum, image_size))
+ if (!process_kho_entries(minimum, image_size) &&
+ !process_efi_entries(minimum, image_size))
process_e820_entries(minimum, image_size);
phys_addr = slots_fetch_random();
--
2.49.0.906.g1f30a19c02-goog
next prev parent reply other threads:[~2025-05-01 22:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 22:54 [PATCH v7 00/18] kexec: introduce Kexec HandOver (KHO) Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 01/18] memblock: add MEMBLOCK_RSRV_KERN flag Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 02/18] memblock: Add support for scratch memory Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 03/18] memblock: introduce memmap_init_kho_scratch() Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 04/18] kexec: add Kexec HandOver (KHO) generation helpers Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 05/18] kexec: add KHO parsing support Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 06/18] kexec: include asm/early_ioremap.h Changyuan Lyu
2025-05-02 0:35 ` Andrew Morton
2025-05-02 18:37 ` Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 07/18] kexec: enable KHO support for memory preservation Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 08/18] kexec: add KHO support to kexec file loads Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 09/18] kexec: add config option for KHO Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 10/18] arm64: add KHO support Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 11/18] x86/setup: use memblock_reserve_kern for memory used by kernel Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 12/18] x86/kexec: add support for passing kexec handover (KHO) data Changyuan Lyu
2025-05-02 18:39 ` Dave Hansen
2025-05-01 22:54 ` [PATCH v7 13/18] x86/e820: temporarily enable KHO scratch for memory below 1M Changyuan Lyu
2025-05-02 18:39 ` Dave Hansen
2025-05-01 22:54 ` Changyuan Lyu [this message]
2025-05-02 18:48 ` [PATCH v7 14/18] x86/boot: make sure KASLR does not step over KHO preserved memory Dave Hansen
2025-05-02 21:16 ` Mike Rapoport
2025-05-02 21:36 ` Dave Hansen
2025-05-05 20:07 ` Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 15/18] x86/Kconfig: enable kexec handover for 64 bits Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 16/18] memblock: add KHO support for reserve_mem Changyuan Lyu
2025-05-01 22:54 ` [PATCH v7 17/18] Documentation: add documentation for KHO Changyuan Lyu
2025-05-06 2:31 ` Bagas Sanjaya
2025-05-07 17:38 ` Changyuan Lyu
2025-05-07 23:54 ` Bagas Sanjaya
2025-05-01 22:54 ` [PATCH v7 18/18] Documentation: KHO: Add memblock bindings Changyuan Lyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501225425.635167-15-changyuanl@google.com \
--to=changyuanl@google.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.yznaga@oracle.com \
--cc=arnd@arndb.de \
--cc=ashish.kalra@amd.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=graf@amazon.com \
--cc=hpa@zytor.com \
--cc=jgowans@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ptyadav@amazon.de \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=saravanak@google.com \
--cc=skinsburskii@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox