[akpm-mm:mm-unstable 272/272] fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'mapping' not described in 'metapage_migrate_folio'

[akpm-mm:mm-unstable 272/272] fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'mapping' not described in 'metapage_migrate_folio'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head:   ea17e4fdc13cae144d90ce8561c2f50a49492037
commit: ea17e4fdc13cae144d90ce8561c2f50a49492037 [272/272] jfs: implement migrate_folio for jfs_metapage_aops
config: csky-randconfig-002-20250501 (https://download.01.org/0day-ci/archive/20250501/202505011647.L0LGO7Lm-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250501/202505011647.L0LGO7Lm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505011647.L0LGO7Lm-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'mapping' not described in 'metapage_migrate_folio'
>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'dst' not described in 'metapage_migrate_folio'
>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'src' not described in 'metapage_migrate_folio'
>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'mode' not described in 'metapage_migrate_folio'


vim +637 fs/jfs/jfs_metapage.c

   631	
   632	/**
   633	 * metapage_migrate_folio - Migration function for JFS metapages
   634	 */
   635	static int metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
   636					  struct folio *src, enum migrate_mode mode)
 > 637	{
   638		int expected_count;
   639	
   640		if (!src->private)
   641			return filemap_migrate_folio(mapping, dst, src, mode);
   642	
   643		/* Check whether page does not have extra refs before we do more work */
   644		expected_count = folio_expected_ref_count(src) + 1;
   645		if (folio_ref_count(src) != expected_count)
   646			return -EAGAIN;
   647		return __metapage_migrate_folio(mapping, dst, src, mode);
   648	}
   649	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [akpm-mm:mm-unstable 272/272] fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'mapping' not described in 'metapage_migrate_folio'

[Shivank Garg]

On 5/1/2025 1:51 PM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> head:   ea17e4fdc13cae144d90ce8561c2f50a49492037
> commit: ea17e4fdc13cae144d90ce8561c2f50a49492037 [272/272] jfs: implement migrate_folio for jfs_metapage_aops
> config: csky-randconfig-002-20250501 (https://download.01.org/0day-ci/archive/20250501/202505011647.L0LGO7Lm-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 13.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250501/202505011647.L0LGO7Lm-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505011647.L0LGO7Lm-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'mapping' not described in 'metapage_migrate_folio'
>>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'dst' not described in 'metapage_migrate_folio'
>>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'src' not described in 'metapage_migrate_folio'
>>> fs/jfs/jfs_metapage.c:637: warning: Function parameter or struct member 'mode' not described in 'metapage_migrate_folio'
> 
> 
> vim +637 fs/jfs/jfs_metapage.c
> 
>    631	
>    632	/**
>    633	 * metapage_migrate_folio - Migration function for JFS metapages
>    634	 */
>    635	static int metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
>    636					  struct folio *src, enum migrate_mode mode)
>  > 637	{
>    638		int expected_count;
>    639	
>    640		if (!src->private)
>    641			return filemap_migrate_folio(mapping, dst, src, mode);
>    642	
>    643		/* Check whether page does not have extra refs before we do more work */
>    644		expected_count = folio_expected_ref_count(src) + 1;
>    645		if (folio_ref_count(src) != expected_count)
>    646			return -EAGAIN;
>    647		return __metapage_migrate_folio(mapping, dst, src, mode);
>    648	}
>    649	
> 

Hi Andrew,

Apologies for missing this kernel-doc warning in my local testing.
Below one-liner change will fix these warnings.

From a0685c29b71cf007bd7fb3e5ed58d1cb74e171a3 Mon Sep 17 00:00:00 2001
From: Shivank Garg <shivankg@amd.com>
Date: Thu, 1 May 2025 11:10:54 +0000
Subject: [PATCH] jfs: Fix kernel-doc warning in jfs_metapage.c

Change comment style from "/**" to "/*" as the metapage_migrate_folio
function comment is not kernel-doc.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505011647.L0LGO7Lm-lkp@intel.com/
Signed-off-by: Shivank Garg <shivankg@amd.com>
---
 fs/jfs/jfs_metapage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index f863ba521533..c37835d47821 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -629,7 +629,7 @@ static bool metapage_release_folio(struct folio *folio, gfp_t gfp_mask)
 	return ret;
 }
 
-/**
+/*
  * metapage_migrate_folio - Migration function for JFS metapages
  */
 static int metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
-- 
2.34.1