From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A88BCC369DC for ; Thu, 1 May 2025 16:39:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 603386B0088; Thu, 1 May 2025 12:39:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B3986B0089; Thu, 1 May 2025 12:39:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 484E06B008A; Thu, 1 May 2025 12:39:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A1376B0088 for ; Thu, 1 May 2025 12:39:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 30B331CD04E for ; Thu, 1 May 2025 16:39:23 +0000 (UTC) X-FDA: 83394899406.09.0FFD4CD Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf22.hostedemail.com (Postfix) with ESMTP id 6E9F2C0008 for ; Thu, 1 May 2025 16:39:21 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AkDR9Jq8; spf=pass (imf22.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746117561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=TZdpeaEefEtsI5U4bsRp7ztRh4qRfGNOADZjn1xJAfk=; b=EEx7gsvA35UdYnCm5hcVkE4C1DOFVwd6WvuGmp37ivsq+r4wxUfmRtIFsFvkMxSVkE1P97 OBF0RKM4CNBq0Rfl//xLfdU7VVRBBv0Vd4BAck7tyyrxsmqNCFqE5hAWWk1tKiaeDElonq N3dfSpxu/Id9A85pvjs1GW32QbJf668= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AkDR9Jq8; spf=pass (imf22.hostedemail.com: domain of ujwal.kundur@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=ujwal.kundur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746117561; a=rsa-sha256; cv=none; b=pD+eWQyGohsjxVLKxbZ/5ghS/jLIr0eAApI4Sx/ZlS0xD0oeglMK/zq/avfkSZYZQkoYW9 2LCFaqIRbKRfakpM7i8fNvSWz7Pe9YodNkFJnKiuehWfn9NgKDTh67pU6G5anbA17nIhnh eEGNoGcqdtPSh6zo7ExuX47/5XBiH/o= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-223fb0f619dso13893615ad.1 for ; Thu, 01 May 2025 09:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746117560; x=1746722360; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TZdpeaEefEtsI5U4bsRp7ztRh4qRfGNOADZjn1xJAfk=; b=AkDR9Jq8bdlJNvUO73vQysr6HAfOfshdN3+NyhrLx8pn6XmeYcik8kaCwgWFzXC1Am v5qR6lcTlm07k0YCOOghsHZb9FvUbxrOYsAzrqY3plL/umXtj/bXLytHapDx/8Mh0Ctm XSiTJg9yO8XkQrMwCXlb0AH7fnbPipvokFmkax65pkLEHdpW9QY1JfBK0DHrPngzBVpi Bx417bHNS3savRggNzUnugpw8REi8YVqUinWlVrA4Tm56zwxv8BEj2XgzA4VuVlsPurI ecJuZfXXHHqMDzP+NciCq9wT2QhxG+sO892m7KjO4L3aWiqfxBiw/gTLyR+Qp41q3vny hbUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746117560; x=1746722360; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TZdpeaEefEtsI5U4bsRp7ztRh4qRfGNOADZjn1xJAfk=; b=C5CvU40Bqf/HHgEqxFqWRyN1LD32TstKLDTsXrtS9ntJUM+AMSdHssbnf1+lrejDTe tbiSSz0euqeB73vAcvJ2BkKVgaKW0l4Rb3zS0WY4PIdbC86aEmvDR3JjLDvg4HOp99JO EGv+1S0Do/MuevWafNUusjOn46wECez0g6VIsm2PlLBvyviFrNadBWCQ68uYNuB8Wk9z 9bPm9++aM8ZU72C7W+nwbg0SOX7/yyjNmR87h32zouSM0lw0b5p4QZfj+8/GJ38CgCY7 JNNsuBHBNs1hNwTH0Pk2HUKyA400hklAJb2GMr0YrsZyu0mP2449pT3pDWfGJveYYMLW RJ6w== X-Gm-Message-State: AOJu0YyaQZ7Dgnod0r6GHZqH/oilmh7XQCp17+hmS1xTHDb53Xl+SgqF kytHhlXrVTmOihpmmvwJDj0YlsKDSommiNRMLygJ+cviaUBzj8o= X-Gm-Gg: ASbGnctrDaHpfy/xOeC3wrlBsTg2ryDlh17IKqcV+OvEg+UoS/D2HRHCjmTRGfDh4Rl eUGyzwJPsUVRK36oapAX8/0tVExnxt015u2v+Sp8aBUW72mzMRlfRUpO76PXzili6YZBxwqj3vD pE/JgngCqI9kIYMA83lp/Jtd9e0foixDJkv+WOkA1Hws6bbm6vtXhXNTKKnKI9i5JaVPxyJK89C Py/54vnw+yMn5FqBycC2HrXJcJOA7NwKhYZyO/YVQDi2GeTNJAj1Mtp+kQcz/kzlGG96xmdQA4T cMQv6KuvbYaJXXE2eJed7j6TYmgkLiIHm0A/4aw9pDlXs3quhQ== X-Google-Smtp-Source: AGHT+IFcwEYNw1wVY/04aDP3XIHmVYZkBEqwaQakpwHu+5ab04JpJku3qjLTtv6yJLXJHjahlvlAfA== X-Received: by 2002:a17:902:ea0a:b0:220:e9ac:e746 with SMTP id d9443c01a7336-22e0865c0c9mr54769345ad.53.1746117560161; Thu, 01 May 2025 09:39:20 -0700 (PDT) Received: from debian.ujwal.com ([223.185.132.49]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e0bc6e678sm8797525ad.132.2025.05.01.09.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 09:39:19 -0700 (PDT) From: Ujwal Kundur To: akpm@linux-foundation.org, peterx@redhat.com, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ujwal Kundur Subject: [PATCH 0/4] selftests/mm/uffd: refactor global variables Date: Thu, 1 May 2025 22:08:23 +0530 Message-Id: <20250501163827.2598-1-ujwal.kundur@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6E9F2C0008 X-Stat-Signature: h13its45hzgqmsbjqq5t4jrwcuorgmd3 X-HE-Tag: 1746117561-680385 X-HE-Meta: U2FsdGVkX190MeugWGab9paIh25zicEqYy1gF7JbI3obJzmXhN4UcEVHoQYdsPBwchxl+mdaibpAp2DRwoaZj+ESWO+QIPiADTm8J8EpGuvvQ0kyOzgnbUU5ir1aRApHhvCrSwofxriOblULcvWF8MqrJnaZbmx8EFFvNPk/6YNc+M2T3ljcKpyEsArgYKk07lfPux27AjoNobJnPgm+Rt0fNH9Jzg4GzsbxDGpfBEoX/Ppe8FKceNUlJlUWbdKlq6qTPLsmcNK/JPCfAvYaYHUuXm+lUA4G3nrj3Jb9qxCBq165Vrn+i7kHt72WkiTxht3SC/1kYHiFGp+PTrzo+Kq8ugwpmq3WTy/R9Br5cgE2550jjr+kradJ2Cnagq7oqSyQBf7du+Xtg+FPnK7tHo8E/aPip2Wa1djAp8ehhe9BQwlPajVxzAHg3/soGZ59CzvZ5GB/N7zapXi9PlnWc7y9/y28pwyFO+lu4RZblDe9pU72/YWjIQiPJfYmWt4BvN4B/ad/29hXM54SaCnyUXtv9743ZAM5wR2yJCAFBlANjQgnFi0EeX6moto2CAB7kdS8s1jZ+UCMim0y+T4VGBeXUcM+fX5cr8LT/vlap6RCX25XQKsTkGKojidcG9h/FJHqrvEzafAC7SgUcJda1A8+EmAUHxDCdgJybqN+tDhuzGfdyqkCSjhsOCAxYIwyxAkQd+pfR4l54W3ifyU8paZ5eNPkPPWHp9zk9JOAU17xbJOCVmUEfxM9PuRCsQPGn4AsZSnyqtmKstmqnKeShV3S3KHfDwc3W5kgTmAhvoo4TTowFJTpMMD/BBoJbOGdxbND7hP1a/n7AmE1iGQGxCKsQ9k7LWWnq/+b57DklYOGMkO6MbeLJ8DYWSO8vaLdfwONGuFWyvZBPi+/XRkOYa1BrVKKX4gugEB99TMHaoNRsiAmbVlVCEIgz63RNcs0+mjlejnTuHRR6dHXD/Q LrjfJAKs rCElKnjMahwlNOaJXQ5cye9i0m9mQ4Co6Qt4N9oPeRDXA3jX3f/1NtqvsXKa+4ZmgGzoNsVXET6/ZbXXfQD39wH1x9PosLDSB4prva6epNMGnG1hKAvkNHkTNn9DtcqgU/UY096NEUNAxUTL5WDaa4EipcefZcbx6wKPinTYW2+2dWSjR+78DyMEOqYQrlguMG7diw7qnA0ZTnJe/gvKink1yBC09WZ8aOu8WqcDaBwWuV2qou6o6HyMtwlA6awHokBLMMBoYmbDXW6v45zo0ckjLrTlYo8SGFxuD7olPNwUboo6Fbl5bivBxPUtstgglUhh5w+QD1+xAndY0pFWvOgRf97nINOEA9BCsMgw7IFoX7KTAmKWS9FYpaicG/xpKlipodJO9trreM7iT/3fcU+ekh3jDWkuSvqLr00kS5kqrQnOiebGs92u//nALlycY437oAcjAoRwJQIA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patchset refactors non-composite global variables into a common struct that can be initialized and passed around per-test instead of relying on the presence of global variables. This allows: - Better encapsulation - Debugging becomes easier -- local variable state can be viewed per stack frame, and we can more easily reason about the variable mutations Patch 1 needs to be applied first and can be followed by any of the other patches. I've ensured that the tests are passing locally (or atleast have the same output as the code on master). Ujwal Kundur (4): selftests/mm/uffd: Refactor non-composite global vars into struct selftests/mm/uffd: Swap global vars with global test options selftests/mm/uffd: Swap global variables with global test opts selftests/mm/uffd: Swap global variables with global test opts tools/testing/selftests/mm/uffd-common.c | 269 +++++----- tools/testing/selftests/mm/uffd-common.h | 78 +-- tools/testing/selftests/mm/uffd-stress.c | 226 ++++---- tools/testing/selftests/mm/uffd-unit-tests.c | 523 ++++++++++--------- tools/testing/selftests/mm/uffd-wp-mremap.c | 23 +- 5 files changed, 591 insertions(+), 528 deletions(-) -- 2.20.1