From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED536C3ABAA for ; Thu, 1 May 2025 22:59:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D217B6B00BB; Thu, 1 May 2025 18:59:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA7456B00BC; Thu, 1 May 2025 18:59:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B97596B00BD; Thu, 1 May 2025 18:59:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9D26E6B00BB for ; Thu, 1 May 2025 18:59:14 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F0F35BE8AC for ; Thu, 1 May 2025 22:59:15 +0000 (UTC) X-FDA: 83395856670.29.470C520 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id 28B9AA0012 for ; Thu, 1 May 2025 22:59:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=svg1gv8T; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746140354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GEgaII0kDcsSXlHpWQMEIxTM4nnILnk8oUE1P3mgM6c=; b=FqZryCkTz82J2A4Ou3YSv6nFCZf0/J6skrWLE1rL5dYmHuuEKjvn+IHnhn04T/FOt7gdtX 1fiG8lyHgd5Q8o2zGqM6alJwIiI+dWxetOeC6x6Yi/5pvNgpDrC/l2pINTq2xD31vgG6X5 fojsuqKsK9SPXoIedsGmk1pTmIP1EDg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=svg1gv8T; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746140354; a=rsa-sha256; cv=none; b=hwbfUk3Cp0hrTQv8XJKXKRiLuhRWe5cq4zjup6RIaqxnRTWJCQaqVjoGKiu37B+GM2va/l nCKcjugjFHhTYFxFM6ksgKWVUt5igPpcx2msHsAr5kxh/Zg3yQtCL0jq25ITonpZD75KQS QRSOp15xCbaPVU3koNUmztx8QxNn76o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8F9B3A4C1E8; Thu, 1 May 2025 22:53:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7081C4CEED; Thu, 1 May 2025 22:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746140353; bh=VuqnoELnEvk2Nf7UetaqLNzV2RQ+T4JbbkAsve1OGJk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=svg1gv8TyYx+D1i/pyZ1bCUfQxcWz+U7V6lM1fnDFppANr9sENoOQtflNVLrplWpA jSHQQpiA18XTB5gpnkRXcB6p0rLY9Wo/P+PyVwsn7R0UoaygyBlyB3YmMNZtFMCp32 59U6z2P9phy8PaIvnyD5A+7SM4adssdgNdhYML9s= Date: Thu, 1 May 2025 15:59:12 -0700 From: Andrew Morton To: Matthew Wilcox Cc: kernel test robot , Shivank Garg , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [akpm-mm:mm-unstable 272/272] include/linux/stddef.h:8:14: error: called object is not a function or function pointer Message-Id: <20250501155912.fc59c6e36c87c623501fe988@linux-foundation.org> In-Reply-To: References: <202505020405.YzD9aNCo-lkp@intel.com> <20250501141304.beac3e9d892495eea7a4e9cb@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: x54ckzea13igire1rwem1g4fxfpzzcbt X-Rspamd-Queue-Id: 28B9AA0012 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746140353-278844 X-HE-Meta: U2FsdGVkX1+zD+r01s0rRgLkJUZxMxu/la+x9k2L9k1HiAQ8G2TYGutVCacc1/r3yVbyOUiVvbKDuscwpgshF8+erDiChC1xwR0kEQuYk3D3iUiBMgCN0p+tHPyuVZ/oLd1GA4vpn2/G+nHVXAckqvbs8j87XRDUkpJbkctuHLLat8VSBuP79x5d5lN9jW9CLDWHuOKwxVaWeCCy+kuxUxFzcGEWTu1vWjeBKakGtBJUQxiw/DSZdq7TECqkXW2vyukwCBYasqh/y+arzWrmPN18zlWtYNfU6whNQnRW1CIXnJeLt3EfBDqNJfOWEMZMZtKSoDjq30BCttVWEWaTYRf/NyoDSfzOMdqR1XYNtDzmOWuSn49PWdL/ISJ6A4CyoWjcAHaQS6IkZvEfAcGQ3s7Mj1PzJtQJMrK36YJa5fkRsbza8ozJ6aNYd8+7hy+W1SnY2yJ4tmo8TsVa+jEOQgwrzV+33ZoynePx2m6VCQV8Qt9M0wBzz+l6iJKvYUPNMBpDdcoFIBGwfZNMqMETfHr58dcaxaXQat9YNPncDGuEng/1iSd9tM0wbahYdxkyZumHPJ6t/KWDkt9O8DZInV6XiDz9krDHxhzYNkX9V68MI2Crzv78xW6742RZUm50MlYbNbJSl39jdYn3RtWeCLgTfvjHU3/RTZd7c6MLdjGpwqpSTgBQEv259SsVLhLDAzgQ9BgII+P8MBKCRx3Q6VcTEQVi1zvCRS8P+JmtKDjpCsLeSeIw96ovDuY9oi/wqEQKReQx1cQdcCFGgfMtqLRoeoxxpQx6uAxRlHCVJEp1g++NQwiUdw/SMZqRq5k7JHQ9iK6RiJMUGqf0adohE2/8Hwe2N1xGJ6h6xYTTvg23ssnkJFiSz8dsLBdvTYCe1A9Hsi3CN5EwfS7BbovE3L38PeeOZnM1BCxSolmSgxL5nnDpxe1EiexrY+8+lGx3D1NOp51adlhK1cEQ4EL zfvENT+y fBvUP+pPhjl/wKqdhj7KwHXj4jGsBtNBjtrIQHHMJPJo+PsvA8+7cv4Vmc9N4FZDBfnawdp6S6AhKEBIZG3GWOdAez2EQW+L00tAx1k8G5z5qQCdOOtjiS/LEIfiutLlRm/suWsL8MeLBbS4qizJLvMJ9rSmb9TLk/BdLJQ/jQXiQqvVtNXXLxtr6yEs4CgQ2L85gQHIA0utqsu1AYsiyRJtut3m4/ext6QgvwMpMgASq0krTK3CKZH9HgrzQLNluN2EIAMdNtwqF3pwQ1F0B0dWevPB2iiFUTxBfmKCMcRnbrFDQWAOVRcCFkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 1 May 2025 22:52:30 +0100 Matthew Wilcox wrote: > On Thu, May 01, 2025 at 02:13:04PM -0700, Andrew Morton wrote: > > Should this new JFS migration code be wrapped in #ifdef CONFIG_MIGRATION? > > Yes OK, thanks, I'll try this. Maybe there's a way to reduce the amount of ifdeffing. Warning, contains bonus whitespace tuneups! --- a/fs/jfs/jfs_metapage.c~jfs-implement-migrate_folio-for-jfs_metapage_aops-fix-2 +++ a/fs/jfs/jfs_metapage.c @@ -152,8 +152,10 @@ static inline void dec_io(struct folio * handler(folio, anchor->status); } -static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst, - struct folio *src, enum migrate_mode mode) +#ifdef CONFIG_MIGRATION +static int __metapage_migrate_folio(struct address_space *mapping, + struct folio *dst, struct folio *src, + enum migrate_mode mode) { struct meta_anchor *src_anchor = src->private; struct metapage *mps[MPS_PER_PAGE] = {0}; @@ -199,8 +201,10 @@ static int __metapage_migrate_folio(stru return MIGRATEPAGE_SUCCESS; } +#endif /* CONFIG_MIGRATION */ #else + static inline struct metapage *folio_to_mp(struct folio *folio, int offset) { return folio->private; @@ -224,8 +228,10 @@ static inline void remove_metapage(struc #define inc_io(folio) do {} while(0) #define dec_io(folio, status, handler) handler(folio, status) -static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst, - struct folio *src, enum migrate_mode mode) +#ifdef CONFIG_MIGRATION +static int __metapage_migrate_folio(struct address_space *mapping, + struct folio *dst, struct folio *src, + enum migrate_mode mode) { struct metapage *mp; int page_offset; @@ -249,6 +255,7 @@ static int __metapage_migrate_folio(stru return MIGRATEPAGE_SUCCESS; } +#endif /* CONFIG_MIGRATION */ #endif @@ -629,11 +636,13 @@ static bool metapage_release_folio(struc return ret; } +#ifdef CONFIG_MIGRATION /* * metapage_migrate_folio - Migration function for JFS metapages */ -static int metapage_migrate_folio(struct address_space *mapping, struct folio *dst, - struct folio *src, enum migrate_mode mode) +static int metapage_migrate_folio(struct address_space *mapping, + struct folio *dst, struct folio *src, + enum migrate_mode mode) { int expected_count; @@ -646,6 +655,9 @@ static int metapage_migrate_folio(struct return -EAGAIN; return __metapage_migrate_folio(mapping, dst, src, mode); } +#else +#define metapage_migrate_folio NULL +#endif /* CONFIG_MIGRATION */ static void metapage_invalidate_folio(struct folio *folio, size_t offset, size_t length) _