From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCACC3ABA3 for ; Thu, 1 May 2025 15:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B86D6B0088; Thu, 1 May 2025 11:03:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 640726B0089; Thu, 1 May 2025 11:03:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B8356B008A; Thu, 1 May 2025 11:03:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A4D96B0088 for ; Thu, 1 May 2025 11:03:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BCEFCCC159 for ; Thu, 1 May 2025 15:03:07 +0000 (UTC) X-FDA: 83394656814.20.0A32B04 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 7A15F40009 for ; Thu, 1 May 2025 15:03:05 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QE9K7S0F; dmarc=none; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746111786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SknNweDJMYv6Cc7JXUCuginAJHi4T0ZKllMpOn1Yf9A=; b=W+E2VRMeaV6CeYcjDL3UNLfPBlSmsnsQuRwkhgIZKXG9HoIgy8ophsfzLlsRlYvKGuQE9X Mlku9GP4PVTX0ytmkiGctKQgYZfUTI5jY1JkNY6Uun7CDkNxQcM9iNlKltuaF0BORZuhtw nmwAc5FgsVMEBbWZMQ9NERIW6J/h80g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746111786; a=rsa-sha256; cv=none; b=ej3dXis2Ld8+F8nd/ROTgb48jGIy5Qatbekw+OSjz3u690ara8eO8U+e2zqqQvPxTAPn6o nCopNoCEiJ84Bu2YaG5GbWEjzu5Hx8XhwAa8rd+ridG+FQa25vywVOagl1zv/fNz2d8Rhd cuP+/1nQnrySltzwbwQeh+kwztleLXE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QE9K7S0F; dmarc=none; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SknNweDJMYv6Cc7JXUCuginAJHi4T0ZKllMpOn1Yf9A=; b=QE9K7S0FqJXdRMiI2MUQfyFVKN zJkaOZZAvX0UK9xBOJnD6xr1oo4dLko0vESRIIkP4sjHHPxZkleb2D8Zai321exEYA2JJr82ElX7s y72vsCa48dbNhj3sR2u6AvvpDc6GUftTpqrd7fLDiVr8l4ZJcPOvCc/B4Kso/X5VwtY001koeorb7 w0lpR1LpdbzQwtNNGzQXqNnli6Sbl3pH+QAdCVePhkf3FUFd/ngVNiv41q8dPOdm8t1mbTM/UmJ5P NuryBBTCcNBBOjT/+JRWnUfQQL+DhMwA+igl0308JTBNEPRBnnqN+OImNHFtw2Imib6YH9ERSKUcP cmUpe09A==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uAVQk-00000000oH8-33tB; Thu, 01 May 2025 15:02:30 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 1B7DC30072F; Thu, 1 May 2025 17:02:30 +0200 (CEST) Date: Thu, 1 May 2025 17:02:29 +0200 From: Peter Zijlstra To: Brendan Jackman Cc: Christoph Hellwig , chenlinxuan@uniontech.com, Keith Busch , Jens Axboe , Sagi Grimberg , Andrew Morton , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Peter Huewe , Jarkko Sakkinen , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Dmitry Vyukov , Andrey Konovalov , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, Winston Wen , kasan-dev@googlegroups.com, xen-devel@lists.xenproject.org, Changbin Du , Linus Torvalds Subject: Re: [PATCH RFC v3 0/8] kernel-hacking: introduce CONFIG_NO_AUTO_INLINE Message-ID: <20250501150229.GU4439@noisy.programming.kicks-ass.net> References: <20250429-noautoinline-v3-0-4c49f28ea5b5@uniontech.com> <20250429123504.GA13093@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7A15F40009 X-Rspam-User: X-Stat-Signature: i4aak18ma44waijmynz8zoaj6ppngx4p X-HE-Tag: 1746111785-364825 X-HE-Meta: U2FsdGVkX19BNDSF1Y/kMVscImka/wXOdBuN6dGoxNpk6pZD/HBP12E69uk5gbznY1ELPROQkP1Us4WiMyKLQ8BO5hCIa9e81J0ikHqlZ7JiGJOV6mHj+CWrDG2+8H+wjHqeE9sNZwYQoYHbwS6jHUDOw1gmEaEMdreo05atPoB7autDSX84Eu8OBRh8o5ZNj1kT/xBE7TZsoq9ccwv2Br1tn55vaUs6a8ysngFoWrLDlHSesvhZ9cy4jNcQFDvpig+VCMD/ERWxLKw09v67+TnL0sSqxwD/FBqJI2slU9Zv/E8iaBocLyEkfbdJnQpPKCQYDRVuE4TYtrP6megGFqralqhEA/rG5Y1RRPYO02fmepaE4T39PrLSOWqGZmpju/locYYYt5N6LW5Sl8odV30+Y0L0N1gFXkJ2CBnnPfs6SM9aMODd9NwXBMBh4q1mp9iOJSmAUVjXyNAUaKxQ+SBwTV58sBQtMmor0FHQlXB96S/DNMc44x6zs0A69y6eWPVBNsdFNR9DW4AUt5Ra3aSLR9MZRlDfZFIdqIxZY60cvWqnk+xkRf6VnhU0rb+7P6R3Lj6Go62t7g7yOfH6X2Uiz9jlPNU9vkbpLCqkG3cbSahxb2MnUAC+HdJim9ObV484rG+/V3Q+eUMfnjMZbWldS/3i7fklwkyokAlO8wd6V9+C71Pcvj44n1I1sV2bnEc7gyAReueiG2zwwlMgSUrubF0UflHwgBE4AXkPLvRr2QvRnYJQ4NKZfCWOsuNBbLtt3QhVBzU4dnu6WU6O5b5/obiylNc5a/r7/e2EerFvKMagsdIUrY5bWU4Q1mXRBYyYZSyG+j8COs49d6OOFdiwE54oSzu5PfvkMmRYHkXHl8ES5jMOYWc/ScVkFSTUmhHUTP6lHqW47V0nwKXWEJuwOo50eLUb9T/lnudTRLWgIM8M0nFkGRoIuJ8owYoxtIznvlqiBFCyS65UjyD J13S2KV9 fhf77xAEJ7wd9IF2Jh/giI9nNzpqUbV7Y9rFWULCaxOvk2SrI23ropZ7zSaY8+xgCj1BZ0DIXN5W00uMzpL+NgaCo0yKV426mjx7h9k9KNSsXmy1wdo2JwWZLEOdBrTUqYuJ8lVFDrY+VffzhzL+dV2TyLB9Tmb+uxvqdp+neJac9IE8iFpQLIVpaSp/JnNg/SPVxNekdqcp0SD8/nBdivom/ADMqJqliKhE+QpLg3/F3QQGvAymm0zIcmd6aclbVy+gTNbK2JQgVq6ERNcDL9Q0tLkm811XQS/Qjr9p6LsFy74kXp/jMcd3EHl/rHDgSEq7K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 02:19:47PM +0000, Brendan Jackman wrote: > On Tue Apr 29, 2025 at 12:35 PM UTC, Christoph Hellwig wrote: > > On Tue, Apr 29, 2025 at 12:06:04PM +0800, Chen Linxuan via B4 Relay wrote: > >> This series introduces a new kernel configuration option NO_AUTO_INLINE, > >> which can be used to disable the automatic inlining of functions. > >> > >> This will allow the function tracer to trace more functions > >> because it only traces functions that the compiler has not inlined. > > > > This still feels like a bad idea because it is extremely fragile. > > Can you elaborate on that - does it introduce new fragility? given it needs to sprinkle __always_inline around where it wasn't needed before, yeah. Also, why would you want this? function tracer is already too much output. Why would you want even more?