From: Peter Zijlstra <peterz@infradead.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: Christoph Hellwig <hch@lst.de>,
chenlinxuan@uniontech.com, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
Andrew Morton <akpm@linux-foundation.org>,
Yishai Hadas <yishaih@nvidia.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Kevin Tian <kevin.tian@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, kvm@vger.kernel.org,
virtualization@lists.linux.dev, linux-integrity@vger.kernel.org,
linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
Winston Wen <wentao@uniontech.com>,
kasan-dev@googlegroups.com, xen-devel@lists.xenproject.org,
Changbin Du <changbin.du@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH RFC v3 0/8] kernel-hacking: introduce CONFIG_NO_AUTO_INLINE
Date: Thu, 1 May 2025 17:02:29 +0200 [thread overview]
Message-ID: <20250501150229.GU4439@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <D9KW1QQR88EY.2TOSTVYZZH5KN@google.com>
On Thu, May 01, 2025 at 02:19:47PM +0000, Brendan Jackman wrote:
> On Tue Apr 29, 2025 at 12:35 PM UTC, Christoph Hellwig wrote:
> > On Tue, Apr 29, 2025 at 12:06:04PM +0800, Chen Linxuan via B4 Relay wrote:
> >> This series introduces a new kernel configuration option NO_AUTO_INLINE,
> >> which can be used to disable the automatic inlining of functions.
> >>
> >> This will allow the function tracer to trace more functions
> >> because it only traces functions that the compiler has not inlined.
> >
> > This still feels like a bad idea because it is extremely fragile.
>
> Can you elaborate on that - does it introduce new fragility?
given it needs to sprinkle __always_inline around where it wasn't needed
before, yeah.
Also, why would you want this? function tracer is already too much
output. Why would you want even more?
next prev parent reply other threads:[~2025-05-01 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 4:06 Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 1/8] nvme: add __always_inline for nvme_pci_npages_prp Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 2/8] mm: add __always_inline for page_contains_unaccepted Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 3/8] vfio/virtio: add __always_inline for virtiovf_get_device_config_size Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 4/8] tpm: add __always_inline for tpm_is_hwrng_enabled Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 5/8] rseq: add __always_inline for rseq_kernel_fields Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 6/8] kcov: add __always_inline for canonicalize_ip Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 7/8] x86/xen: add __init for xen_pgd_walk Chen Linxuan via B4 Relay
2025-04-29 4:06 ` [PATCH RFC v3 8/8] lib/Kconfig.debug: introduce CONFIG_NO_AUTO_INLINE Chen Linxuan via B4 Relay
2025-04-29 12:35 ` [PATCH RFC v3 0/8] kernel-hacking: " Christoph Hellwig
2025-05-01 14:19 ` Brendan Jackman
2025-05-01 15:02 ` Peter Zijlstra [this message]
2025-05-01 15:22 ` Brendan Jackman
2025-05-01 15:50 ` Peter Zijlstra
2025-05-03 19:13 ` Bart Van Assche
2025-05-06 2:40 ` Chen Linxuan
2025-05-06 2:30 ` Chen Linxuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501150229.GU4439@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=andreyknvl@gmail.com \
--cc=axboe@kernel.dk \
--cc=boqun.feng@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=changbin.du@intel.com \
--cc=chenlinxuan@uniontech.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=jackmanb@google.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=justinstitt@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kbusch@kernel.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=paulmck@kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sagi@grimberg.me \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux.dev \
--cc=wentao@uniontech.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yishaih@nvidia.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox