From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D449C369DC for ; Thu, 1 May 2025 12:46:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF04E6B0092; Thu, 1 May 2025 08:46:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA01D6B0093; Thu, 1 May 2025 08:46:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9904A6B0096; Thu, 1 May 2025 08:46:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 797716B0092 for ; Thu, 1 May 2025 08:46:52 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1E56114076A for ; Thu, 1 May 2025 12:46:54 +0000 (UTC) X-FDA: 83394313548.15.03E6AD4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 4975420009 for ; Thu, 1 May 2025 12:46:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="j/ailoTZ"; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746103612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MT3KCqHjly6/WkVzRYtUyUQ6kHv1G8+d/uDnpb9+Wlg=; b=GFBJszV2jetLg9zDRKgS2MAd4bFMKbGYZEr2eVlVJGv54+4cTD1Ea7mlAqXlyaUxBkX9P1 G75frizj+FTxslssVSau29wp3on8a+HCsROgZwxC7RX1FO86u3cRlFEeTVnFFPO6MzKEPA z1GDPiReu/gQMaGD0NuxgffGdr1tfiA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="j/ailoTZ"; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746103612; a=rsa-sha256; cv=none; b=IuiI2jA8Pj+xG801idk3Hm4sl0tt8KV1MfrouraoOsVC9BXYPg1kIUyyPI6kzj40nr3L1j KQ9ArirXHonTtGT2pwoeId4k/8mOmdan6HMIaQzmkK/b9OHMDHqsZ1bizLc4NDHZMyNhXE G5rcSKdDC6rXaxK2Ct2FPp2GaO/DZcQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MT3KCqHjly6/WkVzRYtUyUQ6kHv1G8+d/uDnpb9+Wlg=; b=j/ailoTZKXoaOPmmlFPl9MsAHX 5BfvpF7rqDdfdJugevO0RmalbtVN3LbzoZJDuMhHYIUL5GBPHa/45fnthYZ3G1iYo4Lp9g5Tll1QV IZWjYKVgb2nJy11r156J1w4KMzxpbxS6teghHN/7aWMVFUAvyRaMWkXdpYqr8b7ibLi0sFbImszXQ 7npg6eL8VRnWIqGdqLPUz+o4vQ80fPV6Aw1DKk/gPW3VWB8g54fzKPrvft5cp+jO1I0o0Y4vPRUzY bimGToFXaLY3sInkkKgAYGCRZLun+XgZoZ1/V6IzM7YOqBQnuI+m/uCmpz98Cz8V/j0HYTRKtaQSp Hz22RDpA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uATJP-00000000Euy-2n9s; Thu, 01 May 2025 12:46:47 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id DBB8830035E; Thu, 1 May 2025 14:46:46 +0200 (CEST) Date: Thu, 1 May 2025 14:46:46 +0200 From: Peter Zijlstra To: John Hubbard Cc: Lorenzo Stoakes , Shuah Khan , Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , seanjc@google.com Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* Message-ID: <20250501124646.GC4356@noisy.programming.kicks-ass.net> References: <5b0b8e1e-6f50-4e18-bf46-39b00376c26e@nvidia.com> <20250501114235.GP4198@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250501114235.GP4198@noisy.programming.kicks-ass.net> X-Stat-Signature: 8dtaz53y7r6nd6tsa4r1br46hdco3bk6 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4975420009 X-Rspam-User: X-HE-Tag: 1746103612-212199 X-HE-Meta: U2FsdGVkX18A+MU0bp39LMXlyYgdrTzhxUNNzF6PM4HnnBCOr7UtIKiYyC7C0jQuqZS5uoEqaJjVpMbYtmUw9ps6Q8sSbhlnkoxP8P6LK2eIUOlSH2uk7kGNwNa8ayXKE8sCAjKNSuC0QcFyrHv+bIhUqwMJBdgGuF1l75Oft2LVH+ZDjhUgSsPUceddBjyNxj093Y0/rKSJgMfR/xuAd8tB84wW4+RHgbUNsMRIFp1vzonT5DAcfvstElMYNcU+lN/70/5Lc/EMgihcOy4Sbtr9Hh7qOMJejS2+UIyunOfZVdzU0SsjXekg0ZhVAFRPUkcscGUo/kpgT4dIGjEBPL8F64iWHYN3TZX6awsvDakAerbb+eYcjOTv+/VUuZvWDMVg5bn6ymWSP95AhXkvuOPR4caJmsk+3aRkpcvyeRjKVKBz6CeskR2/Y4ag4UiAt2lPbxb5nDcS/JwkTLu/V0lEsgcRIk28oxQnVNx2zSgG+2E/+GPgGIvgbHINaXfRV6I8moVV0f3cyKqdEa1+u6I/jRcCZaZ3PhPnkfAbltLqUj1sKD+KYoKlKhsQdhn4re6z92PHbxzYzph073nfyQbLGAvINN77YPDIqQNoYzrCCwZEx1FIObkvPvl36S+uJb+sqnwoR47ZIFN+L1kzM8ndGn/gau01emUjHwcEp3ENyrZnKN8RUYtOlGfa2MVHEfW8D6xtpx6gNfbBfrbfvpRk/cSzvuz4dJGvHxdxwxf0jDYyFHxKMCrLGD3Qt8QYq0sVYSQk1XQsvb7bvk6+ESPZJuqQ+QlVsSA+g0gzYXQ66S7JjEZVR5059sjUtQstEO0QaR26W5C48XQhfhGsn1ZfHDFuhcy78yFpY7Nip2C5MIhaj44zohqROJ5zePRs/9+Bv1qt54sRjcBYqurzeUiLF495melpx9CfppMGB0X2ziRW0iGRdZRJm5YQ78ex/mIvmfHQEslxpP5jP0d GcVgTgmm bao9SQ8mPPwpLJd6jhxZf8uXHpv8mN+iFmRas2BJQSaynIuuULGJvQ/V1+H502J7ahqpU29dIgU7j9PSCZTXxki2OWwMGo2QgU52ccK1YBYbkOs16wJag+4+arElMcYU2Up/XMm+J8FgkHhYaXsx+eC36qzKOdg6WRV0vLsQzt9tg0/MQ5dD43ck9cjt9VoqwbPRdpZZjSYfWYM9FkO1XCQn4hendAwMxvZtRg+BnDvu8xQUJKRynRHJ/a6viXxCwSoyh4OauaL0EPcEhn0AWmGicW4nWNhO31OumMoPhSudtGIUuZ4UHlhj/Ow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 01:42:35PM +0200, Peter Zijlstra wrote: > On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: > > On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: > > > On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: > > > > On 10/16/24 04:20, Lorenzo Stoakes wrote: > > ... > > > > > diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h > > > > > index 88d6830ee004..1640b711889b 100644 > > > > > --- a/tools/testing/selftests/pidfd/pidfd.h > > > > > +++ b/tools/testing/selftests/pidfd/pidfd.h > > > > > @@ -50,6 +50,14 @@ > > > > > #define PIDFD_NONBLOCK O_NONBLOCK > > > > > #endif > > > > > +/* System header file may not have this available. */ > > > > > +#ifndef PIDFD_SELF_THREAD > > > > > +#define PIDFD_SELF_THREAD -100 > > > > > +#endif > > > > > +#ifndef PIDFD_SELF_THREAD_GROUP > > > > > +#define PIDFD_SELF_THREAD_GROUP -200 > > > > > +#endif > > > > > + > > > > > > > > As mentioned in my response to v1 patch: > > > > > > > > kselftest has dependency on "make headers" and tests include > > > > headers from linux/ directory > > > > > > Right but that assumes you install the kernel headers on the build system, > > > which is quite a painful thing to have to do when you are quickly iterating > > > on a qemu setup. > > > > > > This is a use case I use all the time so not at all theoretical. > > > > > > > This is turning out to be a fairly typical reaction from kernel > > developers, when presented with the "you must first run make headers" > > requirement for kselftests. > > > > Peter Zijlstra's "NAK NAK NAK" response [1] last year was the most > > colorful, so I'll helpfully cite it here. :) > > Let me re-try this. > > This is driving me insane. I've spend the past _TWO_ days trying to > build KVM selftests and I'm still failing. > > This is absolute atrocious crap and is costing me valuable time. > > Please fix this fucking selftests shit to just build. This is unusable > garbage. So after spending more time trying to remember how to debug Makefiles (I hate my life), I found that not only do I need this headers shit, the kvm selftests Makefile is actively broken if you use: make O=foo -INSTALL_HDR_PATH = $(top_srcdir)/usr +INSTALL_HDR_PATH = $(top_srcdir)/$(O)/usr And then finally, I can do: make O=foo headers_install make O=foo -C tools/testing/selftests/kvm/ So yeah, thank you very much for wasting my time *AGAIN*. Seriously, I want to be able to do: cd tools/testing/selftests/foo; make and have it just work. I would strongly suggest every subsystem to reclaim their selftests and make it so again. And on that, let me go merge the fixes I need to have x86 and futex build without this headers shit.