From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52537C369DC for ; Thu, 1 May 2025 11:42:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA0BA6B0082; Thu, 1 May 2025 07:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C50D66B0088; Thu, 1 May 2025 07:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B18FC6B008A; Thu, 1 May 2025 07:42:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 943C76B0082 for ; Thu, 1 May 2025 07:42:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C26FC120674 for ; Thu, 1 May 2025 11:42:44 +0000 (UTC) X-FDA: 83394151848.16.6C82E3C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 1F86A14000E for ; Thu, 1 May 2025 11:42:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Yk3be88r; dmarc=none; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746099763; a=rsa-sha256; cv=none; b=GRIi7/iSsksCYynkvi4hEhNd8We/OxRh2gg7r/gOj1OPDDk7sQvEduwJCD1q75fEif3QMu nwMKgiGnuMj+F3YmzmzzgshVIzfXGy8kXi84hb1pqAAvq72TxFgSQIz0GZYaZKWSuhtl64 1cveDyUMSAZXSCMOXjfE2B24+KsD7JA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Yk3be88r; dmarc=none; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746099763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iqBDQiUTHDotW7wVOgOpaA+Ei6LCT/MLR0aCdooTSVE=; b=tgjSxFZKgrMkhDhkAe5zLbrO35OXwQoIPHkDGPlKuVXstn6mZJva7lr9HHIH9IVTv+IOuV R8DFjKydqlLYQ75nfnXK5OK2DqFK3iJUk2MIV83aFH69HUnYVd8QUdZxw9qnmLiTfG9gke wGgJ2hLw+EXr+TD8y4KRjogYG9MMcdQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iqBDQiUTHDotW7wVOgOpaA+Ei6LCT/MLR0aCdooTSVE=; b=Yk3be88rXMdkvtvYTEFgEsVg2U KX31JyfrrdYikKuRl0b+5OWvgTVHG+ONcKzs4Cu2aDHMRvNUG6GscQblkqt3JodaSIiqg3MF7nkFk TI0lQdOU1kLghLWMKMYIhBS9U8lkQMS4Vc7JNDw0DdyNoNJPcyOwXaXRuycOSL+0u/pmtnHJyK4V0 6CjGpPmp8zdboJ0LsZK85RgAsKHKglwTe5kcV1FAWxhIODOZlbu8rlAiC2fd5QiJmlVs4lq9rOQW+ B0SKLVu+W70dG8Sfj/8Dp69wXViD1RIz/4yHDFrMCERk2IpVmVfwbiR0F6ln0nG2Rv+P8IOZl0Dzi p3Nzjbjw==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1uASJH-000000003XF-3tOB; Thu, 01 May 2025 11:42:36 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 3944D300230; Thu, 1 May 2025 13:42:35 +0200 (CEST) Date: Thu, 1 May 2025 13:42:35 +0200 From: Peter Zijlstra To: John Hubbard Cc: Lorenzo Stoakes , Shuah Khan , Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , seanjc@google.com Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* Message-ID: <20250501114235.GP4198@noisy.programming.kicks-ass.net> References: <5b0b8e1e-6f50-4e18-bf46-39b00376c26e@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b0b8e1e-6f50-4e18-bf46-39b00376c26e@nvidia.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1F86A14000E X-Stat-Signature: am9gsurjq7mqdrnnyxn58ajiuk9zqzn5 X-Rspam-User: X-HE-Tag: 1746099760-927906 X-HE-Meta: U2FsdGVkX1+VsM1FQemACAatBK5VfcAsDKpbQ+WKZhBJVqWz7YQTRCqryY7QFyrnRv3NsX5HfwJupL0hG4OC8yF5ZDZqCe5bu0dIB6uQwKbU72AxsetjCjNy/5vNXL0qvQLzHKyDDX0GY0zX+5XCxrsMhBRJ6LyBrDmj5GsX/lkTVZGkCE+V986H1bhYmVR5QQbDTBeafeg5300/Jku7YupCxD7T2TSXP9cE3gzHZUSrafdH97LCxNetpGsr8HAdDDwfpfL+3utwcAXhih6iSwBPRnJ05jjnSey9PDuukjhR2e4VZ9l3RImD2sMKpUecmKuo0Z34H3tif5p6nas0aLh8If9/J2ty7Ewr5uDKIfNE6QoLBiSMjrh+viunrbRnEfdKrqiO5KKAZmLnJpeyMrKhwKe2cfjJq69tBlrqjXWClOlVBQf0lz9IhhSToSYMFpPHoycG8S/YVYU/1kPM70fMomh7+wmVQ/DHNCSfAHQ6l/iJIpxntteK3Pda1XCgHS3f4qKx6cmqyu1BMSyFQq/QLG+yAzNhc7YDr2U1BtG75RJELSDp5ciE1nzuUNEN1clpm1OU06mII7YeMZQRfh++eqX5CavY2x6OiWJN2qCXsEU1zT7oS+KxyHg3EDu7LeMLq/lVSCf7V/vj+EHHGNR9BPObdpDpIrH0rYweSGxVxJbut6onpXAR/lXtGdlnMu34WmntGxbxrVQc/NOQLIvOWH2l+I/rAr6mrlc1649o5IAzgH3Izi8hlY1zPR+jP9n1JBrAtkQL7AaNGEem+ljKHWKRtVaSAevBCnuwnFqVD5/w/tEz0Z9NefimLtjDUwXcAEm9VUkhj8muQWUOOQKQvMTIhB9ZdNqF5E3ebQUJlhOC7XDpq7Mv3/xPEXjj+r8zjjlSRFhGm6UmPHaI7PB7gEq70oRaVWYhbtpBnloY+RVkqF4aEQ309btEibMnBzZ0OLH0BFEEmWEGMs6 zoQQ5GqM ifLMf1/WOvTEVD48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: > On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: > > On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: > > > On 10/16/24 04:20, Lorenzo Stoakes wrote: > ... > > > > diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h > > > > index 88d6830ee004..1640b711889b 100644 > > > > --- a/tools/testing/selftests/pidfd/pidfd.h > > > > +++ b/tools/testing/selftests/pidfd/pidfd.h > > > > @@ -50,6 +50,14 @@ > > > > #define PIDFD_NONBLOCK O_NONBLOCK > > > > #endif > > > > +/* System header file may not have this available. */ > > > > +#ifndef PIDFD_SELF_THREAD > > > > +#define PIDFD_SELF_THREAD -100 > > > > +#endif > > > > +#ifndef PIDFD_SELF_THREAD_GROUP > > > > +#define PIDFD_SELF_THREAD_GROUP -200 > > > > +#endif > > > > + > > > > > > As mentioned in my response to v1 patch: > > > > > > kselftest has dependency on "make headers" and tests include > > > headers from linux/ directory > > > > Right but that assumes you install the kernel headers on the build system, > > which is quite a painful thing to have to do when you are quickly iterating > > on a qemu setup. > > > > This is a use case I use all the time so not at all theoretical. > > > > This is turning out to be a fairly typical reaction from kernel > developers, when presented with the "you must first run make headers" > requirement for kselftests. > > Peter Zijlstra's "NAK NAK NAK" response [1] last year was the most > colorful, so I'll helpfully cite it here. :) Let me re-try this. This is driving me insane. I've spend the past _TWO_ days trying to build KVM selftests and I'm still failing. This is absolute atrocious crap and is costing me valuable time. Please fix this fucking selftests shit to just build. This is unusable garbage.