From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35BBEC369DC for ; Thu, 1 May 2025 08:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCC256B0088; Thu, 1 May 2025 04:50:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C57006B0089; Thu, 1 May 2025 04:50:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF7106B008A; Thu, 1 May 2025 04:50:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8DE506B0088 for ; Thu, 1 May 2025 04:50:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BAAC5C241A for ; Thu, 1 May 2025 08:50:23 +0000 (UTC) X-FDA: 83393717526.02.DE4B94A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 5BDDD40003 for ; Thu, 1 May 2025 08:50:21 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p6orWX5I; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QntaoXpy; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p6orWX5I; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QntaoXpy; dmarc=none; spf=pass (imf12.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746089421; a=rsa-sha256; cv=none; b=yISC6XnpJBDwRqsAa3rC0scx/oWq3D/tRS8YBQs9tLLSiGyDnXgS7kDFO/KW4jU9vuM+Ht OnNeTvdtIblDk0uC3HGwW3YblY9bX+ZjTOrgmCmTv7qDYhZV1EW0zru+82dIMTJxYw+kyM H8gXbURo5DdO/6QRDDZayCzSI5fNAUc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p6orWX5I; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QntaoXpy; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=p6orWX5I; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QntaoXpy; dmarc=none; spf=pass (imf12.hostedemail.com: domain of dsterba@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746089421; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r5zIrmd5W9mcaRLQuezc6RZmJaUSbNbg4XZp0yaIFm4=; b=WXtzk9KDdtxOXgGyqqYwdelfyVEI4ZoTnJDihEjmV/8OvTNOGrqYGGPnLb90g01F8s2l9B yl4KwGju/Sc+fGLhUS+zNBoS3i/V61kyYCj+mdwg6ZQh2TYfY0DEjpjxR56zwr/DNJ/My4 SXF0WL+4WI50f7zyTVswbmHYDH0d1Mg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5B8211F388; Thu, 1 May 2025 08:50:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746089419; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5zIrmd5W9mcaRLQuezc6RZmJaUSbNbg4XZp0yaIFm4=; b=p6orWX5IrPomBFqQP3tyGwqXRDqAHdN89S6uPu8QinFYCTWfZ3k0WJ3hg2EWriU0LzHPDO 8KHynGzipMcBSDv6J85bnfUuw72WBWZTZcmZA8l6jMTj7N1gK04+iKXURnhZgIsmNZhsde Ir80m3EhBSd+DzVbsYbn43oop7VBnHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746089419; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5zIrmd5W9mcaRLQuezc6RZmJaUSbNbg4XZp0yaIFm4=; b=QntaoXpyGckBRK9h3U6A7HPb9az9ovf0QpcDepuVPTnft6nHBf2tYH06Bz4mYt/fVf+zBc rnj8BaZ3oC4sWxAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746089419; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5zIrmd5W9mcaRLQuezc6RZmJaUSbNbg4XZp0yaIFm4=; b=p6orWX5IrPomBFqQP3tyGwqXRDqAHdN89S6uPu8QinFYCTWfZ3k0WJ3hg2EWriU0LzHPDO 8KHynGzipMcBSDv6J85bnfUuw72WBWZTZcmZA8l6jMTj7N1gK04+iKXURnhZgIsmNZhsde Ir80m3EhBSd+DzVbsYbn43oop7VBnHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746089419; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5zIrmd5W9mcaRLQuezc6RZmJaUSbNbg4XZp0yaIFm4=; b=QntaoXpyGckBRK9h3U6A7HPb9az9ovf0QpcDepuVPTnft6nHBf2tYH06Bz4mYt/fVf+zBc rnj8BaZ3oC4sWxAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3403213931; Thu, 1 May 2025 08:50:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kWQwDMs1E2h8DwAAD6G6ig (envelope-from ); Thu, 01 May 2025 08:50:19 +0000 Date: Thu, 1 May 2025 10:50:13 +0200 From: David Sterba To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , David Hildenbrand , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Qu Wenruo Subject: Re: [PATCH v3 2/6] btrfs: drop usage of folio_index Message-ID: <20250501085013.GL9140@suse.cz> Reply-To: dsterba@suse.cz References: <20250430181052.55698-1-ryncsn@gmail.com> <20250430181052.55698-3-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250430181052.55698-3-ryncsn@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Rspamd-Action: no action X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5BDDD40003 X-Stat-Signature: tcsmq8h64j4he8qgkxb965ta17qcx7zp X-Rspam-User: X-HE-Tag: 1746089421-296073 X-HE-Meta: U2FsdGVkX1+J51819kjYBwpMJks1pvHIl8vfrHXRwzaRseUXY5qiQQw1tXOmfxnoLMKIp7CUKUr+EGFAeUbthN7RtQCpKTxouHAWDpMP7gdSSKd2EvC5C5WC4canPxnz5sWq8wMCsE+AhEBGe/3wpP2CR0f65AZiF6YpFhul/C60tpZAMfyZyo75VPhUmRGq1IOrmhhEtp9K/35Q3N3f+Spib+FHSO5jME0WUdnndrJuXfB1R5AMz+43VgQMeTj4S22IVqYmFiMZVwX7eGyoPSKu7Uar3IMlxvfZDr3r0ximmYb2I6K1xgDnBU1BLMMAdcWs5W4d8LHNewhf5nkgMrVOKhixIOZNRo6ttsTm/yOFbuxdH8MDsoqlZiyE3ucj2Slb1anDNe/vBdLxy0WpTWCO5xWNZDuNVt+N/ETXqzJ6XeqrkwJ3tLrwwhRqn9s+3W+2rYcou7EsQ3CnWKY3avUbQ/O6xvLoWuomLiWObChpLcb+Rtfu855Jp5daS/kfahA+s2t5RYzcklY6RsWogytvsGdkj/dvEv+FqcGcTVQJaBD4eD3TnFCTSEeQ/pJYZF5TnmPRcwKtEZCmOJrl+PjihfSCwzI9BCrp3VjFKTujdhWSW3OVkRejcpTQr2v1sCnG32DC6738sQ7EfppiwU5i8+3EZOLr+WshYwHGF6uuOSunP1S0Wm2OjxuTzmvr3ZeQNygSrQDah57SWsDhemSMcv9uhrFABkI8VtUQih9J+IGEpV/rbAvL0QZ/goCTTzuzfWbdGmEBcJeNfQf9JMAkH51KwArtOfcBxGtrYtD1yvR6/97caREk5yhxI9tEc3JwOBq4txE0pxUsFwuZcsrLNiWNny2KXdNsPnqofBmqqm5qNogbqgyHy7q/jy4NjP5bCm+7takxmb7b2QlOBLSLWgKSi4Qs3Zy0sGAxeADbD4GridjZx41rYGybo4bNfjOcfmBPLtTPtcmR2fz o/1n/O0y crsLiU82q8et/XuRWzGyTOUY9lKjyVUhXl7moKpR138P4arQY1H3kGGpnAZ1jdEKhPvprwlGmIc4yGXADrxuWWG+HbblKDWF/tDBLjurMRVMTaWF8LvrNkYStV+BqOdUKFiyVkqs2edVH7MH066InLbVsWWmIdv+uuE0lwSsSQWgeH1yfAUDZ4NB7YYmlxJGng/cdc3ye663GfS4xokNC/m4OLOq/Tph+/e0vDtHuZ5nyAcKOd9sKyZj3BFX56JS1JtrC1eZQ+YDPRHpIb9YLeAVzNxL+Ahc/kFGoNFpHTf+XfVzXHtuNbYQaBhmZD9reLa708wWJOgXseiwysc3c1MPLnd3wuHvN2W1t51le6NDBjwP4NEDs7ncLJ/EmheCblI6TQBfb03Crq5MGOiewJb+9hv8ZP0M0auhYZ/Pl5h7I8j343LZtmbf6CWXYPFkG/K+WtAvFEOdFh1SYG86BINmRaBCNcXb1y1XmcsyzK4Y9+bBdwd23w2SR9uWCcT9DvEejnyfukDilgbaAzuLCA34t5JnNVIGHNK0qK9ZoBOp1EQRZnqu9MOsmhvqn/VDva2eNKGq/hu7Bj6WUvPbaWG16Jef+NDUUjYZYjp87LvId6X2y5eguVBr2e41jk5KDf8Nj7MX6VTAR5Tgl6Q38hbp/c71k43IL0pgUGResr4XRaYPr8e+P/gCAog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 01, 2025 at 02:10:48AM +0800, Kairui Song wrote: > From: Kairui Song > > folio_index is only needed for mixed usage of page cache and swap > cache, for pure page cache usage, the caller can just use > folio->index instead. > > It can't be a swap cache folio here. Swap mapping may only call into fs > through `swap_rw` but btrfs does not use that method for swap. > > Signed-off-by: Kairui Song > Cc: Chris Mason (maintainer:BTRFS FILE SYSTEM) > Cc: Josef Bacik (maintainer:BTRFS FILE SYSTEM) > Cc: David Sterba (maintainer:BTRFS FILE SYSTEM) > Cc: linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM) > Reviewed-by: Matthew Wilcox (Oracle) > Reviewed-by: Qu Wenruo The patch is from a series but seems to be independent. I'd like to take it through the btrfs tree unless you have other work that depends on it.