From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669D4C3ABA3 for ; Thu, 1 May 2025 04:13:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0CAF6B008C; Thu, 1 May 2025 00:13:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B9B66B0092; Thu, 1 May 2025 00:13:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 882696B0093; Thu, 1 May 2025 00:13:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6B86E6B008C for ; Thu, 1 May 2025 00:13:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 34CBC161997 for ; Thu, 1 May 2025 04:13:58 +0000 (UTC) X-FDA: 83393020956.08.76E6C8C Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf28.hostedemail.com (Postfix) with ESMTP id 39ED4C0004 for ; Thu, 1 May 2025 04:13:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XYnglkaE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.214.194 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746072836; a=rsa-sha256; cv=none; b=VwNP6c+wkILPrDKka4RxPf2xIksbgbVKNXGYEeY0hYGYqXXjXEOx0fWSgTuuod8Qs4I3xT ELlg5/GOnvkd0EhVgmhOb0AEAauSbwIpoSiFQ+CMQCg3Rv03nfC2j2UYmv9N4K8FKnn9Zg cdSlkYwO1650Aef/v4ZGKrsCeXv5WpQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XYnglkaE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of xu.xin.sc@gmail.com designates 209.85.214.194 as permitted sender) smtp.mailfrom=xu.xin.sc@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746072836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CIk5P/ejsLPrdbPMn0Ve6H4xUkHSSg3SisVuP8kmDBA=; b=xJjGuWoyqNHHrCgGD+vnpwRw1q5Ha09NPXvXnOZmXYFASP3D4FNKVjFKvPTv6tgu9n3R3V /0DigD0bgLssEhCAq9KURXHSAOVr7oPyPeo3ZFJ2znrQEYl2SzDIot1sx/BTmFokwKa0cw g12Ma/wiILRs6X7iCBuHl/JwstjPkc8= Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2295d78b45cso8391695ad.0 for ; Wed, 30 Apr 2025 21:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746072835; x=1746677635; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CIk5P/ejsLPrdbPMn0Ve6H4xUkHSSg3SisVuP8kmDBA=; b=XYnglkaEkwNXibsqLNmU1sEasq73NqH2iM5p72DTtgKrekbWWRWknRw9TImsNVlxiC UyjxKZwFA6eaADUe4uKMZtyWaXvnaV1ngametnggYsIEK2lfqsKQQFxu5h8BNdpet+RR e2X4u3KFmPKaMXlNa2P3qtdfLDmZxvh4xavQYUVHg43mY+J5t0vyVjwAl3eIEHWfcCcc Jx06lxif9FY6FtXXXTw8/FRg1JTbRyFUvqtbPKAJ6X09yTqvogmHoH468fzyXjMGlN2i ZVFIE/JeYh7bnUeR3yKw9sB1t/Qj8Xp5SEeF06Hk+NG93vbxAlnymvwV7DAtXzez/q6N KOOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746072835; x=1746677635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CIk5P/ejsLPrdbPMn0Ve6H4xUkHSSg3SisVuP8kmDBA=; b=Bo7CBxK6LE7vjBlxy1uI4vrRLXaxUeCEuH9QW6LmqVrDYWe1B2/oWjFXWteV0D9UAr LxJTsUKe4LHDwwL95GktlanPllGvkDUpzT0HhZKZmaiB3Te9l/rpaJKTbTz994aclt3a z9/eKkaLJjwmvRlEe9EIov5ou+0k98vVaKXy1wPHlA63bjAFvi3UyC58kPlP6x2jg93x tI5/heNe4FhMCifBowqiowWDBC+1nkx+qGQFuSDAI0KwVRMLEzIU5HaboqGvFy8piQ5Q GOhlnbssJWpPEXN49t43LO5GIQ5XprZ6CXm7bap2FGAG4u0ArVM9q0FSpIjXlVBsoIdX Py5A== X-Forwarded-Encrypted: i=1; AJvYcCX8e3vNwErtoNOMVFU5a5zVLxc7QlJ2mZmbmOGqKnOeXFiCkJ1e+BPIGTOPkpdsWAToG0iwF4YY3Q==@kvack.org X-Gm-Message-State: AOJu0YycblZsqBbC+B+fHDvZVQnJ4qu70MVrlGWKPEiY02Z6cgnxPvTS hi4IvlzscyNWdjUd6SF2PEVoxv5Q1jzrOmWHluys5ub81tuJoZys X-Gm-Gg: ASbGncvYXznYt3+HGQg42pvQew/koE503cL7AnTXFct0qBLCUDQTXS60Mg1XqwLf+8W 9XZRSgpjVLzyMmF7csc0hV+98dhZdawbwXLV/6qYVl9Cp2KKhFUxvlcoqwtITl8i8iuXgeojWdp A3JB7MkNZFuoWAO+UMjoZ/JaVxP2+pn2fLEt2GkijyCReU6hJitVs93FJdFq57WITT84nRgTjU9 TwFvV9LyWdjkLK4EcwDCAXQ6Vzvz0RHOX3i6o9eTHoSkBMjz4QodJGSbrd1v3InjA+tRehE57ca OI1ROnGquXQn9I5lL0wF9ue0MsU9lhZdWvSo7Gb1xWSjQKA4r/tjtw== X-Google-Smtp-Source: AGHT+IFSpSg6g2ApNTApEGIeTJvR6iuG7EXlp92mzkJ/HA1tiLw70I+wddiypjYWmIRDhTC+3u9n2Q== X-Received: by 2002:a17:902:ec8e:b0:224:1781:a947 with SMTP id d9443c01a7336-22df578bce0mr78813545ad.21.1746072834969; Wed, 30 Apr 2025 21:13:54 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbdce2sm131036025ad.85.2025.04.30.21.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 21:13:54 -0700 (PDT) From: xu.xin.sc@gmail.com X-Google-Original-From: xu.xin16@zte.com.cn To: xu.xin16@zte.com.cn Cc: akpm@linux-foundation.org, david@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, wang.yaxin@zte.com.cn, yang.yang29@zte.com.cn Subject: [PATCH v2 2/9] memcontrol: introduce the new mem_cgroup_scan_tasks() Date: Thu, 1 May 2025 04:13:50 +0000 Message-Id: <20250501041350.3324212-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250501120854885LyBCW0syCGojqnJ8crLVl@zte.com.cn> References: <20250501120854885LyBCW0syCGojqnJ8crLVl@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 39ED4C0004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: khtzgnpotpt7hirw7w1opm6xjcwd456a X-HE-Tag: 1746072835-778464 X-HE-Meta: U2FsdGVkX18/veO1smOAJovpav6HUXKebplhwOYOlB+Jt+bzg6wEJWutiFQ9SmfhSmYqJ/4jFiUydQ5B2utu0YqgdKirma2bzUu7JiFzEQVcK8J8+xGDOAoWv6/xGmq/uINxls3MaQTz1F4ql/HpVji7N1a32iDPqi7a5h53/s/rUGI6B645m9QTPoC4ACmDlQQF7Ro1uZ6sIRWdvvkbgs5Ruq5GALzywnRBO6PLs0epZgfdX9LHqnT21D9XuGIPxXMBnJ7gg2k1jrglLbZ8MDKm3fHwcyXowJp4WfcpSv0TCjNFR/nmG9wFSZDnjxTDv3Aj+0MaA7nh29HcAeFLoPrr3c2Va7JPfIjGJaIFAUSSvsV1uZX4ZxMXKG5gfD34Nj+yi2evLP+rXaCXF9hDfmeEK8Rsa6zEhEn65/Lg54plcsO8K99u4GLqAju9x+t3Pr/83k5F/FKo4Etf8nMhWOLZFbmTvR/etXJ+SiXEKzEIJpfB28Mw7uFloYPJIlAJSFJ+0T2baBzoaLpIe4hY/vOkJVnup0TdW7kZ9X9sTKxEltElCpPusW8eBib4KSGsKnP5Qns2SBqUoVlfh9Wmr0ZPmOH+JXEtWlXr1Cj+tYp1fgJ2ABO0grnHMIWHi3BLriRpqlh25KjlP6ZUSStDTnihmyQDwkGU4hjF5HXYvlyqsHSKZR9+4MZxxiUGISqLfzCsDs77Cc2DTL1h2fDF5qBQRB52qzozJYzFWudZOsiTnKsC+hZxWaLsOspNeBAqirNMb3+2BSzqW9VU6ZyiJTW8gKY/vgpiBmyoyGF6eGSH6YG/+L308wB5/ijLhNMg2IfW3Bim/LRqgpWvuBYhYJqvba+/e/yWnd95Md0+DZypFtuPuIPkPwYkuWAfuzClfXEceVTOJHyl8N3cm6tz9XIdCZWA4sDX8CB8rtVckkX+sGwdIn8oTXY11+1uTY2ubl2SRxk416sokPRi4ql /UEnFMjL RwhhKM1X/AyzXr+by1QrD0M63vSQf+DCJ2ZXvfkx+jdKmGcp7Br465wVZb+C4Dz+N9akPNpwq0aXjmynyl+0+Fxust4dH3WHPJqNzu45tPJKabTFOVMHmSLtko4XCPI+W4G/mwBwM0e3I+exAsR1gIz06gTdWOku9+28Yi7tPfE5WFFR94fTa2nYuNwFiT3Zak0gfMx5t/zNvOySZzcTP+F3lgHAt5ympNBBw8N4mQoo7nHhPQ1hqoZfn7M7a6yZaVLq12+SQl5iQzRBoHbtvcxZQNNoofUyHU20t+t4CIrHypnRnSnZHBnugDKrWDQ6zQw4oKkcxyfwk/VSxOxZz9kIml9m7zqqpd9JyhwlvvmRtEm7/LSugWyq5cwMjhsyFr4nRyknjiC1ZDeekKrGUWCeh4XXgoQ/azlixUyKm2i+Muix58rg/UOVkY2c0FlCI8ZIyTbCvYU8NE6EFkXdVt2Zq/nHR4lEBk9erjG7vFTfTL5fBH3cyazbFhHl9HwSMY3KaZx4toF2AQAKmDHu8u/R/kQyoxCzBO0oM4N8lCiCGfQbvB7pWmHXBXTETy+wzCht30wBhB/JaH9kvpZkWhayxy4T+86X0KlH+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: xu xin Introduce a new mem_cgroup_scan_tasks function that strictly iterates processes only within the current memcgroup, aligning its behavior with its name. Signed-off-by: xu xin --- include/linux/memcontrol.h | 7 +++++++ mm/memcontrol.c | 24 ++++++++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 1c1ce25fae4c..f9d663a7ccde 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -795,6 +795,8 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *, struct mem_cgroup *, struct mem_cgroup_reclaim_cookie *); void mem_cgroup_iter_break(struct mem_cgroup *, struct mem_cgroup *); +void mem_cgroup_scan_tasks(struct mem_cgroup *memcg, + int (*)(struct task_struct *, void *), void *arg); void mem_cgroup_tree_scan_tasks(struct mem_cgroup *memcg, int (*)(struct task_struct *, void *), void *arg); @@ -1289,6 +1291,11 @@ static inline void mem_cgroup_iter_break(struct mem_cgroup *root, { } +static inline void mem_cgroup_scan_tasks(struct mem_cgroup *memcg, + int (*fn)(struct task_struct *, void *), void *arg) +{ +} + static inline void mem_cgroup_tree_scan_tasks(struct mem_cgroup *memcg, int (*fn)(struct task_struct *, void *), void *arg) { diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 3baf0a4e0674..629e2ce2d830 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1163,6 +1163,30 @@ static void invalidate_reclaim_iterators(struct mem_cgroup *dead_memcg) dead_memcg); } +/* * + * mem_cgroup_scan_tasks - iterate over tasks of only this memory cgroup. + * @memcg: the specified memory cgroup. + * @fn: function to call for each task + * @arg: argument passed to @fn + * + * Unlike mem_cgroup_tree_scan_tasks(), this function only iterate over + * these tasks attached to @memcg, not including any of its descendants + * memcg. And this could be called for the root memory cgroup. + */ +void mem_cgroup_scan_tasks(struct mem_cgroup *memcg, + int (*fn)(struct task_struct *, void *), void *arg) +{ + int ret = 0; + struct css_task_iter it; + struct task_struct *task; + + css_task_iter_start(&memcg->css, CSS_TASK_ITER_PROCS, &it); + while (!ret && (task = css_task_iter_next(&it))) + ret = fn(task, arg); + + css_task_iter_end(&it); +} + /** * mem_cgroup_tree_scan_tasks - iterate over tasks of a memory cgroup hierarchy * @memcg: hierarchy root -- 2.15.2