From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jann Horn <jannh@google.com>,
Pedro Falcato <pfalcato@suse.de>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <willy@infradead.org>
Subject: [RFC PATCH 2/3] mm: secretmem: convert to .mmap_proto() hook
Date: Wed, 30 Apr 2025 20:59:36 +0100 [thread overview]
Message-ID: <7bd9f0abd33677faa7d9aaeabede8d310f361a16.1746040540.git.lorenzo.stoakes@oracle.com> (raw)
Message-ID: <20250430195936.tG9GwxFgQ4MqT1aegROFedhhl8F3GLbgDGeJz7oYmEo@z> (raw)
In-Reply-To: <cover.1746040540.git.lorenzo.stoakes@oracle.com>
Secretmem has a simple .mmap() hook which is easily converted to the new
.mmap_proto() callback.
In addition, importantly, it's a rare instance of a mergeable VMA mapping
which adjusts parameters which affect merge compatibility. By using the
.mmap_proto() callback there's no longer any need to retry the merge later
as we can simply set the correct flags from the start.
Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
mm/secretmem.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/mm/secretmem.c b/mm/secretmem.c
index 1b0a214ee558..64fc0890a28b 100644
--- a/mm/secretmem.c
+++ b/mm/secretmem.c
@@ -120,18 +120,18 @@ static int secretmem_release(struct inode *inode, struct file *file)
return 0;
}
-static int secretmem_mmap(struct file *file, struct vm_area_struct *vma)
+static int secretmem_mmap_proto(struct vma_proto *proto)
{
- unsigned long len = vma->vm_end - vma->vm_start;
+ unsigned long len = proto->end - proto->start;
- if ((vma->vm_flags & (VM_SHARED | VM_MAYSHARE)) == 0)
+ if ((proto->flags & (VM_SHARED | VM_MAYSHARE)) == 0)
return -EINVAL;
- if (!mlock_future_ok(vma->vm_mm, vma->vm_flags | VM_LOCKED, len))
+ if (!mlock_future_ok(proto->mm, proto->flags | VM_LOCKED, len))
return -EAGAIN;
- vm_flags_set(vma, VM_LOCKED | VM_DONTDUMP);
- vma->vm_ops = &secretmem_vm_ops;
+ proto->flags |= VM_LOCKED | VM_DONTDUMP;
+ proto->vm_ops = &secretmem_vm_ops;
return 0;
}
@@ -143,7 +143,7 @@ bool vma_is_secretmem(struct vm_area_struct *vma)
static const struct file_operations secretmem_fops = {
.release = secretmem_release,
- .mmap = secretmem_mmap,
+ .mmap_proto = secretmem_mmap_proto,
};
static int secretmem_migrate_folio(struct address_space *mapping,
--
2.49.0
next prev parent reply other threads:[~2025-04-30 20:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 19:54 [RFC PATCH 0/3] eliminate mmap() retry merge, add .mmap_proto hook Lorenzo Stoakes
2025-04-30 19:54 ` [RFC PATCH 1/3] mm: introduce new .mmap_proto() f_op callback Lorenzo Stoakes
2025-04-30 19:59 ` Lorenzo Stoakes
2025-04-30 21:44 ` Jann Horn
2025-05-01 10:37 ` Lorenzo Stoakes
2025-04-30 21:58 ` David Hildenbrand
2025-05-01 10:23 ` Lorenzo Stoakes
2025-05-01 12:17 ` Mike Rapoport
2025-05-01 13:00 ` Lorenzo Stoakes
2025-05-01 13:51 ` Liam R. Howlett
2025-05-01 13:57 ` Lorenzo Stoakes
2025-05-05 13:29 ` Christian Brauner
2025-05-06 10:01 ` Lorenzo Stoakes
2025-04-30 19:54 ` Lorenzo Stoakes [this message]
2025-04-30 19:59 ` [RFC PATCH 2/3] mm: secretmem: convert to .mmap_proto() hook Lorenzo Stoakes
2025-04-30 19:54 ` [RFC PATCH 3/3] mm/vma: remove mmap() retry merge Lorenzo Stoakes
2025-04-30 19:59 ` Lorenzo Stoakes
2025-04-30 19:58 ` [RFC PATCH 0/3] eliminate mmap() retry merge, add .mmap_proto hook Lorenzo Stoakes
2025-04-30 19:59 ` Lorenzo Stoakes
2025-04-30 21:29 ` Jann Horn
2025-05-01 10:27 ` Lorenzo Stoakes
2025-05-01 14:33 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd9f0abd33677faa7d9aaeabede8d310f361a16.1746040540.git.lorenzo.stoakes@oracle.com \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox