From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C561CC369D9 for ; Wed, 30 Apr 2025 16:57:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11E7F6B00DC; Wed, 30 Apr 2025 12:57:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 056B86B00DD; Wed, 30 Apr 2025 12:57:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC53D6B00DF; Wed, 30 Apr 2025 12:57:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B8EA86B00DC for ; Wed, 30 Apr 2025 12:57:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6162280508 for ; Wed, 30 Apr 2025 16:57:27 +0000 (UTC) X-FDA: 83391316134.04.426CDC2 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf20.hostedemail.com (Postfix) with ESMTP id 770081C000E for ; Wed, 30 Apr 2025 16:57:25 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qsTn3KXG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 3dFYSaAUKCLEkRSSRXffXcV.TfdcZelo-ddbmRTb.fiX@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3dFYSaAUKCLEkRSSRXffXcV.TfdcZelo-ddbmRTb.fiX@flex--tabba.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746032245; a=rsa-sha256; cv=none; b=5IBO2QfQAAg1HFR1cwVOdyBhdFb420vL5pcs6B1usblX1jXg8yKDll+e+Gmenn2vp805KX sVt7x/BJAyJAYeuxXq68dcIP23ELMdrXpH4W3pif62AquAHBylo30vKhH+P/GWi8E28JA7 SNaL2DLIHmPatSha3e9DeVJ0DNpZUY8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qsTn3KXG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 3dFYSaAUKCLEkRSSRXffXcV.TfdcZelo-ddbmRTb.fiX@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3dFYSaAUKCLEkRSSRXffXcV.TfdcZelo-ddbmRTb.fiX@flex--tabba.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746032245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+9uoDx+86QSTziNQV39E2QQb4dm1IuLCuTSYjONJ8/4=; b=D/jXl15QASOV1cQ5RcsUvCwRVwSAkmmSPKJlsqLWggOI8LV04nlzjW6sOmtRg+86WGhve3 UBM0sgYolrqtnXcyfNY5MsgVuaKA7DkIrqhnIplcIOD5yycBBHLs5Bbn32nWMu5vG1wgs/ VRAenrVZCS/bmsrtIvaUOWrRLYkbdbE= Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so39775e9.3 for ; Wed, 30 Apr 2025 09:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746032244; x=1746637044; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+9uoDx+86QSTziNQV39E2QQb4dm1IuLCuTSYjONJ8/4=; b=qsTn3KXGYsIhuU0ySKop7aLfPpEdEvhTRmbM90valdPBS9IJXSC/EIA44rbs2IjzuH 1vagTB1tUv7W/UVcnQkQPEkZUAjnFMyCpRAQWPs7NvCZRMz3rbNr4e+V9OVfYoHToeka xZq79aMhkVKMrH/ROTLdvbd6VHOPHfPFdMqDEsTIzvKkG+Af1gXXIptWc1C3l8t1LIkE 8fSUTjFDL4XR63M8yvM4ZsQRlZA43m34fuvLV+6oSmIyHAWI/++/mIpVET+aR7RjMhK5 6T3uvPHOauadFmmx2DErijBjBz25Uc4Yb12CI6GpNTgq7CFhg5ch6D+6dnHGn+WcfZFr Z1QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746032244; x=1746637044; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+9uoDx+86QSTziNQV39E2QQb4dm1IuLCuTSYjONJ8/4=; b=Oa9/EzfrgAnjAwQYSjwm79DsLlUp1UTfxgJVe81qHTVMELwZVEtRs0tlNTwhKJrAEm alyHMsTO+upNapm46xp/CxQf6gEaAYWidnXcV+zQtIDBxMHLI/xv3PwfvgLALPXvIP5g CS8FeSEug9jJwm533JM9vJjT4uwLqrEQGdnR4fXXknecy5B396EDYGh4vJEOPvGsxsqF 64Pg2p2O7ZpwFJykkDdbrcAa3mfS0HaDLJrVkf5VROEcDHWaHUiIzIXM0AmAjycFZgL+ XQxXDNoi84y7qCpTFlFAwnwtH42JfU8ToObf6EQDChhK3cZq13/9znRU3BwdVEgeYjVZ HUsA== X-Forwarded-Encrypted: i=1; AJvYcCXWYqR4obTE3xujknN5bydo6j0h0WRj0agjwPRBWbRAc5GPzKaGLDPet5+HXPfIWd569XJ7Le6jqQ==@kvack.org X-Gm-Message-State: AOJu0Yx/3p7dO7OajOs/EgoO+b8//4wfWCULAvrR4xDxs8zfbQYE32g9 K/xDq7pD4RlgwGS4JgfCuTBHGAX8zGgkOPjqqrICXsPAlJLn7nZWy9pmUvgEVRSGs1PN+2ITnA= = X-Google-Smtp-Source: AGHT+IFDpTzi9FcOVjJwpujZOVhPqGqNNrby7RROx+UeO014EyEnbkZ/iK1EmHM4+ksMKNW3EMqbqBmh0g== X-Received: from wmqc15.prod.google.com ([2002:a05:600c:a4f:b0:43c:fce2:1db2]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:384a:b0:43c:ec28:d31b with SMTP id 5b1f17b1804b1-441b263a413mr38860435e9.10.1746032244111; Wed, 30 Apr 2025 09:57:24 -0700 (PDT) Date: Wed, 30 Apr 2025 17:56:55 +0100 In-Reply-To: <20250430165655.605595-1-tabba@google.com> Mime-Version: 1.0 References: <20250430165655.605595-1-tabba@google.com> X-Mailer: git-send-email 2.49.0.967.g6a0df3ecc3-goog Message-ID: <20250430165655.605595-14-tabba@google.com> Subject: [PATCH v8 13/13] KVM: guest_memfd: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 770081C000E X-Stat-Signature: p5t8q8zfprn31p8a3sze45h6tmomfncq X-Rspam-User: X-HE-Tag: 1746032245-198781 X-HE-Meta: U2FsdGVkX1/qmiOfCd51LjdpG4hfI5040Sc9d9gh1hkVmb8XKlk0PEi14Wg20kCnln+MrgZOutA3onI32Sn8K0nQ7NWoglNZnpaLip0rXLzYhgY0q+lmfQkpZFNTpdwlkkq1cCIEsUdf2aAzA3vpxes7/1xQCySOsE6A5isfpCKcdg69oJUCRkEJryfobizfuo2xdBqZ2e1LVrUcYaWkA7xMExytd6PwmSTGbJJGIByF0JXUDoEOAMd9XWz5DXJUz8GKocBg/vD1kimSJTxGy8Li1wxS42S2PrZYEdkx4VekDq+KT8v3aWN8ee7CY7K/hu+buKva07eJmGZt85KdWBusmyTKS21pb+H/Ij5CvbM45sNSNPT659x+S598/rae1s65pGKy3m56JIL2uxmOUAizWtRFHJtDHvoRAKcvVZ5CdX0nJz7uwL76dxrDXdM2CDxrGvIJ+hYu6V93tIz6kn2OiHLQKCR54oFI/s8j2dB5YULqOKu2LdIAcAW3dsz6i4T2vK0AD6x5t/ucjdwkni7gQveNRuBoatdDu0khKWvNB/usEawB2h3Sy33gNsNQCNkoG/L9az9472OK2ktahAsKGmpjmcya15GWS1gJKQF93BLD5OFo9K2P1N6kQiKAIdEHy1eocpoHl66OagR9LAejtcKdw7FR8KyB1u2NQ9SsKGeEPOWji71UzZskiALSSZSnZq5og925BrbroxgAd8Shop1zkOfbpXBsVY2dwegOXeim2QubB2+Xsf7Seon+MtvlmTLasCMIhIN2VCYiT3wlW60fIb/wmJzc9ZJgyp+wXLGvxKFVUAWZHlA/zS0Xp9jtu+ctWqJSabsoxINlFbotq5r9xeMJLlpDOPpNHm8ljcjeeN01FzpRNkPN4WH3tgVjAE9Ly+s/k6dT/V4qqnxqdxfsTPd0lPKXBmbpG3LYU1l9zicTwcOtRV4W17TVbDY3/AeQWNuubPFuQQJ 6RqYJKxR y0eSZjsDxnYOlskjyadduwfA+EztSnc3O0dY9nFX1n/x42oWOKyAKfbjst1fg5RhwA7lcHy0Kj7rsjGANooBOCVtaPRbaIHRj3Cke3e1gTfliGVvtJtKNpx6jMacfCCKwk+LGoH5eJ2aaWtEbGu3cnz6lyLNDBR1nHw++906VGZ6jSZd6nVtHbNGotOS6ST++EnGEgEhVw178eKtQUqueoAClZNcTqWhOtsvgJovzPc7UQKMsMNhBozUFSK5m16F+MwP+pEzh4YoFcYuX9IcEdn1vlZg1l3eKTJ3UPatMQyAH1FcJvZNLzSAydpvtkRMlcZjqA49G1u51TczOPahRVp9dhQq3S8XokZDPy2mC6vCDzUbaeM14EYBT68RPzeVIf02TMDdz98QpLRy485XBlyceThZpjTFfvC1WTckTB155oy7vw/qCqRi+o6BxZYf8nw4xqQ0sztlooS49wPheHFvQNJ7oJp0VnRVEwJQrQOKrG51wOxq8qKeKm9uMk6KIZHo9EaztlavbkZPgZ4uVTlnjWVhwvKr/p2leO+Wjl0YYvcS6wH+1uuKfm2l0D0afKv5J+PGbkGGAqaaMJXcQaWZSC/ebvrhzv3YjR5N4MQwesgZmBZE0cDO5YqAOl6b5SCgsb/xbLLW+bI4ma5CzbOzn4gqUD4sho9mrw20y20dQtpHZe4lp1gHfJ5DCyj2dZE3H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Also, build the guest_memfd selftest for arm64. Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 75 +++++++++++++++++-- 2 files changed, 70 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index f62b0a5aba35..ccf95ed037c3 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -163,6 +163,7 @@ TEST_GEN_PROGS_arm64 += access_tracking_perf_test TEST_GEN_PROGS_arm64 += arch_timer TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += get-reg-list TEST_GEN_PROGS_arm64 += memslot_modification_stress_test TEST_GEN_PROGS_arm64 += memslot_perf_test diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..bd35b56c90dc 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -34,12 +34,48 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_allowed(int fd, size_t total_size) { + size_t page_size = getpagesize(); + const char val = 0xaa; + char *mem; + size_t i; + int ret; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed"); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_denied(int fd, size_t total_size) +{ + size_t page_size = getpagesize(); char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -170,19 +206,27 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +unsigned long get_shared_type(void) { - size_t page_size; +#ifdef __x86_64__ + return KVM_X86_SW_PROTECTED_VM; +#endif + return 0; +} + +void test_vm_type(unsigned long type, bool is_shared) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(type); test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); @@ -190,10 +234,29 @@ int main(int argc, char *argv[]) fd = vm_create_guest_memfd(vm, total_size, 0); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (is_shared) + test_mmap_allowed(fd, total_size); + else + test_mmap_denied(fd, total_size); + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +int main(int argc, char *argv[]) +{ +#ifndef __aarch64__ + /* For now, arm64 only supports shared guest memory. */ + test_vm_type(VM_TYPE_DEFAULT, false); +#endif + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + test_vm_type(get_shared_type(), true); + + return 0; } -- 2.49.0.901.g37484f566f-goog