From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D83C3ABA9 for ; Wed, 30 Apr 2025 14:59:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E16DD6B00C0; Wed, 30 Apr 2025 10:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9F406B0088; Wed, 30 Apr 2025 10:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C43286B00C2; Wed, 30 Apr 2025 10:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F2BD6B0088 for ; Wed, 30 Apr 2025 10:59:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D40411A0192 for ; Wed, 30 Apr 2025 14:59:35 +0000 (UTC) X-FDA: 83391019110.15.47E1516 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 97B3C160006 for ; Wed, 30 Apr 2025 14:59:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746025174; a=rsa-sha256; cv=none; b=RvlMUol+o/wLCX2BWDxf5wObYLpUyunb+FOsjGtqChzXjU4v+zDrookqmKC3bYscfZliSx sBIbdVzbNFw0SoCW2Vig4LI6ulyslqgrMJZSptuOASCBkuxuWgUH8lNpXzL6Cchu3Y6lQq OYkXYALCbc7ru2JGuUbnnJfIKdRbWcw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746025174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=hvyBASHyC+YJ/AQDfp5OteL24N2sH4yo5lpIbele6wQ=; b=dWqNmAB3JmokWUdWrEmpHCkQxinBqFhqm32uDafQAMDJlm89rsv8/nR2RpUiAoJtA/Pmf0 XKsHFjs6KZyFy7oFTlsT5pWjCs66ce5L4DuqhzrTun2DarF4Z8OOLkv9LLaOZi+/Q+tE/t ENxzBWDjajhzWt/nUtVxEtqbsNiqlNs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66C201007; Wed, 30 Apr 2025 07:59:24 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B37EC3F5A1; Wed, 30 Apr 2025 07:59:29 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , David Hildenbrand , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan Cc: Ryan Roberts , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v4 0/5] Readahead tweaks for larger folios Date: Wed, 30 Apr 2025 15:59:13 +0100 Message-ID: <20250430145920.3748738-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 97B3C160006 X-Stat-Signature: bbgk8uhmnz6knjd3rxi5kphymacc1end X-Rspam-User: X-HE-Tag: 1746025172-295663 X-HE-Meta: U2FsdGVkX19kFYyvNxu4CP7Pq7tJatMLa0KYewHlaEOaOVXQIo4sbDgcDppwEhqDntlM+QLL6mPXQOwpHroBfBb5f0i8Z/vc10xdGgW+OXCxkqhkWLwV6qLgInTahaXMl583IyG5/WqWN9fu6XeNyzBU4o8D1OTLmPOikMc/iBk0YT/nVHzpKblE4RZcewPHYez358QjiS/n/sWwm+v+8WnxzrUlZA5Hljtk8zyr6DZdWZDtkLrFnJILktJJEPXepjdyb/MMdMt5vxyhXGhXsXCA/SCmPa/pctsf8+dSF8pqDFjx2FE0ITzh3q/IbRHWfWNYaAcRpGrxU6Wx2V42CMCCfdNAGW77b6OXfPrmFZa4o0Gge2YnTF8gd9f2Qcuot0CcUs1KD5CrVTlHpq9tWpBZPYvu842bdvPjCcnizR0hidO030JJ6cMaMVHEoZEUyroa9YhNp5ZZnn1G19mQ7RaxBSsOc9VneA8zeMB38tb8kpLtZ1JLKWbefmxDdYQcIEuO0UO3M2dYln90Kwp36ZhMYSpGNk32Y3ngTZOdX8JRqsiSFFJbe3gU2j/tVk6oLm/ZMdWE13swYmKPxA7DnzH30Cub8kHfg78Zrr7cebGtWjX1Mh+Hqwoq44nPkaYU6RVDR6TyvcgN+d+R3rxOndBYlMW7y0+URDdXaT0nuQdbP+a7T9XFpC248avCcfaCGYu6Jh/qpCWefJ4UHb8+a9XQrPgqOHiHYLZiKMXQA9L4vf+EmAITWfHtJ8tMqv9auXEBNl0yg93bQ4Q4GhgyAtLrrHWNRRuW1iip78MbI5NS2vfD5E+BsmFzFwiW1RKjA6BXGppQEH3sPyzeM3OOFq+XBrL49dQlE4z3jpSdA6MN85YCrlUxHshfsk8VAvonBuKsR9XN3L10NxvPkzrDexmssIrNsrYFq1lGJ+24D9qsgdtCefyXFwZu5FOtpUhObbGG4qNqizTU7cs6hKR kOsFEgwh 3iWQNOb44Cj3nRRtpDjtxrv/jLm0z6Ww6+dJQbVmCv1KdNbS7DUa5aZnVhgoGUORwMrb+T/lJ4Rw8UBj2ipmg4D7qu+0yyomGq7joxChxMrZBzcmMnC3kgUtq/8wPm1aTU+knZv3WvvsG6YT+ISJoRZpM5VGAha+FLbwFaNqs/XdWxFV2f9txCIG2Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi All, This RFC series adds some tweaks to readahead so that it does a better job of ramping up folio sizes as readahead extends further into the file. And it additionally special-cases executable mappings to allow the arch to request a preferred folio size for text. Previous versions of the series focussed on the latter part only (large folios for text). See [3]. But after discussion with Matthew Wilcox last week, we decided that we should really be fixing some of the unintended behaviours in how a folio size is selected in general before special-casing for text. As a result patches 1-4 make folio size selection behave more sanely, then patch 5 introduces large folios for text. Patch 5 depends on patch 1, but does not depend on patches 2-4. --- I'm leaving this marked as RFC for now as I intend to do more testing, and haven't yet updated the benchmark results in patch 5 (although I expect them to be similar). Applies on top of Monday's mm-unstable (b18dec6a6ad3) and passes all mm kselftests. Changes since v3 [3] ==================== - Added patchs 1-4 to do better job of ramping up folio order - In patch 5: - Confine readahead blocks to vma boundaries (per Kalesh) - Rename arch_exec_folio_order() to exec_folio_order() (per Matthew) - exec_folio_order() now returns unsigned int and defaults to order-0 (per Matthew) - readahead size is honoured (including when disabled) Changes since v2 [2] ==================== - Rename arch_wants_exec_folio_order() to arch_exec_folio_order() (per Andrew) - Fixed some typos (per Andrew) Changes since v1 [1] ==================== - Remove "void" from arch_wants_exec_folio_order() macro args list [1] https://lore.kernel.org/linux-mm/20240111154106.3692206-1-ryan.roberts@arm.com/ [2] https://lore.kernel.org/all/20240215154059.2863126-1-ryan.roberts@arm.com/ [3] https://lore.kernel.org/linux-mm/20250327160700.1147155-1-ryan.roberts@arm.com/ Thanks, Ryan Ryan Roberts (5): mm/readahead: Honour new_order in page_cache_ra_order() mm/readahead: Terminate async readahead on natural boundary mm/readahead: Make space in struct file_ra_state mm/readahead: Store folio order in struct file_ra_state mm/filemap: Allow arch to request folio size for exec memory arch/arm64/include/asm/pgtable.h | 8 +++++ include/linux/fs.h | 4 ++- include/linux/pgtable.h | 11 +++++++ mm/filemap.c | 55 ++++++++++++++++++++++++-------- mm/internal.h | 3 +- mm/readahead.c | 27 +++++++++------- 6 files changed, 81 insertions(+), 27 deletions(-) -- 2.43.0