From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B16C369D9 for ; Wed, 30 Apr 2025 14:49:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C79606B00B3; Wed, 30 Apr 2025 10:49:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C02C26B00B5; Wed, 30 Apr 2025 10:49:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2A4E6B00C6; Wed, 30 Apr 2025 10:49:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7E94E6B00B3 for ; Wed, 30 Apr 2025 10:49:17 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 762818015C for ; Wed, 30 Apr 2025 14:49:18 +0000 (UTC) X-FDA: 83390993196.12.2D6387F Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf05.hostedemail.com (Postfix) with ESMTP id 6362D100009 for ; Wed, 30 Apr 2025 14:49:16 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="AYriKUt/"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746024556; a=rsa-sha256; cv=none; b=gQ9Vc5L4tZ7cBSZ1iEom0Pm7i1QoAxFrzGCx7qJnsQtvu4qe0vFxKJoZBP9tRO9V6Iew2f yA/bJj7E07hMgN8e2sn2HjpAbslsv5DG+WdwrvhnPAttgQNvOOv2U7kafib2n8jBS4j/ud 3XuvVJ+2/ionLDQXrQ3FFtZHbZ3PtA8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="AYriKUt/"; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746024556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VAQavjtHywDtkfWDi7d5KrAtXnOwl53XsLV1VpcfMts=; b=1eGlg/iM7PN30yDlS19Ocu0IQn3byU9m7n55AYNmhtA+jts5/Ly8MvifZzpWdrLW59nsGN BjdB1UvUBozSPJ8j6YdXmA/q5IaCDOX7n6ZnL85/0ObGRKdnhB6VD9WN+66h+zFxm13gj1 sDSlg1qSDMlYuAR+My558F0N7ZwiYqU= Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7c597760323so812672985a.3 for ; Wed, 30 Apr 2025 07:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1746024555; x=1746629355; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VAQavjtHywDtkfWDi7d5KrAtXnOwl53XsLV1VpcfMts=; b=AYriKUt/6OBx+wU0y0dA+MgSK+lJ4viQQThNorn3tjBkMj/etMukWdL+6yDxql5qZp ciemmSPtMRzTiQ+WnRAI/UFWo5c6EHZPjIzI/K5ENd6Up822EAxxM1d3YBKL0lsbDCCs AdVV5tt6vafq9MAo4DRcrUFj1CcaqYfPYViQQKdwebttMix8a5pUVhG+K8qxc1fgMQ7h LloiTdUpMJcOy4h7CKBjM/COeE5fiFtYbmvEfhsZSKyLh9MAOLyZVauPPyad93TaQ6vY xsNXQHhOM0XrX67Rttq0HmIUz58+O2M3wIyqwka+1PL6kUaSFT9/yj4NMRc4eOyaDeiI B+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746024555; x=1746629355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VAQavjtHywDtkfWDi7d5KrAtXnOwl53XsLV1VpcfMts=; b=SCIwN1RonGFkPNkSV9LRCNPD9x/H+agopq2TEo1Kakc9ws4Av4IRu/uPNHHotIx2XF R7PoTBtU5mSv+5/X7D7q5y+4uIfSnhzQMspkjDgRRwcis95+2BsGYQdLmdF90MgW7mtA Jfs+zcr/3NbzwARADPqKLx+nCPl3R5QEB/7R8MNWfTN3yUX+maKjxeGb26K74nS9ua5r ogr8N5gBrAW8r5qFLlyFXNXXB/Z/s1/Y5DaIlSHVzzPgslPgGMZoMloP5eodEVUUOrx0 CZryHhlN3NQk5HFRNqaVcwW4iyMgZWAXwGGmn7FZmLLpY/N80Jn0kjXEEjWA9MUz5gVh KrUw== X-Forwarded-Encrypted: i=1; AJvYcCXGPKXI9BVt5Sgjd4CbfENHwphVfutnmcmC/0kUvy9AALVSL/9R50bkxsxsO5EXzvuzps/dntLI9w==@kvack.org X-Gm-Message-State: AOJu0YwaJtt61uwB6jcjslqQpCfz5Wu+4o3Y8JL86yNvE9krKtnAa8ei NuOnN7QQA3Bp6NC7LcdL1SUgzZj79E9Ce4qw/pAj8ZbjJsSfgc9cUEhOUw+SvnY= X-Gm-Gg: ASbGncv+E+E7lZhhu9PuBBaJ1ohGpFLf8XHYIvjcsQjdplDdKTQRWfJd6yU3/MY8l4q /0MJgeW6442c1mUVGrGWRZtYU5+EbOBTSgy1ff7yzBh+LYdr7Kqk3Zp2lZb4DXYz5LkLnujfQBq i3QPtPD1s7gBPsc8E7sCuHdRip9jw14LOjGoxDEsDcvgzDxoYDoacF3qNlAV0uV07OqAjziUBZm ag8htVLzh6isin543GGK0EWeIEehFnpgxrWhNyQSmmev1/LZ1ShD5MO1HRTzcRUOuq6KPLMq25T O9t42pxtknwdT8Rt/Ar+bZY0mqTqZcY5hchL2sA= X-Google-Smtp-Source: AGHT+IF/96hom3+JLrgXk+J7xCewYly0PcXOER+WWiY7E5OjDkUIEfEPnoq4AJrHoZ/ktBIx3YvJ0g== X-Received: by 2002:a05:620a:4056:b0:7c3:c695:156 with SMTP id af79cd13be357-7cac761117dmr431803885a.16.1746024555355; Wed, 30 Apr 2025 07:49:15 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c965750a69sm656679585a.1.2025.04.30.07.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 07:49:14 -0700 (PDT) Date: Wed, 30 Apr 2025 10:49:10 -0400 From: Johannes Weiner To: Muchun Song Cc: mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com Subject: Re: [PATCH RFC 08/28] mm: vmscan: refactor move_folios_to_lru() Message-ID: <20250430144910.GB2020@cmpxchg.org> References: <20250415024532.26632-1-songmuchun@bytedance.com> <20250415024532.26632-9-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415024532.26632-9-songmuchun@bytedance.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6362D100009 X-Stat-Signature: wsxdwnx5judf7rwkhupkepgbe74xmjy9 X-Rspam-User: X-HE-Tag: 1746024556-288286 X-HE-Meta: U2FsdGVkX18NWoFzs5WA/Q1yHrzcHuWJ7cD7a6Eg7ADLVgwcB35tj+RRYvI6698Y0cnkD0bZ+8xRIqf9P83j/drh3Bo3wsrvGrYXPUp/rYes5rLi/xaEFtr28JadG86n9hrNtlSYeac0tBJGn4FeYF8v+WqpYaK2dAU+F7GYltaePNPyv+O+rZ2uJXcBqn7m8VmAtimAb/oFBw0f7agKq/r1TmFF0DCO0aGxWs/GE3BvHiYsJGuVbMvBKGfmbXD35g6hMk2n3SA8WnPF3divk7wqAmkqPkSn+fuXEUolAa7BTidBpwPyq7WzqvYfMdBMlx5SzonZOrq8PhrUNhxtNGitoIbpzt8qkjUCbC4FAMcdtcLOUO9Zo/rKeRkxcM6ZQXD+6y4ZaV0ikKUe0QLgwNSmCWMWhwI5GApfem3w2Or7bJMHiEowqFsQJyMmAazVKSjmens79z+6cYEhQuxXw/P/sXzRQ6gV9wOLThQoZufEWNtXCFSdjNm104y6Q93ymk5B62byZMzUrj6KiAo6sTfmxnDZzQcNLUgW9A01Llp6vUNlk79U1gn0Mzh8KX2O52h9S+K8y8QKUo8i7zFnz/DHffYZKkRBOqb1cg6asuJGUdq/KdAf10BFW73sJhiVlffkwGL7wEePg3ZgXpNsOuV3FVFg5crF+7jBOn2/m8JuS5JR0Lb8mMPtyZzB1C18mbVeDjhW8zWUB3mLnI0hb2RMPH9jU9HGJEQYfPvYXZ6D4OnGDI1wPNDosg8cJkkfYRzojY9aHuoCR6Eazx6z8LGbkMqR2m7WM5sw7i7lkC/ZCapsUwvseP32VHy9q/WO5FIPBzSpcr4yipPi57MDoXUa8QkpzxriVtHrN5kdBueYCpOdFKGkH3YrBAa5bbo/yfryT7e4hd7KwX/G72P6U44+RDeCAD0gxl6bCzZv+ON0+UqDYRSAOZqPAibX8b4796L3Xh+9bG7CTrHwn1K zbE5qfaq AQ+f6B+6x8nFNeu0pQOD9PSKx9tFPREVJk9w5dilu/Qm5SJqiwudjqRRfbBxZ/wIe1xKdXWFRa9BAi8obxWUB39qTmdrDBsfmLUdkpw8vUN+VKfjTY3wUY4/0lAf1SRv3TaFBkpl1cJb5JRYiM96knMoQCX8Hd0/c84pilWT13LBGGg6Emhga0ERoC+255lNOrCYpa3FtPAsehAeLmLjJ/vQv51mfuxKrJOKh8IADcGowj0idMa65OWMuROkkr3JMSMomQtxLCJ5Sf+pusQt84sdyPOvyU6ULML1QvVRUPdz5+2hD70Z2CLm/eUdi17CsYwmgsPVZv/QcvQ4IobUTjpKeIpF0SJtnH7tzgty4F6wAbycXLEcolJ6C6t3kP+WiK47UZKYBMy0Gv1J48VaWkusVMsHB0S9nPhq9cTuek39tyE4vYvi8GXll+XXyKjsZvDwISpIG0uuGUGwoCdN6qjrFEbsO2U/V4mUsq+LDvqacqW4k+CF/5f5zxwGAzgwusSBWbySFFyLjaI+KBfCb7ibDgy1gqzkPQ/3PMRLMTX1r9CoU685iebiEU+xlTSwGlcbSRh4NQnvJ2UY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 15, 2025 at 10:45:12AM +0800, Muchun Song wrote: > In a subsequent patch, we'll reparent the LRU folios. The folios that are > moved to the appropriate LRU list can undergo reparenting during the > move_folios_to_lru() process. Hence, it's incorrect for the caller to hold > a lruvec lock. Instead, we should utilize the more general interface of > folio_lruvec_relock_irq() to obtain the correct lruvec lock. > > This patch involves only code refactoring and doesn't introduce any > functional changes. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner