From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA99C369D9 for ; Wed, 30 Apr 2025 21:21:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98EB06B00D2; Wed, 30 Apr 2025 17:21:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 917646B00D3; Wed, 30 Apr 2025 17:21:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B9A06B00D4; Wed, 30 Apr 2025 17:21:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 545506B00D2 for ; Wed, 30 Apr 2025 17:21:43 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 11B6FC0E0D for ; Wed, 30 Apr 2025 21:21:44 +0000 (UTC) X-FDA: 83391982128.29.6BD59C7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 596EA8000F for ; Wed, 30 Apr 2025 21:21:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gxb9jZ47; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746048102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LN2mXmXsynroXE0asdACVtziUMnqitVFMy5WkFwcVbg=; b=Rd3ChTkt1CuGqIuE8g3chh2wD6hAiLxDsq7JJFEhLlXEf6zUjGb+IoZn7pMtecpz1GrLaY 1OlgunXtuziUEul0dfArfd9ZTIN0wE1sI1Dv0ejj2dtkXfA/88Q4m5aHrgU22g26TXp9if N5WWBjIEEKFbXi0WFtNXVtREN3AVZ2E= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gxb9jZ47; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746048102; a=rsa-sha256; cv=none; b=7I7vh4A8YE1r6DkJfN8rcUWbekzw4W+x7YcxwILon9egaMXXghi//wtHFdNtEsGamm+50o MU5UYe6kDXBxKCdHK3MIWq3cjm0r1fxbv0PcGB11KrpngRUupQ3xeszjYR0lKW+UJfwq4T Grs3TeUjTW9IDuWBKOe/fa4nPx3XN8c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D8DE0A4B86E; Wed, 30 Apr 2025 21:16:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF854C4CEE7; Wed, 30 Apr 2025 21:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746048101; bh=D+CfDT9wAoO6bnY9uzXeEDaa8NmhSoGRGgHb17XWCj4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gxb9jZ473ZU7zsOxhj3AeB1R1+hcEzaw+WBrOkaV71F/6AYOXIoPnUQAURPyiS0wX odbTKvysLOYr/srKd4hBz62+o39XO1dO+g8yJMFAOrMIpK1HMWaqssOPvNM5NGthJK wKB0aDHCt0mA1MAk64td4x7vJ6cP1u/s5v+Tm/Tk= Date: Wed, 30 Apr 2025 14:21:35 -0700 From: Andrew Morton To: Shivank Garg Cc: , , , , , , , , , , , Subject: Re: [PATCH V5 0/2] JFS: Implement migrate_folio for jfs_metapage_aops Message-Id: <20250430142135.099ecfa33963f0895b0f2c1d@linux-foundation.org> In-Reply-To: <20250430100150.279751-1-shivankg@amd.com> References: <20250430100150.279751-1-shivankg@amd.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: wtxxsjbo5o64xfx9edwc9sisg4atafps X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 596EA8000F X-Rspam-User: X-HE-Tag: 1746048102-159817 X-HE-Meta: U2FsdGVkX19YVZSq19DuvTh+DHNpm+2Eh5xo9FjHI2nD6grW64qOPppZsUtPm49x4Yquqhw0DkeQj99XwFODzvuxXXtNg/tKTJy8J6LAK+yEUH4lAtvNyVsx2dp8mCyuzjOEhpiIV/Ca9pBpp1eR9MON/NVMjyi5njtj6P1wy3RMAkjWKqICxMcP/N1PuipWVO1IHw7heKLnZYMiWNwKrT/LHEpxs9ZG47dNW74sKQOEPJW0sFBXKVnZZJTedwRVSNMAUOgV1CnLMvWXWRErVMqAuJFIy877aNHppJBbAqbdb1p0Tz7mlqZB8/8KXLLO0BqgVJHinUj8Q2DdiSglzTROpck1KI+jXl/IJFDi1+IRc3Em6+eNsTKNDLPMS4UmC4kkGrO0X/Ts+k8aqsNCYMl6+kfhw4wfyi0tLFQTTZAXtcvz5j3JlgdzbyKVcVhTBaEvNMAMWMPRIvLCI7E/Tj4eyOczD37UecMwnHhRUfDH/a+tgQ6t+zpw5IQvdXqS9ECXhiFsEBEg77th0spEu7A5PZmyDbjuA6cEAqWgpjaqYmyawX5cW+UXwb8DlWgvmB6fObBAUQSwVEfVyGKBkl+z6ml2X/xdAEI4lxJpzB8JvDvH60YaApOR6mHTXETMpNvrTrn/fQvh9C+Yuhd4/9a+mIZ/OIDZCy+RJyWdIUuNG5gck+fYMDGqzP4Kl2ELSsQLvaOITiML7V6wY9Q2weCOPIbdjvVKJUbkKWha9mtsH2Ozlxw+NvgXpD77XwyjgazRI52uMF/Zc+dns+v+NH8Xfy03Nj8E72yNY5APe7j9LvPJyL4PR/s6AXC49B2JdWWcJFeiDkyLVHRUDKVZMr8mtOyk3EcTjgjJL27fDvHZ/Z9JZ+PIu95gApj48S7oplS601QEKic91G6d51L5+FNUdu+2EMCmiaAdR0Q4CQGN7d0plBXPu/useJpAHt/skLUTc3jKO2yH0SHlMC2 TcVnfN8T tEIfHFHZGmdTR0y/57JXoVoXpG671dT0hHLaUUVgrcjUKWyexFuglpsFt6wsFmrRHrSWOxN4/WruJVIThj76auXUal4mCcimalpIHOQI9jrDsFNqtL4SLqx7sjovkQy5Mz4kX0odAt6jczFFj1e8xv/kuPNiFr3vI9F3PYftnvxahkbSpuZd2quZ1gQSXMNlIaTyBOS/MxQSUCNMBkM+JOR1cF245WVXIZVTDQW0hW5HYO+5JVzV/uXyvvsM6vRJhzyEyNC/qcMaGzjadrSpSgPegKXbp90xKccb55Rgi6uc2Vf3e2lT8gbAaMPVfQPxuKt9g+JoitWwHHaYsJRwcNt86+/jZ6bt5/5qRwknUxFTbovOS8QKCh8ddkGS8uVb1AaheO6YaLU3gg2K2HLRbcSeLe35gDtpl8bJl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 30 Apr 2025 10:01:49 +0000 Shivank Garg wrote: > This patch addresses a warning that occurs during memory compaction due > to JFS's missing migrate_folio operation. The warning was introduced by > commit 7ee3647243e5 ("migrate: Remove call to ->writepage") which added > explicit warnings when filesystem don't implement migrate_folio. > > The syzbot reported following [1]: > jfs_metapage_aops does not implement migrate_folio > WARNING: CPU: 1 PID: 5861 at mm/migrate.c:955 fallback_migrate_folio mm/migrate.c:953 [inline] > WARNING: CPU: 1 PID: 5861 at mm/migrate.c:955 move_to_new_folio+0x70e/0x840 mm/migrate.c:1007 > Modules linked in: > CPU: 1 UID: 0 PID: 5861 Comm: syz-executor280 Not tainted 6.15.0-rc1-next-20250411-syzkaller #0 PREEMPT(full) > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 > RIP: 0010:fallback_migrate_folio mm/migrate.c:953 [inline] > RIP: 0010:move_to_new_folio+0x70e/0x840 mm/migrate.c:1007 > > To fix this issue, this series implement metapage_migrate_folio() for JFS > which handles both single and multiple metapages per page configurations. Thanks, I'll add these to mm.git for some testing while discussion proceeds. Do we think these patches should be backported into -stable kernels? Or maybe we should simply remove the warning from -stable kernels then re-add it when we're confident that all in-tree filesystems are good?