From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23BB1C369D9 for ; Wed, 30 Apr 2025 06:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DDFC6B00B3; Wed, 30 Apr 2025 02:18:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6645E6B00C2; Wed, 30 Apr 2025 02:18:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DE6B6B00C9; Wed, 30 Apr 2025 02:18:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 29CF96B00B3 for ; Wed, 30 Apr 2025 02:18:23 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1149380645 for ; Wed, 30 Apr 2025 06:18:24 +0000 (UTC) X-FDA: 83389705728.16.B797C53 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf12.hostedemail.com (Postfix) with ESMTP id 2A96F4000D for ; Wed, 30 Apr 2025 06:18:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Z/8zEJOW"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745993902; a=rsa-sha256; cv=none; b=OV6jZAoM9JxUS9voZZzuKODUX10GK6jjV5edINoNnidwY0pP/2OUNiWAUDQROPk7yW7p+R YX1B4PvNiOJGgB/bvzipKHu1mWSrrblLPRQA2Ee5ImpIkw3YAcaULmLYdaAo5PEvTMszuk nCfsIPqoxObx0DHDHR/2BNoUrvR9f98= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Z/8zEJOW"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745993902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tx2RU4mYzFpV71SR5xjVuK8naKNCoMEJ8PxcPvgudp4=; b=hBAgyajnBtLtyrO8T+0SY6znrFFdkdbdpJPtHrFxcmPgeSzg8gRUx+ircL277eyIzOxOG3 zbuf1RrVh4+ZVVcML5ms+BckyBKzvNbveqxhcGMkDFpddJTCCQQR5L9d7zGy11rBV7u0Z0 75TLoO/JolgbZiAIzEZrPk0oVWeObX8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745993902; x=1777529902; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PYkZX74d10lvPGrseB5FE9s3+bTtnF0aDOcSfLFSv0w=; b=Z/8zEJOWazGmvqVkKB58d3/ITJAhGtqVmlyO6YKcBKldF8BxnnIfIumW DrEHYMj1U+iM6ENh9tWyNTXmR9ET0pPNAsNQFlaCgqn7sC48U0p9a0rGH ET7mR1M1j8oCG3Xze/ZbQyw2O1Mn2EON73aIFQ58gOOjOg7n1KuJU0qoG OVjzA/bvtXiwz1zmS2cJVADKI18fq3Z9sR4JhGuii2ftsOgtkZrMgUebM c9CmVn4TRmvY8N4h21cjw6f7jU4qGqWUa+r5MYu5PXFK4DZUOeJPUaOpO XrOA5xopqTA0LVwoVt8JeeXMeik2M3UKNBp+xS2EGgsqwOsXZEuf7f/+G w==; X-CSE-ConnectionGUID: g9VtnNVYQVW48S6SWbclGg== X-CSE-MsgGUID: MyYW+lNTSpSiLyzYjWiJWQ== X-IronPort-AV: E=McAfee;i="6700,10204,11418"; a="47521358" X-IronPort-AV: E=Sophos;i="6.15,251,1739865600"; d="scan'208";a="47521358" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 23:18:20 -0700 X-CSE-ConnectionGUID: JZDNPxd7Si6aYG0rC+r71w== X-CSE-MsgGUID: v1JASB2zTtuddJoWKG34Iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,251,1739865600"; d="scan'208";a="133929263" Received: from lkp-server01.sh.intel.com (HELO 1992f890471c) ([10.239.97.150]) by orviesa006.jf.intel.com with ESMTP; 29 Apr 2025 23:18:12 -0700 Received: from kbuild by 1992f890471c with local (Exim 4.96) (envelope-from ) id 1uA0lm-0003Dv-0B; Wed, 30 Apr 2025 06:18:10 +0000 Date: Wed, 30 Apr 2025 14:17:42 +0800 From: kernel test robot To: Dev Jain , akpm@linux-foundation.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, namit@vmware.com, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com, Dev Jain Subject: Re: [PATCH v2 6/7] mm: Batch around can_change_pte_writable() Message-ID: <202504301306.AU2G1yvg-lkp@intel.com> References: <20250429052336.18912-7-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250429052336.18912-7-dev.jain@arm.com> X-Rspam-User: X-Rspamd-Queue-Id: 2A96F4000D X-Rspamd-Server: rspam04 X-Stat-Signature: 9c3rcx1qob3ubegot8hezk4cx9quxicg X-HE-Tag: 1745993900-631594 X-HE-Meta: U2FsdGVkX1+GMjwdm6uPNE5YhxVAhxHdIc28iUg5BcWkhwOrz51BL4YUJT7WzdyMIAhS89Hflehe4rETxniccx8EChhqY2VDaIgkdLKkXYI43JICuUq6p5I3HbTI5w61PUsGaTokU520ulT4KcmY5qaLOGh0A5NkO/b1QMmTXvDRg+tvqSBlH/YxKpOdjxdnMs1cHGyvdXGo+WyJTojR/1KAsbTVsr3hoGDzMZh9acaNBKwSMQImmStJN3HrrmU5qZetIgIFBe9uJ0+oHC3ejN/77oFtCMrlQHvS4cK/JIfpiZ9BhBM5F9ufvfQd1Fzbil04verbXID7wCtlKITZrkD1GFtiNNcaKlxtjdYZ3HApi7NuZuknvjtPPGh8lzdKEwpDJi+lGoIb4c3Mezoe9e5AFaURnChGvEXW65kWC5cfKhVcjNk0NI7Be/QYk2OYG8wGN3e0Qdj9O7zM1CGyJ5ZpYGHsyc0WkiAnmMb8yHWB4V4yK52YfjNUIATLP6N22zDexv8HxEyOrt5ciq5Yt8mXYIFEPNEpPM6EyP7/pOCvXSyra2J7u927e9fVbI7xjmx2DcmDjNqQZUkhXR/7MIqgUPmjm70v5Eh3Y78zeS0zwroGC9dgLt1opnjNinqEiGgy9OcXxhDg7M560jsmhM8g3PgRFLBIYN5saYrosV5h8+GxDK0ynZDB9DStfNHDyG2pHRRvnCOFPkwliTXAedavLc9wUFb9LOrj+mVoipy8vNLNBrnnY/FRX4WXhT9CEJbwniRZ+p3ZVVy8EAWzwxOOnb4duWEQ7rqOzoHy/Tw+qxed66chjErbpKrjYdBrfTv7csTQehHR1qzdvcZvgqWix8cIGM6mcMH9iEE6Zj5cdupJFfe7zVyRhHJhUPT3NqZp1H+Vo3Hgguh+e8auKcj+9bz0euskmtKZ7J5x82TjD/zxbp2o0G5cj/KUiMQnYc1oGN1NHvePfui4Sqx Ky2EEOEl fwPt/ecJbfEdKFs+VPoDeV+VrVZb6JRdGehq+S1bfnPj5CEr/6wf7IXNPoIjpWRCkNvgrc5Mecfm/DOXNY/pBAKIElT3tAroScAkLk9x/k02c4YgYaBhNrnE1X0BYcsxyAIViRJr1XYxNWzr+INWvhEHE+w2rTZACOSN/DBD3F3z0qcC5Hgh0R3og1yUG+Vies/PCfTamjlQ013fIFJHR0rBezwHmODKwdbr2oXSP4Zce3sOGYUCQxfqB3LyeqZuHydrr+VQJuBe+dCB4NlkIaLnpk5BSs6hte/S9ef7bMRKTIKCfEkh0+D+2uXAnMbZgFpA4UJ1xrO5rqLJ0if2aJuFv9J1WPukut800r3rsRSpW/oqNv8IjMY5WyAry8bFFLm8iaizthAhTJVtXT8afUq5A10Aiw1idpEKZyDxt5PT7QUgj/kLhdc90YShF1Unb4FEzwijJrFp+9M4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dev, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on arm64/for-next/core linus/master v6.15-rc4 next-20250429] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dev-Jain/mm-Refactor-code-in-mprotect/20250429-133151 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20250429052336.18912-7-dev.jain%40arm.com patch subject: [PATCH v2 6/7] mm: Batch around can_change_pte_writable() config: arm64-randconfig-002-20250430 (https://download.01.org/0day-ci/archive/20250430/202504301306.AU2G1yvg-lkp@intel.com/config) compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250430/202504301306.AU2G1yvg-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202504301306.AU2G1yvg-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/mprotect.c:46:15: warning: unused variable 'page' [-Wunused-variable] 46 | struct page *page; | ^~~~ mm/mprotect.c:226:51: error: use of undeclared identifier 'folio' 226 | can_change_ptes_writable(vma, addr, ptent, folio, 1)) | ^ 1 warning and 1 error generated. vim +/page +46 mm/mprotect.c 36f881883c5794 Kirill A. Shutemov 2015-06-24 42 695112a1385b39 Dev Jain 2025-04-29 43 bool can_change_ptes_writable(struct vm_area_struct *vma, unsigned long addr, 695112a1385b39 Dev Jain 2025-04-29 44 pte_t pte, struct folio *folio, unsigned int nr) 64fe24a3e05e5f David Hildenbrand 2022-06-14 45 { 64fe24a3e05e5f David Hildenbrand 2022-06-14 @46 struct page *page; 64fe24a3e05e5f David Hildenbrand 2022-06-14 47 7ea7e333842ed5 David Hildenbrand 2022-11-08 48 if (WARN_ON_ONCE(!(vma->vm_flags & VM_WRITE))) 7ea7e333842ed5 David Hildenbrand 2022-11-08 49 return false; 64fe24a3e05e5f David Hildenbrand 2022-06-14 50 7ea7e333842ed5 David Hildenbrand 2022-11-08 51 /* Don't touch entries that are not even readable. */ d84887739d5c98 Nadav Amit 2022-11-08 52 if (pte_protnone(pte)) 64fe24a3e05e5f David Hildenbrand 2022-06-14 53 return false; 64fe24a3e05e5f David Hildenbrand 2022-06-14 54 64fe24a3e05e5f David Hildenbrand 2022-06-14 55 /* Do we need write faults for softdirty tracking? */ f38ee285191813 Barry Song 2024-06-08 56 if (pte_needs_soft_dirty_wp(vma, pte)) 64fe24a3e05e5f David Hildenbrand 2022-06-14 57 return false; 64fe24a3e05e5f David Hildenbrand 2022-06-14 58 64fe24a3e05e5f David Hildenbrand 2022-06-14 59 /* Do we need write faults for uffd-wp tracking? */ 64fe24a3e05e5f David Hildenbrand 2022-06-14 60 if (userfaultfd_pte_wp(vma, pte)) 64fe24a3e05e5f David Hildenbrand 2022-06-14 61 return false; 64fe24a3e05e5f David Hildenbrand 2022-06-14 62 64fe24a3e05e5f David Hildenbrand 2022-06-14 63 if (!(vma->vm_flags & VM_SHARED)) { 64fe24a3e05e5f David Hildenbrand 2022-06-14 64 /* 7ea7e333842ed5 David Hildenbrand 2022-11-08 65 * Writable MAP_PRIVATE mapping: We can only special-case on 7ea7e333842ed5 David Hildenbrand 2022-11-08 66 * exclusive anonymous pages, because we know that our 7ea7e333842ed5 David Hildenbrand 2022-11-08 67 * write-fault handler similarly would map them writable without 7ea7e333842ed5 David Hildenbrand 2022-11-08 68 * any additional checks while holding the PT lock. 64fe24a3e05e5f David Hildenbrand 2022-06-14 69 */ 695112a1385b39 Dev Jain 2025-04-29 70 if (!folio) 695112a1385b39 Dev Jain 2025-04-29 71 folio = vm_normal_folio(vma, addr, pte); 695112a1385b39 Dev Jain 2025-04-29 72 return folio_test_anon(folio) && !folio_maybe_mapped_shared(folio); 64fe24a3e05e5f David Hildenbrand 2022-06-14 73 } 64fe24a3e05e5f David Hildenbrand 2022-06-14 74 fce831c92092ad David Hildenbrand 2024-05-22 75 VM_WARN_ON_ONCE(is_zero_pfn(pte_pfn(pte)) && pte_dirty(pte)); fce831c92092ad David Hildenbrand 2024-05-22 76 7ea7e333842ed5 David Hildenbrand 2022-11-08 77 /* 7ea7e333842ed5 David Hildenbrand 2022-11-08 78 * Writable MAP_SHARED mapping: "clean" might indicate that the FS still 7ea7e333842ed5 David Hildenbrand 2022-11-08 79 * needs a real write-fault for writenotify 7ea7e333842ed5 David Hildenbrand 2022-11-08 80 * (see vma_wants_writenotify()). If "dirty", the assumption is that the 7ea7e333842ed5 David Hildenbrand 2022-11-08 81 * FS was already notified and we can simply mark the PTE writable 7ea7e333842ed5 David Hildenbrand 2022-11-08 82 * just like the write-fault handler would do. 7ea7e333842ed5 David Hildenbrand 2022-11-08 83 */ d84887739d5c98 Nadav Amit 2022-11-08 84 return pte_dirty(pte); 64fe24a3e05e5f David Hildenbrand 2022-06-14 85 } 64fe24a3e05e5f David Hildenbrand 2022-06-14 86 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki