From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29662C3ABA5 for ; Wed, 30 Apr 2025 00:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 055C26B00C7; Tue, 29 Apr 2025 20:54:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 000406B00C9; Tue, 29 Apr 2025 20:54:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D48B76B00CA; Tue, 29 Apr 2025 20:54:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A5EE46B00C7 for ; Tue, 29 Apr 2025 20:54:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0EE15BC34A for ; Tue, 29 Apr 2025 23:39:04 +0000 (UTC) X-FDA: 83388699408.30.8A9937B Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf08.hostedemail.com (Postfix) with ESMTP id 44A1A160006 for ; Tue, 29 Apr 2025 23:39:02 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dVJQC6dX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745969942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rEZyehd4zLYWxImC6V7ghpPr92k+M9DC2r20TkQaMas=; b=apCpYayNoN0YRR/EYu53Vj7azTYrFD73iLMc0b3WYK+W3QUNHslwWmWEdfvZV887PdKppR yzNLSHxTzGCxJmMQZPY3cpYAW/Y/TC+sEIjhGd4rIFd8vFBHBZW7AeOb3ClOuFyGlCamND twmTTLnHuyyYnnyjcSCbiLkwBbbd0pU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dVJQC6dX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745969942; a=rsa-sha256; cv=none; b=DFRmlWu9vYNISYmnApCTJwQ6wDqIQHibyF3HQ16GOvKSlEaOc30CuYZ6mSgCOR67MxaWAV qM909bli8sMmZqBJtXu1xJ6QClV2aMdjVnF3c0OMcd8MQeN4A1aNooDjgfZNZoT2Ixanzn NxaJVnuG7JLJcvOEX208SmyIAqOER0E= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-707d3c12574so3207757b3.1 for ; Tue, 29 Apr 2025 16:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745969941; x=1746574741; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rEZyehd4zLYWxImC6V7ghpPr92k+M9DC2r20TkQaMas=; b=dVJQC6dX27hfiI4VImKM/HmS3JWwILX9COBzXxlqXaHkkI2p1k0RCJrv8wTz624Vf3 jf//jIhFLGHm7O5cIDR5dnYhsQKTFVIOoQyddNhCpWA8+jJlqXsfkbK5UEKMeE6+3Of7 QxIJtaRwFMCLjkdHT+XJThZAnVGm0iT7VVYBEbpQ+r/ZvDD3OxFkxJDiyazr4iOEro0p 6nHvJRCwGfL+Hdvi1fSmPNLdg8KS6ITdf3uvZFCwDbWa0VRQtqAuR6CIUn1LJmjRG2Gz F2KN9O9A9Kw4y4YDA19DHHB0p84lw6Qu4G70RycqbgfZ1evR4NQjjk0bQX/ntgmlpRsd 98kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745969941; x=1746574741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rEZyehd4zLYWxImC6V7ghpPr92k+M9DC2r20TkQaMas=; b=OYKaaO8Pr8qSM3NSYfKB8hAo3ZwcyBTEvFhfwk5tRGS/HMpPKnFI/Z+44009EqDZz1 t8Jeu45BEiXRD6xMoRByJbIQ5WaNuxvzaxIzw8zqBEBmCX+GSmQ5ApzW8sSGoXBE+wXW TCasI9qJC6AbQEw5PtyxN4I6/KHSDuRId3EXjxuAjr8LovHNXBYgOzfs0AQiHM4KhoAq 6m7CWhVvCX+3dSvYtQ2dO3hjy+O1S7HJbPDBjHcwwuaL9b3KNT5pPuZr0EMb6zH2IBZJ GfKjzUC6Hxzcv1fpGYMJTTxBl74KPfYnPKMoEk3KBZ5mlLgkY1R9MVAJZ8oAHKOti4uB RyZQ== X-Gm-Message-State: AOJu0Yw0Uvwfsr+4/xVGtUUIcIlLgVd9QYahAfX+RntIj/HsDBA1qkIm fIZLHvaPHFnaoOl/A6NkLEggeXSixLdyq74OsP0swtCQ3xVN+44STxjuFA== X-Gm-Gg: ASbGnctJhMmJ4H+6Tt/yHUzcEmY3luaqA19l2/Rtr1koEI4owNuc1fbPMWlNiAqdX7G rcDuHMF42TyPncub0eBbZbkF+lJw3PhxYfTXwGL2OE7b9voddTyn5RILo2fhH8R4PJ1FSO1YQj/ 7tIOw6NVOrSFsJcLPowGRnDIsezeZeGY2O4Sa1MwkBNiHLvHrduFGYvqOdiLnR3xc5RCQ20mhZE RY7OiKuA55o6cj4ZD6aZ62zMfmhDJ4fsIzJqUBVNSmdarx8/RRC9k6O3R4c1H+rTenqovYCCsmB gkLe43a2r/F99dMJv+dpsSCFb6WkggRO8bkiW/Pq7g== X-Google-Smtp-Source: AGHT+IHLBOt1mg0UkEf7TqpYRdSt7F/Em6EVYpt0sNHt2NR3UzEsMCk2MhPOS7GmiEg/ttkp85F6Dg== X-Received: by 2002:a05:690c:998a:b0:6fb:9445:d28e with SMTP id 00721157ae682-708ad0cc1bdmr11913687b3.10.1745969941309; Tue, 29 Apr 2025 16:39:01 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:8::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-708ae035c65sm760327b3.42.2025.04.29.16.39.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 16:39:00 -0700 (PDT) From: Nhat Pham To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, hughd@google.com, yosry.ahmed@linux.dev, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, len.brown@intel.com, chengming.zhou@linux.dev, kasong@tencent.com, chrisl@kernel.org, huang.ying.caritas@gmail.com, ryan.roberts@arm.com, viro@zeniv.linux.org.uk, baohua@kernel.org, osalvador@suse.de, lorenzo.stoakes@oracle.com, christophe.leroy@csgroup.eu, pavel@kernel.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-pm@vger.kernel.org, peterx@redhat.com Subject: [RFC PATCH v2 13/18] zswap: do not start zswap shrinker if there is no physical swap slots Date: Tue, 29 Apr 2025 16:38:41 -0700 Message-ID: <20250429233848.3093350-14-nphamcs@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250429233848.3093350-1-nphamcs@gmail.com> References: <20250429233848.3093350-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: px1soe35139di3ryok8xjitocugd6ozc X-Rspamd-Queue-Id: 44A1A160006 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745969942-849806 X-HE-Meta: U2FsdGVkX1+XcWjuOT0HbYScKyC04iefziGgFhhlVA3HM78eBVhBfjHfR9dYUNoxCmeLj9Qqcl4I3NaC2Oqs460GfX9LkqQEyYD3vFxd7Y87JDaqzvTt/6QSvCM2C1QBdDQMyvHsaRglX0Ueu5cFpdR42TPXHSC+FxkcFWcteyvSPGYj0MdqPX/fRJqWmTjQvwRGWjud9Muho4jrjHJ1pAhwq2m7cWZWx/EslCeMe+tTGpUQuzHormmZUMnGzTBD3aQnpjSvFLbCIovLWir21dOyajJwtpFdneR/I3JS7GHc1pyat0i9/Dv9hxlmFTI3CIkvnNQ81bYkHoHpGCzohgG0eCD2452d3sThQZCZoepBlped8VcJgpxhUJoxsmtjw1UVylLwO98lDkgXGVBn+0r9ia/baLI9t+Kg0mgmJOFG4rff8U0Y3kYn2eS6+L6bWtgmJ+NXtngw+8sulvcyOq1/R1C/QItLFxQNES8kn0zOuTv1dlE7LPN/f4wEfjzlpcxegzQbBC/A6ivGOoqutlnj5gz7dHJytFcmXaj9jtNQiFguT2XASC7dgQjx5dz83edckGheKOkTQYDoiy6OHUruJhaN5vSK2lX6mkftrg/lM6irjsCd7BTI30tAPDJuES6NYDqgynj5NowUYMezfeDuj4qYSwD1FR8JBwlYh1zYN5hiT5p7xEv8GKT5nKmAKlTDYBJFo2Du68DqpmUYsyYwIGecJ8cmDn0mm9es3LAQJ8ggq2SITFc4DmhWzJFeD4R1eYuZZ/mOzb2WcFBPOIAmgkA2+7m10/ggWwZMjZx8imOOlE1gpLdRFPeVVHP/MzJa8TbZB87o7mUwINp3mNYe9+WcDaS2nfdZUuDGcbnc8IsTkpdON7QqOirQKkeZjjv8xBCRa75eLK5OhnV/uiyCMG/rMQdy1GoA6MRatxpNq77dY5sxCCBfaS7S5Btt57MmQXJG8zm7rKP5NRO WcG7GiHJ GmswYN983UpIeQBZi2aJOBzBTI7HPOo+GrpdTy14eheyGa8YSjNbefyCaFMRndngvpdLd1jjnqhsf1eGPRLUL2QMc4uvYa+CuwpwXOKqM78jRcowtfKiLpGLs2dFhFjUvH9UGjlnm84/93hXiPHpec0t8KBYYznGo9yHCWut3RoB6m7IpZca3yERQFEsmHKa+YRw3vgGbtohTQi5lYUie3lL0wYuJgD21aorE+IQTPAzjBPmPOoodVizISKM835ZS6z2WHVk3Y8Ysi1jGuttSpgiNO0oobu55d8SzLlq+CiwzJFYycUqsQiBXEcPcwRzo8L8KD/6DXf6gVRI4ogkoESk9b6iMKx4mlFSSiO9kbEWSAGnmzLEIYeujYWlHuEWikiv9QtdS0Lvfan2SWNRrsDnQcmcwJ72HeClhpaNn+BxkOaucRg1QH5jpI4s/EG/wKgwzYEsPq/ct/e2Ey9IZfau5xdOHgYnRNBDDGDF/z/s9qNIX6/C4pOM5oA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When swap is virtualized, we no longer pre-allocate a slot on swapfile for each zswap entry. Do not start the zswap shrinker if there is no physical swap slots available. Signed-off-by: Nhat Pham --- mm/zswap.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mm/zswap.c b/mm/zswap.c index 15429825d667..f2f412cc1911 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1277,6 +1277,14 @@ static unsigned long zswap_shrinker_count(struct shrinker *shrinker, if (!zswap_shrinker_enabled || !mem_cgroup_zswap_writeback_enabled(memcg)) return 0; + /* + * When swap is virtualized, we do not have any swap slots on swapfile + * preallocated for zswap objects. If there is no slot available, we + * cannot writeback and should just bail out here. + */ + if (IS_ENABLED(CONFIG_VIRTUAL_SWAP) && !get_nr_swap_pages()) + return 0; + /* * The shrinker resumes swap writeback, which will enter block * and may enter fs. XXX: Harmonize with vmscan.c __GFP_FS -- 2.47.1