From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE040C369DC for ; Tue, 29 Apr 2025 11:50:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 339756B0022; Tue, 29 Apr 2025 07:50:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C0026B0023; Tue, 29 Apr 2025 07:50:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 139F36B0024; Tue, 29 Apr 2025 07:50:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E004E6B0022 for ; Tue, 29 Apr 2025 07:50:37 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 80EB5809D7 for ; Tue, 29 Apr 2025 11:50:38 +0000 (UTC) X-FDA: 83386914156.11.CEB8AD0 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 887D3A0004 for ; Tue, 29 Apr 2025 11:50:36 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e1tC7ASh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745927436; a=rsa-sha256; cv=none; b=dVx53AtCmYXlZyRIIunisQ22mm3rYsPbZ7ipyb+YqeKaePjB/yTkMRlPy1qK1I5bK7YQSa JLChs9wdvnC5Lqa7wJd9FSIWqnw5ZnewrOWDriZFZ1pGKEQI+aIqe57b6seiRIJP5om3Cn UsqNAe1SdH9jwQBXsJnjvEjUlVnYkXk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=e1tC7ASh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of ryncsn@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=ryncsn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745927436; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dgq83EGL/QD5wjuy65QG87e6Pc1gzfmOWc21Ho8xkpg=; b=eUhIsj93O811la3czzbPFoLa3Jpj2G6760GVz70Mtxmegs1Huzjh5XckgLk+Oeev0GdAcc o7MenDB5KBHFWO5/52asbyPFV4jiUao0GzS0weRRSe9q5fgZzBTR7+AYNUoOEBLmrJXcFV a0eoA1sC+7XY5czrGVk/JiHPS6TR7MA= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7394945d37eso5054882b3a.3 for ; Tue, 29 Apr 2025 04:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745927435; x=1746532235; darn=kvack.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Dgq83EGL/QD5wjuy65QG87e6Pc1gzfmOWc21Ho8xkpg=; b=e1tC7ASheTmPqC3HhOQmS0oj+foi1j+OMV1xEWdbpGtO4K7Oa/bGnb+CWO/lTcTH8n D1CoCuaDdTMLZvDatKQ6e+GwKt/sn40dmiaOW3quKw3yz9uzdHfEuqPmQ80QYELI9TvX oYbLSznCWtgv3jR2suZJe1BsT45snkBYuckyhdi/Jj4RcOaWfITsVhFCIDSxB1AEb4Y+ 9dwHQafFgeXyMHDRA5ZeoaEWGZ8zMqWkRT++M62xlZ/mEiVVAJg/HLCpxQqlJkD5ka+f GqWQmGk0qRKZdacDhxXetRmrl4otvanZa/zC0zB+ncvV8lkcNqMxdJPrv0PS0GJSPPXN jnTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745927435; x=1746532235; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Dgq83EGL/QD5wjuy65QG87e6Pc1gzfmOWc21Ho8xkpg=; b=DNowPjeEB0ie2fBT7JxlYwypOp/YRk49oihH+8CxvEb27TaljPkhYiSVV3DVz7GOTK jOjuf8dfidpaH1ffkrOZfu8o5ENRM+Jxsae3xVRtm7T63MwSh1/dwseag/PMXDFFKoTi mvI9HH6HAGWVN9+6o+Tmh4IyWtt0N/L/tBpl0l1LHYXu6OkWXZFwPaN/xOXbBI78N5x0 9IhVAaY6lVDm2Ac8TKm8c+Iq0vwlWBiVBGrOKFAiZZuW2DEaSxbIOYULd//c69JtJrmn x3dj+e4lScm8H/I27WwX8jdUJ/U6Nl4R/o2SFZnl+6iXoU6fvX/1KA7EgVRP1SllWj6r oPoQ== X-Gm-Message-State: AOJu0YyvFRFBTWfhB1oqdLJJ1njqqX1SC58uwxHE9llWUVpP9glrgeH0 L3fbl7Wu1WOWyZDgzJuCbsQyNwbibt1H3V6aZwjQvn+34M1DALNfHqKvAHOp X-Gm-Gg: ASbGncvnfG1DVnLT9/J5U8FSRZwF738jrjW5PEv8KaSZXlawrVzm5j0m7f8bVmtSEgz fh1mIxMeP7gOGwGSVO7P8NKPmYJ86A0xKpmL29QFJdmAPykKazyBgrqhx3gGzqPW+mQ60Kco3+y D4s9oCWPX+wr8BZla04UiEGzsZuMi14bVKqzcvCi36Jv7MK3lWFe4eoPVGSZenQHGWlCGivHzGE 20PPHOz0k5wKTXRIRcpCgd1Xio4QYbHSsecsRzME6HdB/BspJbjZ8Fux83oWelf4NPRzxfk+WyE 0nrbHNXeV4ElE+33D6ZB4P8UnxRjotCmcZKTlgtxG9XVgSgGGpwqBVtYCNUr6B/bTqqkaz4= X-Google-Smtp-Source: AGHT+IHGZhZY/3nMBx8I+Rv77oPScvGIRbeEGosfvczsqDw+cy+3eOjBSzpIR0MnqGfEbpansUl/vQ== X-Received: by 2002:a05:6a00:3a12:b0:73e:2dc8:94f3 with SMTP id d2e1a72fcca58-73ff725247amr15262051b3a.1.1745927434739; Tue, 29 Apr 2025 04:50:34 -0700 (PDT) Received: from KASONG-MC4.tencent.com ([43.132.141.24]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25aca62csm9661644b3a.167.2025.04.29.04.50.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 29 Apr 2025 04:50:34 -0700 (PDT) From: Kairui Song To: linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , David Hildenbrand , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Kairui Song Subject: [PATCH v2 4/6] filemap: do not use folio_contains for swap cache folios Date: Tue, 29 Apr 2025 19:49:47 +0800 Message-ID: <20250429114949.41124-5-ryncsn@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250429114949.41124-1-ryncsn@gmail.com> References: <20250429114949.41124-1-ryncsn@gmail.com> Reply-To: Kairui Song MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 887D3A0004 X-Stat-Signature: btge6ppfsnorgwcrebbcabcco316s9o4 X-Rspam-User: X-HE-Tag: 1745927436-505013 X-HE-Meta: U2FsdGVkX19z/izES0Jkp0l7xD+KdgQt75BEQpkB7Ugae8CkHZ1wyOcopCK7d/iTZi/DAGmnvaqVoIJIhOnUkglb9RBvKcBNoAQKcXpDWWbnMsyn1z/fFBdQdFBu7mvXvJNXe5uVwy88jNa7m3sglRK3DfmJWij/k+0FJgMxFzsf14ne8NP5O8u11cP2Nmm+5d7sC1iX+d7ozhrcW+RjkrlfKkr4LdaM7yBvYL9mhhFa4A30XxIdWZ5j+fZwhPy7QC2fyF0zESwTcKwWxnqE7zseWxodEzpGF9LPFZw6l1dEcjvdnDpNl4ng2+tZ8hJ9/PC0+IOWd0CA/IhfFZPoWadY6f/vPnVAuUa8tZsAlFxpOtw/FDfEVEgiXdKIWno6xRQcRfw0vvNPh2FuRs3iPMlrApLVUOvXcN+Alts5noc8vpq7P2fsS129cxEVjIDpwS5rzVV0ysPy57mBGRsBFDZ5f9LHK2ueKnlfdgp5qLi+vEFpcMkfv/2BVz5RvD35Bpv2UhTEaTWC7VuBAo5rjYRyK/yqj8DGCbnQSlmEptyY/hURoM0sj38XIaX/+HL6AMyMUsTuWb6uEFfsKGy5nXrP+uQDUIFhZd9V/yWzd9QdD5Z0VetAJ6DZOJ1BkpnP0f8Wcgc82Sp2JI54O7dIt8tJONmDEcwHPHpZQlTYoFi6m3L61XZ35Zm3LyfIvvgDS3yVZbzH7UsN2GhUWpHbcAvgp6Snqs3SGDS3VM+zUeo7cJJh2RMJ4fbJlUQO8aplN5WeozkYAX1Qg1nX1amqCmvn4qCv779tR8fXoRh8etXuqLxxDh6ml9CWuStjnBwnKOXRWUQ2z3H2cUnSlnIHZ/spAf+jEfv6DqURf8/SqPjIQt7Ku9O2XhwBA5adNxromMcqdiwpyTIt3CDr2IamRAh4NqRWtiu35deGLEY2G2sTGNSjauTntFaKHmOpxJQRK22HDb5+pD9WciVPy32 cCLSbzSy wLUJ1iHokWl77P+I7ab2H2FCJ6AbEh5CdXc8TAz5InoWKVHZCpDz93fwJMbiBVu8XU4nvNB1EJqa1kaHpjIv/gRJftQ8n4qviPAUXuNsnq1wg6Rroyoe2Ykgp2oB05wM44biO33xRfPE25e7YIlkZFi1VZLYA/B7gOr3OXXIHzZIkye+SUPS8tFrUdUaw7ijJJwGn65doOK1A0pYUrijJUaP/jcPqEPZp+Z/imhtoYIWyQ0VhUPpYfC9uGrZDZMmQqF9QbuoGLQkAyBXCb+S8UfuwOkzT3c+Kv169IjNiBd7rJ7BdqSmXkoyGcySV/5zd8ok2u3EOjy9KtJFOuULWayfSizJ4EKuPOmgzI2jEdq6EV4zo68ZQhFnwbq73yPE949DubldvDzxGaj6/nEK0d1/KKrY11LBm5hnjPsKAwo9JHCUIRyij+5FMSf9qJ3gzYPLFwP5+qzSHZbT5kM76Ik0wxermCGNpw3Y6am+m7T1k5oWxwg1t10R/L1ZzCB1oF4CL0SqO7UUFS7mGulz0eYrpbqZSHngiFNLkI9oYgXwS0ncmJVMSk4BDbyIEVftuO1O77PZytoDfILf6X/nydEma/ctznCrRd7A3JDKb8UmeaeE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Kairui Song Currently, none of the folio_contains callers should encounter swap cache folios. For fs/ callers, swap cache folios are never part of their workflow. For filemap and truncate, folio_contains is only used for sanity checks to verify the folio index matches the expected lookup / invalidation target. The swap cache does not utilize filemap or truncate helpers in ways that would trigger these checks, as it mostly implements its own cache management. Shmem won't trigger these sanity checks either unless thing went wrong, as it would directly trigger a BUG because swap cache index are unrelated and almost never matches shmem index. Shmem have to handle mixed values of folios, shadows, and swap entries, so it has its own way of handling the mapping. While some filemap helpers works for swap cache space, the swap cache is different from the page cache in many ways. So this particular helper will unlikely to work in a helpful way for swap cache folios. So make it explicit here that folio_contains should not be used for swap cache folios. This helps to avoid misuse, make swap cache less exposed and remove the folio_index usage here. Signed-off-by: Kairui Song --- include/linux/pagemap.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index af25fb640463..1dc3416a9c0d 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -935,14 +935,14 @@ static inline struct page *folio_file_page(struct folio *folio, pgoff_t index) * @folio: The folio. * @index: The page index within the file. * - * Context: The caller should have the page locked in order to prevent - * (eg) shmem from moving the page between the page cache and swap cache - * and changing its index in the middle of the operation. + * Context: The caller should have the folio locked and ensure + * (e.g.) shmem did not move this folio to swap cache. * Return: true or false. */ static inline bool folio_contains(struct folio *folio, pgoff_t index) { - return index - folio_index(folio) < folio_nr_pages(folio); + VM_BUG_ON_FOLIO(folio_test_swapcache(folio), folio); + return index - folio->index < folio_nr_pages(folio); } unsigned filemap_get_folios(struct address_space *mapping, pgoff_t *start, -- 2.49.0