From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7849C369DC for ; Tue, 29 Apr 2025 10:26:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDADF6B0007; Tue, 29 Apr 2025 06:26:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C893D6B0008; Tue, 29 Apr 2025 06:26:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B51A06B000A; Tue, 29 Apr 2025 06:26:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 97D6B6B0007 for ; Tue, 29 Apr 2025 06:26:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7F9C75FF78 for ; Tue, 29 Apr 2025 10:26:02 +0000 (UTC) X-FDA: 83386700964.01.117B802 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf13.hostedemail.com (Postfix) with ESMTP id 3DB5B20011 for ; Tue, 29 Apr 2025 10:26:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=sFhTFzJx; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745922360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ekglh/dA3wRPB8yYZpbO8TuZXP094Ab8hzDsZSCc+RI=; b=TeeVJ8T11pAeCB3GcPerdM/rPxcPGb6ySO1hpRm9IEYj9yMQZL1QJdJGUqvyoBOyxC3DWy HkRyeVIClFsyHEWd5Xb1qnW5EqG/aib5U2VE6mHCbp/oVTDleM2j5slXr7u8iVL6tHr1g5 /fy3nNDVYpRQz7U39nCkjSp1v10+ZeY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745922360; a=rsa-sha256; cv=none; b=iJ/3KvTmQaItmTc3IyH/oDQArzHfswMvTuW+JxbmgSwoyttjWGDYgE5ALjH4Bgk82j/sNe jBkDH2tW6EUjuiAJAYnTpNIG1+FPRwgLVBliluhMDyBDDfgdFfc01OR0tp87nwrpWs2BQq B0yyaqPsZoUKpfQNEL5G2OXGMD+XXIk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=sFhTFzJx; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53T4Ec39007851; Tue, 29 Apr 2025 10:25:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=ekglh/dA3wRPB8yYZpbO8TuZXP094A b8hzDsZSCc+RI=; b=sFhTFzJxrIK7JX4TDyJmj3CAI5+FQcMuujEWTNX1svc7V4 iMx/EHyGL6BzdOXdQMUyRlwsJ7bnrRD1VDDPBz8FcBdiGgBh5KjuNQQL7czPF9OQ GRPed/g+126gC0mvTYUrK4ymurYmFPcspBqnTeIGDD8PCe2OY3EfmylKH1biFcXx F4xGyakZlbqFlsrHUZZ1FMcIqBvZPTYfLHlkBoKeSH0e28w9OdR6ifFYwvVcqHam DrivzV7B7mQrduD4NZW07rz0t7QVxSlpHs9BEoIf/iDwN1izywT6l7LiAaHTqb6p dWhmNcxFMBIfnv68WaP2Ve6cQ5bCEgm+7XmEW+dQ== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46akn0t26u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 10:25:59 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53TAGsKI024662; Tue, 29 Apr 2025 10:25:58 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 469c1m2h92-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 10:25:58 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53TAPuII38601018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Apr 2025 10:25:56 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8DEC820D02; Tue, 29 Apr 2025 10:08:32 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 608D420D04; Tue, 29 Apr 2025 10:08:32 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 29 Apr 2025 10:08:32 +0000 (GMT) Date: Tue, 29 Apr 2025 12:08:31 +0200 From: Heiko Carstens To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm, swap: fix false warning for large allocation with !THP_SWAP Message-ID: <20250429100831.8629C3b-hca@linux.ibm.com> References: <20250429094803.85518-1-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250429094803.85518-1-ryncsn@gmail.com> X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=AeCxH2XG c=1 sm=1 tr=0 ts=6810a937 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=kj9zAlcOel0A:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=GvQkQWPkAAAA:8 a=aL_wZZtXDkcKPmASj-QA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: liS4cQCsfDwQjkie4Ouy93YR5RAYoAyp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI5MDA3NSBTYWx0ZWRfX8cx8t7EGE8DD nP9nHG7Rw+gognLiLCCxhjEDvBjf2N6sWjeOhUc/lhXSMxFEKrBYTW5W5au2G63928wSiofobxM S1oKLkOn9vGOE8nCeM0JVovcEV7U+OVOw2JoUgIw1ICfIcexNalppxUQF1++AV9QTu63/TBc2Vi YjWoUG+w+5DW4uLvmpteAHBlWXPPFcHx51Jtur58JQOSzVMdjfu4vcL4ndyOILVSftALz3aqkgp tnLwsUhWoxzbo10k/ainfYse6cRK36x4TQtkw9tkS84Hp1EHpCoBUQjQlJj2xKb1ObXdKiYY9cE CrG8vhEJKCirxVZbwD+x8OFjpIsNDozCP4xNw6eIB7QQNLQFmtpESkZop7rLrQKC9+NPaKf1jq1 mhV6e8GdB48vzICcyTAY63zKFfNFvGLU2qsmPqvbn9pNuov48fUpzPGdHPL66aLVIfomng0o X-Proofpoint-GUID: liS4cQCsfDwQjkie4Ouy93YR5RAYoAyp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-29_03,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=814 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 mlxscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504290075 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3DB5B20011 X-Rspam-User: X-Stat-Signature: tjwe83nubkk1bwpfjai67xthzaar9sdo X-HE-Tag: 1745922360-58171 X-HE-Meta: U2FsdGVkX19defNUo87k3nWEdFTs1H/UPiloyVoVEuA7K76AqKqNKxDmgudYvk1UJeEXDFxIWLbQQSxvoD296J5HiTE9lPEs0mVZ+A6o7ODEXTjrdzrH5fibgRmKzPwMhDHkY94k91bYGDOs3fWjmVOXGuhGxuyoSXeGinCcpPzz0eTfxKktiMRNC4Yk/E/X/iDSYT7gNJMpJZBbb9qupDph8yYaRs778sPQWvCZhz6lzGBpjOy1i0Bu8wJDnU77HN6wKO+wwLwqgDFgVJ3IPrNle/cBTmRGNUvjWLonLGlSLNv9eVqns5q8EhxwDq9mAp5XNVqrsJ3HvaBqaKL5tQDSLxuf00bdLLFlZMDBTkKfCHwuMXM4SG9swwnsGSg7qie1dJMGxjT3UNdYbyIgz4qRag8CHQSfSDV/IJnp0cnmeimw+wDMMBwwDpqGiur72yd280OHf5X99IZBSOg7gX7fTb0P84m6EY8fcb5TT3ZdvMr1/ibGiVJBHtmhX4woYrLyT+vfsBHbTI4aVjcegnBLmCocbhTsJ0OSOkPalnjBw4OF1iWWuBDobkz0uOgf929nHTjVRRsKmeD5dMZnHqrT2KWIndGuW4lNNKEGz4eWXDdjDD+O7IstT87QEluyt/ix1DxK5JW8F7sld5HeXSijSPcBxiODUYHXag7gDgi98anTXc6KJ+5zLcNpjThT6fL5cB2jtZ6/i9wAueTUkqhAgpYVOQGr5KU2t1wwmfUyJHVUnZqLMVnzeMgjJKao0pZOA9z70Ubjo6moRJ9RZR/0+y+i+kanqxw4/4jhblkTsmPk4oD1tNMxvPX2AO7xFH57Pg+NMprfYHj8ev3PmMOqNENdIYNnLd+4UtuObNWCkpkEJ5lIYy/MnDdL2+8HD5Ha5v/zQvaSznEi2eqNqjdClckezM9c0thmuxy49p1IMDzGk2hHsbG1lWaCLPhhDRFzRZ7A7FJFfMnmMIc RqYt8CR9 tpn2GdA/O5YhWjTF8GORj/oImskxpsTdl5pmhJv1J8nTZWPscqX/XPemHzVfFfrPULJWm2L0Clp40iJSFulWHwDvOgeFTqMoWB+GOWUssagPp1s2xeykO2bEbi+y9UtU575N5mDu1bNMpOWUjb2bRGr+xA6wfq1feJNexc+X5Vhs8KxSKIMduNNzcnzTwDPh7zoGhNymGd9zTPqgoWmUxBfi+QfvQJ0Kd5IK8bs4wmYnrHp+yWPPOOZ9z4hx/oJ7AfolqVD0LK+6KVRQQCCa3nDrxNTQ5iipm3J3/m/hleHjhXl9WBmz8xhT5F4QyrFINd+0ise0GudHAYO0XStsfDiYDiDb/52Lz1nHmPAJ1zmOXSHvSb1SzZ7zr8R3SAFvT4o0+NsSmL2RdePBcND8QmFQrieHJU5w6i7WEabxvz5TPIBT1K6ERysd1tps/jCqlt0N39o7tPXXwwrx/Ml4hzve6OPDMCC+pQQTn0rotn9vLksdUZePyEnncow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 05:48:03PM +0800, Kairui Song wrote: > From: Kairui Song > > The !CONFIG_THP_SWAP check existed before just fine because slot > cache would reject high order allocation and let the caller split > all folios and try again. > > But slot cache is gone, so large allocation will directly go > to the allocator, and the allocator should just fail silently > to inform caller to do the folio split, this is totally fine > and expected. > > Remove this meaning less warning. > > Fixes: 0ff67f990bd4 ("mm, swap: remove swap slot cache") > Reported-by: Heiko Carstens > Closes: https://lore.kernel.org/linux-mm/20250428135252.25453B17-hca@linux.ibm.com/ > Signed-off-by: Kairui Song > --- > mm/swapfile.c | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) Tested-by: Heiko Carstens