From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE9EC369DC for ; Tue, 29 Apr 2025 16:54:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EABF6B0011; Tue, 29 Apr 2025 12:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99A7F6B0012; Tue, 29 Apr 2025 12:54:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83BE86B0022; Tue, 29 Apr 2025 12:54:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 62A916B0011 for ; Tue, 29 Apr 2025 12:54:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0BF291A0B52 for ; Tue, 29 Apr 2025 16:54:24 +0000 (UTC) X-FDA: 83387679690.28.FC43688 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 56E8640003 for ; Tue, 29 Apr 2025 16:54:23 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YjBqGeHi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745945663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FYy1IVO3FRmbMuu7hf166FYVOBMHQze2YjQGkx57lA8=; b=tplyfmB2sGbdou0M5zoX0gtbmZkrT9z2aGCG+nSCLeSSwow4zkAwJrSUyWPr+h6IUoI2Tw OS0xwmFnQ64yW8V9Ra+u4JJDi7Nlp6+CCQBMFPD0IpgjZHbzeRoB0P2bBkt5JbdhnWCedj LhHJQ+l/N2rjMdvRd4DWeLREHV26nNM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YjBqGeHi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745945663; a=rsa-sha256; cv=none; b=VDr2YcdQ+gqIjo94dzqpA+Dg+gk91dpX6IE8YP5rOALL17UGtPh+umpu4QBYuUpFw3U/4r 8MvyygGhRsSRfUcT/JG+HAKSpX1OLSuXttJydXIOO61dkZRxCTiW/G4VMkEXcFQYNF6tu8 NQKcTWs+/9dXys1yIr/rWkugz0cosaM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 46B635C06B1; Tue, 29 Apr 2025 16:52:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18493C4CEE9; Tue, 29 Apr 2025 16:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745945662; bh=gr9TqpDzik67MmDx/yJNWxsvaR2w9xNR+74mtWIzDSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YjBqGeHiSIyYnLF9JqHGyzte8jhcIToNNU0IVcuqLDrSYZO4KSuKRFBBoTEc++q12 lRPsVjFUCO7dUmV6nBeu4sP1DX4s8GJwbjslnBbXSyJ8s0/A7VnvhbAeGyyUmjXlyr 74K+qiT2F8xLKeivwmSxSxaA1T2BFaN4tG9805eYGd4/SSvIIWEXvHdfPKqx7RtDOW vwZTyUXri3wv6BHe+ghfzhoBxNEyJBSCZ2cF6IM6oX9aVhzUEQAUKFHJoleIoC10X1 ZLybNxoWxmfyvSZKPug07cfwmUSIXJdEX5uOpWH+2j8uxPR6rYOHxRtvE9D9ORGAIn bRaUOpC+98uxQ== Date: Tue, 29 Apr 2025 09:54:21 -0700 From: Kees Cook To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] mm: perform VMA allocation, freeing, duplication in mm Message-ID: <202504290954.B4A4F99E7@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: m6eo1g5wb945pmrerc9h94sizusagoda X-Rspamd-Queue-Id: 56E8640003 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745945663-450263 X-HE-Meta: U2FsdGVkX1/oLA9daYaIw9+zzaPV1l/6rqYm5EZPjm7FEQMz54UmdZf69d23eK9Ydeb3H+pZ7vsMFxVBaBCIJWtBhsoN2htrPMh+a+OLWUzK0dDWQu/FloTCmKBlHp9cgjSPSsXlQLe6pSpCFfGalYxHC3PTiezDnIaGfVYPloVcDbpZ/h5juJ/bs7em9OR2RWH+GXkhe3IcV/UASccEtaAEDp2NqkMAH4SASDZx87/gjYecFHc7AMBOychrSU6ztahic+s4RDGOSKHjIFMZBtVxAkqZ4gwIoajIJ2L1ekb52eBAOk59qoJ6+XrIOBvA6yg79fOxmU7X8lxgcPe3iEIDWAts3qem0kw9XfVaXs+HFf/xCdejjzp/JxiDFSP57zEXsCAG51sDGG0gzRy5VJJTbZWYLYpaT7h6SdfJ8l73mvnxe5Vf1gNjGk2xVA1VFm+Owv69FSITUfRfBip23+JwcuqsHpj7Hij+Tj7bsN5ExV3IvtF5hjC4MepqO10qwFbCsTACaWySCpJXYYVUtuNLHwziViJx3uwrETfxShVrhBrQzcFmOhf1a1Kylrtz/gy6NxjluDWh5E3Oamhgh6sQ1jgOgNxcTqeYbZwEz5qKcHc/TzczFZ6P307hc1SFO7YLGRmAIXNrwZmcKXksVLFO62Tp4N36Kj5CYjBMkVi+v2SvExuwxOp+Suffg0p6QULpyor9GAgDhRlrA9+H4LQbXL03ui48VGAdgJnkggXgqaGdwgqXqHOpTolGApA3CYeAh97Bs1B0UVqEGsqfW18Hz/aEwInp1FZU103X4mSpUSub9QdJgk+JW8uI0U6L5nHIhDGfD3/U3Mz/0K6UL+93oLuqRmob5QoucgA7SxuWDtMGF9TAgSAIXgEvtXTefxsjzkPzvKdGNChjMqNO2TSLYBwI8ALimr2A6TNIcDiuKWDRRXi0gswuPX02snieOTXFN7iMBce+J8D/9ro N67YMjJa CpV2xW/Q9ZCLuOVNXaMc6UA3yzU35IQVkIh0Wast/CUq+IYiK16GQwkBkNNCVm7HLywS4maeR9hrZQd50+Dhd+a8hpMOt7LUrMpu3oyPQpsBh4H23NJgCa79ERdAlmMmj1mvaNAOT/LnqOnmXfxn48UY+ErXPGjM76dski4LUej/5+sgxAXX3JHF0F2voU4eUmy2nXalR78AIPs52A52Si8SfjfAl2YPju44Ef0a7Np33g63Xwfg9P6aDvRROhLCGd/febbu6dSI89UtamJcrQ+vUjIi1lEaxtWhO/Hrp1+m6+a8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 04:28:17PM +0100, Lorenzo Stoakes wrote: > Right now these are performed in kernel/fork.c which is odd and a violation > of separation of concerns, as well as preventing us from integrating this > and related logic into userland VMA testing going forward, and perhaps more > importantly - enabling us to, in a subsequent commit, make VMA > allocation/freeing a purely internal mm operation. > > There is a fly in the ointment - nommu - mmap.c is not compiled if > CONFIG_MMU not set, and neither is vma.c. > > To square the circle, let's add a new file - vma_init.c. This will be > compiled for both CONFIG_MMU and nommu builds, and will also form part of > the VMA userland testing. > > This allows us to de-duplicate code, while maintaining separation of > concerns and the ability for us to userland test this logic. > > Update the VMA userland tests accordingly, additionally adding a > detach_free_vma() helper function to correctly detach VMAs before freeing > them in test code, as this change was triggering the assert for this. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Kees Cook -- Kees Cook