From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org
Cc: david@redhat.com, lorenzo.stoakes@oracle.com, riel@surriel.com,
vbabka@suse.cz, harry.yoo@oracle.com, jannh@google.com,
baohua@kernel.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [RFC Patch 3/5] anon_vma: add test for mergeable anon_vma
Date: Tue, 29 Apr 2025 09:06:37 +0000 [thread overview]
Message-ID: <20250429090639.784-4-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20250429090639.784-1-richard.weiyang@gmail.com>
Add test to assert anon_vma is mergeable at the first level.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Jann Horn <jannh@google.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Barry Song <baohua@kernel.org>
---
tools/testing/anon_vma/anon_vma.c | 149 +++++++++++++++++++++
tools/testing/anon_vma/anon_vma_internal.h | 35 ++++-
2 files changed, 183 insertions(+), 1 deletion(-)
diff --git a/tools/testing/anon_vma/anon_vma.c b/tools/testing/anon_vma/anon_vma.c
index f3ca193857ec..2e6a1200e6c7 100644
--- a/tools/testing/anon_vma/anon_vma.c
+++ b/tools/testing/anon_vma/anon_vma.c
@@ -29,6 +29,7 @@ static struct mm_struct dummy_mm = {
static int vmas_idx;
static struct vm_area_struct *vmas[NUM_VMAS];
static struct kmem_cache *vm_area_cachep;
+struct vm_area_struct *mergeable_vma = NULL;
static void vma_ctor(void *data)
{
@@ -79,6 +80,7 @@ void cleanup(void)
}
vmas_idx = 0;
+ mergeable_vma = NULL;
}
static bool test_simple_fault(void)
@@ -408,6 +410,152 @@ static bool test_fork_grand_child(void)
return true;
}
+static bool test_mergeable_vma(void)
+{
+ struct vm_area_struct *root_vma, *child_vma, *vma1, *vma2;
+ struct anon_vma_chain *avc;
+ struct anon_vma *root_anon_vma;
+ DECLARE_BITMAP(expected, 10);
+ DECLARE_BITMAP(found, 10);
+
+ bitmap_zero(expected, 10);
+ bitmap_zero(found, 10);
+
+ /*
+ * root_anon_vma
+ * +-----------+
+ * | |
+ * +-----------+
+ * \
+ * \
+ * \ root_vma
+ * \ +-----------+
+ * > | |
+ * +-----------+
+ */
+ root_vma = alloc_vma(0x3000, 0x5000, 3);
+ /* First fault on anonymous vma. */
+ __anon_vma_prepare(root_vma);
+ bitmap_set(expected, root_vma->index, 1);
+ root_anon_vma = root_vma->anon_vma;
+ ASSERT_NE(NULL, root_anon_vma);
+ ASSERT_EQ(1, root_anon_vma->num_active_vmas);
+
+ mergeable_vma = root_vma;
+
+ vma1 = alloc_vma(0x5000, 0x7000, 5);
+ /* First fault on next adjacent anonymous vma. */
+ /*
+ * root_anon_vma
+ * +-----------+
+ * | |
+ * +-----------+
+ * \
+ * \------------------+
+ * \ root_vma \ vma1
+ * \ +-----------+ \ +-----------+
+ * > | | > | |
+ * +-----------+ +-----------+
+ */
+ __anon_vma_prepare(vma1);
+ bitmap_set(expected, vma1->index, 1);
+ ASSERT_EQ(vma1->anon_vma, root_anon_vma);
+ ASSERT_EQ(2, root_anon_vma->num_active_vmas);
+
+ vma2 = alloc_vma(0x2000, 0x3000, 2);
+ /* First fault on previous adjacent anonymous vma. */
+ /*
+ * root_anon_vma
+ * +-----------+
+ * | |
+ * +-----------+
+ * \
+ * \------------------+------------------+
+ * \ vma2 \ root_vma \ vma1
+ * \ +-----------+ \ +-----------+ \ +-----------+
+ * > | | > | | > | |
+ * +-----------+ +-----------+ +-----------+
+ */
+ __anon_vma_prepare(vma2);
+ bitmap_set(expected, vma2->index, 1);
+ ASSERT_EQ(vma2->anon_vma, root_anon_vma);
+ ASSERT_EQ(3, root_anon_vma->num_active_vmas);
+ dump_anon_vma_interval_tree(root_anon_vma);
+
+ anon_vma_interval_tree_foreach(avc, &root_anon_vma->rb_root, 2, 7) {
+ bitmap_set(found, avc->vma->index, 1);
+ }
+ /* Expect to find all vmas in range [2, 7] */
+ ASSERT_TRUE(bitmap_equal(expected, found, 10));
+
+ /* Expect to find only root_vma in range [3, 4] */
+ anon_vma_interval_tree_foreach(avc, &root_anon_vma->rb_root, 3, 4) {
+ ASSERT_EQ(avc->vma, root_vma);
+ }
+
+ /* unmap adjacent vmas before fork */
+ unlink_anon_vmas(vma1);
+ unlink_anon_vmas(vma2);
+ ASSERT_EQ(1, root_anon_vma->num_active_vmas);
+
+ /* Fork a child from root_vma */
+ /*
+ * root_anon_vma root_vma
+ * +-----------+ +-----------+
+ * | | ---> | |
+ * +-----------+ +-----------+
+ * \
+ * \ child_vma
+ * \ +-----------+
+ * > | |
+ * +-----------+
+ */
+ child_vma = alloc_vma(0x3000, 0x5000, 3);
+ anon_vma_fork(child_vma, root_vma);
+ ASSERT_NE(NULL, child_vma->anon_vma);
+ /* Parent/Root is root_vma->anon_vma */
+ ASSERT_EQ(child_vma->anon_vma->parent, root_vma->anon_vma);
+ ASSERT_EQ(child_vma->anon_vma->root, root_vma->anon_vma);
+
+ mergeable_vma = child_vma;
+
+ vma1 = alloc_vma(0x5000, 0x7000, 5);
+ /* First fault on next adjacent anonymous vma in child. */
+ /*
+ * vma1->anon_vma vma1
+ * +-----------+ +-----------+
+ * | | ---> | |
+ * +-----------+ +-----------+
+ */
+ __anon_vma_prepare(vma1);
+ ASSERT_NE(vma1->anon_vma, child_vma->anon_vma);
+ ASSERT_EQ(1, child_vma->anon_vma->num_active_vmas);
+ ASSERT_EQ(1, root_anon_vma->num_active_vmas);
+
+ vma2 = alloc_vma(0x2000, 0x3000, 2);
+ /* First fault on previous adjacent anonymous vma in child. */
+ /*
+ * vma2->anon_vma vma2
+ * +-----------+ +-----------+
+ * | | ---> | |
+ * +-----------+ +-----------+
+ */
+ __anon_vma_prepare(vma2);
+ ASSERT_NE(vma2->anon_vma, child_vma->anon_vma);
+ ASSERT_EQ(1, child_vma->anon_vma->num_active_vmas);
+ ASSERT_EQ(1, root_anon_vma->num_active_vmas);
+
+ /* Expect to find only 'child_vma' in range [2, 7] */
+ anon_vma_interval_tree_foreach(avc, &child_vma->anon_vma->rb_root, 2, 7) {
+ ASSERT_EQ(avc->vma, child_vma);
+ }
+
+ cleanup();
+
+ ASSERT_EQ(0, nr_allocated);
+ return true;
+}
+
int main(void)
{
int num_tests = 0, num_fail = 0;
@@ -428,6 +576,7 @@ int main(void)
TEST(simple_fork);
TEST(fork_two);
TEST(fork_grand_child);
+ TEST(mergeable_vma);
#undef TEST
diff --git a/tools/testing/anon_vma/anon_vma_internal.h b/tools/testing/anon_vma/anon_vma_internal.h
index 296c1df71f7c..a761048a2f34 100644
--- a/tools/testing/anon_vma/anon_vma_internal.h
+++ b/tools/testing/anon_vma/anon_vma_internal.h
@@ -33,11 +33,44 @@ static inline int rwsem_is_locked(struct rw_semaphore *sem)
return 0;
}
-static inline struct anon_vma *find_mergeable_anon_vma(struct vm_area_struct *vma)
+extern struct vm_area_struct *mergeable_vma;
+
+static int anon_vma_compatible(struct vm_area_struct *a, struct vm_area_struct *b)
{
+ return a->vm_end == b->vm_start &&
+ b->vm_pgoff == a->vm_pgoff + ((b->vm_start - a->vm_start) >> PAGE_SHIFT);
+}
+
+static struct anon_vma *reusable_anon_vma(struct vm_area_struct *old,
+ struct vm_area_struct *a,
+ struct vm_area_struct *b)
+{
+ if (anon_vma_compatible(a, b)) {
+ struct anon_vma *anon_vma = READ_ONCE(old->anon_vma);
+
+ if (anon_vma && list_is_singular(&old->anon_vma_chain))
+ return anon_vma;
+ }
return NULL;
}
+static inline struct anon_vma *find_mergeable_anon_vma(struct vm_area_struct *vma)
+{
+ struct anon_vma *anon_vma = NULL;
+
+ if (!mergeable_vma)
+ return NULL;
+
+ /* Try next first. */
+ if (mergeable_vma->vm_start >= vma->vm_end) {
+ anon_vma = reusable_anon_vma(mergeable_vma, vma, mergeable_vma);
+ if (anon_vma)
+ return anon_vma;
+ }
+
+ return reusable_anon_vma(mergeable_vma, mergeable_vma, vma);
+}
+
#ifndef pgoff_t
#define pgoff_t unsigned long
#endif
--
2.34.1
next prev parent reply other threads:[~2025-04-29 9:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 9:06 [RFC Patch 0/5] Make anon_vma operations testable Wei Yang
2025-04-29 9:06 ` [RFC Patch 1/5] mm: move anon_vma manipulation functions to own file Wei Yang
2025-04-29 9:06 ` [RFC Patch 2/5] anon_vma: add skeleton code for userland testing of anon_vma logic Wei Yang
2025-05-01 1:31 ` Wei Yang
2025-05-01 9:41 ` Lorenzo Stoakes
2025-05-01 14:45 ` Wei Yang
2025-04-29 9:06 ` Wei Yang [this message]
2025-04-29 9:06 ` [RFC Patch 4/5] anon_vma: add test for reusable anon_vma Wei Yang
2025-04-29 9:06 ` [RFC Patch 5/5] anon_vma: add test to assert no double-reuse Wei Yang
2025-04-29 9:31 ` [RFC Patch 0/5] Make anon_vma operations testable Lorenzo Stoakes
2025-04-29 9:38 ` David Hildenbrand
2025-04-29 9:41 ` Lorenzo Stoakes
2025-04-29 23:56 ` Wei Yang
2025-04-30 7:47 ` David Hildenbrand
2025-04-30 15:44 ` Wei Yang
2025-04-30 21:36 ` David Hildenbrand
2025-05-14 1:23 ` Wei Yang
2025-05-27 6:34 ` Wei Yang
2025-05-27 11:31 ` David Hildenbrand
2025-05-28 1:17 ` Wei Yang
2025-05-30 2:11 ` Wei Yang
2025-05-30 8:00 ` David Hildenbrand
2025-05-30 14:05 ` Wei Yang
2025-05-30 14:39 ` David Hildenbrand
2025-05-30 23:23 ` Wei Yang
2025-06-03 21:31 ` David Hildenbrand
2025-04-29 23:15 ` Wei Yang
2025-04-30 14:38 ` Lorenzo Stoakes
2025-04-30 15:41 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429090639.784-4-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=david@redhat.com \
--cc=harry.yoo@oracle.com \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox