From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD19C369CB for ; Tue, 29 Apr 2025 05:23:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4101F6B0008; Tue, 29 Apr 2025 01:23:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BE776B000A; Tue, 29 Apr 2025 01:23:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2856E6B000C; Tue, 29 Apr 2025 01:23:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BBF46B0008 for ; Tue, 29 Apr 2025 01:23:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3D35ABA486 for ; Tue, 29 Apr 2025 05:23:54 +0000 (UTC) X-FDA: 83385939588.02.EBFAE97 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 71B5FC0007 for ; Tue, 29 Apr 2025 05:23:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745904232; a=rsa-sha256; cv=none; b=EQyMNWOVlShvDxbrrSwrTLUOq7GvwLpQvGKNVk7+JSiYDL8Eufb+dU0XedVFJZYm4dALlV 46PtMqyU1MZzDxhQX+Xgo8e8x0PaYD+JNPy5gc0q/2lvI6LqGCDjbaoABrO4xd+R9oXdrb 2ikA/azFv+YbIsz8hI9BKKcKEpVicAM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745904232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=qIbZJlNMhbSEmprd78lKLWlB6+65wt48maP2tOZf1Go=; b=NpwOR6Zrl8VVxGAAfmMKoLim4fJZdAZhBySdOU+KMFbnktPqTWFRN914a73KYTwelxwSCb C/v52DyxDDD2SN8A/MU22k8NbdCSPmWG4YxYV30EtXI/xKyZprEEkvchenwewvlrbfsb5v Mn/cRhT/MVnKd8fHggKEqPWlCP50LD4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB84E1515; Mon, 28 Apr 2025 22:23:44 -0700 (PDT) Received: from K4MQJ0H1H2.arm.com (unknown [10.163.78.253]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0692B3F5A1; Mon, 28 Apr 2025 22:23:41 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org Cc: ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, namit@vmware.com, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com, Dev Jain Subject: [PATCH v2 0/7] Optimize mprotect for large folios Date: Tue, 29 Apr 2025 10:53:29 +0530 Message-Id: <20250429052336.18912-1-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 71B5FC0007 X-Rspamd-Server: rspam04 X-Stat-Signature: nn99tu93hh6ke6u85kegwcetk9s3hh5g X-HE-Tag: 1745904232-668538 X-HE-Meta: U2FsdGVkX18lbJesU0RSTQAo1hNulOkEsNCaz0/3aahaNkgAvszrhzdHfB/zvPhKK48ip+jxjAb1L6/uXDLJOoYmvipSbgrhsvDyPnOyymoHHblTHiN8+h28JULH2VBs3vYEwSRpM7PWGmfYN51WO88lzACV8JtBkADRollFZvPzeBo48aSJ4fO1AicXR1h7J4fc6shrg///pe4L19f/xvCfPOzV1zP4WDv9txkaY9XCH3Ex9fcftAaC5aBvWxqeMCqAdmPPc0x7XLqpHYowCuBHzIe0xuAxfOgmZ6SoexEB2emKZy7YJ+s54DVfqwW3KA295DqErw+koWmCMFvugHZGHjgfen02/KlAmnZVmtP+CIdUPKn1DH4m3gGointuxYNyYYBZ5VyqNO48zXDeeBG1I84VzFJM9eDH3p6CvfI/ckJVzQvUgJR3HysC+GLwR1HxU56EyDlnTfsr0bADxXiy4z5m2s3Ekei8hkF/OcMmC7Jc6Yxg+wXSS0CLGK8sWqCocZMUox0F/1D1wq4oGQ/gSrI4Kqb+/+hQglxSOVvKsHkbUr+09zUg0X2PjOdNw+epnckS++uomhWIeD86l4AMCeaveJX6NCbPtQn4Kya2ZrCfcwEof/E8sInO12JZ4DOJJ8XkaxhCdTlxu7tpWWRoYa4WUx/aaD/IbQQxNCZSe7gF2XaSzOQYsW2of2lftySZgccgSaEuin20VPNkubreOAGaf04ubtkkcIOptuW+mvJEKDjtoBGO1DQCr8xYhpd+z7u3xdzMoznPLwOJBBsS5IJwcNo8VRkRFj9dm5BcFEPX2kdLd99zU1BuJ0y2tw6IFhIbPN4CkhLopBj0a3YSxwYDoyFphgN9TMDXVDz51eCWciVFlIqoGQewBHp2X1D1v1OCBzdBu1LCry4VVCEYn0rXXUGBiOA37IKZwd+t/Ua1VYQsRWLpqliYyaw1k1dCqXZWKcyevaMKG9i MdUqU9dX pIfedMR42MtgF7HF3rM2gsk5pAQyDdw0MTT7/jKIgRRImYDyJrAJdvXuEEjVq0W4LzyQuCu5MJ09gvEyVil1VoOvCGhwt4aBCsNie X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patchset optimizes the mprotect() system call for large folios by PTE-batching. We use the following test cases to measure performance, mprotect()'ing the mapped memory to read-only then read-write 40 times: Test case 1: Mapping 1G of memory, touching it to get PMD-THPs, then pte-mapping those THPs Test case 2: Mapping 1G of memory with 64K mTHPs Test case 3: Mapping 1G of memory with 4K pages Average execution time on arm64, Apple M3: Before the patchset: T1: 7.9 seconds T2: 7.9 seconds T3: 4.2 seconds After the patchset: T1: 2.1 seconds T2: 2.2 seconds T3: 4.2 seconds Observing T1/T2 and T3 before the patchset, we also remove the regression introduced by ptep_get() on a contpte block. And, for large folios we get an almost 74% performance improvement. v1->v2: - Rebase onto mm-unstable (6ebffe676fcf: util_macros.h: make the header more resilient) - Abridge the anon-exclusive condition (Lance Yang) Dev Jain (7): mm: Refactor code in mprotect mm: Optimize mprotect() by batch-skipping PTEs mm: Add batched versions of ptep_modify_prot_start/commit arm64: Add batched version of ptep_modify_prot_start arm64: Add batched version of ptep_modify_prot_commit mm: Batch around can_change_pte_writable() mm: Optimize mprotect() through PTE-batching arch/arm64/include/asm/pgtable.h | 10 ++ arch/arm64/mm/mmu.c | 21 +++- include/linux/mm.h | 4 +- include/linux/pgtable.h | 42 ++++++++ mm/gup.c | 2 +- mm/huge_memory.c | 4 +- mm/memory.c | 6 +- mm/mprotect.c | 165 ++++++++++++++++++++----------- mm/pgtable-generic.c | 16 ++- 9 files changed, 198 insertions(+), 72 deletions(-) -- 2.30.2