From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BFCC3ABA5 for ; Tue, 29 Apr 2025 04:06:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A38B6B000C; Tue, 29 Apr 2025 00:06:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1686B000E; Tue, 29 Apr 2025 00:06:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 097FD6B0022; Tue, 29 Apr 2025 00:06:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BB1506B000C for ; Tue, 29 Apr 2025 00:06:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1E88FB8E5F for ; Tue, 29 Apr 2025 04:06:20 +0000 (UTC) X-FDA: 83385744120.29.0C7CB22 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id 3A793A0008 for ; Tue, 29 Apr 2025 04:06:18 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lG9VsAzy; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745899578; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DHY7yhZZbBEsyb+2Ly/Nb1eYeiuoEspG92fLONiY6Co=; b=rMm8lWVQZEihfGAS0ewL8doHmpmHtM74xKnMCBuye/eV743rQN1DsgaXJnew0uU3LwLaJy uGvjohoqMb+3mr0TKhsTFmL7Z2BnlszcctBURYbPMuApLppQKe3AP6s6MbIJ5eCkMM6oM+ JWN2yvVZF0t1mAHgAszfTF2eE3L6Ae0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lG9VsAzy; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745899578; a=rsa-sha256; cv=none; b=B3HAhAQczj+EpR9Up86otqtwDPZnVL7B30a4dDQda4OTgJaWrub2C45ZfIMVPwwSd30ymL dUhayzsylKjaurfj0redVc8+CqR+tHgxSLuuG35jUBXaazG7eccMnambDxh7CgHpS6xabb RyBe0ZWn/If1RQEcRbwQZoL0vyDeIxE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 894DBA4BAEE; Tue, 29 Apr 2025 04:00:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id EE095C4CEF8; Tue, 29 Apr 2025 04:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745899577; bh=/prxRR17A4AUb6KENZNu6wyfYJfvM5OCsGMmrdX+6/8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=lG9VsAzybNMbTnUEEHKSZoytPudEOxylRsU+yA6SDAHUs3Vk7juqULDjS6C9O5LhB floTcFwObWWgd9Qy9P+MsJCS+3gFOAKzAAOH7m0u/4KWl+qdSjhZU9WQHFKvNXdN8W BSe3ulfFjmdzCAMY/eCXZehkexHdlwS5pZrZjTrqFgqJT72FDN8uZXwL8SBxJ7riwk AI428EO6T1lPUaWRb0VGqUy9vaGQ4WcwBN3SKW2NraiH6KEL9CXGwiRwCQCvt5x0qw YvgmY7X/yDpGTRvRh8Zxgu/GQZGWWwyBUifBfdMWpSe5cOyf5FDSzF4WkOsKwik//K Pr92s9YBYEgyA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E278EC369CB; Tue, 29 Apr 2025 04:06:16 +0000 (UTC) From: Chen Linxuan via B4 Relay Date: Tue, 29 Apr 2025 12:06:07 +0800 Subject: [PATCH RFC v3 3/8] vfio/virtio: add __always_inline for virtiovf_get_device_config_size MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250429-noautoinline-v3-3-4c49f28ea5b5@uniontech.com> References: <20250429-noautoinline-v3-0-4c49f28ea5b5@uniontech.com> In-Reply-To: <20250429-noautoinline-v3-0-4c49f28ea5b5@uniontech.com> To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Peter Huewe , Jarkko Sakkinen , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Mathieu Desnoyers , Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , Dmitry Vyukov , Andrey Konovalov , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, Winston Wen , kasan-dev@googlegroups.com, xen-devel@lists.xenproject.org, Chen Linxuan , Changbin Du X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3264; i=chenlinxuan@uniontech.com; h=from:subject:message-id; bh=xG7js8JRxRjbFUIGcKi60xVgk95Kd+hLnEeuvHk0cSk=; b=owEBbQKS/ZANAwAKAXYe5hQ5ma6LAcsmYgBoEFAwmuPV3ACiHfIboeRqguBq0EhDlCeY2gJxc awVBFVX6dWJAjMEAAEKAB0WIQTO1VElAk6xdvy0ZVp2HuYUOZmuiwUCaBBQMAAKCRB2HuYUOZmu i/7eD/9hIYexsn7L7GF/snRnakoE8V20CWkBNi/mt9lRdndsCiW2OdR1Ihha5YAXqecwmxRnfIk Emq8Rre/zUQpqoY7eJyR2xDIWhTnkwkCyfEyTsfGHJLEwQpKTt6VJJ194lzRgNJrsRGkdhoJgPI YVf5pd6n5+4vBUJ/2hfI/Wqt3KqqPR6vu9hUhNnSvGaEfJr67namCj1dKTEwipm+iyXGN7sYjwk snpKKFC8f1CyrsuOK1huwKroAFyXxK4bO9wRbSoE6Gt/WzfA3AIzffrZ/aMgOYpKOZs6Ing6PD3 JJtFMLXppoFpuxaeXTedKMV2BuZ+QBRT8o4qDbJfIlRShfkM7nmkNgwKfyWdeXJVC/xO2NpbaXw oP4yE1mGjdBOkSpdcza79ucV0LSYANd8QnYJp5U0wRF5sJzj2Nll37E/9/W1L6yc4KSM3WdsvwP RsV1dnU8iFNZu61T95iCwa1GRo9dBbiQkjhkOvrBKEnM4ASeS1O0D2PdUlpWE7vO5rmS4F+3XCa Y/P1rp+j9DMaFuEPisA/6hp+L1E2HvBW5Md/Z6qu10+dwT1kPXvMWF0HUIgHhAppENa897twV7b 6F9KYT4mFmdKNtZU6HSx6NzlGP2GxiJ1qZQP6mSPk+y5h2cOxYVABAdoN0CT/1P2jyc5Gq7LZo4 ETnYNoxJgZ1iw4Q== X-Developer-Key: i=chenlinxuan@uniontech.com; a=openpgp; fpr=D818ACDD385CAE92D4BAC01A6269794D24791D21 X-Endpoint-Received: by B4 Relay for chenlinxuan@uniontech.com/default with auth_id=380 X-Original-From: Chen Linxuan Reply-To: chenlinxuan@uniontech.com X-Stat-Signature: 7qywfrosp14mdcztdeqzeh7brw9huh7y X-Rspamd-Queue-Id: 3A793A0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745899578-781536 X-HE-Meta: U2FsdGVkX18FU6kHUmJy29+s4ruBl2lzWsm8Ag5pWA0hvPIIlukX6Cj2jK167L2SUVwZKHAWBj8i1WXt6TdA0Wm13IyRczRRTW+ejMAiheh8odrr2Yn8HhFc1806+K3ee3ULpKAZODpaCYBL7KpEUFebbEhEthup0wM5JmKzM+cjGABClR37XlMeIZpLUOkeqb9w73ADjQuP7HsP/+lww3UUxxKTJ9HJwcoy2VWRVwNjWViKXKGLHJkl4gyxcsxVg9Ter9OzT9+CYZICNhnKlTwXWSpSR9BNlJ7BkiVaioDuOqHrTVavwdTzc9WgilHinGB4/FJ4svMzGxnyHE6McBca1ZA5rbIB8THQ2S9nCMjQt9Y5BirN0ZhVvhc/63oqtLglIaYfTe3PlVY7yRHs3qSs7CizUFf3NWCGGic6cEtnln68rNAd26USPUM4Jw9hLaeNYo5Zb4tj9evOuSEQxu4SD5X6qjnpn+/T1X1Yy9vIp+iJK1dayyAYhADFjqf3E1vHGnXDqb1zJgi6pPs9/pb8L8sA0tQ20rAEAK9xLnxbZCNnlAYmqRF4hkLNxzsIGCEBNTsD7P0V97K28E7kw8uoX4qOhp/+DSQSBZL36zqUctKHiGs7mPMyuT44CAFGSfwAfpcCRIwgHzo3Cf9jlZeuaCD38mS3L2eOlg1cffsSVXAYP4Qeb2Y9PC8k7KHDAfvUdCb3EXLz4lGxVXA214+GF7X0dBdqBl8Vfws+Zwf5FHgP7lVzs6kW4ExCqTXfcjlqsk1IjXIFCpjHl+mgXcWgBpfKf4y9FTRgTSnvXGQ1WHYL+EHV+iAxJtEncZGPDAqfsF52KBs7HTkyx9ntl9sX/ArqkYzwHWvKBWK33Ild6Y2ASR+uElQag2jyKlVZ7L9+KlaKOw7ns3ymEZwnVTIf+QjYbP3sDbog3EDUIqu8NVdR23x5vl/vjmsWOknpv365zmpTzVE2d6WgnYo sXqoEhiF p5QPabJSEi49VInTekDhdZ4Pm7yLB3vYn6+hehtwPUTS2MP6GsV+C+7lLN4+pQ3n7Etxu40cP9g+Xf4733d9OVvcc8renIoWBnqhTqmOY1dX+Cpk+eg+UrKIca8vY0VEyuqF+JLZMrX0JholprmJ/e9OmTQemcntqZc/Gpj/ESj98O1X9I1v0xDKbLtd+N3LxtqzMFGS/9sQqXvwJ7UooDANFfe0JCWCXWAXl6nrilIoY2bKLYAbYGuoSZJB3xbpYRWvt3yRvUNwGMMQ0oBwhRAuvn5Ly3TQzzudoFuDFuKRnWlq61MWt/aSm9kRX3Ewbi36vr7F9tDkj6PdLs+a580HyrcI+JnUO5H7JWxiresEQ25C8vQ3q5iL9MdSfE3Ao70HHa+4aazq4RMTcDl7WwNw4CKmKWvXQq2jM7PjPUKAyWUVu6O48QJRXGOOXJOVKQFYyr0+TgPZZ8qRqmgoNvCZd0QFeOnzQeBelpBExbillHp16Ws7yOFMWxVp1vm7l9hYn2/j49Pjtt6tgLjKPOWrHiM5M1KC2C+RU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Winston Wen Presume that kernel is compiled for x86_64 with gcc version 13.3.0: make defconfig ./scripts/kconfig/merge_config.sh .config <( echo CONFIG_VFIO=m echo CONFIG_VIRTIO_PCI=y echo CONFIG_VIRTIO_PCI_LIB_LEGACY=y echo CONFIG_VIRTIO_VFIO_PCI=m echo CONFIG_VIRTIO_VFIO_PCI_ADMIN_LEGACY=y ) make KCFLAGS="-fno-inline-small-functions -fno-inline-functions-called-once" \ drivers/vfio/pci/virtio/legacy_io.o This results a compile error: CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC drivers/vfio/pci/virtio/legacy_io.o In file included from : drivers/vfio/pci/virtio/legacy_io.c: In function 'virtiovf_init_legacy_io': ././include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_889' declared with attribute error: BUILD_BUG_ON failed: !is_power_of_2(virtvdev->bar0_virtual_buf_size) 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ ././include/linux/compiler_types.h:538:25: note: in definition of macro '__compiletime_assert' 538 | prefix ## suffix(); \ | ^~~~~~ ././include/linux/compiler_types.h:557:9: note: in expansion of macro '_compiletime_assert' 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ drivers/vfio/pci/virtio/legacy_io.c:401:9: note: in expansion of macro 'BUILD_BUG_ON' 401 | BUILD_BUG_ON(!is_power_of_2(virtvdev->bar0_virtual_buf_size)); | ^~~~~~~~~~~~ BUILD_BUG_ON needs virtvdev->bar0_virtual_buf_size to be computed at compile time. So we should mark virtiovf_get_device_config_size() with __always_inline here. Co-developed-by: Chen Linxuan Signed-off-by: Chen Linxuan Signed-off-by: Winston Wen --- drivers/vfio/pci/virtio/legacy_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vfio/pci/virtio/legacy_io.c b/drivers/vfio/pci/virtio/legacy_io.c index 832af5ba267c49a079009cfe0fa93c15ba7a490f..b6871d50b9f9e278ef3c49a9cb2baf474b8271c6 100644 --- a/drivers/vfio/pci/virtio/legacy_io.c +++ b/drivers/vfio/pci/virtio/legacy_io.c @@ -350,7 +350,7 @@ int virtiovf_open_legacy_io(struct virtiovf_pci_core_device *virtvdev) return virtiovf_set_notify_addr(virtvdev); } -static int virtiovf_get_device_config_size(unsigned short device) +static __always_inline int virtiovf_get_device_config_size(unsigned short device) { /* Network card */ return offsetofend(struct virtio_net_config, status); -- 2.43.0