From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C1EC3ABA5 for ; Tue, 29 Apr 2025 04:06:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64EC06B000E; Tue, 29 Apr 2025 00:06:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 468756B0023; Tue, 29 Apr 2025 00:06:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 226CD6B0012; Tue, 29 Apr 2025 00:06:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CBF9F6B000E for ; Tue, 29 Apr 2025 00:06:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5797316082F for ; Tue, 29 Apr 2025 04:06:20 +0000 (UTC) X-FDA: 83385744120.06.4BD948A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf24.hostedemail.com (Postfix) with ESMTP id 71E7F180004 for ; Tue, 29 Apr 2025 04:06:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FyUVqYls; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745899578; a=rsa-sha256; cv=none; b=DcPMpi5ao0cJ437chi/2uib27u8ALSHFJIdZP7HOVMHgGOOpk84rfyrpXAcu/QJEnvl/2d 0RNRQJpGnPES92+K0vq0Gc53QhOPi21lyZhQxonmpV2pBgCTbyrcuigHCwtun0IL7hrtja YR2GC4K3QaICdcQWChr4E2U4c8eABng= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FyUVqYls; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745899578; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=32GUHxOnJ3+ew70SHa0f65jKdkmGy6tQFDGoZR2Kj/Q=; b=ge6M8U8GNKeSIcXvSU7234YarCGgBxS/0RrehLwxqHeiX+pHOiyRMcr3Ie/qzMRm6BW0C3 tmajpMXCp4a8k7EbswBAxSLek/eVLP5QtYS8qpWWoK73qFRhl02WWQ2m4621g1EQDzUqWm DEqdH6Oju7rv8dw3cj+9WzQt+GXHt00= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D24B068429; Tue, 29 Apr 2025 04:05:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id CD555C4CEF1; Tue, 29 Apr 2025 04:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745899576; bh=pJ9VpLz2vL2PDt7J0K2cXMYeDKnStbQajileR/wxzK8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=FyUVqYls/+KqU5DpInz9ZWqZ/4CAAzIPkLtTAq2+9vTbtkfDvRR2CjebexTY9QBGl a18CtmbbDxF0tvb3AcYhTkIyRG0rGmIkJvOQyXGZmREvsxGc9clSCgXVDMI44bfCOB RwUBZ5vLAptbw96/QZcz10zYj2Ww1cjxiuhaCIV1kmi57bliowHPSI7urlxZe9vKEG oDldZTQDIsI86OtD5RmJoGS5Kqw98y9Y2hrIZWtmhbDW+Op3bNrJJxNcoQ6l/9xD1A sZMVPjVE+TJH9Zf+qU8izf83pAhbghYD3h20CeX6p7lBgVhUV7G4DchS76qQNbjUfj iEE1ouz0ZXZDA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4A1C3ABA6; Tue, 29 Apr 2025 04:06:16 +0000 (UTC) From: Chen Linxuan via B4 Relay Date: Tue, 29 Apr 2025 12:06:06 +0800 Subject: [PATCH RFC v3 2/8] mm: add __always_inline for page_contains_unaccepted MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250429-noautoinline-v3-2-4c49f28ea5b5@uniontech.com> References: <20250429-noautoinline-v3-0-4c49f28ea5b5@uniontech.com> In-Reply-To: <20250429-noautoinline-v3-0-4c49f28ea5b5@uniontech.com> To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Peter Huewe , Jarkko Sakkinen , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Mathieu Desnoyers , Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , Dmitry Vyukov , Andrey Konovalov , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, Winston Wen , kasan-dev@googlegroups.com, xen-devel@lists.xenproject.org, Chen Linxuan , Changbin Du X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2614; i=chenlinxuan@uniontech.com; h=from:subject:message-id; bh=+y8wKlsn55GLtsirs4Essnozl8lVGDb1RUHKRb3UGRw=; b=owEBbQKS/ZANAwAKAXYe5hQ5ma6LAcsmYgBoEFAvQHTkSNXJxyOgEHVD9PhzBBGToDo54ToKB JTzQ3Bt13uJAjMEAAEKAB0WIQTO1VElAk6xdvy0ZVp2HuYUOZmuiwUCaBBQLwAKCRB2HuYUOZmu i2wDD/94Tikof0KqTbmGNltSJN0BkZfS5swTBN23SRIvCigAsJMsSAEE8+hsOfF5ug0IHuwNOI/ 1Qnd48PesFnCihU7hm3JfucE304u3ikq3JpHS8byjD3Iq2171RsPQwl30uxz+vEZ8hzs0TpTQBL tbOgvO5HS5tVi2N8UEoiRrD/AIGE1AKJx646BKh7BWEfqlVn8Piwh3FS7UZcthV+4LqoV/TILJ5 CqwIUJDj8ZerV5DorB5SDBkZEPqwYLdujwzVjj9cp8vZwKMj+w/cFPS+07AzMtQNZybB8QumHsU DHQmASWQEn05ggN/6NnlkKJvxaDxaREGdoSN4rVPnwenoh7XG44AwW+NWt2oRVUae7CdZaTJ02f UozQggCd6pQA5H1c2SG9aalj7diOg0zrkq7srXqL9aVnJGeGkbSHAIxpmoG3bA+uXmBJSKWtr2+ 7DF6eO6UhF2ql4ur4skO7HIRADaqOFdEcIXMoQ8iutz4ml3kKwVIMhsOOAXwoXgNTZw6dPFvTUK oOGrXVNKLy/fJX/0x7AiWVUMQSMsG/Kuios2R+atYaJYgzNmP+h2IF2Il+UfCg1zti1vGWy17fO jFSai1Av+dm6o4iuFeMJx4Tgo52MAnqfyksIfcNlB+/tDcM4IwZn3C7WTQp9uxdiHyZV0edPtRS Z2AKjqx+hU/5gsw== X-Developer-Key: i=chenlinxuan@uniontech.com; a=openpgp; fpr=D818ACDD385CAE92D4BAC01A6269794D24791D21 X-Endpoint-Received: by B4 Relay for chenlinxuan@uniontech.com/default with auth_id=380 X-Original-From: Chen Linxuan Reply-To: chenlinxuan@uniontech.com X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 71E7F180004 X-Stat-Signature: mtyhaxonfuaijc5u8re5ymtc91ppbsg5 X-Rspam-User: X-HE-Tag: 1745899578-451069 X-HE-Meta: U2FsdGVkX1+Mqvs9qG/K4lW9cZzvTwDVUdg4k4loDwG3iIaGPfAOF/crK7D5UpkqpbLD6i3ebbS3Owoeck7iiVv7VW8227Qfz/3e4K134jeW/ZyTTTvgwXeHHYB4OfLSWGqY8lPA30AdIoRWknGpvQY6siPySOntFyTHSfMsh+GYr9o8eyVKMF2uYz3UP105ylTG9ZvB3UqaWq0pJYcVHin62TG+rwcvmyHJA0msPIPkJUzoDZXTqK0z+sGyzAldSG47fG8eBzD44x/feOeWBRasWnDQ/H1BvIcMD1+SSAOYPAbArTEIa6BUN2Bg2lL0NxGJm65yJ9XDcNdX2ecyYYFZeyjLFwQOCgHsjoToQ+xKSVNVxBA6nspgq0zx/mmErlPi3q2czaiHMGJxjBWJYxxRWjtku6rRH1vnqdwj5HsQkZaBG7fyqTun9nBywvvfi8O7Ja9sDb7ICuA06FHcIprWnMrme/l522/UKeKSmhYvav8W3PdgW75TUyxBOJJ/hSMAkikKWHoqlypKkUD8tyMZN9vhasedSJaiw3eNIl6LzmxcxxtOnmlL8Xk4IicOonUhxTITg1aW0FniVqt9IFkhSWFZwjkIElHh25S/k3ucCnNbsU+Rm+k6/UxauyN/licnV2HItIOe4vlHxZaJc4Jct/L1XBd25pMQsL1LXm8AeZ2gLyOAguND9JmgzLGfnCV6c9iuluNJMFzsC3Z/1ipMH5EJf8yCKUI7vkMNdcr6lcckcAQjvzc3InXWj4eTOISSiqFc8V3l4n99+GemqVrNEFHMoyltBLMAPJ3sw7T7N8vp3eRbTUHxojkqjbv/Aw2Q8SxW3uBPrAuGIuaXBpbkV2W9D6P99ekMfdViCZhjeI076fOTzvkC08EF2jjZ9s/3iZgAXXpdFNxQmvPwnt/Qz5kGzlhgxu5i77cwCnep/8xQv5Od8EEZ/7f1lMAHPt9LWKQp6rYY0zptKmy 7bu5+Jau /+Lap6xIyB6nZJbTOSuBJGsFqAJjhE5J67vJNgzFgkilnUqn1FNNR703KRnNdSqPPYUVl+KfNuatgwl2TYu6grk7yrYtnj472JDVsFyl6/6zVOnUo6CLnu2VUQM+/AxOub2RvHq1rd5jmnP+nZkPrNDjKob1r4nq61jDwal+ZUPcy8HLVoSTozqB0NsuXZ/ISrevAry/pHCPwtOJMaDIEnzoG5yRpTMtZIexqmIwUa/jBsRG+jz8zCQvM0yWkc3gbsP1on6x5biWelZZamnAPNTlKCkm1FkJDqVXaermRf0FYmpLQoU0fYig3RACMjRvngCMOC9qc7V/orx8UOgCwhYxc40TFfS9yfG41IM1LRJdBpxbIdJZssvEEev2n7xKAW1Q0g2A5ditXlr7YDjhb4TqwZXmLOCqtUYEJ9HApocBIgnEj5Aiv70klSzZOO9sBjr7kQdM3eLLQlEBEtKNIyAP+8EsGjk5umoaYtnkCiC6bBrFV+8SvEo1PW/VzcjG7e5d05tX+hbq5domBLEYWHb0j0RF1gqC2PgOVlJQ9y2OvSigQT+WTQG+spQkzigzI0ItNLNCfjtTX+Gs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Winston Wen On x86_64 with gcc version 13.3.0, I compile mm/page_alloc.c with: make defconfig make KCFLAGS="-fno-inline-small-functions -fno-inline-functions-called-once" \ mm/page_alloc.o Then I get a compile error: CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC mm/page_alloc.o In file included from : mm/page_alloc.c: In function '__free_unaccepted.isra': ././include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_1013' declared with attribute error: BUILD_BUG failed 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ ././include/linux/compiler_types.h:538:25: note: in definition of macro '__compiletime_assert' 538 | prefix ## suffix(); \ | ^~~~~~ ././include/linux/compiler_types.h:557:9: note: in expansion of macro '_compiletime_assert' 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ mm/page_alloc.c:7301:9: note: in expansion of macro 'BUILD_BUG' 7301 | BUILD_BUG(); | ^~~~~~~~~ Marking page_contains_unaccepted with __always_inline and let dead code elimination remove reference to __free_unaccepted() here. Co-developed-by: Chen Linxuan Signed-off-by: Chen Linxuan Signed-off-by: Winston Wen --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5669baf2a6fea75c17b2be426443a6cf29051f52..433dc1936114469a323c8f3659730747965b2c3d 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7346,7 +7346,7 @@ static bool __free_unaccepted(struct page *page) #else -static bool page_contains_unaccepted(struct page *page, unsigned int order) +static __always_inline bool page_contains_unaccepted(struct page *page, unsigned int order) { return false; } -- 2.43.0