From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BEABC369CB for ; Tue, 29 Apr 2025 04:06:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C55426B000A; Tue, 29 Apr 2025 00:06:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDFA86B0012; Tue, 29 Apr 2025 00:06:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A33DB6B000E; Tue, 29 Apr 2025 00:06:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 82A036B000C for ; Tue, 29 Apr 2025 00:06:18 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD52C1A082A for ; Tue, 29 Apr 2025 04:06:19 +0000 (UTC) X-FDA: 83385744078.14.C63257F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id 030B040004 for ; Tue, 29 Apr 2025 04:06:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=umnHgPjx; spf=pass (imf01.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745899578; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xrhMzzLIHTdVCC3mv+/FwPsHGQdx15A5wVwExQY5NgA=; b=N2GFY/Ih15N0xFTU4GCdKHd4FsajtYf9D8af1r4yMHfI+6Y//Tim8Ia2eSid2nSBXSbsal ngykMkR0XVixGAoj+gJ79wPsiXz95Mzr4m3gO1tDAnvP/Q5hDDQSR40k6QbiJKfsfYKZCX L3RXqyaP+1UMHw6EJTAP4hwugBMG2DM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=umnHgPjx; spf=pass (imf01.hostedemail.com: domain of devnull+chenlinxuan.uniontech.com@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=devnull+chenlinxuan.uniontech.com@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745899578; a=rsa-sha256; cv=none; b=30lLOW0SNA0qyk+5GEkw6/UR+iLJeNE7ki2Sln2D1ohloKtBnnDWKgxOiOknxq4etWqSR+ HUJXPGdyfVtVtg0NfSmawTcMf3iwKSl8yXB7Ck3IQojFv+4XkR6279E1rXA3i1iE4RLu6G fro8P6IkxXuYztxUeU0K8ChiHjWNI9w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 77AD9A4BA30; Tue, 29 Apr 2025 04:00:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id BF675C4CEEE; Tue, 29 Apr 2025 04:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745899576; bh=94UzipiV219n1Nsds3GgUffrYhVWmSEuqNwCotvgHTg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=umnHgPjx/uswvCkSmQAtfNXwh0J1RgCPXPtU15EJ3BJrGMr9TeAkv+02Hx8/aJrZP B9pids9hDCCRiksaveqMrCaUIPjjT40xeYtCj3KLeve1mYRGk57NEeo0YsYHn7kloJ Wb5lXlJ1ICFfjMDI7QXO7ihYek6tuetYOzZNrzvuaGAxSxtzS6wFaDjCD1KHmLlOpd mGs+bcfHf0EcMQwc5GWPCv3Q+hydECGq09BD3DqCK5uZZKY6iXbfQpCANImiozP2H4 ry6PlbZas22d5KF1Q/sW5U8JGsO3qzDZZJpJ9Sos51pOgukjAw6CGW4cOv/pPGGvJh 2wpUI2Qi0eYHg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC846C369D1; Tue, 29 Apr 2025 04:06:16 +0000 (UTC) From: Chen Linxuan via B4 Relay Date: Tue, 29 Apr 2025 12:06:05 +0800 Subject: [PATCH RFC v3 1/8] nvme: add __always_inline for nvme_pci_npages_prp MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250429-noautoinline-v3-1-4c49f28ea5b5@uniontech.com> References: <20250429-noautoinline-v3-0-4c49f28ea5b5@uniontech.com> In-Reply-To: <20250429-noautoinline-v3-0-4c49f28ea5b5@uniontech.com> To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Peter Huewe , Jarkko Sakkinen , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Mathieu Desnoyers , Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , Dmitry Vyukov , Andrey Konovalov , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, Winston Wen , kasan-dev@googlegroups.com, xen-devel@lists.xenproject.org, Chen Linxuan , Changbin Du X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2975; i=chenlinxuan@uniontech.com; h=from:subject:message-id; bh=Z0QiTYLHzEeebaywUqCSW16Ny4EMqCsjjX+KS5KBMNU=; b=owEBbQKS/ZANAwAKAXYe5hQ5ma6LAcsmYgBoEFAukhIgTV0U3xfinuIjd2L0FB1AExqdCchlv A3ri9QFLWiJAjMEAAEKAB0WIQTO1VElAk6xdvy0ZVp2HuYUOZmuiwUCaBBQLgAKCRB2HuYUOZmu i9PbD/0bxMLZB/tZ4Ta8gMq1WIv38DYhUP3aWnHRrfHrBmcZmF3pYKgj7U3bQhz1rGgW21/5jLf O6iQHC8JkszMXt7z43locXuD3D2XLaMzfIjJ4SYSBJJCUhLDwTO0hXO+SgM8VdRdhmjZUc1WhnK MotrwNb7+YScOJV7UKO27QZ4mEX9QtP1og5KDtG4fX2A4elJ/oUz5VyPu1ZVWaZIPGpR6UfQu2W 3V96onZcmtcYOTu7m+Q4YYn57iocabwdiYGXp9u6+muG1V36fqjgCWLFdJ87b10fBGpqSdLd78K Np/ZrE3r79VyFTS10nLQwcH5emDVtRsUooPidOTFB5RbtCiWZVwNXbzPXeUAOlpo1fud6r4VWu6 qQumY8DgxrRS5yYkJuqNuYsyMje5EqNF0cT9ACHUWaiTx2mc4D4GMZxmlK0Gb/i6H6b5Nn2r2Xj wAaoImxclHPRalFdhXU+KjoIiAQ+6sz9E+8WePUUrBdVGKfCKQPnIoZrmz83bxpZtjB8fQ0tEQM iAAaovwAWgBfxfbUHIa8VeSzTs5I5aHhO+aY/5Sd1k2ttkBswHZJumET7aNiQoPsJoewmJYilGQ jL21aH2TLLnbAvvZ8tf8QpXJtxzRSYrmcdb8wsQqvI0rVPoHUhioggOtX3jm+SKC+ApmPIpQr8u b//ZkECSNX3jkKQ== X-Developer-Key: i=chenlinxuan@uniontech.com; a=openpgp; fpr=D818ACDD385CAE92D4BAC01A6269794D24791D21 X-Endpoint-Received: by B4 Relay for chenlinxuan@uniontech.com/default with auth_id=380 X-Original-From: Chen Linxuan Reply-To: chenlinxuan@uniontech.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 030B040004 X-Stat-Signature: h7i9hodk4k3r6uk5e8dg7iq6b7kft8fz X-HE-Tag: 1745899577-966253 X-HE-Meta: U2FsdGVkX18VDB6YkuzALxRTHDI/3nbUxd1/jxKGdaSFcHn1GpNK9iUtf8NFtsOTIDgJ4YAC0ddCAX6E9+W8R0ToY+i98ZK6qmgBmWioDSNV17tsGvWRVzJICvHSXMczHKZsjz+5RuXZ65jx2btPHsxGV1dwvK7x59qcv4/NQ/FkcY6Sw4ywP5xZfAl2CBtaqIJPPHeVD1f5ulRFEZ519sbHI5thD2y/0DYbKoRBJX+vlETi3inUIrH0P3TH7Eu9tykGj/ayKI5kih220svtNmfB4VcftobnVobJCpsGik51GLqP8nZbyj4sClPokWxesEQHLoFe3+xEA82bz6D7ZGJQnPq2hGCgl4vNPxdy3ABrROG/XDyAsvdE+RQZRNoRlombEfGX1COzGiPo2GRfu2MQ0qqvCYRFoxlM1YlWtDRhmuHrn95vCQ+NIkDL3+Tis4EUrzgzLeSU7vn8VOKuS3SowcOhEe3vBj6FQwU6CrlJFgiOxRzHEfBadr8toxal8WXkEZGhMRJc8RRoSuc/kEI8x6S4iIOnZOjT+78DesU/bX8DFuhd2YTFye2CeD2PwcGeCnviSMTm2iA2VUpB2P1AvUDblHvvRRVMU/JGDdAkq7SraIrRaOiUWJBTtVQzzxFoLdkPiPc+DQv0FVeRTHRLliSjk0WWzXxBgh/DwM8x+FG/9YbLV0rjeOLaXoR9e6kOCZ1faoXFu8vS/0/bTRtzRlJt7xCkm/Ta7hD943k3iWjiWTSeNvDyEOQN5puToqSubLTyb7459eAJ8jVtA8Jk/vT5b8i4TMl5dSqdD4lN+du8JzYY80thTZtryY0A8tg4T973PMkv6M2cnVXH7xOphzWv5OjefW1s8RnNGQq/Jskz5ZyzYHo35GJUiUi8/pVl3/nNQuSRIg9odYuXsBji7UqevlkcQDmvOxnhivFij6ssROsGG/+wiKIVdqvUpnUVNwFHEaN8KL7e+9w 27UIOxfo NnpvSuWJevo0rlrAKLqV671jI5QN4HvEWuCXNbTaHOKoew25v6PPyZZ/rCpaHzPIptNQcHz4dJ6sLnr6yneXHu2ENmmZIHRgbLXsJw/kMC9LGuE4exIMq4ZSzDACC/rUjfzBCoGK3/nqTxawgu3x9hfBUg+DUIDTZHqNW9gEU5Z4GxWsnobLLUBWptm+NOP5YLegYwIJRvrVm5GdtIUD2O2M6II0cH4tFDgWstiGGcKEtNB/pfSHHPsb+vhMDqXpLH1bbK6JXPJkjK+McFCzCVzJ1savL9KVYfrw+4/A2QZsxpRMOO2R6gc8CTr/+ymt4CCx3apWBsmKjFaomtXExP2cY/6YIZQWwA8mWuyajR51feOl8MoACHRPpcB7gbgb6OkOHY+BTcstV/qbuNWnieaMdbKZQE3Mzkk77RURb2lVl6TrRwjotxWvY4GapHni/opgO1urT+c5MCkHH/wrOExDHsME9Fd+mLleTuBEOXTwEkAYw9MiHsolejQ9ef8FpHbiKmt730MTql3ZtVHFoIdAhivUxB68GNZjP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Winston Wen On x86_64 with gcc version 13.3.0, I build drivers/nvme/host/pci.c with: make defconfig ./scripts/kconfig/merge_config.sh .config <( echo CONFIG_BLK_DEV_NVME=m ) make KCFLAGS="-fno-inline-small-functions -fno-inline-functions-called-once" \ drivers/nvme/host/pci.o Then I get a compile error: CALL scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC drivers/nvme/host/pci.o In file included from : drivers/nvme/host/pci.c: In function 'nvme_init': ././include/linux/compiler_types.h:557:45: error: call to '__compiletime_assert_878' declared with attribute error: BUILD_BUG_ON failed: nvme_pci_npages_prp() > NVME_MAX_NR_ALLOCATIONS 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ ././include/linux/compiler_types.h:538:25: note: in definition of macro '__compiletime_assert' 538 | prefix ## suffix(); \ | ^~~~~~ ././include/linux/compiler_types.h:557:9: note: in expansion of macro '_compiletime_assert' 557 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ ./include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ drivers/nvme/host/pci.c:3804:9: note: in expansion of macro 'BUILD_BUG_ON' 3804 | BUILD_BUG_ON(nvme_pci_npages_prp() > NVME_MAX_NR_ALLOCATIONS); | ^~~~~~~~~~~~ Mark nvme_pci_npages_prp() with __always_inline make it can be computed at compile time. Co-developed-by: Chen Linxuan Signed-off-by: Chen Linxuan Signed-off-by: Winston Wen --- drivers/nvme/host/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index b178d52eac1b7f7286e217226b9b3686d07b7b6c..9ab070a9f0372bc6595c29a884ee9f2ffe5ae8e9 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -390,7 +390,7 @@ static bool nvme_dbbuf_update_and_check_event(u16 value, __le32 *dbbuf_db, * as it only leads to a small amount of wasted memory for the lifetime of * the I/O. */ -static int nvme_pci_npages_prp(void) +static __always_inline int nvme_pci_npages_prp(void) { unsigned max_bytes = (NVME_MAX_KB_SZ * 1024) + NVME_CTRL_PAGE_SIZE; unsigned nprps = DIV_ROUND_UP(max_bytes, NVME_CTRL_PAGE_SIZE); -- 2.43.0