linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: nifan.cxl@gmail.com
To: muchun.song@linux.dev, willy@infradead.org
Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net,
	akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Fan Ni <fan.ni@samsung.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH v3 1/4] mm/hugetlb: Pass folio instead of page to unmap_ref_private()
Date: Mon, 28 Apr 2025 10:11:44 -0700	[thread overview]
Message-ID: <20250428171608.21111-4-nifan.cxl@gmail.com> (raw)
In-Reply-To: <20250428171608.21111-3-nifan.cxl@gmail.com>

From: Fan Ni <fan.ni@samsung.com>

The function unmap_ref_private() has only user, which passes in
&folio->page. Let it take folio directly.

Signed-off-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
 mm/hugetlb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index e287d8050b40..b1268e7ca1f6 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -6039,7 +6039,7 @@ void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start,
  * same region.
  */
 static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma,
-			      struct page *page, unsigned long address)
+			      struct folio *folio, unsigned long address)
 {
 	struct hstate *h = hstate_vma(vma);
 	struct vm_area_struct *iter_vma;
@@ -6083,7 +6083,8 @@ static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma,
 		 */
 		if (!is_vma_resv_set(iter_vma, HPAGE_RESV_OWNER))
 			unmap_hugepage_range(iter_vma, address,
-					     address + huge_page_size(h), page, 0);
+					     address + huge_page_size(h),
+					     &folio->page, 0);
 	}
 	i_mmap_unlock_write(mapping);
 }
@@ -6206,8 +6207,7 @@ static vm_fault_t hugetlb_wp(struct folio *pagecache_folio,
 			hugetlb_vma_unlock_read(vma);
 			mutex_unlock(&hugetlb_fault_mutex_table[hash]);
 
-			unmap_ref_private(mm, vma, &old_folio->page,
-					vmf->address);
+			unmap_ref_private(mm, vma, old_folio, vmf->address);
 
 			mutex_lock(&hugetlb_fault_mutex_table[hash]);
 			hugetlb_vma_lock_read(vma);
-- 
2.47.2



  reply	other threads:[~2025-04-28 17:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28 17:11 [PATCH v3 0/4] mm/hugetlb: Let unmap_hugepage_range() and nifan.cxl
2025-04-28 17:11 ` nifan.cxl [this message]
2025-04-28 20:49   ` [PATCH v3 1/4] mm/hugetlb: Pass folio instead of page to unmap_ref_private() David Hildenbrand
2025-04-28 21:02   ` Matthew Wilcox
2025-04-30  7:50   ` Oscar Salvador
2025-04-28 17:11 ` [PATCH v3 2/4] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page nifan.cxl
2025-04-28 20:50   ` David Hildenbrand
2025-04-30  7:52   ` Oscar Salvador
2025-04-28 17:11 ` [PATCH v3 3/4] mm/hugetlb: Refactor __unmap_hugepage_range() " nifan.cxl
2025-04-28 20:51   ` David Hildenbrand
2025-04-30  7:58   ` Oscar Salvador
2025-05-04 21:35     ` Fan Ni
2025-05-05  7:01       ` David Hildenbrand
2025-04-28 17:11 ` [PATCH v3 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() nifan.cxl
2025-04-28 20:53   ` David Hildenbrand
2025-04-30  8:09   ` Oscar Salvador
2025-04-28 19:31 ` [PATCH v3 0/4] mm/hugetlb: Let unmap_hugepage_range() and Andrew Morton
2025-04-28 19:41   ` Fan Ni
2025-04-28 20:54     ` David Hildenbrand
2025-04-28 21:30       ` Fan Ni
2025-04-28 21:01 ` Matthew Wilcox
2025-04-28 21:33   ` Fan Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250428171608.21111-4-nifan.cxl@gmail.com \
    --to=nifan.cxl@gmail.com \
    --cc=a.manzanares@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@stgolabs.net \
    --cc=david@redhat.com \
    --cc=fan.ni@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=sidhartha.kumar@oracle.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox